Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Normal   |Version:
 Keywords:  must-fix-before-028-rc,  | Resolution:  fixed
  TorCoreTeam201605  |  Actual Points:  2 hours
Parent ID:  #18809   | Points:  small
 Reviewer:  nickm|Sponsor:  None
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:  nickm| Points:  small
 |Sponsor:  None
-+-

Comment (by teor):

 Replying to [comment:13 nickm]:
 > NOTE to '''nickm''': I'll have to rebase this one last time since I went
 and squashed and merged #18921.  That's on me, though.

 I did the rebase into my branch feature18483-028-v2 because of changes in
 #18929:

 Old commit / New commit / Name
 0de9faa a5b5447 Make clients always use begindir for directory requests
 15fe5e8 950eae4 Make clients only select directories with reachable
 ORPorts
 aec84c5 8febffe Only choose directory DirPorts on relays

 The following commits were deleted because this no longer depends on
 #18929:
 8adbfab Merge branch 'bug18921' into feature18483-028
 1100a70 Revert "Remove must_have_or from
 router_has_non_preferred_address_rs"
 5c8fde2 Only fall back to nodes with valid ORPorts when using begindir

 > 0de9faa402bebc98a58c9f65149e72e598926184:
 >   * begindir_reason will never be set!  You need to declare the `reason`
 argument in `directory_command_should_use_begindir` as "const char * *",
 not `const char *`.

 Oops! Pointer handling error.
 Calling this NM1.
 9f01dc4 fixup! Make clients always use begindir for directory requests

 > Otherwise, this looks good.

 Let's get it merged, I am much happier with it now it's disentangled and
 #18929 has shrunk.
 (And it merges fine on top of both maint-0.2.8 and the new #18929.)

 See #18962 for a rebased feature18483-cleanup-v2, which can go in 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:  nickm| Points:  small
 |Sponsor:  None
-+-

Comment (by nickm):

 Oh, one last thing: Did you forget to push feature18483-028?  All I see is
 feature18483 and feature18483-cleanup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:  nickm| Points:  small
 |Sponsor:  None
-+-
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-

Comment (by nickm):

 NOTE to '''nickm''': I'll have to rebase this one last time since I went
 and squashed and merged #18921.  That's on me, though.

 0de9faa402bebc98a58c9f65149e72e598926184:
   * begindir_reason will never be set!  You need to declare the `reason`
 argument in `directory_command_should_use_begindir` as "const char * *",
 not `const char *`.

 Otherwise, this looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-
Changes (by bugzilla):

 * keywords:  must-fix-before-028-rc, CoreTorTeam201605 => must-fix-
 before-028-rc, TorCoreTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  CoreTorTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-
Changes (by teor):

 * keywords:  must-fix-before-028-rc, CoreTorTeam201605, TorCoreTeam201605
 => must-fix-before-028-rc, CoreTorTeam201605


Comment:

 I split #18483, #18921, and #18929 into three separate branches for 0.2.8,
 and a branch for 0.2.9.
 Please see feature18483-028 on https://github.com/teor2345/tor.git for
 this issue.
 feature18483-028 depends on bug18921 and bug18929-v2. It needs to be
 merged to 0.2.8.
 I split off a branch which contains cosmetic changes only into #18962.

 Replying to
 [https://trac.torproject.org/projects/tor/ticket/18921#comment:9 nickm
 from #18921]:
 > Initial Questions:
 >   * e726459eaf57ffe98c36730af58287229c9531d6: Are we really really sure
 that every possible case of the big complicated function
 directory_fetches_from_authorities() should be replaced with
 !directory_must_use_begindir() ?

 Calling this NM1.

 e726459eaf57ffe98c36730af58287229c9531d6 is Make clients always use
 begindir for directory requests.
 After the split, it is 0de9faa402bebc98a58c9f65149e72e598926184 in
 feature18483-028. The code is unchanged from the original commit.

 This function determines whether one-hop connections use a DirPort or
 begindir over ORPort.

 Previously, our logic was "if connecting to an authority, don't use
 begindir".
 (Perhaps this was to reduce load? If so, the fallback directories feature
 should reduce load on the authorities, more than enough to compensate for
 the increased load from begindir. Also, some relays will not use begindir
 now, when they used to before.)

 Now, our logic is, "if you are a client, or hidden service, or bridge, use
 begindir".

 Here are the cases from directory_fetches_from_authorities, and how they
 change:
 * FetchDirInfoEarly
   * changes clients to use begindir
   * previously, anything with FetchDirInfoEarly 1 used DirPort, which is
 bad for clients
   * now, clients with FetchDirInfoEarly will use begindir, which is what
 we want
   * now, relays with FetchDirInfoEarly will use DirPort, which is also
 what we want
 * BridgeRelay
   * stays the same
   * unchanged, bridge relays will continue to use begindir
 * server_mode() and don't know our address
   * stays the same
   * previously, relays without an IP address used DirPort to get an IP
 address
   * now, all relays will use DirPort (including relays without an IP
 address)
 * !dir_server_mode(options) && !refuseunknown
   * changes some relays to use DirPort
   * previously, non-directory non-exits used to use begindir
   * now, all relays will use DirPort (including non-directory non-exit
 relays)
   * now, all clients will use begindir
 * !server_mode(options) || !advertised_server_mode()
   * changes some relays to use DirPort
   * previously, non-servers or non-advertised servers used to use begindir
   * now, all public servers will use DirPort
   * now, all clients and bridges will use begindir
 * !router_get_my_routerinfo || (!supports_tunnelled_dir_requests &&
 !refuseunknown)
   * changes some relays to use DirPort
   * previously, tors without descriptors (clients), and non-directory non-
 exits used to use begindir
   * now, all relays will use DirPort (including non-directory non-exit
 relays)
   * now, all clients will use begindir
 * default
   * stays the same
   * previously, directories and exits used to use DirPort
   * now, all relays will use DirPort (including directories and exits)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  CoreTorTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-

Comment (by teor):

 Added further commits to this branch as part of #18929, including a unit
 test from isis.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  CoreTorTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-

Comment (by teor):

 I've added 3 more commits to this branch, to fix #18929.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
-+-
 Reporter:  teor |  Owner:
 Type:  enhancement  | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,  |Version:
  CoreTorTeam201605  | Resolution:
Parent ID:  #18809   |  Actual Points:  2 hours
 Reviewer:   | Points:  small
 |Sponsor:  None
-+-
Changes (by teor):

 * keywords:  must-fix-before-028-rc => must-fix-before-028-rc,
 CoreTorTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
+
 Reporter:  teor|  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  must-fix-before-028-rc  |  Actual Points:  2 hours
Parent ID:  #18809  | Points:  small
 Reviewer:  |Sponsor:  None
+
Changes (by teor):

 * status:  new => needs_review
 * points:   => small
 * type:  defect => enhancement
 * parent:   => #18809
 * actualpoints:   => 2 hours


Comment:

 Please see my branch feature18483 on https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort (was: Clients should always tunnel connections, even if FetchDirInfoExtraEarly is set)

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a 
DirPort
+
 Reporter:  teor|  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  must-fix-before-028-rc  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  None
+
Changes (by teor):

 * status:  needs_information => new


Comment:

 When a Tor client selects a directory mirror with an ORPort it can't
 reach, it uses the DirPort. Instead, clients should only select relays
 with ORPorts they can reach, and should never use DirPorts.

 Clients (and onion services, and bridges(?)) should never use the
 following dir_indirection_t:
 * DIRIND_DIRECT_CONN
 * DIRIND_ANON_DIRPORT

 We should modify the meaning of DIRIND_ONEHOP so tor only falls back when
 it is in public_server_mode():

 Default: connect over a one-hop Tor circuit. Only fall back to direct
 connection if you are a relay or authority.

 Is this too big a change to make just before the 0.2.8 release?
 I'm concerned because we need it to make #18809 simpler, and that's a fix
 on a feature that's in 0.2.8.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs