Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  must-fix-before-028-rc, tor-hs,  |  0.2.8.2-alpha
  TorCoreTeam201605, TorCoreTeam-| Resolution:  fixed
  postponed-201604, review-group-1   |  Actual Points:  very
Parent ID:   |  small
 Reviewer:  asn  | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Agreed.  Merged. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  merge_ready
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, tor-hs,  |Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-|  0.2.8.2-alpha
  postponed-201604, review-group-1   | Resolution:
Parent ID:   |  Actual Points:  very
 Reviewer:  asn  |  small
 | Points:  small
 |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

 Might be worth pointing out that this patch will also suppress the
 following log message:
 {{{
 node = node_get_by_nickname(rp_nickname, 0);
 if (!node) {
   if (err_msg_out) {
 tor_asprintf(_msg,
  "Couldn't find router %s named in INTRODUCE2 cell",
  escaped_safe_str_client(rp_nickname));
   }

   goto err;
 }
 }}}

 Are we OK with hiding this from HS operators? I guess yes because it's not
 like they can do anything about it (and it's probably caused by consensus
 desynchronization between client and service).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, tor-hs,  |Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-|  0.2.8.2-alpha
  postponed-201604   | Resolution:
Parent ID:   |  Actual Points:  very
 Reviewer:  asn  |  small
 | Points:  small
 |Sponsor:
-+-

Comment (by nickm):

 bug18761_028 now has a fix for that.  Ready for review again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, tor-hs,  |Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-|  0.2.8.2-alpha
  postponed-201604   | Resolution:
Parent ID:   |  Actual Points:  very
 Reviewer:  asn  |  small
 | Points:  small
 |Sponsor:
-+-

Comment (by arma):

 Bug:
 {{{
 -  log_warn(LD_REND, "%s on circ %u", err_msg,
 +  log_warn(err_msg_severity, "%s on circ %u", err_msg,
 (unsigned)circuit->base_.n_circ_id);
 }}}
 this wants to be {{{tor_log(err_msg_severity)}}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, tor-hs,  |Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-|  0.2.8.2-alpha
  postponed-201604   | Resolution:
Parent ID:   |  Actual Points:  very
 Reviewer:  asn  |  small
 | Points:  small
 |Sponsor:
-+-

Comment (by arma):

 Also tor_log wants a log domain (LD_REND), so let's not lose that one
 either.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, tor-hs,  |Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-|  0.2.8.2-alpha
  postponed-201604   | Resolution:
Parent ID:   |  Actual Points:  very
 Reviewer:  asn  |  small
 | Points:  small
 |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc tor-hs|Version:  Tor:
  TorCoreTeam201604  |  0.2.8.2-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:  very
 |  small
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * actualpoints:   => very small


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc tor-hs|Version:  Tor:
  TorCoreTeam201604  |  0.2.8.2-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 > let's make it rate-limited.

 Actually let's not. PROTOCOL_WARN is fine. See branch `bug18761_028`.
 Please review?  Very small patch; review should be fast if we don't start
 painting the bikeshed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18761 [Core Tor/Tor]: Make logging of rendezvous to private address quieter

[Tor Bug Tracker & Wiki]

#18761: Make logging of rendezvous to private address quieter
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  accepted
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc tor-hs|Version:  Tor:
  TorCoreTeam201604  |  0.2.8.2-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * keywords:  must-fix-before-028-rc tor-hs => must-fix-before-028-rc tor-hs
 TorCoreTeam201604
 * owner:   => nickm
 * status:  new => accepted


Comment:

 let's make it rate-limited.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs