Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.2.7.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Major | Resolution:  fixed
 Keywords:  test, patch 026-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.2.6.x-final => Tor: 0.2.7.x-final


Comment:

 Not planning an 0.2.6 backport; users should upgrade to 0.2.7 if they need
 this resolved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.6.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Major | Resolution:
 Keywords:  test, patch 026-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 You're welcome, and thanks for your patience and persistence with
 investigating this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.6.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Major | Resolution:
 Keywords:  test, patch 026-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by trudokal):

 Hi nickm

 Just wanted to say thanks for your responsiveness and cooperation. Keep up
 the good work!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.6.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Major | Resolution:
 Keywords:  test, patch 026-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  test, patch, review-group-1 => test, patch 026-backport
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.6.x-final


Comment:

 I made a branch `bug18841_1_025` for this so we can backport it as far as
 we want. I'm adding it to 027 and forward, for possible backport to older
 versions.

 I am also leaving this particular ticket open in case there are more
 reasons this happens.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Major | Resolution:
 Keywords:  test, patch   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by trudokal):

 * status:  new => needs_review
 * keywords:  test => test, patch
 * severity:  Normal => Major


Comment:

 (raised severity, because this bug misconfigures tor, see below)

 Replying to [comment:4 trudokal]:
 > = Possible solution =
 > Since the test depend on '-rdynamic' being set and this does not seem to
 be
 > enabled by all distributions. It should be enabled for the test.
 > But instead of enabling for the whole build (a distro might have a good
 reason
 > for disabling it, I don't know), only enable it in the linking phase of
 > test-bt-ct.
 >
 > I'm not an expert in autotools/make, but getting a '-rdynamic' in the
 target
 > for test-bt-cl in Makefile.in seems to do it. Sadly, I have no clue how
 to get
 > it there, because the target is auto-generated by autogen.sh.


 Investigated a little further why '-rdynamic' is not defined in
 {{{CFLAGS}}}.
 config.log states

 {{{
 [...]
 configure:9451: checking whether the linker accepts -rdynamic
 configure:9494: x86_64-pc-linux-gnu-gcc -std=gnu99 -o conftest -g -O2
 -D_FORTIFY_SOURCE=2 -pedantic -Werror  -I${top_srcdir}/src/common
 -rdynamic conftest.c -lcap -lpthread -ldl   >&5
 :0:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
 :0:0: note: this is the location of the previous definition
 cc1: all warnings being treated as errors
 configure:9494: $? = 1
 configure: program exited with status 1
 configure: failed program was:
 [...]
 configure:9508: result: no
 }}}

 Similar for a bunch of other configure checks.

 The reason is that Gentoo has some patches which predefine
 {{{_FORTIFY_SOURCE}}} yielding warnings of the form

 {{{
 :0:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
 :0:0: note: this is the location of the previous definition
 }}}

 which in configure yield an error and hence a misconfiguration.
 This warning is also printed at every file we compile.

 I found a similar issue by an other software:
 http://tracker.ceph.com/issues/13920

 The solution is simple: undefine {{{_FORTIFY_SOURCE}}} before defining it.

 = Patch =
 {{{
 diff --git a/configure.ac b/configure.ac
 index 4bdd2d3..bd50577 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -761,7 +761,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [
  #endif])], have_clang=yes, have_clang=no)

  if test "x$enable_gcc_hardening" != "xno"; then
 -CFLAGS="$CFLAGS -D_FORTIFY_SOURCE=2"
 +CFLAGS="$CFLAGS -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2"
  if test "x$have_clang" = "xyes"; then
  TOR_CHECK_CFLAGS(-Qunused-arguments)
  fi
 }}}
 (patch is also attached)
 Patch was tested against current master branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by trudokal):

 * status:  needs_information => new


Comment:

 Replying to [comment:2 nickm]:
 > Hm, what kind of linux are you on?  This works for me, and I can't
 reproduce the failure.
 >
 > (Then again, I have gcc 5.3.1.  I wonder if the gcc is at fault?)
 >
 > Did earlier versions of Tor (containing test_bt.sh) also fail?


 Did some test test_bt.sh seems to have been introduced for tor-0.2.7.3-rc.
 I checked versions

 tor-0.2.7.3-rc
 tor-0.2.7.4-rc
 tor-0.2.7.6
 tor-0.2.8.2-alpha

 After getting a little more used to the output, I realise that the output
 is actually no error but intended.
 What lets the test fail is that the stacktrace does not contain the
 'function names', e.g. output for 'test-bt-cl crash' is

 {{{
 src/test/test-bt-cl(+0x15e3f)[0x7f298f879e3f]
 src/test/test-bt-cl(crash+0x50)[0x7f298f879a10]
 src/test/test-bt-cl(crash+0x50)[0x7f298f879a10]
 src/test/test-bt-cl(oh_what+0x25)[0x7f298f879a85]
 src/test/test-bt-cl(a_tangled_web+0x25)[0x7f298f879ae5]
 src/test/test-bt-cl(we_weave+0x25)[0x7f298f879b55]
 src/test/test-bt-cl(main+0xe9)[0x7f298f879389]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7f298eb95b45]
 src/test/test-bt-cl(+0x15882)[0x7f298f879882]
 }}}

 and not

 {{{
 src/test/test-bt-cl(+0x15e3f)[0x7f298f879e3f]
 src/test/test-bt-cl(+0x50)[0x7f298f879a10]
 src/test/test-bt-cl(+0x50)[0x7f298f879a10]
 src/test/test-bt-cl(+0x25)[0x7f298f879a85]
 src/test/test-bt-cl(+0x25)[0x7f298f879ae5]
 src/test/test-bt-cl(+0x25)[0x7f298f879b55]
 src/test/test-bt-cl(+0xe9)[0x7f298f879389]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7f298eb95b45]
 src/test/test-bt-cl(+0x15882)[0x7f298f879882]
 }}}

 (note the missing names.)

 I'm not a C/C++ programmer. But googleing reveals that passing '-rdynamic'
 to gcc produces those names in the stacktrace.
 Indeed:

 {{{
 export CFLAGS="-rdynamic -g -O2"
 ./configure
 make
 make verify
 [...]
 PASS: src/test/test
 PASS: src/test/test-slow
 PASS: src/test/test-memwipe
 PASS: src/test/test_workqueue
 PASS: src/test/test_keygen.sh
 PASS: src/test/test_zero_length_keys.sh
 SKIP: src/test/test_switch_id.sh
 PASS: src/test/test_ntor.sh
 PASS: src/test/test_bt.sh
 
 Testsuite summary for tor 0.2.9.0-alpha-dev
 
 # TOTAL: 9
 # PASS:  8
 # SKIP:  1
 # XFAIL: 0
 # FAIL:  0
 # XPASS: 0
 # ERROR: 0
 ===
 }}}

 Note: Above output is for the master branch, but I also tested
 tor-0.2.8.2-alpha
 tor-0.2.7.6
 and they succeed as well.

 

 = Possible solution =
 Since the test depend on '-rdynamic' being set and this does not seem to
 be
 enabled by all distributions. It should be enabled for the test.
 But instead of enabling for the whole build (a distro might have a good
 reason
 for disabling it, I don't know), only enable it in the linking phase of
 test-bt-ct.

 I'm not an expert in autotools/make, but getting a '-rdynamic' in the
 target
 for test-bt-cl in Makefile.in seems to do it. Sadly, I have no clue how to
 get
 it there, because the target is auto-generated by autogen.sh.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Hm, what kind of linux are you on?  This works for me, and I can't
 reproduce the failure.

 (Then again, I have gcc 5.3.1.  I wonder if the gcc is at fault?)

 Did earlier versions of Tor (containing test_bt.sh) also fail?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18841 [Core Tor/Tor]: Test test_bt.sh fails

[Tor Bug Tracker & Wiki]

#18841: Test test_bt.sh fails
--+
 Reporter:  trudokal  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.2.8.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs