Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Applied to master and maint-1.9.5
 (0a5af31aed37e4fd9faec408455b2d4ae139841e and
 e22642323f09efd18b4315d0b7145a781bb3dbdc). It won't make it into 6.5a4. We
 try to get it squeezed into 6.0.6, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I just discovered that the right arrow on the donate button that I just
 added is failing to render on OS X. Very sorry about this last minute
 discovery! Here's a patch to fix it:

 ​https://github.com/arthuredelstein/torbutton/commit/20414+14

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed with 2f8570e04f2465710b02abaf1e0cfd3059580134 (master) and
 1a79b90c4cf41558d2b637b6314e0c64338d158d (maint-1.9.5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Here's one more minor revision. If there isn't time to include this
 revision in the release, it's not really a problem. This patch simply
 delays the banner launch by one more day (to November 23) and also fixes a
 minor mistake in the code that doesn't stop it from functioning correctly.

 ​https://github.com/arthuredelstein/torbutton/commit/20414+13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Alright. Looks good to me. Applied to master and maint-1.9.5 (commit
 64f16026a2e9899c136e925f4487721d2746c56e and
 ba95ab383ce6ecdcdba9cc905095b0a85ad1b08e). I updated the `pt` translations
 on maint-1.9.5 with commit e6ce4a86360b4b17f690dcd229bb8b478fa19679.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I copied Isabela's pt-BR translation of the banner strings over to the pt
 locale in Transifex; they are now available for import.

 Here's another patch that adds the pt locale, delays launch by a week to
 November 22 (because the donation page needs a little more preparation
 time), and improves the font-size and appearance of the donate button.

 https://github.com/arthuredelstein/torbutton/commit/20414+12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201611R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * keywords:  TorBrowserTeam201611, crowdfunding => TorBrowserTeam201611R,
 crowdfunding


Comment:

 (I guess it can't hurt to test the code better before 6.0.6 is getting
 out, though ;) )

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
+
 Reporter:  arthuredelstein |  Owner:
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  TorBrowserTeam201611, crowdfunding  |  Actual Points:
Parent ID:  #20413  | Points:
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I applied .2 to master and maint-1.9.5 (commits
 c8ec31a111cf15971a341df02bca04fe09dd3bed and
 f5b70b5a4d5f5fd8db9acb74d62c3cc1b86f3ee2).

 After updating the translations on master I realized that `tr` is ready as
 well and activates that one on maint-1.9.5
 (6af7c834e9f79af974625d0f925d064a098bbee8) after getting the banner
 translations on that branch as well
 (94e5cfa96ed3ce4a3172efcbda8638e280de637e).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
+--
 Reporter:  arthuredelstein |  Owner:
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201611, crowdfunding  |  Actual Points:
Parent ID:  #20413  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
+--
 Reporter:  arthuredelstein |  Owner:
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201611, crowdfunding  |  Actual Points:
Parent ID:  #20413  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by arthuredelstein):

 Replying to [comment:12 gk]:
 > okay, I gave it a whirl and it looks good to me with some nits
 addressed:

 Thanks for the review.

 > 1) What is the scope of `count`?

 Fixed.

 > 2) s/that stop observing/that stops observing/

 Fixed.

 > 3) We put in the translations early to give translators time to produce
 the properly localized strings for non en-US Tor Browser versions. Yet the
 code is only concerned with en-US bundles anyway. What is the plan here
 then? Don't we want to ship 6.0.6 with the donation banner enabled for as
 many users as possible (this is more a needs_information point as I am not
 sure whether we should fix the code or not)?

 I have currently added several locales. I hope more can be translated in
 time for the release (including French and Russian). If so, we'll need to
 add those to the `kBannerLocales` list when they are ready.

 New version: https://github.com/arthuredelstein/torbutton/commit/20414+11

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
+--
 Reporter:  arthuredelstein |  Owner:
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201611, crowdfunding  |  Actual Points:
Parent ID:  #20413  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  TorBrowserTeam201610R, crowdfunding => TorBrowserTeam201611,
 crowdfunding
 * status:  needs_review => needs_revision


Comment:

 okay, I gave it a whirl and it looks good to me with some nits addressed:

 1) What is the scope of `count`? It seems to me we could rewrite
 {{{
 if (Services.prefs.prefHasUserValue(shownCountPref)) {
   count = Services.prefs.getIntPref(shownCountPref);
 } else {
   count = 0;
 }
 }}}
 into
 {{{
 let count = 0;
 if (Services.prefs.prefHasUserValue(shownCountPref)) {
   count = Services.prefs.getIntPref(shownCountPref);
 }
 }}}
 2) s/that stop observing/that stops observing/

 3) We put in the translations early to give translators time to produce
 the properly localized strings for non en-US Tor Browser versions. Yet the
 code is only concerned with en-US bundles anyway. What is the plan here
 then? Don't we want to ship 6.0.6 with the donation banner enabled for as
 many users as possible (this is more a needs_information point as I am not
 sure whether we should fix the code or not)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:10 mcs]:
 > Kathy and I reviewed the JS/HTML/CSS changes. They look okay; we noticed
 just a few small things:

 Thanks for the review and catching all my mistakes!

 > - The comment says "2016 Dec 1" for the start date but the code uses
 October 1st.

 Fixed. The comment and code both now set a start date of November 15.

 > - Please remove some of the console.log() statements.

 Done.

 > - "fitt" should be "fit" in one comment.

 Fixed.

 > - The CSS has some rules for other browsers, e.g., `-khtml-user-select:
 none` (but if the same CSS file is going to be used on the website, maybe
 you do not want to remove these).

 Yes, I'll leave those in for that reason.

 > - It would be nice to clean up the
 `extensions.torbutton.donation_banner2016.shown_count` pref somehow. Maybe
 reset it after the end date has been reached? This is not a big deal
 though; I do not know if we cleaned up last year's pref.

 I've added some code to clean up the pref.

 New version: https://github.com/arthuredelstein/torbutton/commit/20414+9

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Kathy and I reviewed the JS/HTML/CSS changes. They look okay; we noticed
 just a few small things:
 - The comment says "2016 Dec 1" for the start date but the code uses
 October 1st.
 - Please remove some of the console.log() statements.
 - "fitt" should be "fit" in one comment.
 - The CSS has some rules for other browsers, e.g., `-khtml-user-select:
 none` (but if the same CSS file is going to be used on the website, maybe
 you do not want to remove these).
 - It would be nice to clean up the
 `extensions.torbutton.donation_banner2016.shown_count` pref somehow. Maybe
 reset it after the end date has been reached? This is not a big deal
 though; I do not know if we cleaned up last year's pref.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I cherry-picked the strings (commit
 269031f7aba449312189f73753e616fb82e5af48).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 After feedback from Shari, I've modified the text and layout somewhat.
 Please see images below.

 The new patches are here:
 https://github.com/arthuredelstein/torbutton/commits/20414+8
 The patch for strings alone is at
 
https://github.com/arthuredelstein/torbutton/commit/9eed15d158f4763471150a97c83bb8d772774d57

 [[Image(banner1a.png)]]
 [[Image(banner2a.png)]]
 [[Image(banner3a.png)]]
 [[Image(banner4a.png)]]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Here's the HTML/JS/CSS patch for review. For now it's only visible on US-
 English locales, but when we the strings have been translated, we can add
 another patch to show more locales.

 ​https://github.com/arthuredelstein/torbutton/commits/20414+5
 (two patches)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:5 mcs]:
 > Replying to [comment:3 arthuredelstein]:
 > > I'm working on the banner, and it's getting there, but it still needs
 some polishing. In the meantime, here are the strings (for review) we are
 going to use for the banner text. (This text was suggested by Shari, with
 minor revisions.) If these strings look OK, I would like to get these
 added to the repository ASAP so we can give the translators a chance to do
 the translation ahead of our deadline for the next release.
 > >
 > > https://github.com/arthuredelstein/torbutton/commit/20414+2
 >
 > The strings look okay to me. I am old school, so I would capitalize
 Internet... but I suspect that is not something the cool kids do these
 days.

 At the risk of losing my Cool Kid status, I think I prefer it capitalized
 as well. Here's my new version:

 https://github.com/arthuredelstein/torbutton/commit/20414+4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:3 arthuredelstein]:
 > I'm working on the banner, and it's getting there, but it still needs
 some polishing. In the meantime, here are the strings (for review) we are
 going to use for the banner text. (This text was suggested by Shari, with
 minor revisions.) If these strings look OK, I would like to get these
 added to the repository ASAP so we can give the translators a chance to do
 the translation ahead of our deadline for the next release.
 >
 > https://github.com/arthuredelstein/torbutton/commit/20414+2

 The strings look okay to me. I am old school, so I would capitalize
 Internet... but I suspect that is not something the cool kids do these
 days.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 [[Image(banner1.png)]]
 [[Image(banner2.png)]]
 [[Image(banner3.png)]]
 [[Image(banner4.png)]]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201610R, crowdfunding  |  Actual Points:
Parent ID:  #20413   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  new => needs_review
 * cc: gk, ssteele, isabela (added)
 * keywords:   => TorBrowserTeam201610R, crowdfunding


Comment:

 I'm working on the banner, and it's getting there, but it still needs some
 polishing. In the meantime, here are the strings (for review) we are going
 to use for the banner text. (This text was suggested by Shari, with minor
 revisions.) If these strings look OK, I would like to get these added to
 the repository ASAP so we can give the translators a chance to do the
 translation ahead of our deadline for the next release.

 https://github.com/arthuredelstein/torbutton/commit/20414+2

 (For reference, I will post screenshots of the banner in the next
 comment.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
--+-
 Reporter:  arthuredelstein   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #20413| Points:
 Reviewer:|Sponsor:
--+-
Changes (by mcs):

 * cc: brade, mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

[Tor Bug Tracker & Wiki]

#20414: Donation banner on about:tor page for 2016 campaign
--+-
 Reporter:  arthuredelstein   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #20413| Points:
 Reviewer:|Sponsor:
--+-
Changes (by arthuredelstein):

 * parent:   => #20413


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs