Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  refactor, easy, review-group-26  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging to master; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Oops, my master branch was about 1500 commits behind.
 Not sure how that happened. Sorry for any confusion.

 This is fine, it passes `make check` and `make test-network`.
 Let's get it merged.

 It's branch bug23760_nc in my github if you prefer branches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by teor):

 Hi,

 When I try to compile this, I get the following errors:
 {{{
 src/or/circuitbuild.c:2699:5: error: implicit declaration of function
   'node_get_curve25519_onion_key' is invalid in C99
   [-Werror,-Wimplicit-function-declaration]
 node_get_curve25519_onion_key(node);
 ^
 src/or/circuitbuild.c:2699:5: note: did you mean
   'node_has_curve25519_onion_key'?
 ./src/or/nodelist.h:78:5: note: 'node_has_curve25519_onion_key' declared
 here
 int node_has_curve25519_onion_key(const node_t *node);
 ^
 src/or/circuitbuild.c:2698:34: error: incompatible integer to pointer
 conversion
   initializing 'const curve25519_public_key_t *' (aka 'const struct
   curve25519_public_key_t *') with an expression of type 'int'
   [-Werror,-Wint-conversion]
   const curve25519_public_key_t *curve_pubkey =
  ^
 }}}

 Please import the correct header for node_get_curve25519_onion_key(), or
 put a declaration in the correct header.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by neel):

 I have a new patch which includes a changes file. The filename is
 003-node_get_extend_info-r2.patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by neel):

 * Attachment "003-node_get_extend_info-r2.patch" added.

 Patch to introduce node_get_curve25519_onion_key() in
 extend_info_from_node() (Revision 2)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by teor):

 Ok, looks good to me.

 Do you want to write a changes file?
 Any code changes get a changes file, even simple refactoring.

 Also, we should check this compiles and passes the tests before we merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by neel):

 I have an updated patch under the filename
 002-node_get_extend_info-r1.patch which makes curve_pubkey a const.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by neel):

 * Attachment "002-node_get_extend_info-r1.patch" added.

 Patch to introduce node_get_curve25519_onion_key() in
 extend_info_from_node() (Revision 1)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Hi neel, thanks for the patch!

 node_get_curve25519_onion_key() returns a const pointer, so the variable
 also has to be const. Otherwise, some compilers will complain.

 The rest of the patch looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by neel):

 I have a patch to resolve this. The filename is
 001-node_get_extend_info.patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by neel):

 * Attachment "001-node_get_extend_info.patch" added.

 Patch to introduce node_get_curve25519_onion_key() in
 extend_info_from_node()

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:  prop224, tor-hs, single-onion, ipv6, refactor, easy =>
 refactor, easy
 * parent:  #23577 =>


Comment:

 Removing the parent and spurious keywords.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node() (was: Use node_get_curve25519_key() in extend_info_from_node())

[Tor Bug Tracker & Wiki]

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion,   |  Actual Points:
  ipv6, refactor, easy   |
Parent ID:  #23577   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  prop224, tor-hs, single-onion, ipv6, refactor => prop224, tor-
 hs, single-onion, ipv6, refactor, easy


Old description:

> In #23577, we are going to implement a node_get_curve25519_key()
> function. We can use this in extend_info_from_node() if we want to.

New description:

 In #23577, we are going to implement a node_get_curve25519_onion_key()
 function. We can use this in extend_info_from_node() if we want to.

--

Comment:

 Modify the name for consistency with node_has_curve25519_onion_key().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs