Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by cypherpunks3):

 Implementing `GlobalAlloc::alloc` requires respecting the alignment in the
 Layout that's passed to it, and right now there isn't an API for
 allocating aligned memory.

 So first gotta add something like `tor_aligned_alloc` that uses
 `aligned_alloc` (C11), `_aligned_malloc` (Windows), or `posix_memalign` or
 `memalign`. And you'd have to make the original `tor_malloc` forward to
 the new function, too, it can't keep calling `malloc`.

 At least it seemingly can't on Windows, because pointers returned by
 `_aligned_malloc` have to be freed with `_aligned_free`. The docs say
 [https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/aligned-
 malloc Using free is illegal.] And there'd be no way to distinguish which
 pointers were allocated by which.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.6.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by chelseakomlo):

 Replying to [comment:8 cypherpunks3]:
 > `GlobalAlloc` is now stable.
 >  https://doc.rust-lang.org/stable/std/alloc/trait.GlobalAlloc.html
 >  https://blog.rust-lang.org/2018/08/02/Rust-1.28.html

 Excellent, this is great news. Thanks for updating this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by cypherpunks3):

 `GlobalAlloc` is now stable.
  https://doc.rust-lang.org/stable/std/alloc/trait.GlobalAlloc.html
  https://blog.rust-lang.org/2018/08/02/Rust-1.28.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, rust-pilot  |  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:  Sponsor8-can
--+

Comment (by isis):

 The tracking issue for stabilisation of the `std::heap::Alloc` trait is
 here https://github.com/rust-lang/rust/issues/32838, which is probably
 also important since the global allocator feature that Manish linked to
 requires that we `impl<'a> Alloc for &'a TorAlloc`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, rust-pilot  |  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:  Sponsor8-can
--+
Changes (by chelseakomlo):

 * cc: chelseakomlo (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23882 [Core Tor/Tor]: Investigate implementing a Rust allocator wrapping tor_malloc

[Tor Bug Tracker & Wiki]

#23882: Investigate implementing a Rust allocator wrapping tor_malloc
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.2-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, rust-pilot  |  Actual Points:
Parent ID:| Points:  3
 Reviewer:|Sponsor:  Sponsor8-can
--+

Comment (by manish.earth):

 The tracking issue for stabilization is at https://github.com/rust-
 lang/rust/issues/27389 . FF isn't using it, but I would like it to.

 I'll be trying to get stabilization to happen soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs