Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+
Changes (by nickm):

 * status:  reopened => closed
 * resolution:   => implemented


Comment:

 Changes file added as 8441189b3caee2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Note: this is missing a changes file!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 then, merged!  thanks for the review and the testing!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 The code looks fine, lgtm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+

Comment (by nickm):

 I'd be okay with taking this before we test it on hardware we don't have,
 and letting the integration tests let us know if we missed anything... so
 long as the code looks okay?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf, review-group-27  |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:  teor  |Sponsor:  Sponsor8
--+
Changes (by teor):

 * reviewer:   => teor


Comment:

 This compiles and passes make check for me on macOS 10.12, x86_64, Apple
 clang 9.0.0.
 I haven't tested it on i386, because I don't have the libraries installed
 on my local machine.

 I checked that mach_time_info.numer and denom are around the right way.

 The quotient can be up to 40 on PowerPC macs, see:
 https://stackoverflow.com/questions/23378063/how-can-i-use-mach-absolute-
 time-without-overflowing

 I think we are safe from overflow here. And in this context, the divide
 then multiply inaccuracy doesn't matter.

 Next step is to check on i386 and mobile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf   |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:|Sponsor:  Sponsor8
--+
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf   |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:|Sponsor:  Sponsor8
--+

Comment (by nickm):

 I believe `monotime_coarse_stamps` is ready for review, though I want to
 double-check the numer/denom stuff for osx.

 As a followup ticket, we should look into using this for the padding
 timers as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf   |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:|Sponsor:  Sponsor8
--+

Comment (by nickm):

 Note to self -- I've started work here in a branch called
 `coarse_monotime_032`. Right now the unit tests are broken and it wastes a
 bunch of RAM.

 I've also just thought of a better way: `monotime_coarse_stamps` has the
 key concept, though it isn't finished.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24374 [Core Tor/Tor]: Reduce monotime_coarse_absolute_msec() usage

[Tor Bug Tracker & Wiki]

#24374: Reduce monotime_coarse_absolute_msec() usage
--+
 Reporter:  ahf   |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  s8-perf   |  Actual Points:
Parent ID:  #24062| Points:
 Reviewer:|Sponsor:  Sponsor8
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted
 * milestone:   => Tor: 0.3.3.x-final


Comment:

 This shouldn't be hard.  The trick will be to use monotime_coarse_t in
 more places, and only convert to msec as lazily as possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs