Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
  029-backport 032-backport  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks!  Cherry-picked to 0.2.9 as
 a350f216b30c5841b8eb0303c9c3fd32a2b2245b; added a changes file as
 27a2a6cb9b8a590a88c479539efae7bd31a4102f; and merged forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
  029-backport 032-backport  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by Jigsaw52):

 It's a good ideia. I've tested it just to be sure it works and it does.
 I've updated my branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
  029-backport 032-backport  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326, 033-backport, AffectsTails,
 034-deferred-20180602, 035-removed-20180711
 =>
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326, 033-backport, AffectsTails,
 034-deferred-20180602, 035-removed-20180711 029-backport 032-backport


Comment:

 (Otherwise this looks fine to me.  It appears that the bug is present in
 0.2.9 and later, so we'll want to backport to maint-0.2.9 when we take
 it.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 What would you think about using "unsigned int" instead of "uint32_t"?
 That way, if the "int fd" argument to openat() ever becomes 64-bit, the
 unsigned cast should still do the right thing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => needs_review
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  033-backport, AffectsTails,|
  034-deferred-20180602, 035-removed-20180711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Jigsaw52):

 After looking at this again, I think my fix will not ruin anyone's day.
 My fix would only cause problems if AT_FDCWD is a 64bits value. As far as
 I know, there is no system currently using 64bits values for this
 constant.

 I've rebased my branch with the current master and wrote a better commit
 message:

 https://github.com/Jigsaw52/tor/tree/fix-25440

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 This is also a problem on the soon to be released (2018-04-26) Ubuntu
 18.04 with tor 0.3.2.10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Jigsaw52):

 The problem is related to AT_FDCWD being a negative constant and
 libseccomp using uint64_t for parameters.

 See https://github.com/seccomp/libseccomp/issues/69#issuecomment-273805980

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Jigsaw52):

 I was wrong. The number of parameters is just strace pretty printing the
 call. The syscall is exactly the same on both cases.

 The problem is related to the constant AT_FDCWD.
 The changes on this branch fixed the problem on my machine:

 https://github.com/Jigsaw52/tor/tree/quick-fix-25440

 It does not work if I only change SCMP_CMP_STR to SCMP_CMP. The cast for
 uint32_t is needed. I do not know why and I think they will break on other
 machines but it seems like a good starting point for a better solution.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Jigsaw52):

 * cc: danielpinto52@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Jigsaw52):

 * Attachment "orconfig.h" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Jigsaw52):

 * Attachment "strace.log" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Jigsaw52):

 * Attachment "tor.log" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Jigsaw52):

 I believe I am experiencing the same issue, with the master branch, on
 Ubuntu 18.04 64bits, which uses libc 2.27.

 I can confirm the string is being interned correctly: I have checked the
 pointers on the sandbox initialization and on the failing syscall and they
 are the same.

 I have tor run under strace and greped for openat calls and noticed
 something: the openat call that kills tor has and extra argument which all
 the others do not.
 I believe the cause of this problem could be related to this.

 I have attached my logs and my orconfig.h file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport, AffectsTails |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by intrigeri):

 * keywords:
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326 033-backport
 =>
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326 033-backport, AffectsTails


Comment:

 (Assuming removing the AffectsTails keyword was a mistake. Sorry if it was
 not :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ageisp0lis):

 >
 > Question 1: Can you tell me, what version of libc exactly does your
 system use?  I am wondering if maybe we have a problem in our
 implementation of libc_uses_openat_for_everything, which checks for a
 version later than 2.26.

 Thought I had replied to you already but didn't see it on the ticket!
 Oops. Pretty sure I was using 2.27.

 >
 > Question 2: And if you're building Tor from source, could you attach the
 orconfig.h file that is generated when you run "configure" to build tor?

 Was running official binaries from your apt repository, in the 'buster'
 distribution, not built from source.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
  033-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326, AffectsTails
 =>
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326 033-backport
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 We're not going to figure this out on schedule for 0.3.3, but maybe we can
 backport if the fix isn't too complicated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326,|
  AffectsTails   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by intrigeri):

 * cc: intrigeri (added)
 * keywords:
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326
 =>
 sandbox, 033-must, regression, 033-triage-20180326,
 033-included-20180326, AffectsTails


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by intrigeri):

 I see a very similar startup failure on the development version of Tails
 based on Debian 10 (Buster); to r is 0.3.2.10-1, libc6 is 2.27-2 (both
 from Debian testing).


 {{{
 [notice] Tor 0.3.2.10 (git-0edaa32732ec8930) running on Linux with
 Libevent 2.1.8-stable, OpenSSL 1.1.0h, Zlib 1.2.8, Liblzma 5.2.2, and
 Libzstd 1.3.3.
 [notice] Tor can't help you if you use it wrong! Learn how to be safe at
 https://www.torproject.org/download/download#warning
 [notice] Read configuration file "/usr/share/tor/tor-service-defaults-
 torrc".
 [notice] Read configuration file "/etc/tor/torrc".
 [warn] Skipping obsolete configuration option 'ControlListenAddress'
 [warn] Skipping obsolete configuration option 'TransListenAddress'
 [warn] Skipping obsolete configuration option 'WarnUnsafeSocks'
 lid
 [notice] Tor 0.3.2.10 (git-0edaa32732ec8930) running on Linux with
 Libevent 2.1.8-stable, OpenSSL 1.1.0h, Zlib 1.2.8, Liblzma 5.2.2, and
 Libzstd 1.3.3.
 [notice] Tor can't help you if you use it wrong! Learn how to be safe at
 https://www.torproject.org/download/download#warning
 [notice] Read configuration file "/usr/share/tor/tor-service-defaults-
 torrc".
 [notice] Read configuration file "/etc/tor/torrc".
 [warn] Skipping obsolete configuration option 'ControlListenAddress'
 [warn] Skipping obsolete configuration option 'TransListenAddress'
 [warn] Skipping obsolete configuration option 'WarnUnsafeSocks'
 [notice] Scheduler type KIST has been enabled.
 [notice] Opening Socks listener on 127.0.0.1:9050
 [notice] Opening Socks listener on 127.0.0.1:9062
 [notice] Opening Socks listener on 127.0.0.1:9150
 [notice] Opening DNS listener on 127.0.0.1:5353
 [notice] Opening Transparent pf/netfilter listener on 127.0.0.1:9040
 [notice] Opening Control listener on 127.0.0.1:9052
  T= 1522412451
 (Sandbox) Caught a bad syscall attempt (syscall openat)
 /usr/bin/tor(+0x1a2f3a)[0x5fe2178aff3a]
 /lib/x86_64-linux-gnu/libpthread.so.0(open64+0x4b)[0x7b392350d3ab]
 /usr/bin/tor(tor_open_cloexec+0x40)[0x5fe217896260]
 /usr/bin/tor(start_writing_to_file+0x17a)[0x5fe2178a9a3a]
 /usr/bin/tor(+0x19cb1b)[0x5fe2178a9b1b]
 /usr/bin/tor(+0x19cc68)[0x5fe2178a9c68]
 /usr/bin/tor(networkstatus_set_current_consensus+0xc99)[0x5fe21776c3e9]
 /usr/bin/tor(connection_dir_reached_eof+0x14cb)[0x5fe217841ccb]
 /usr/bin/tor(+0x10c9d9)[0x5fe2178199d9]
 /usr/bin/tor(+0x52a1e)[0x5fe21775fa1e]
 /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(+0x229ba)[0x7b39249ac9ba]
 /usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.6(event_base_loop+0x5a7)[0x7b39249ad537]
 /usr/bin/tor(do_main_loop+0x28d)[0x5fe21776096d]
 /usr/bin/tor(tor_main+0xe1d)[0x5fe21776378d]
 /usr/bin/tor(main+0x19)[0x5fe21775c1b9]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7b3922f5fa87]
 /usr/bin/tor(_start+0x2a)[0x5fe21775c20a]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox, 033-must, regression,   |  Actual Points:
  033-triage-20180326, 033-included-20180326 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_information


Comment:

 Hi!  I've been staring at this for a few weeks, and I think we might
 actually have a way to progress.

 So, openat() has to be happening within the start_writing_to_file() in the
 stack, which is happening inside write_str_to_file() in or_state_save().
 And start_writing_to_file calls tor_open_cloexec, which always calls
 sandbox_intern_string().

 The sandbox_intern_string() function will log a warning if the string
 wasn't interned.  We didn't see that warning, so the string was indeed
 interned.

 Question 1: Can you tell me, what version of libc exactly does your system
 use?  I am wondering if maybe we have a problem in our implementation of
 libc_uses_openat_for_everything, which checks for a version later than
 2.26.

 Question 2: And if you're building Tor from source, could you attach the
 orconfig.h file that is generated when you run "configure" to build tor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
-+-
 Reporter:  ageisp0lis   |  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  sandbox 033-must regression  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  (none) => nickm
 * keywords:  sandbox => sandbox 033-must regression
 * status:  new => accepted
 * milestone:   => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25440 [Core Tor/Tor]: Broken openat syscall in Sandbox mode

[Tor Bug Tracker & Wiki]

#25440: Broken openat syscall in Sandbox mode
--+
 Reporter:  ageisp0lis|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  sandbox   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * component:  Core Tor => Core Tor/Tor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs