Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+-
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  closed
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Great! Squashed and merged. Will deploy later today. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+-
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  merge_ready
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Looks fine and can be just one commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+--
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:6 iwakeh]:
 > The webstats/MainTest fails.  Maybe, remove or replace by other tests
 (it seems to test log line parsing, which is done in metrics-lib now).

 Hmm, you're right. Everything's tested in metrics-lib, so we can just
 remove this test.

 > Please take a look at [https://gitweb.torproject.org/user/iwakeh
 /metrics-web.git/commit/?h=task-25520 this patch].
 > I tweaked the use of streams a little.  Log line counts could be bigger
 than integer: use long in java and bigint in sql.  If you think that it
 suffices to use int (and don't want to alter the db table) please
 introduce a cast to int at before writing to the db.

 Looks good. I'll alter the database table as part of deployment.

 Please find my updated branch with your commit and with the removed test
 class. I think I'd like to squash all three commits into one, unless you
 think that's a bad idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  needs_revision
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 The webstats/MainTest fails.  Maybe, remove or replace by other tests (it
 seems to test log line parsing, which is done in metrics-lib now).

 Please take a look at [https://gitweb.torproject.org/user/iwakeh/metrics-
 web.git/commit/?h=task-25520 this patch].
 I tweaked the use of streams a little.  Log line counts could be bigger
 than integer: use long in java and bigint in sql.  If you think that it
 suffices to use int (and don't want to alter the db table) please
 introduce a cast to int at before writing to the db.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+--
Changes (by karsten):

 * priority:  Medium => High
 * status:  accepted => needs_review
 * reviewer:   => iwakeh


Comment:

 Please review [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-25520=4ca4df91fcd05720ba717e0d96fb66f6229dd7cf
 commit 4ca4df9 from my task-25520 branch].

 Optimistically assigning iwakeh as reviewer. :)

 Setting priority to high, because I'd really like to cross this off the
 list by end of the month.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * owner:  iwakeh => karsten


Comment:

 Grabbing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  iwakeh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by iwakeh):

 Fine, this is down on a list, so you can just grab the ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  iwakeh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by karsten):

 Oh, wait, I started hacking on this after we talked yesterday. Mind
 picking something else for now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

[Tor Bug Tracker & Wiki]

#25520: Adapt webstats to read CollecTor provided logs
+--
 Reporter:  iwakeh  |  Owner:  iwakeh
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * cc: metrics-team (added)
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs