Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 0.3.3 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by atagar):

 Looks great to me! Thanks David.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  fast-fix, 033-included-20180403  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 To address atagar's comment about having a mention about the formatting
 hacks, I've added a commit that does that to all options like this one:

 See branch: `bug25582_033` (based on nickm's from above).

 This is ready to merge imo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 LGTM, though again I think this (and the other options mentioned above)
 should be accompanied by a comment saying that they're formatting hacks so
 it's clear they're not intended to be a torrc option.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Fix in `bug25582_033`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 Oh! Did a little more looking and it's not there to provide an anchor at
 all. Rather, it's a hack so the following text is formatted as a
 paragraph. This is discussed in #20885.

 Sure, reverting that line back to an anchor sounds good. Preferably with a
 comment above that, the SocksPortFlagsMisc, and ORPortFlagsExclusive (if
 they're still around) to explain that these are formatting hacks rather
 than intentional anchors.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 let's leave the anchor in -- somebody may be using it, and I'd rather not
 remove anchors once we've added them, unless they're ''completely''
 pointless.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 Gotcha. Is such an anchor useful? I just did a quick grep of webwml but no
 hits. An anchor seems pretty boot if nothing links to it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25582 [Core Tor/Tor]: Manual includes non-existant ExitPolicyDefault option

[Tor Bug Tracker & Wiki]

#25582: Manual includes non-existant ExitPolicyDefault option
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Have a look at the state before 3563a2c8194ebe9430603803a53b073e181ce773
 -- I think that it was meant to be an anchor only, with no label.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs