Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+
Changes (by atagar):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Hi dmr, sorry about the delay! Change looks good, pushed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--
Changes (by dmr):

 * status:  assigned => needs_review


Comment:

 Replying to [comment:4 dmr]:
 > teor:
 > I don't fully get the `AssumeReachable` option.
 > I'm running `Tor 0.3.2.10 (git-0edaa32732ec8930)` and this is what my
 `man torrc` says:
 >
 > {{{
 > AssumeReachable 0|1
 > This option is used when bootstrapping a new Tor network. If set to
 1, don’t do self-reachability
 > testing; just upload your server descriptor immediately. If
 AuthoritativeDirectory is also set, this
 > option instructs the dirserver to bypass remote reachability testing
 too and list all connected
 > servers as running.
 > }}}
 >
 > I'm assuming that the part about `just upload your server descriptor
 immediately` is moot with `PublishServerDescriptor 0`, although that's not
 quite clear from the manual. So I'm assuming the combo means `don’t do
 self-reachability testing`, which //does// sound quite appropriate for a
 local test relay, although I'm not sure what reachability testing looks
 like. (Just thought I'd ping you for confirmation and a potential learning
 opportunity for me.)

 I think it's a safe assumption for me that this is a good change :).
 Without knowing more about reachability testing, I'd imagine it
 constitutes some sort of outbound communication to check whether our
 ORPort is reachable from another relay. Since we explicitly don't want to
 publish info to contact our relay, turning off this sort of behavior just
 makes sense to me (if it //is// as I'm guessing it to be).

 I've pushed another commit to the github branch:
 `g...@github.com:dmr-x/stem.git` branch `25631-integ-torrc` commit
 `37d11c67773361bbebf521691d57468e6ea51d32`

 web links:
 ​https://github.com/dmr-x/stem/tree/25631-integ-torrc
 https://github.com/dmr-x/stem/commit/37d11c67773361bbebf521691d57468e6ea51d32

 atagar and/or teor: please review :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--

Comment (by dmr):

 Replying to [comment:4 dmr]:
 > `ProtocolWarnings 1`, `SafeLogging 0`, and `LogTimeGranularity 1` all
 look good; I'll file that as another trac ticket just because I feel they
 constitute an enhancement, not a defect. :)
 Filed; see #25632

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--

Comment (by dmr):

 teor:
 I don't fully get the `AssumeReachable` option.
 I'm running `Tor 0.3.2.10 (git-0edaa32732ec8930)` and this is what my `man
 torrc` says:

 {{{
 AssumeReachable 0|1
 This option is used when bootstrapping a new Tor network. If set to 1,
 don’t do self-reachability
 testing; just upload your server descriptor immediately. If
 AuthoritativeDirectory is also set, this
 option instructs the dirserver to bypass remote reachability testing
 too and list all connected
 servers as running.
 }}}

 I'm assuming that the part about `just upload your server descriptor
 immediately` is moot with `PublishServerDescriptor 0`, although that's not
 quite clear from the manual. So I'm assuming the combo means `don’t do
 self-reachability testing`, which //does// sound quite appropriate for a
 local test relay, although I'm not sure what reachability testing looks
 like. (Just thought I'd ping you for confirmation and a potential learning
 opportunity for me.)


 `ProtocolWarnings 1`, `SafeLogging 0`, and `LogTimeGranularity 1` all look
 good; I'll file that as another trac ticket just because I feel they
 constitute an enhancement, not a defect. :)

 `SOCKSPort 0` doesn't make sense - at least //not right now//. There's
 only a chief torrc used as the base for integration tests in stem, many of
 which rely on the SocksPort.

 I would agree that it makes sense in the future to split this up into
 multiple torrc sets for different tests.

 Thanks again for the feedback! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--
Changes (by dmr):

 * status:  needs_review => assigned


Comment:

 teor: thanks! Looking over those options now. Assigning self again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--
Changes (by dmr):

 * status:  assigned => needs_review


Comment:

 atagar:
 I've rebased the original patch for this and pushed the commit up to a
 public repo on github.
 `g...@github.com:dmr-x/stem.git` branch `25631-integ-torrc` commit
 `2a91f9e35f6bd7f40d1894128b0a362aa359dae4`

 web links:
 https://github.com/dmr-x/stem/tree/25631-integ-torrc
 https://github.com/dmr-x/stem/commit/2a91f9e35f6bd7f40d1894128b0a362aa359dae4

 Please review! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25631 [Core Tor/Stem]: Integration tests set up and publish descriptors for an exit relay

[Tor Bug Tracker & Wiki]

#25631: Integration tests set up and publish descriptors for an exit relay
---+--
 Reporter:  dmr|  Owner:  dmr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  atagar |Sponsor:
---+--

Comment (by teor):

 You might want some of the other options from endosome's test relay
 script:
 {{{
 AssumeReachable 1
 ProtocolWarnings 1
 SafeLogging 0
 LogTimeGranularity 1
 SOCKSPort 0
 }}}
 https://github.com/teor2345/endosome/blob/master/relay-local.sh

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs