Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:  Sponsor8-can
-+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:  Sponsor8-can
-+

Comment (by nickm):

 Okay, we've run out of time on merging the parent, so we're going to merge
 this removal and hope for the best.  If it turns out we do need this
 feature, we'll have to restore it and refactor it to use the new token
 buffer code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:  Sponsor8-can
-+

Comment (by robgjansen):

 Replying to [comment:2 nickm]:
 > Thanks, Rob!
 >
 > Is there anybody else you think I should ask?  Otherwise I think I
 should remove these fast, since they're getting in the way.

 Since this is a testing network event, I think the primary consumers would
 be Shadow and chutney. For Shadow, there is a chance that some researcher
 out there is using the event, but I doubt this is the case (and I don't
 recalling having been asked any questions about it). For chutney, I think
 you and teor are among the main users. The only other person that comes to
 mind is Karsten.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:  Sponsor8-can
-+
Changes (by nickm):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:   |Sponsor:  Sponsor8-can
-+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 whoops, hit "submit changes" too early.

 In the meantime, could I have a review on my branch `remove_tb_empty`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:   |Sponsor:  Sponsor8-can
-+
Changes (by nickm):

 * status:  assigned => accepted


Comment:

 In the meantime

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:   |Sponsor:  Sponsor8-can
-+

Comment (by nickm):

 Thanks, Rob!

 Is there anybody else you think I should ask?  Otherwise I think I should
 remove these fast, since they're getting in the way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask  |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:   |Sponsor:  Sponsor8-can
-+

Comment (by robgjansen):

 We are collecting and logging these events in our Shadow experiments, but
 we haven't recently been using the data in any analysis. At this point, I
 think the benefits of cleaner code outweighs the benefits of keeping the
 event around. Thank you for checking!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs