Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:  wontfix
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:  #25386| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => wontfix


Comment:

 Now that we have alex's fixes, we don't need to make this change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:  #25386| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:  #25386| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by teor):

 * parent:   => #25386


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+

Comment (by chelseakomlo):

 As an update from https://trac.torproject.org/projects/tor/ticket/25386,
 it looks like only doctests and compiling with sanitizers are not working
 as expected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+

Comment (by chelseakomlo):

 Replying to [comment:9 nickm]:
 > I've merged this to master, and added some previously missing items to
 build.rs.
 >
 > Before we close this, I think we should have a note about how to
 actually invoke these tests, if you do want to enable them.  I tried
 adding --features=test-c-from-rust to test_rust.sh, but it makes most of
 our crates' tests fail.

 Adding a note that fixing
 https://trac.torproject.org/projects/tor/ticket/25386#comment:74 will
 allow us to remove this feature gate, and something that we should
 prioritize.

 In the next couple weeks I will organize a discussion at a patch party and
 work with some Rust people to make sure we can resolve this in a way that
 allows us to run the full test suite (if someone else wants to take this
 on organizing this sooner, please do and I will attend said discussion).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.5.x-final


Comment:

 (Also I'm inclined to say "no 0.3.4 backport" here.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+

Comment (by nickm):

 I've merged this to master, and added some previously missing items to
 build.rs.

 Before we close this, I think we should have a note about how to actually
 invoke these tests, if you do want to enable them.  I tried adding
 --features=test-c-from-rust to test_rust.sh, but it makes most of our
 crates' tests fail.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_information
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by nickm):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  nickm |Sponsor:
  |  Sponsor8-can
--+
Changes (by dgoulet):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+
Changes (by catalyst):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:6 isis]:
 > Looking at the current status of #25386 it seems there's still going to
 be linker issues, particularly from doctests, for the time being until
 everything has rustc 1.27 stable (when the `-C` option [https://github.com
 /rust-
 lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f was
 added] to rustdoc). But also, feel free to disagree.
 >
 > It might be good to have a configurable way to disable this stuff until
 all the issues are resolved, that way teor and I can continue writing
 tests as we would normally for now.  In the future, it also gives us an
 easier way to enable running the tests all the time, when we remove C code
 (e.g. if I were to write a sha2 or keccak implementation and we used that
 instead of the C code).
 After thinking about the current situation some more, I think we want to
 adopt something  like this approach.  Right now there is a restricted set
 of Rust testing configurations that we run in Travis, instead of the more
 comprehensive set that we used to do.  Basically, on master, none of the
 older Travis subjobs with Rust enabled pass tests because of linker
 problems with `--enable-fragile-hardening`.

 I put this back in "needs_review" because I want to make sure we do
 something reasonable with the doctests in the crypto crate, and a few
 potentially conflicting changes to Rust tests have happened on master
 since the original pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+

Comment (by isis):

 Replying to [comment:5 teor]:
 > Replying to [comment:4 nickm]:
 > > Isis, Catalyst: Do you still think we should merge this?
 >
 > I think I'll need it for the PrivCount noise branch. Or did we fix the
 linker issues?

 Looking at the current status of #25386 it seems there's still going to be
 linker issues, particularly from doctests, for the time being until
 everything has rustc 1.27 stable (when the `-C` option [https://github.com
 /rust-
 lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f was
 added] to rustdoc).

 It might be good to have a configurable way to disable this stuff until
 all the issues are resolved, that way teor and I can continue writing
 tests as we would normally for now.  In the future, it also gives us an
 easier way to enable running the tests all the time, when we remove C code
 (e.g. if I were to write a sha2 or keccak implementation and we used that
 instead of the C code).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+

Comment (by teor):

 Replying to [comment:4 nickm]:
 > Isis, Catalyst: Do you still think we should merge this?

 I think I'll need it for the PrivCount noise branch. Or did we fix the
 linker issues?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+

Comment (by nickm):

 Isis, Catalyst: Do you still think we should merge this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Thanks! Looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+

Comment (by isis):

 PR is https://github.com/torproject/tor/pull/158

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26398 [Core Tor/Tor]: feature gate testing C code from Rust for now

[Tor Bug Tracker & Wiki]

#26398: feature gate testing C code from Rust for now
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.3.3.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-test, fast-fix, tor-ci  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
  |  Sponsor8-can
--+
Changes (by isis):

 * status:  assigned => needs_review


Comment:

 See my `bug26400` branch. Note that the tests on it will fail until #26400
 is merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs