Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Applied to `master` (commit 5cd65aaa478a41bd8c98a5405a5bf5b82256ca67).
 Yay!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810R
 * status:  needs_revision => needs_review


Comment:

 Commit `95ddadc04cd34315c91348a78cb928672e19cee4` looks good to me. I
 think we can merge it after we know we won't need to do rebuilds for
 8.5a4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Fixed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 In commit `7d14d1b96aaf5c5718fdf9ed6ad8986abfa6902d` the trailing white
 space is removed, but now there is a typo: `ha256sum` instead of
 `sha256sum`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:13 boklm]:

 > Replying to [comment:12 sisbell]:
 >
 >
 >
 > > Removed trailing white space: https://github.com/sisbell/tor-browser-
 build/commits/android-1017
 > >
 > >
 > >
 >
 > In commit `9f90042f71ec8d509c7beb5e9efeb97a8390aa3a` from the
 `android-1017` branch, I still see a trailing white space after the
 sha256sum. Actually the commit is the same in the `android-rebased` and
 the `android-1017` branch.
 > > Fixed, try now

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:12 sisbell]:
 > Removed trailing white space: https://github.com/sisbell/tor-browser-
 build/commits/android-1017

 In commit `9f90042f71ec8d509c7beb5e9efeb97a8390aa3a` from the
 `android-1017` branch, I still see a trailing white space after the
 sha256sum. Actually the commit is the same in the `android-rebased` and
 the `android-1017` branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Removed trailing white space: https://github.com/sisbell/tor-browser-
 build/commits/android-1017

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, this works for me I think. Just the nit in comment:9 and we can
 merge this part.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810R => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 One nit: This contains a trailing whitespace after the sha256 sum. Please
 remove it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * priority:  Medium => High
 * status:  needs_revision => needs_review


Comment:

 Commit `9f90042f71ec8d509c7beb5e9efeb97a8390aa3a` looks good. I think it
 can be merged, once it has been checked that it doesn't break generation
 of other images.

 Setting priority to High, as this is the first commit we need to merge
 before being able to merge the others.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Added 18.04.1 version to config. This still needs to be tested to make
 sure it doesn't break anything. I'll do testing this week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201809R => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809


Comment:

 Replying to [comment:2 sisbell]:
 > Commit: !https://github.com/sisbell/tor-browser-
 build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

 Some comments about this patch:
 - subject of the commit should be in the format "Bug XXX: description"
 - maybe something like "add support for stretch in debootstrap-image" is
 more clear than "Update Debian Image to use Stretch"
 - it seems there is a `18.04.1` ubuntu release, so maybe we should use
 that instead of `18.04`.

 Otherwise this looks good. Before merging this we should also check that
 changing the ubuntu version does not break generation of the other debian
 images (for instance by trying to do a full build of Tor Browser for
 Windows/Linux/macOS with this patch).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201808 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809R
 * status:  new => needs_review
 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Commit: !https://github.com/sisbell/tor-browser-
 build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch

[Tor Bug Tracker & Wiki]

#27441: Update Debian Image to use Stretch
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Also see #26976 Hardening Wrapper Removed in Debian Stretch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs