Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-18 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  CollecTor
  |  1.7.0
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * milestone:  Tor: 0.3.5.x-final => CollecTor 1.7.0


Comment:

 Squashed and merged to master (0.3.6)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-18 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-17 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_revision => merge_ready


Comment:

 lgtm. I've cherry pick the fixup:

 Branch: `ticket27549_035_01`
 PR: ​https://github.com/torproject/tor/pull/355

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-17 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+

Comment (by dgoulet):

 lgtm;

 We'll need a PR here asn if you can push one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-17 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Marking as needs_revision to make it obvious that an action is requested
 from dgoulet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-16 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, hs-auth, refactoring  |  Actual Points:
Parent ID:  #27544| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by traumschule):

 * keywords:  tor-hs, refactoring => tor-hs, hs-auth, refactoring


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-10-16 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:  asn  |Sponsor:
-+--

Comment (by asn):

 I pushed a fixup on my branch `ticket27549_035_01` that kills the helper
 functions to simplify the patch.

 The helper functions did not help with simplifying the code or with making
 it more abstract since the underlying code still needed to know the
 structure of keys to do:
 {{{
 -  memcpy(client_out->client_id,
 - get_client_id_from_keys(keystream), HS_DESC_CLIENT_ID_LEN);
 }}}

 Please review and mark as merge_ready if you like it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-18 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dgoulet):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-18 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by dgoulet):

 Branch: `ticket27549_035_01`
 PR: https://github.com/torproject/tor/pull/355

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-18 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * owner:  neel => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * status:  new => assigned
 * owner:  (none) => neel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * cc: neel (removed)
 * owner:  neel => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27549 [Core Tor/Tor]: hs-v3: Refactor the descriptor cookie computation code

2018-09-07 Thread Tor Bug Tracker & Wiki 
#27549: hs-v3: Refactor the descriptor cookie computation code
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, refactoring  |  Actual Points:
Parent ID:  #27544   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by neel):

 * cc: neel (added)
 * owner:  (none) => neel
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs