Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Ok, I merged it to master as commits
 8aeb04965f9993b7572c7fe98d9ad3e0b2fe4453,
 6ca067d2d716283c47c6b2fb822305e61b16e168,
 9b4b31f5bacfffb2b35e914fe5535999c7db45e1,
 84d95d6d2a51d93f62e9927cfa2e63e674066c7d and
 023ce30eb3c6082af3353fe6876c202d849cfea8.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:52 boklm]:
 > The patches from branch `gk/bug_28238_v16` look good to me.
 >
 > I think a possible improvement is defining `var/setup` in
 `projects/mingw-w64-clang/config` so that we can define `var/compiler` in
 the projects where we want to use it:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=1510201478c07569466e1fea83873dd1ffb4c1ca
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=d93e89635eae1718b0c44be0d698e998754d4289
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=5ef691810ea0e4f97d9262283947298756b88507
 >
 > In branch `bug_28238_v3` I squashed the suggested fixup patches, and
 rebased on master:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/log/?h=bug_28238_v3
 >
 > I am currently testing a build with this branch.

 Works for me and the fixups look good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 The patches from branch `gk/bug_28238_v16` look good to me.

 I think a possible improvement is defining `var/setup` in
 `projects/mingw-w64-clang/config` so that we can define `var/compiler` in
 the projects where we want to use it:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=1510201478c07569466e1fea83873dd1ffb4c1ca
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=d93e89635eae1718b0c44be0d698e998754d4289
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2=5ef691810ea0e4f97d9262283947298756b88507

 In branch `bug_28238_v3` I squashed the suggested fixup patches, and
 rebased on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/log/?h=bug_28238_v3

 I am currently testing a build with this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:46 tom]:
 > > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 > >
 > > I think we don't need it when building with `mingw-w64-clang`. At
 least the build passes and I'd suspect compile time issues if that were a
 problem.
 > >
 >
 > No, from my recollection it will compile fine but won't run if the dll
 is missing from the directory.  (However if firefox builds, then fxc2
 didn't error and it worked...)
 >
 >
 > > >  - I'm not sure what you do about PDBs; but it would be good to get
 a bug on file about generating/outputting them. (Perhaps in some
 configuration generating the static clang libraries with debug info also.)
 > >
 > > I agree. Right now don't generate them.
 >
 > I suspect you do generate them; but without setting MOZ_COPY_PDBs they
 are not winding up next to the outputed files so they're not winding up in
 the final tarball. You could stick that into the mozconfig and see if they
 show up though.

 I think that might be true for 64bit, yes. However, for 32bit we
 explicitly set `--disable-debug-symbols` as we are still not cross-
 compiling 64bit->32bit (which #30384 should solve). Anyway, I've filed
 #31546 for generatin/exposing PDB files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:45 gk]:
 > Replying to [comment:44 tom]:
 > >  - Have you confirmed you don't need the spec thing for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1460801 ?  (If so, I can
 close that bug.)
 >
 > I think it worked for me back then a couple of months ago when I worked
 on the toolchain. I'll double-check with nightly builds once things landed
 but am optimistic.
 >
 > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 >
 > I think we don't need it when building with `mingw-w64-clang`. At least
 the build passes and I'd suspect compile time issues if that were a
 problem.
 >
 > >  - I see some flags in our mozconfig you don't have:
 > >- https://searchfox.org/mozilla-
 
central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/config/mozconfigs/win32/mingwclang#53-54
 >
 > Yes, I am not sure why we don't need those but the build is not
 breaking, so we could leave that investigation for later.

 From reading a bit more in the respective Mozilla bug I think we don't
 need those lines as we only have one clang available in our build
 environment (the one we intend to get used). Thus, there won't be any
 potential compiler confusion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:45 gk]:
 > Replying to [comment:44 tom]:
 > >  - Have you confirmed you don't need the spec thing for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1460801 ?  (If so, I can
 close that bug.)
 >
 > I think it worked for me back then a couple of months ago when I worked
 on the toolchain. I'll double-check with nightly builds once things landed
 but am optimistic.

 I think this works now without the spec hack due to switching to ucrt
 which should be available on all supported platforms. It seems both 64bit
 and 32bit bundles are working both on Windows 7 and Windows 10 systems and
 I tried the new 32bit version on my Windows 7 box where I previously had
 the problem at hand. However, it works there as well now. Thus, I'd say we
 are good here. I'll close the respective bugs on our side once the patch
 for this bug lands.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Replying to [comment:47 gk]:
 > Replying to [comment:46 tom]:
 > > > >  - fxc2 requires the winpthread dll to be in its bin directly
 IIRC; but I don't see where you're copying that. (I might have missed it.
 If you're not getting errors on fxc2 it must be working.)
 > > >
 > > > I think we don't need it when building with `mingw-w64-clang`. At
 least the build passes and I'd suspect compile time issues if that were a
 problem.
 > > >
 > >
 > > No, from my recollection it will compile fine but won't run if the dll
 is missing from the directory.  (However if firefox builds, then fxc2
 didn't error and it worked...)
 >
 > Another thought here: how are you compiling `fxc2`? I recall that I
 needed to resort to the .dll when compiling `fxc2` with `mingw-w64-gcc`,
 which was my main motivation to use `mingw-w64-clang` when building `fxc2`
 as well.

 No, you're right - I completely misremembered; I'm sorry. When I cut fxc2
 over to mingw-clang I got rid of needing winpthread (which makes sense now
 that I think more deeply about it.)  https://hg.mozilla.org/mozilla-
 central/rev/918d2aeb31eb7d18603be0c5f6ae9b27c12b6fc2

 Sorry!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:46 tom]:
 > > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 > >
 > > I think we don't need it when building with `mingw-w64-clang`. At
 least the build passes and I'd suspect compile time issues if that were a
 problem.
 > >
 >
 > No, from my recollection it will compile fine but won't run if the dll
 is missing from the directory.  (However if firefox builds, then fxc2
 didn't error and it worked...)

 Another thought here: how are you compiling `fxc2`? I recall that I needed
 to resort to the .dll when compiling `fxc2` with `mingw-w64-gcc`, which
 was my main motivation to use `mingw-w64-clang` when building `fxc2` as
 well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 >
 > I think we don't need it when building with `mingw-w64-clang`. At least
 the build passes and I'd suspect compile time issues if that were a
 problem.
 >

 No, from my recollection it will compile fine but won't run if the dll is
 missing from the directory.  (However if firefox builds, then fxc2 didn't
 error and it worked...)


 > >  - I'm not sure what you do about PDBs; but it would be good to get a
 bug on file about generating/outputting them. (Perhaps in some
 configuration generating the static clang libraries with debug info also.)
 >
 > I agree. Right now don't generate them.

 I suspect you do generate them; but without setting MOZ_COPY_PDBs they are
 not winding up next to the outputed files so they're not winding up in the
 final tarball. You could stick that into the mozconfig and see if they
 show up though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:44 tom]:
 >  - Have you confirmed you don't need the spec thing for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1460801 ?  (If so, I can
 close that bug.)

 I think it worked for me back then a couple of months ago when I worked on
 the toolchain. I'll double-check with nightly builds once things landed
 but am optimistic.

 >  - fxc2 requires the winpthread dll to be in its bin directly IIRC; but
 I don't see where you're copying that. (I might have missed it. If you're
 not getting errors on fxc2 it must be working.)

 I think we don't need it when building with `mingw-w64-clang`. At least
 the build passes and I'd suspect compile time issues if that were a
 problem.

 >  - I see some flags in our mozconfig you don't have:
 >- https://searchfox.org/mozilla-
 
central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/config/mozconfigs/win32/mingwclang#53-54

 Yes, I am not sure why we don't need those but the build is not breaking,
 so we could leave that investigation for later.

 >  - I'm not sure what you do about PDBs; but it would be good to get a
 bug on file about generating/outputting them. (Perhaps in some
 configuration generating the static clang libraries with debug info also.)

 I agree. Right now don't generate them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 - Have you confirmed you don't need the spec thing for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1460801 ?  (If so, I can
 close that bug.)
  - fxc2 requires the winpthread dll to be in its bin directly IIRC; but I
 don't see where you're copying that. (I might have missed it. If you're
 not getting errors on fxc2 it must be working.)
  - I see some flags in our mozconfig you don't have:
- https://searchfox.org/mozilla-
 
central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/config/mozconfigs/win32/mingwclang#53-54
  - I'm not sure what you do about PDBs; but it would be good to get a bug
 on file about generating/outputting them. (Perhaps in some configuration
 generating the static clang libraries with debug info also.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 `bug_28238_v16` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_28238_v16) picks up the new change from
 `bug_28716_v14` (but does not contain new Firefox related ones.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:41 boklm]:
 > Switching to 64bit host for the 32bit builds sounds like a good idea.

 I agree with that and we should probably do that in our alpha cycle for
 Tor Browser 9. However, I fear that's more work involved than we have
 capacity in, say, the next two, three days given all the other stuff on
 our plate.

 It seems I managed to solve the build problems for now with
 `bug_28238_v15` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_28238_v15). Please use that one for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Switching to 64bit host for the 32bit builds sounds like a good idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,   |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-9.0-must-nightly, TorBrowserTeam201908,
 GeorgKoppen201908 =>
 tbb-rbm, tbb-9.0-must-nightly, TorBrowserTeam201908R,
 GeorgKoppen201908
 * status:  new => needs_review


Comment:

 `bug_28238_v14` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_28238_v14) has the patches to get this going.
 pospeselr checked that a 64bit build is working, which is nice!

 The patches are on top for those for #28716 to make testing easier. One
 caveat are the 32bit builds wich are currently failing due to memory
 issues when building `gkrust`. I need to find some configure flags that
 help here or we need to bite the bullet of using a 64bit host for 32bit
 builds as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201904,   |  Actual Points:
  GeorgKoppen201904  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #30321 => #30322


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201904,   |  Actual Points:
  GeorgKoppen201904  |
Parent ID:  #30321   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #29318 => #30321


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201902  |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:22 tom]:
 > x64 build: On first run; tor failed; noting:
 >
 > > 2/5/19, 16:46:34.346 [NOTICE] Bootstrapped 40% (loading_keys): Loading
 authority key certs
 > > 2/5/19, 16:46:34.952 [WARN] ISO time "2019-02-05 16:00:00\r" was
 unparseable
 > > 2/5/19, 16:46:34.952 [WARN] Unable to parse networkstatus consensus
 >
 > On second run (I ran firefox.exe directly but I don't think that
 mattered) it worked and I was able to load a website, youtube, play a
 video, and hit an onion site.
 >
 > x86 build: same problem with the authoritity certificates. On second run
 (this time I used the Start Tor Browser shortcut) it worked; again with a
 website, onion, and youtube. (I actually exited using IPv6 too!) I
 confirmed ASLR on the x86 build.
 >
 > All on Windows 10.

 This looks like #28614.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201902  |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 x64 build: On first run; tor failed; noting:

 > 2/5/19, 16:46:34.346 [NOTICE] Bootstrapped 40% (loading_keys): Loading
 authority key certs
 > 2/5/19, 16:46:34.952 [WARN] ISO time "2019-02-05 16:00:00\r" was
 unparseable
 > 2/5/19, 16:46:34.952 [WARN] Unable to parse networkstatus consensus

 On second run (I ran firefox.exe directly but I don't think that mattered)
 it worked and I was able to load a website, youtube, play a video, and hit
 an onion site.

 x86 build: same problem with the authoritity certificates. On second run
 (this time I used the Start Tor Browser shortcut) it worked; again with a
 website, onion, and youtube. (I actually exited using IPv6 too!) I
 confirmed ASLR on the x86 build.

 All on Windows 10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201902  |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:18 gk]:
 > Replying to [comment:16 cypherpunks]:
 > > Whoa! Cypherpunks operational!
 > >
 > > Of course, that explodes, but whether I'm the only one who is
 interested in it?
 >
 > Care to give more context? Which of the bundles did you test? On which
 Windows version? What happened? What error did you get, if any?
 No answers to my questions - no answers to your questions. But don't
 worry, it's a blocker.
 There are over 1M daily users on Windows and no one here. How so? Are they
 fakes? Or don't care? And you, do you care about security on Windows as a
 primary target, or Windows is incompatible with security for you?
 (5 vs 5 questions)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201902  |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:6 gk]:
 > Replying to [comment:4 gk]:
 > > Testing `bug_28238` shows that we have some reproducibility issues
 with mingw-w64/clang. It seems we have to deal at least with timestamp
 issues in the COFF header. Comparing e.g. `firefox.exe` from two different
 runs shows:
 > > {{{
 > > --- /dev/fd/63  2019-01-10 09:38:08.159230047 +0100
 > > +++ /dev/fd/62  2019-01-10 09:38:08.159230047 +0100
 > > @@ -6,7 +6,7 @@
 > >  0050: 6973 2070 726f 6772 616d 2063 616e 6e6f  is program canno
 > >  0060: 7420 6265 2072 756e 2069 6e20 444f 5320  t be run in DOS
 > >  0070: 6d6f 6465 2e24  5045  4c01 0600  mode.$..PE..L...
 > > -0080: 3b1c 365c 003c  a201  e000 2201  ;.6\.<".
 > > +0080: 45ff 365c 003c  a201  e000 2201  E.6\.<".
 > >  0090: 0b01 0e00 001e  001a     
 > >  00a0: c013  0010     4000  ..@.
 > >  00b0: 0010  0002  0600     
 > > }}}
 >
 > FWIW: That's still an unsolved issue after bumping the LLVM revision to
 r348363.

 That is solved and in the process of being upstreamed. I now get identical
 builds on one machine. However, compared to the other one I tested they
 significantly differ. Not all .dlls/.exe files are affected, though, just
 `firefox.exe`, `libGLESv2.dll`, `mozglue.dll`, `pingsender.exe`, `plugin-
 container.exe`, `plugin-hang-ui.exe`, and `xul.dll`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  GeorgKoppen201902  |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * Attachment "fxexe_diff.bz2" added.

 diff firefox.exe

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:16 cypherpunks]:
 > Whoa! Cypherpunks operational!
 >
 > Of course, that explodes, but whether I'm the only one who is interested
 in it?

 Care to give more context? Which of the bundles did you test? On which
 Windows version? What happened? What error did you get, if any?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * parent:   => #29318


Comment:

 oops

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * parent:  #29318 =>


Comment:

 Whoa! Cypherpunks operational!

 Of course, that explodes, but whether I'm the only one who is interested
 in it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:   => #29318


Comment:

 Here is a 32bit one to try out:

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_28238_1_en-US.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-
 nightly_28238_1_en-US.exe.asc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, I am close with this ticket. Here is a test bundle which compiles
 fxc2 and firefox with mingw-w64/clang while mingw-w64/gcc is used for the
 remaining components. I'd be interested in whether that explodes on
 anyone's machine:

 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_28238_1_en-US.exe
 https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-
 nightly_28238_1_en-US.exe.asc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by fxc2):

 Replying to [comment:12 gk]:
 > So, I have been fighting today with building the whole Firefox related
 part (including `fxc2`) without the old mingw-w64/gcc-based toolchain.
 No, no, don't fight with it! The new tool chain is much more sane. And it
 will make you happy.
 > `fxc2` does not want and I don't know why yet. It fails to run with
 things like
 > {{{
 >  0:03.01 err:module:import_dll Library api-ms-win-crt-convert-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.01 err:module:import_dll Library api-ms-win-crt-heap-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.01 err:module:import_dll Library api-ms-win-crt-private-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.01 err:module:import_dll Library api-ms-win-crt-runtime-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.01 err:module:import_dll Library api-ms-win-crt-stdio-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.02 err:module:import_dll Library api-ms-win-crt-string-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.02 err:module:import_dll Library api-ms-win-crt-
 environment-l1-1-0.dll (which is needed by
 L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.02 err:module:import_dll Library api-ms-win-crt-math-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.02 err:module:import_dll Library api-ms-win-crt-time-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.03 err:module:import_dll Library api-ms-win-crt-locale-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
 >  0:03.03 err:module:LdrInitializeThunk Main exe initialization for
 L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe" failed, status c135
 > }}}
 Do you have wine with ucrt? FWIW, wine 4.0 is out.
 > I need to look closer at the way this is built on Mozilla infra tomorrow
 where this seems to be working.
 They use https://hg.mozilla.org/mozilla-
 central/file/tip/taskcluster/scripts/misc/build-wine.sh

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 So, I have been fighting today with building the whole Firefox related
 part (including `fxc2`) without the old mingw-w64/gcc-based toolchain.
 `fxc2` does not want and I don't know why yet. It fails to run with things
 like
 {{{
  0:03.01 err:module:import_dll Library api-ms-win-crt-convert-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.01 err:module:import_dll Library api-ms-win-crt-heap-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.01 err:module:import_dll Library api-ms-win-crt-private-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.01 err:module:import_dll Library api-ms-win-crt-runtime-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.01 err:module:import_dll Library api-ms-win-crt-stdio-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.02 err:module:import_dll Library api-ms-win-crt-string-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.02 err:module:import_dll Library api-ms-win-crt-
 environment-l1-1-0.dll (which is needed by
 L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.02 err:module:import_dll Library api-ms-win-crt-math-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.02 err:module:import_dll Library api-ms-win-crt-time-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.03 err:module:import_dll Library api-ms-win-crt-locale-l1-1-0.dll
 (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found
  0:03.03 err:module:LdrInitializeThunk Main exe initialization for
 L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe" failed, status c135
 }}}
 I need to look closer at the way this is built on Mozilla infra tomorrow
 where this seems to be working.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 {{{
   if (Args.hasArg(OPT_no_insert_timestamp))
 Add("-timestamp:0");
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 https://reviews.llvm.org/rL332613 seems like the relevant revision for the
 timestamp issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 https://bugs.llvm.org/show_bug.cgi?id=35914

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:7 ld]:
 > https://bugs.chromium.org/p/chromium/issues/detail?id=533657
 > https://bugs.llvm.org/show_bug.cgi?id=24740#c3

 That's about building _clang_ deterministic, yes. Thus, this is more
 suited for #29041.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 https://bugs.chromium.org/p/chromium/issues/detail?id=533657
 https://bugs.llvm.org/show_bug.cgi?id=24740#c3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201901,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:4 gk]:
 > Testing `bug_28238` shows that we have some reproducibility issues with
 mingw-w64/clang. It seems we have to deal at least with timestamp issues
 in the COFF header. Comparing e.g. `firefox.exe` from two different runs
 shows:
 > {{{
 > --- /dev/fd/632019-01-10 09:38:08.159230047 +0100
 > +++ /dev/fd/622019-01-10 09:38:08.159230047 +0100
 > @@ -6,7 +6,7 @@
 >  0050: 6973 2070 726f 6772 616d 2063 616e 6e6f  is program canno
 >  0060: 7420 6265 2072 756e 2069 6e20 444f 5320  t be run in DOS
 >  0070: 6d6f 6465 2e24  5045  4c01 0600  mode.$..PE..L...
 > -0080: 3b1c 365c 003c  a201  e000 2201  ;.6\.<".
 > +0080: 45ff 365c 003c  a201  e000 2201  E.6\.<".
 >  0090: 0b01 0e00 001e  001a     
 >  00a0: c013  0010     4000  ..@.
 >  00b0: 0010  0002  0600     
 > }}}

 FWIW: That's still an unsolved issue after bumping the LLVM revision to
 r348363.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201812,   |  Actual Points:
  GeorgKoppen201901  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Testing `bug_28238` shows that we have some reproducibility issues with
 mingw-w64/clang. It seems we have to deal at least with timestamp issues
 in the COFF header. Comparing e.g. `firefox.exe` from two different runs
 shows:
 {{{
 --- /dev/fd/63  2019-01-10 09:38:08.159230047 +0100
 +++ /dev/fd/62  2019-01-10 09:38:08.159230047 +0100
 @@ -6,7 +6,7 @@
  0050: 6973 2070 726f 6772 616d 2063 616e 6e6f  is program canno
  0060: 7420 6265 2072 756e 2069 6e20 444f 5320  t be run in DOS
  0070: 6d6f 6465 2e24  5045  4c01 0600  mode.$..PE..L...
 -0080: 3b1c 365c 003c  a201  e000 2201  ;.6\.<".
 +0080: 45ff 365c 003c  a201  e000 2201  E.6\.<".
  0090: 0b01 0e00 001e  001a     
  00a0: c013  0010     4000  ..@.
  00b0: 0010  0002  0600     
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201812,   |  Actual Points:
  GeorgKoppen201812  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201812, GeorgKoppen201812


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 We likely start small and just use the toolchain to build the Firefox part
 which means we'd have two mingw-w64 toolchains for the time being (we had
 this back then in the old days for macOS, too). I guess other parts of the
 whole bundle might need quite some amount of work to getting built with
 that new toolchain and we want to move fast here aiming for Tor Browser
 8.5.

 However, if it turns out I am wrong and it is indeed easy to use
 mingw-w64/clang for everything, fine with me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs