Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:  10
  padding|
Parent ID:  #28632   | Points:  10
 Reviewer:  asn  |Sponsor:
-+-
Changes (by gaba):

 * points:   => 10
 * actualpoints:   => 10


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Tests from #28142 LGTM! Closing thiss as it will be resolved along with
 #28142.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:3 asn]:
 > Code LGTM but the bitmask logic is non-trivial. Let's close this ticket
 after we get some unittests as well.
 >
 > I'm also wondering if we should test that `CIRCUIT_PURPOSE_MAX_` is less
 than 32 (which is the max state we can encode in the 32-bit bitfield).

 FWIW, we now have a "CTASSERT" macro for compile-time assertions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Code LGTM but the bitmask logic is non-trivial. Let's close this ticket
 after we get some unittests as well.

 I'm also wondering if we should test that `CIRCUIT_PURPOSE_MAX_` is less
 than 32 (which is the max state we can encode in the 32-bit bitfield).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by mikeperry):

 * status:  new => needs_review
 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28633 [Core Tor/Tor]: Pad on specific circuit purposes + ltups

[Tor Bug Tracker & Wiki]

#28633: Pad on specific circuit purposes + ltups
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,|  Actual Points:
  padding|
Parent ID:  #28632   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 This functionality is provided already by the
 circpad_machine_conditions_t. We can use those conditions to say that
 machines don't activate unless there are a minimum hops built, vanguards
 is enabled, certain usage state conditions, and purpose flags.

 See circpad_machine_conditions_met(), circpad_shutdown_old_machines(),
 circpad_add_matching_machines(), and callers.

 If you think that is sufficient, please close. Otherwise we should figure
 out what else we need soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs