Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  control-port hsfetch, regression,|  Actual Points:  0
  041-regression, 041-must, dgoulet-merge|
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  merge_ready => closed
 * reviewer:   => ahf
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:  0
  041-regression, 041-must, dgoulet-merge|
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  control-port hsfetch, regression, 041-regression, 041-must =>
 control-port hsfetch, regression, 041-regression, 041-must, dgoulet-
 merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:  0
  041-regression, 041-must   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:  0
  041-regression, 041-must   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 0


Comment:

 Fix in branch 30646; PR at https://github.com/torproject/tor/pull/1055

 I added #30676 to look at our controller test coverage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:
  041-regression, 041-must   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 See also #30580, where the same refactor broke POSTDESCRIPTOR.

 What can we do to make sure we haven't broken anything else?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:
  041-regression, 041-must   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  control-port hsfetch, regression, 041-regression => control-
 port hsfetch, regression, 041-regression, 041-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
-+-
 Reporter:  csucu|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  control-port hsfetch, regression,|  Actual Points:
  041-regression |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => accepted
 * keywords:  control-port hsfetch, regression => control-port hsfetch,
 regression, 041-regression
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30646 [Core Tor/Tor]: HSFETCH always returning 512 Bad argument

[Tor Bug Tracker & Wiki]

#30646: HSFETCH always returning 512 Bad argument
--+
 Reporter:  csucu |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.1.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.4.1.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  control-port hsfetch, regression  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * cc: nickm (added)
 * keywords:  control-port hsfetch => control-port hsfetch, regression
 * points:   => 0.1
 * milestone:   => Tor: 0.4.1.x-final


Comment:

 The `.want_cmddata = true,` is set for the HSFETCH command but it
 shouldn't...

 This was introduced by commit `d8b3ec865de2738144bd6bbf9f6355662e64eb25`
 released in 0.4.1.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs