Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  teor-merge, consider-backport-   |  Actual Points:  1
  after-0415, 040-backport, tor-relay,   |
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 1


Comment:

 This was a complex merge.
 There were some trivial conflicts, which I fixed, see the merge commit
 messages for details.

 Thanks for making it happen!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  teor-merge, consider-backport-   |  Actual Points:
  after-0415, 040-backport, tor-relay,   |
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * keywords:
 consider-backport-after-0415, 040-backport, tor-relay, circuitpadding,
 wtf-pad
 =>
 teor-merge, consider-backport-after-0415, 040-backport, tor-relay,
 circuitpadding, wtf-pad


Comment:

 Seems good to me.

 Here's what I'll do to merge this backport:
 * check CI
 * release-0.4.1 and cherry-pick to master:
 https://github.com/torproject/tor/pull/1282
 * maint-0.4.0: https://github.com/torproject/tor/pull/1174
 * maint-0.4.1: https://github.com/torproject/tor/pull/1283
 * merge forward

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 I added the entry to `ReleaseNotes` in my `release-0.4.1` branch (PR
 1282).

 Is there anything else that needs to be done?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 In general, if we need to edit a changelog or releasenotes, we make the
 fix in one branch, and cherry-pick it to the others as needed.  We also
 ask "is this fix really necessary"; having a fixed changelog and having an
 accurate changelog are both desirable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 Apparently we need a branch for release-0.4,1 and master, or something
 special needs to happen with the merge.
 (I tried some release notes fixes in #31461, but they never made it to
 master.)

 Let's wait for nickm's advice here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * cc: nickm (added)


Comment:

 Replying to [comment:30 asn]:
 > Replying to [comment:26 teor]:
 > > I can't backport this branch, because:
 > > * the changes file has the wrong bugfix version:
 > >   * please update the maint-0.4.0 PR with the changes file with the
 correct bugfix version 0.4.0.1-alpha
 >
 > The PR has been updated with a fixup:
 https://github.com/torproject/tor/pull/1174
 >
 > >   * if you'd like, you can create a release-0.4.1 PR that fixes the
 wrong bug versions in the ChangeLog and ReleaseNotes
 >
 > A changelog fix has been pushed
 https://github.com/torproject/tor/pull/1282 , but I couldn't find the
 #30649 entry in the ReleaseNotes.

 30649 is missing from the ReleaseNotes, because the changes file said it
 was a bug on 0.4.1.
 Bugs don't go in the release notes unless they have been released in a
 stable version of Tor.

 Please copy the ChangeLog entry for 30649 into the correct section of the
 release-0.4.1 ReleaseNotes.

 nickm, do we also need to patch the master ReleaseNotes?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 OK, here we go!

 Replying to [comment:26 teor]:
 > I can't backport this branch, because:
 > * the changes file has the wrong bugfix version:
 >   * please update the maint-0.4.0 PR with the changes file with the
 correct bugfix version 0.4.0.1-alpha

 The PR has been updated with a fixup:
 https://github.com/torproject/tor/pull/1174

 >   * if you'd like, you can create a release-0.4.1 PR that fixes the
 wrong bug versions in the ChangeLog and ReleaseNotes

 A changelog fix has been pushed
 https://github.com/torproject/tor/pull/1282 , but I couldn't find the
 #30649 entry in the ReleaseNotes.

 > * the PR doesn't merge cleanly into maint-0.4.1
 >   * please merge the maint-0.4.0 PR to maint-0.4.1, and make that merged
 branch into a separate PR on maint-0.4.1

 An 041 PR can be found here: https://github.com/torproject/tor/pull/1283

 If CI passes, we can go ahead!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 I'm on it!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 I think it might just need an "ours" merge, because the corresponding
 change was already merged to 0.4.1, before being backported.

 But I'm really not sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 Mike is pretty hosed; I can pick this up unless somebody else wants to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 I can't backport this branch, because:
 * the changes file has the wrong bugfix version:
   * please update the maint-0.4.0 PR with the changes file with the
 correct bugfix version 0.4.0.1-alpha
   * if you'd like, you can create a release-0.4.1 PR that fixes the wrong
 bug versions in the ChangeLog and ReleaseNotes
 * the PR doesn't merge cleanly into maint-0.4.1
   * please merge the maint-0.4.0 PR to maint-0.4.1, and make that merged
 branch into a separate PR on maint-0.4.1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415,|  Actual Points:
  040-backport, tor-relay, circuitpadding, wtf-  |
  pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * keywords:  040-backport, tor-relay, circuitpadding, wtf-pad =>
 consider-backport-after-0415, 040-backport, tor-relay, circuitpadding,
 wtf-pad


Comment:

 This PR was merged into 0.4.1.4, so we will test it until 0.4.1.5 is
 released, then merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 OK, pushed a better backport 040 PR. If CI passes, this can be merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  merge_ready => needs_revision


Comment:

 Gr! Compilation errors on travis. Aborting and putting back in
 needs_revision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 Made a branch based on 040 here:
 https://github.com/torproject/tor/pull/1174

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad|
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by nickm):

 * keywords:  040-backport, tor-relay, circuitpadding, wtf-pad, 041-must =>
 040-backport, tor-relay, circuitpadding, wtf-pad


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  040-backport, tor-relay, |  Actual Points:
  circuitpadding, wtf-pad, 041-must  |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * keywords:  tor-relay, circuitpadding, wtf-pad, 041-must => 040-backport,
 tor-relay, circuitpadding, wtf-pad, 041-must
 * status:  reopened => needs_revision
 * version:  Tor: 0.4.1.1-alpha => Tor: 0.4.0.1-alpha
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Please remember to add actual points :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by arma):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 A relay operator (strelnikov) reports getting this message on their
 0.4.0.5 relay.

 It looks like commit 9aaf72ea went into 0.4.0.1-alpha?

 So (a) the bug *is* in our stable, and here is a user reporting it like
 teor predicted, and (b) we only pushed the fix into 0.4.1 above, right?

 Reopening so it can get more eyes. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 Merged to 0.4.1 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 OK, since mike ACKed it I'm moving it to merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Asn's changes are fine with me. I'm not the reviewer though, so just
 setting back to needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Setting to needs_rev as its waiting for action.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 Seems reasonable. Please see my commit in
 https://github.com/torproject/tor/pull/1101.

 I added a log for receiving a legit STOP command, and also promoted a
 protocol warn for receiving a padding from the wrong hop to a normal warn.
 I think if this happens we want to learn about it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 I pushed more log protocol warn updates to the PR: now when padding
 negotiation fails due to either corrupt cell or "valid" refusal, we
 LOG_PROTOCOL_WARN. Those should not happen, but one of them was at info,
 so it was already quiet.

 I will file a new ticket for evaluating if the origin-side
 LOG_PROTOCOL_WARNs here should be LOG_WARNs or not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 Replying to [comment:8 mikeperry]:
 > Hrmm.. but there is something that origins can do.. They can use
 ExcludeNodes to blacklist nodes that violoate protocol. Based on the
 reasoning for having LOG_PROTOCOL_WARN, it sounds like origin-facing
 procotol warns that mention the idhex and recommend ExcludeNodes should be
 fine as regular warns.

 I think you should talk to the Tor Browser team and UX team about this
 kind of warning. It could confuse a lot of Tor Browser users.

 > The reasoning is that I think that some users would prefer having
 padding defenses work over using broken nodes that violate protocol. Right
 now, circpad does not kill the circuit if padding fails in a bizarre way.
 I am thinking it should, or at least should tell the user and advise them.

 We need to design tor for the majority of our users, who do not edit their
 torrcs. But we also need to have advanced options available for users who
 need strict privacy. I don't know if there's a way to do both: we should
 talk to the UX team.

 > This ticket got a lot more complicated than fixing this bug.. Should we
 make a different ticket about the warns?

 Yes, I think so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by mikeperry):

 Hrmm.. but there is something that origins can do.. They can use
 ExcludeNodes to blacklist nodes that violoate protocol. Based on the
 reasoning for having LOG_PROTOCOL_WARN, it sounds like origin-facing
 procotol warns that mention the idhex and recommend ExcludeNodes should be
 fine as regular warns.

 The reasoning is that I think that some users would prefer padding
 defenses to using broken nodes. Right now, circpad does not kill the
 circuit if padding fails in a bizarre way. I am thinking it should, or at
 least should tell the user and advise them.

 This ticket got a lot more complicated than fixing this bug.. Should we
 make a different ticket about the warns?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 LOG_PROTOCOL_WARN Is for warnings about other nodes on the network
 disobeying the tor protocol.

 So it should also be used for log messages on the origin side, when the
 message is caused by the relay behaving badly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by mikeperry):

 Can you be more specific? Do you mean the origin-side messages? I changed
 those from LD_PROTOCOL because I think they should be LD_CIRC. But they
 are not relay side, they are origin side. It's my understanding that relay
 side messages are what LOG_PROTOCOL_WARN is for.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I have some questions about the latest commit: some of the changes look
 like typos?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  accepted => needs_review


Comment:

 Fix as per comment:1 https://github.com/torproject/tor/pull/1063

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by teor):

 If the relay operator can't do anything to fix these warnings, we should
 downgrade the remaining warnings to protocol warnings.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * owner:  (none) => mikeperry
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30649 [Core Tor/Tor]: Every few hours, relays [warn] Received circuit padding stop command for unknown machine.

[Tor Bug Tracker & Wiki]

#30649: Every few hours, relays [warn] Received circuit padding stop command for
unknown machine.
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, circuitpadding, wtf-pad,  |  Actual Points:
  041-must   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by mikeperry):

 This is interesting. The actual log is due refactoring eliminating a
 return value propogation/check of
 free_circ_machine_infos_with_machinenum() in
 circpad_handle_padding_negotiate(). As a result of the check being
 removed, the logline is *always* printing even if the machine is valid and
 did exist. So adding the check back in will eliminate most of those.

 It's not happening that often because normally client-side does not send
 STOP commands. The client will only send a STOP of the machine conditions
 cease applying. This can happen in the event of a circuit build timeout
 (and associated purpose change to MEASUREMENT), though.

 So I think all we have to do is make
 free_circ_machine_infos_with_machinenum() return a success/fail result,
 and check it properly in circpad_handle_padding_negotiate(), before
 warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs