Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:  fixed
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by juga):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by juga):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:3 juga]:
 > I realized about other bug, fixed in
 https://github.com/juga0/sbws/commits/bug30909_11.
 > I'm not sure which the workflow should be here, so just changing this
 ticket to needs review, but not doing PR nor assigning reviewer.

 Since this ticket is blocking #30733 and the potential bug it's not
 related to teor's patch, i've created #33060 for it and changing this one
 to merge ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by teor):

 * owner:  teor => (none)
 * status:  needs_revision => assigned


Comment:

 I am not actively working on this ticket

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by teor):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by juga):

 * status:  merge_ready => needs_review


Comment:

 I realized about other bug, fixed in
 https://github.com/juga0/sbws/commits/bug30909_11.
 I'm not sure which the workflow should be here, so just changing this
 ticket to needs review, but not doing PR nor assigning reviewer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by juga):

 * status:  needs_review => merge_ready


Comment:

 lgtm, just added a comment regarding the commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30909 [Core Tor/sbws]: sbws consensus timestamp updates incorrectly use the current time

[Tor Bug Tracker & Wiki]

#30909: sbws consensus timestamp updates incorrectly use the current time
+---
 Reporter:  teor|  Owner:  teor
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws   |Version:  sbws: 1.1.0
 Severity:  Normal  | Resolution:
 Keywords:  sbws-ci-fail-sometimes  |  Actual Points:  0.2
Parent ID:  #30733  | Points:  0.2
 Reviewer:  juga|Sponsor:
+---
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => juga


Comment:

 See my pull request:
 https://github.com/torproject/sbws/pull/360

 It checks the valid-after time and the timestamp in the same way, so this
 bug shouldn't happen any more. If it does, we should fix the test code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs