Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:  3
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:15 boklm]:
 > I noticed that on Debian 9, my 8.5.5 browser did not restart at the end
 of the update to 9.0. However it correctly started when starting it again
 manually.
 >
 > On Debian 9, the bundled `libstdc++.so.6` is not required in version
 8.5.5, but is required in version 9.0, so I'm wondering if it could be
 related to this issue.

 I opened a separate ticket for this: #32212

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:  3
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I noticed that on Debian 9, my 8.5.5 browser did not restart at the end of
 the update to 9.0. However it correctly started when starting it again
 manually.

 On Debian 9, the bundled `libstdc++.so.6` is not required in version
 8.5.5, but is required in version 9.0, so I'm wondering if it could be
 related to this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:  3
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * actualpoints:   => 3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed with commit b16662aad8d9932819fea73746860ce9d8c711a4 on `tor-
 browser-build`'s `master` branch, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 That's not clear. AFAIK, symvers was developed, so that any package can
 update system version during installation and without bad consequences.
 But if you do something similar to Snap packages, isn't it easier to link
 statically?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_revision => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr =>
 tbb-rbm, TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr


Comment:

 In branch `bug_31646_v3` I updated the commit message to mention fixing
 #31380, and added a comment to `projects/gcc/config` to remind us about
 updating `abicheck.cc` when updating the gcc version:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_31646_v3=b16662aad8d9932819fea73746860ce9d8c711a4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:8 cypherpunks]:
 > Why does this DLL/DSO Hell happen regularly? On sane systems, the app's
 components always use the bundled version, and the system's components
 always use the system version. So, what the heck is here?

 See #25485 for why we can't use the bundled `libstdc++` in all cases.

 > And why these tickets are not synced to bumping GCC?

 This should be done when bumping gcc, but was forgotten.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 => tbb-rbm, TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:7 boklm]:
 > This should be fixed in branch `bug_31646_v2`:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_31646_v2=c88f26cefc658be1773c459d9f63f728312fdf4e

 Looks good. One additional nit: we should probably mention that this fix
 solves #31380, too?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Why does this DLL/DSO Hell happen regularly? On sane systems, the app's
 components always use the bundled version, and the system's components
 always use the system version. So, what the heck is here? And why these
 tickets are not synced to bumping GCC?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr =>
 tbb-rbm, TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 * status:  needs_revision => needs_review


Comment:

 This should be fixed in branch `bug_31646_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_31646_v2=c88f26cefc658be1773c459d9f63f728312fdf4e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 => tbb-rbm, TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr
 * status:  needs_review => needs_revision


Comment:

 Two nits:
 `* system provides required the C++ ABI` not sure what you mean here.

 Let's keep `maint()` instead of `maint ()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909R,  |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr =>
 tbb-rbm, TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 * points:   => 3


Comment:

 There is a patch for review in branch `bug_31646`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_31646=3ff1c896940d0150e90b12560c4a83f22263324c

 With this patch, the abicheck binary now requires `GLIBCXX_3.4.25`, and
 the bundle is starting without error on a Debian 9 machine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by intrigeri):

 * cc: intrigeri (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 On some systems, this can cause an error like this when starting the
 browser:
 {{{
 /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.23' not
 found (required by $FOO/tor-browser_en-US_8.09a/Browser/libxul.so)
 }}}

 A temporary workaround is to edit the file `Browser/firefox` to move or
 copy the line `add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/"`
 outside the `if`:
 {{{
 diff --git a/projects/firefox/start-firefox b/projects/firefox/start-
 firefox
 index 7e7685c..42ea1af 100644
 --- a/projects/firefox/start-firefox
 +++ b/projects/firefox/start-firefox
 @@ -41,6 +41,7 @@ fi
  if [ $? -ne 0 ]; then
add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/"
  fi
 +add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/"
  add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/"
  export LD_LIBRARY_PATH

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:1 gk]:
 > I wonder if #31380 is related here, although that one still puzzles
 me...

 Ah yes, this is probably related.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31646 [Applications/Tor Browser]: Update abicheck to require newer libstdc++.so.6

[Tor Bug Tracker & Wiki]

#31646: Update abicheck to require newer libstdc++.so.6
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201909,   |  Actual Points:
  tbb-9.0-must-alpha, ff68-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I wonder if #31380 is related here, although that one still puzzles me...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs