Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.4.1 and later.
 Merged #31107, #31466, #30916, #31408, #31837, and #31897 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 I cherry-picked #31948 to the 0.4.1 backport branch, because it is a fix
 on this change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * keywords:
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-04233, asn-merge
 =>
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-04233


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233, asn-merge   |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged to master, marking for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233, asn-merge   |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-04233
 =>
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-04233, asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Patch looks good. And thanks for testing this on a SunOS machine :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by svschmel):

 Hello,

 i can commit that this fix works.
 Quick and dirty test:

 svschmel@oibuild:~/oi-
 userland/components/network/tor/tor-0.4.1.6/src/test$ wget
 
https://raw.githubusercontent.com/torproject/tor/2420c8c9366e498dfaf3b4b6389ece9dc27ca537/src/test/test_util.c

 --2019-10-01 12:29:26--
 
https://raw.githubusercontent.com/torproject/tor/2420c8c9366e498dfaf3b4b6389ece9dc27ca537/src/test/test_util.c
 Resolving raw.githubusercontent.com (raw.githubusercontent.com)...
 151.101.112.133
 Connecting to raw.githubusercontent.com
 (raw.githubusercontent.com)|151.101.112.133|:443... connected.
 HTTP request sent, awaiting response... 200 OK
 Length: 202187 (197K) [text/plain]
 Saving to: 'test_util.c.1'

 test_util.c.1
 100%[=>]
 197.45K  --.-KB/sin 0.1s

 2019-10-01 12:29:26 (1.61 MB/s) - 'test_util.c.1' saved [202187/202187]

 ...

 svschmel@oibuild:~/oi-
 userland/components/network/tor/tor-0.4.1.6/src/test$ ls -al test_uti*
 -rw-r--r--   1 svschmel staff 202147 Jun 10 14:46 test_util.c
 -rw-r--r--   1 svschmel staff 202187 Oct  1 12:29 test_util.c.1
 -rw-r--r--   1 svschmel staff  11624 Jun 10 14:46 test_util_format.c
 -rw-r--r--   1 svschmel staff   1814 Jun 10 14:46 test_util_process.c

 ...

 svschmel@oibuild:~/oi-
 userland/components/network/tor/tor-0.4.1.6/src/test$ cp test_util.c.1
 test_util.c

 ...

 svschmel@oibuild:~/oi-userland/components/network/tor$ gmake test
 (cd /export/home/svschmel/oi-userland/components/network/tor/build/amd64 ;
 \
 /usr/bin/env PATH=/usr/gnu/bin:/usr/bin:/usr/sbin:/usr/perl5/bin \
 /usr/gnu/bin/make \
  check)
 make[1]: Entering directory '/export/home/svschmel/oi-
 userland/components/network/tor/build/amd64'
   CC   src/test/src_test_test-test_util.o
   CCLD src/test/test
 /usr/gnu/bin/make  check-TESTS check-local
 make[2]: Entering directory '/export/home/svschmel/oi-
 userland/components/network/tor/build/amd64'
 make[3]: Entering directory '/export/home/svschmel/oi-
 userland/components/network/tor/build/amd64'
 PASS: src/test/test
 PASS: src/test/test-slow
 PASS: src/test/test-memwipe
 PASS: src/test/test_workqueue
 PASS: src/test/test_keygen.sh
 PASS: src/test/test_key_expiration.sh
 PASS: src/test/test-timers
 SKIP: src/test/fuzz_static_testcases.sh
 PASS: src/test/test_zero_length_keys.sh
 PASS: src/test/test_workqueue_cancel.sh
 PASS: src/test/test_workqueue_efd.sh
 PASS: src/test/test_workqueue_efd2.sh
 PASS: src/test/test_workqueue_pipe.sh
 PASS: src/test/test_workqueue_pipe2.sh
 PASS: src/test/test_workqueue_socketpair.sh
 SKIP: src/test/test_switch_id.sh
 PASS: src/test/test_ntor.sh
 SKIP: src/test/test_hs_ntor.sh
 PASS: src/test/test_bt.sh
 PASS: src/test/test_rebind.sh
 
 Testsuite summary for tor 0.4.1.6
 
 # TOTAL: 20
 # PASS:  17
 # SKIP:  3
 # XFAIL: 0
 # FAIL:  0
 # XPASS: 0
 # ERROR: 0
 
 make[3]: Leaving directory '/export/home/svschmel/oi-
 userland/components/network/tor/build/amd64'
 perl /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/scripts/maint/checkSpace.pl -C
 \
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/lib/*/*.[ch]
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/core/*/*.[ch]
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/feature/*/*.[ch]
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/app/*/*.[ch]
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/test/*.[ch]
 /export/home/svschmel/oi-
 userland/components/network/tor/tor-0.4.1.6/src/test/*/*.[ch]
 

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-04233  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-0433
 =>
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-04233


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:  0.1
  041-regression, BugSmashFund, 041-backport,|
  consider-backport-after-0433   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor-test, 042-must, fast-fix, 041-regression =>
 tor-test, 042-must, fast-fix, 041-regression, BugSmashFund,
 041-backport, consider-backport-after-0433
 * status:  assigned => needs_review
 * actualpoints:   => 0.1


Comment:

 See my PR:
 * 0.4.1: https://github.com/torproject/tor/pull/1374

 The merge to master was clean, here is the test PR:
 * master: https://github.com/torproject/tor/pull/1375

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:
  041-regression |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  (none) => teor
 * status:  new => assigned
 * version:  Tor: 0.4.1.6 => Tor: 0.4.1.1-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.6
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:
  041-regression |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
-+-
 Reporter:  svschmel |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.6
 Severity:  Normal   | Resolution:
 Keywords:  tor-test, 042-must, fast-fix,|  Actual Points:
  041-regression |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor-test => tor-test, 042-must, fast-fix, 041-regression
 * points:   => 0.1
 * milestone:   => Tor: 0.4.2.x-final


Comment:

 This looks like a simple signed / unsigned comparison error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31897 [Core Tor/Tor]: util/map_anon_nofork test fails on SunOS

[Tor Bug Tracker & Wiki]

#31897: util/map_anon_nofork test fails on SunOS
--+--
 Reporter:  svschmel  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:  tor-test  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by svschmel):

 * Attachment "test-suite.log" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs