Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  network-team-roadmap-november,   |  Actual Points:  0.2
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged the code changes to 0.4.2, and then merged forward with an "ours"
 merge to master, to prefer the changes in #32404.

 Cherry-picked the new tests to 0.4.2, fixed the commit message, and then
 did a standard merge forward to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:  0.2
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-must
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Looks correct.  #32404 is already merged to master.  Please merge as
 appropriate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:  0.2
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.2


Comment:

 See my PRs:
 * 0.4.2: https://github.com/torproject/tor/pull/1521

 If #32404 has not been merged:
 * master: https://github.com/torproject/tor/pull/1522

 If #32404 has been merged:
 * https://github.com/torproject/tor/pull/1523
   * (these tests will fail until #32404 has been merged)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-

Comment (by teor):

 Replying to [comment:4 nickm]:
 > Personally I think it would almost be okay to leave this as-is in 0.4.2,
 since we haven't made any options obsolete that weren't obsolete before.

 We obsoleted RecommendedPackages in 0.4.2.1-alpha, but that only affects
 directory authority operators. (And no-one was using that option, which is
 why we obsoleted it.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-

Comment (by teor):

 The 0.4.3 ticket is #32404.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * owner:  nickm => teor


Comment:

 It's a serious ux issue for people upgrading from a much earlier version
 to 0.4.2.
 I'll work out some way to pass the name or config line down.

 And I'll open another ticket for the proper fix in 0.4.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-

Comment (by nickm):

 My suggestion would be to change how OBSOLETE is implemented: it doesn't
 really make sense as a type. Instead, there should be an "empty" type for
 fields that can't be read or written, and a CFLG_OBSOLETE flag that causes
 these warnings.  The CFLG_OBSOLETE flag should be handled at the confvar
 layer, I think.

 This makes more sense for 0.4.3 than 0.4.2, though.  Personally I think it
 would almost be okay to leave this as-is in 0.4.2, since we haven't made
 any options obsolete that weren't obsolete before.  But if we think we
 really need a temporary fix there, we could pass the name down to the
 typedvar layer in any kludgey way we want.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * owner:  teor => nickm


Comment:

 nickm, can you help me work out how to do this fix?
 (Or, if it's a quick one, feel free to do it.)

 If we want to warn about obsolete config options using their names (key),
 we need to pass config_line_t to parse(), or pass key and value to parse.

 Which design should we use for 0.4.2?
 Should we change it in 0.4.3?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * status:  new => assigned
 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32295 [Core Tor/Tor]: "Skipping obsolete configuration option." doesn't say which one

[Tor Bug Tracker & Wiki]

#32295: "Skipping obsolete configuration option." doesn't say which one
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  042-backport   |
Parent ID:  #29211   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor31-must
-+-
Changes (by teor):

 * keywords:   => network-team-roadmap-november, 042-backport
 * cc: nickm (added)
 * points:   => 0.5
 * sponsor:   => Sponsor31-must
 * parent:   => #29211


Comment:

 This is a bug on #30864, which was sponsor 31, so it is a must-have for
 Sponsor 31.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs