Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  network-team-roadmap-october  |  Actual Points:  .1
Parent ID:  #29211| Points:  1
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * keywords:  network-team-roadmap-? => network-team-roadmap-october
 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged #32213, #32339, and #32344.

 Resolved conflicts between #32339 and #32344 by taking the V_IMMUTABLE and
 FILENAME changes on PidFile.

 Opened #32373 for follow up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Yes, I think we should go ahead, and make further changes in other
 tickets.

 I'd like to merge #32213, #32339, and #32344 in that order, to minimise
 conflicts (if any). I'm just waiting for CI to pass on #32213.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+

Comment (by nickm):

 (Rationale for proceeding: I believe that this branch is a strict
 improvement over Tor's current behavior, doesn't introduce technical debt,
 and unblocks #30866. If you don't agree, we shouldn't proceed.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 One challenge with looping over logs is that we only want to look at the
 filenames.  We'd also want to look at filenames inside FooPort options

 My eventual hope with Logs and Ports is that we can reuse the control-
 command parsing code in control_cmd.c to break them into their own options
 objects, and handle those with the regular configuration processing code.

 Do you think that, for now, we might be able to take this patch as a
 straightforward refactoring, and add additional checks in a separate
 branch?  For me it is a blocker for #30866, and I'd like to get that
 straightened out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+

Comment (by teor):

 We should be able to loop through Logs like we do HiddenServiceDir?
 Maybe we'll need to do that after we've parsed Logs into log objects.
 I'll see if I can write some code for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+

Comment (by nickm):

 We should, but that's harder and I don't know a good way to do it. Any
 ideas?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Looks fine, but should we also be checking file Logs here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:  .1
Parent ID:  #29211  | Points:  1
 Reviewer:  teor|Sponsor:  Sponsor31-can
+
Changes (by nickm):

 * status:  new => needs_review
 * reviewer:   => teor
 * actualpoints:   => .1


Comment:

 I have the relative-path part of this in branch `ticket32339_relative`
 with PR at https://github.com/torproject/tor/pull/1487

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths

[Tor Bug Tracker & Wiki]

#32339: Use a table to drive options_check_transition and 
warn_about_relative_paths
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  network-team-roadmap-?  |  Actual Points:
Parent ID:  #29211  | Points:  1
 Reviewer:  |Sponsor:  Sponsor31-can
+

Comment (by nickm):

 See #32344 for part of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs