Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  github, releases |  Actual Points:  1
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged at `5684c4fc95`:
 
https://gitweb.torproject.org/gettor.git/commit/scripts?id=5684c4fc95170951f062b36002733034cb6a3904

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  1
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+-
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me! I only had a minor nitpick, which I left in the code.
 Putting the authentication token into an environment variable seems like a
 good solution.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  1
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+--

Comment (by cohosh):

 Also added another commit this morning:
 
https://dip.torproject.org/cohosh/gettor/commit/233d7da2f7749f46ddc100099667f7b794e8f719

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  1
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+--
Changes (by cohosh):

 * status:  merge_ready => needs_review
 * actualpoints:  .5 => 1


Comment:

 Replying to [comment:12 phw]:
 > How about we make the script more robust by making it re-attempt failed
 downloads and uploads two or three times? We may still have to fix issues
 manually on occasion but I would expect this to eliminate the majority of
 transient issues.

 Yeah that sounds like a good idea. I made another commit to do this:
 
https://dip.torproject.org/cohosh/gettor/commit/6aa7e2b2eda363134b572306474e7d646d747315

 This commit also fixes a problem I had where github returns a server error
 when you try to delete a large release. I changed it so that it removes
 each release asset one-by-one first and then deletes it and this seems to
 have solved the problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+-
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+-
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:10 cohosh]:
 > Right now this script is run manually, but this is something we should
 definitely do if/when it is automated in the future. I'm not quite sure
 how to handle this since I don't want an error to stop the update script
 and start over when it is run again. This wastes a lot of bandwidth and
 time. My current thought is that we can print out the missing releases in
 a log file and manually upload them later, but that's not a very elegant
 solution.
 [[br]]
 How about we make the script more robust by making it re-attempt failed
 downloads and uploads two or three times? We may still have to fix issues
 manually on occasion but I would expect this to eliminate the majority of
 transient issues.

 Also, commit
 
[https://dip.torproject.org/cohosh/gettor/commit/ee8d5a85ff6388a27c6aecadcaec3d7c6c920ec6
 ee8d5a85] looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+--
Changes (by cohosh):

 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+---
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+---

Comment (by cohosh):

 Replying to [comment:9 phw]:
 > It's a great idea to use releases and the script looks good to me! I
 left a few comments in the commits.
 Thanks!
 >
 > Are we monitoring the return code of the script? At some point,
 something will break and we should notice right away when the script
 failed to upload new Tor Browser releases.

 Right now this script is run manually, but this is something we should
 definitely do if/when it is automated in the future. I'm not quite sure
 how to handle this since I don't want an error to stop the update script
 and start over when it is run again. This wastes a lot of bandwidth and
 time. My current thought is that we can print out the missing releases in
 a log file and manually upload them later, but that's not a very elegant
 solution.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+---
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:  phw  |Sponsor:
-+---
Changes (by phw):

 * status:  needs_review => needs_information
 * reviewer:   => phw


Comment:

 It's a great idea to use releases and the script looks good to me! I left
 a few comments in the commits.

 Are we monitoring the return code of the script? At some point, something
 will break and we should notice right away when the script failed to
 upload new Tor Browser releases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--

Comment (by cohosh):

 This is the test repo I used: https://github.com/cohosh/releases/releases

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--

Comment (by cohosh):

 Here's a commit that updates the github links:
 
https://dip.torproject.org/cohosh/gettor/commit/8fc567b5680fbf497a1a4e63e0e579a3c1105d6e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--

Comment (by cohosh):

 I just found this [https://dip.torproject.org/torproject/anti-censorship
 /gettor-project/gettor/blob/master/upload/bundles2github.py
 bundles2github.py] script while looking at what we need to do to update
 the links...

 so it looks like we already had a script to upload tor browser as
 releases. However, it also looks old (last edited in 2016) and like it
 does not match the current functionality of gettor. For example, the link
 creation seems outdated:
 {{{core.create_links_file('GitHub', readable_fp)}}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:  .5
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * points:   => 1
 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 Here's a script that uses the github API to upload gertor as releases:
 
https://dip.torproject.org/cohosh/gettor/commit/6a801cfe45753faba996dd3188e928c90e5ddd9a

 I've run it on a test repo I created and it works great! The only thing we
 need to do is generate an authentication token for the `torproject-pusher`
 user and store it somewhere safe on `gettor-01`. Instructions for
 generating it are here: https://help.github.com/en/github/authenticating-
 to-github/creating-a-personal-access-token-for-the-command-line

 I don't have access, so someone who does will have to do that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by arma):

 It does seem like deleting the git branch won't reduce the repo size. It's
 equivalent to deleting a pointer to a commit -- all the commits will still
 be there.

 If we want to make the old approach work on github/gitlab, we probably
 want to throw out the repo periodically and then put new tor browser files
 into a fresh repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32480 [Applications/GetTor]: Use Github/Gitlab releases to distribute gettor binaries (was: Use Github releases to distribute gettor binaries)

[Tor Bug Tracker & Wiki]

#32480: Use Github/Gitlab releases to distribute gettor binaries
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  github, releases |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs