Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 The current implementation does not appear to account for PBM. Kathy and I
 found this bug which is related:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1604272

 We will create a patch to set `browser.ssb.enabled` to `false`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Replying to [comment:3 mcs]:
 > sysrqb or gk, what are your thoughts r.e. comment:2?

 Yes, I agree with that. We currently have bigger fish to fry than stubbing
 out a disabled feature like that. I guess what we can do for now, though,
 is setting the pref explicitly to `false` in our prefs file.

 That said I wonder why this is actually an issue for us at all, given that
 Mozilla likely does not want to reveal any local caching done outside of
 PBM which is then used for that feature in PBM. I feel this is either a
 non-issue (I have not looked at the code)  or something upstream wants to
 address, too, without stubbing out the function. (If the latter is the
 case we should file an upstream bug I think)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Description changed by gk:

Old description:

> When the browser is in site-specific browser mode the app browser icon is
> set to the website's favicon. This icon presumably is cached somewhere by
> the operating syste, so we should not expose the icon in this fashion
> when in private browsing mode.
>
> This mode can be accessed when:
> - browser.ssb.enabled = true
>
> Relevant ticket:
> - https://bugzilla.mozilla.org/show_bug.cgi?id=1602194

New description:

 When the browser is in site-specific browser mode the app browser icon is
 set to the website's favicon. This icon presumably is cached somewhere by
 the operating system, so we should not expose the icon in this fashion
 when in private browsing mode.

 This mode can be accessed when:
 - browser.ssb.enabled = true

 Relevant ticket:
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1602194

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by mcs):

 * status:  assigned => needs_information


Comment:

 sysrqb or gk, what are your thoughts r.e. comment:2?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 This is only an issue if someone flips the hidden pref
 `browser.ssb.enabled` to `true`. The tracking bug for the site-specific
 browsing feature is:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1602117
 If we are worried about someone playing with this loaded gun we could stub
 out the `applyOSIntegration()` function in
 browser/components/ssb/WindowsSupport.jsm but it seems okay to ignore this
 for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---
Changes (by pospeselr):

 * parent:   => #33534


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs