Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Looks good. Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by anarcat):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 karsten]:
 > Replying to [comment:4 anarcat]:
 > >  1. add the collector/collector2 hosts (and you lose the
 colchicifolium/corsicum reference)
 > >  2. add a collector2 service (and you still don't have the
 colchicifolium/corsicum reference)
 >
 > If this is just about the "global/collector" thing, I'm fine with having
 a "global/collector" and "global/collector2" without the host names.

 Done.

 > >  3. add the service to the colchicifolium/corsicum hosts, but then you
 need to fix the check to be able to bypass DNS, as I said
 >
 > I'm afraid this isn't trivial to do for me. If one of the variants above
 works, I'd like to avoid digging deeper into Python library stuff here.

 It's not exactly trivial, which is why I warned about this. :)

 I pushed the new checks now, let me know if it doesn't work as expected...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Replying to [comment:4 anarcat]:
 >  1. add the collector/collector2 hosts (and you lose the
 colchicifolium/corsicum reference)
 >  2. add a collector2 service (and you still don't have the
 colchicifolium/corsicum reference)

 If this is just about the "global/collector" thing, I'm fine with having a
 "global/collector" and "global/collector2" without the host names.

 >  3. add the service to the colchicifolium/corsicum hosts, but then you
 need to fix the check to be able to bypass DNS, as I said

 I'm afraid this isn't trivial to do for me. If one of the variants above
 works, I'd like to avoid digging deeper into Python library stuff here.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by anarcat):

 * owner:  anarcat => metrics-team
 * status:  accepted => assigned


Comment:

 >  Regarding the host/address hack, I don't think we'll need that. We can
 simply put in the public DNS name, rather than the host name.
 >
 > anarcat, can you review these changes and deploy two checks for the two
 hosts, ideally labeled as "colchicifolium/collector" and
 "corsicum/collector", so that I can quickly notice which one I need to
 fix?

 well that's the thing: service checks are attached to hosts here, and
 right now the hostnames are colchicifolium and corsicum - the "collector"
 and "collector2" names do not exist in nagios. so we can either:

  1. add the collector/collector2 hosts (and you lose the
 colchicifolium/corsicum reference)
  2. add a collector2 service (and you still don't have the
 colchicifolium/corsicum reference)
  3. add the service to the colchicifolium/corsicum hosts, but then you
 need to fix the check to be able to bypass DNS, as I said

 Which one will it be? :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  anarcat
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by anarcat):

 * owner:  metrics-team => anarcat
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * cc: anarcat, tpa (added)


Comment:

 I updated the script. Changes are:
  - The script now uses argparse to parse arguments.
  - The newly added `-m` argument allows ignoring missing timestamps. This
 makes it possible to also check the backup CollecTor host that doesn't
 archive all descriptor types.

 Regarding the host/address hack, I don't think we'll need that. We can
 simply put in the public DNS name, rather than the host name. Examples:

 {{{
 python3 tor-check-collector -s collector.torproject.org   # for
 colchicifolium
 python3 tor-check-collector -s -m collector2.torproject.org   # for
 corsicum
 }}}

 anarcat, can you review these changes and deploy two checks for the two
 hosts, ideally labeled as "colchicifolium/collector" and
 "corsicum/collector", so that I can quickly notice which one I need to
 fix?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * Attachment "tor-check-collector" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34029 [Metrics/CollecTor]: Add more command-line arguments to the Nagios CollecTor check script

[Tor Bug Tracker & Wiki]

#34029: Add more command-line arguments to the Nagios CollecTor check script
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Here's a comment from anarcat on #33972 to consider when working on this
 patch:

 > That's fine: the point is to make sure we check on a specific host
 instead of delegating this to DNS or whatever. Keep in mind this means you
 need to bypass DNS while still making HTTPS verification work! It's tricky
 stuff... But since you're already using `urlopen()`, it's possible you can
 implement such a hack.

 Also, once the script actually allows checking different CollecTor hosts,
 we can update the label from "global/collector" to "$hostname/collector"
 or similar.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs