Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320, |
  BugSmashFund   |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by arma):

 On moria1:
 {{{
 Oct 04 09:20:34.684 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.1-alpha-dev 69a1f9c8a7a9c822)
 Oct 04 09:20:34.685 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=F5F76C12B07AC124B3B02E03AC526D6F1B20EB77. md=0x55a95055ced0,
 rs=0x55a994a42af0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.4.2.1-alpha-dev 69a1f9c8a7a9c822)
 }}}

 {{{
 Oct 10 02:16:56.676 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 02:16:56.676 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=5E6D82B5F73EE48D5755949EE42C755D9BA7C5CC. md=0x55bcfd5ed2d0,
 rs=0x55bd13955b40, ri=0x55bd08462740. Microdesc digest in RS matches. RS
 okay in networkstatus. (on Tor 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 }}}

 {{{
 Oct 10 15:16:56.901 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.901 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=FCB454EAB56713C641C7A8F2E45B85E7921B9760. md=0x55bcfbe67330,
 rs=0x55bd177f72a0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.902 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.902 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=CA3733C8774CCF863A47153B2DC9D70C1550C847. md=0x55bcfd72ba70,
 rs=0x55bd047e9bb0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.903 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.903 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=9A0D54D3A6D2E0767596BF1515E6162A75B3293F. md=0x55bcfbcfd410,
 rs=0x55bd0dbf8ac0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.904 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 Oct 10 15:16:56.904 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=8CB3BBC8CEEA91734CF2A275FA52FC55ECBC8A5B. md=0x55bcfd80e120,
 rs=0x55bd18e00f00, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.4.2.2-alpha-dev 0d82a8be77ae8d7f)
 }}}

 {{{
 Oct 11 13:16:57.285 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding 

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320, |
  BugSmashFund   |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-client, 025-backport, nickm-should-review, review-group-24,
 033-triage-20180320, 033-removed-20180320, 042-should, BugSmashFund
 =>
 tor-client, 025-backport, nickm-should-review, review-group-24,
 033-triage-20180320, 033-removed-20180320, BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320, |
  042-should, BugSmashFund   |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-
Changes (by dgoulet):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320, |
  042-should, BugSmashFund   |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-
Changes (by dgoulet):

 * cc: nickm (added)
 * keywords:
 tor-client, 025-backport, nickm-should-review, review-group-24,
 033-triage-20180320, 033-removed-20180320
 =>
 tor-client, 025-backport, nickm-should-review, review-group-24,
 033-triage-20180320, 033-removed-20180320, 042-should, BugSmashFund
 * milestone:  Tor: unspecified => Tor: 0.4.2.x-final


Comment:

 `longclaw` saw this yesterday (reported to me in private):

 {{{
 Oct 06 08:20:03.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 192 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.1.6 )
 Oct 06 08:20:03.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=74A910646BCEEFBCD2E874FC1DC997430F968145. md=0x5560fee9d750, rs=(nil),
 ri=0x5560fd45c210. No RS. (on Tor 0.4.1.6 )
 }}}

 FYI, `ID=74A910646BCEEFBCD2E874FC1DC997430F968145` is longclaw's
 fingerprint.

 So I'm assuming this means there is an issue with its own cleanup of its
 md?

 I'm bringing it back to 042 milestone since this seems wise to revisit it
 a bit since it is hitting our dirauth.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320  |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by starlight):

 {{{
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=1C70C2AA7F3772CE07C4EF6B18A6E330150372EE. md=0x0b55df0,
 rs=0x3fb8440, ri=0x2fd2120. Microdesc digest in RS does match. RS
 okay in networkstatus. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=95D0B345ECC84FD2BF27A33B2765DF5E077ACDBD. md=0xXXXYdaee5c90,
 rs=0xbf2b470, ri=0x3548090. Microdesc digest in RS does match. RS
 okay in networkstatus. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=98EF3981F766F9F87D7C399E6DD0FFC3867711AF. md=0x064d6d0,
 rs=0x0142900, ri=0x2d96bf0. Microdesc digest in RS does match. RS
 okay in networkstatus. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=12F8A0468A77B5BC588780BFC5010C1E43421B0D. md=0x6f79c50,
 rs=0xXXXYdf5073a0, ri=0x53e6090. Microdesc digest in RS does match. RS
 okay in networkstatus. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=DC2E059C157322DF555F2041601EDF7E69655E04. md=0xXXXYdfcfe930,
 rs=0xXXXYda55d4d0, ri=0xXXXYdc5e5210. Microdesc digest in RS does match.
 RS okay in networkstatus. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 0 hours old. Hashtable badness is 0. (on Tor 0.3.5.8 )
 Jun 22: microdesc_cache_clean(): Bug:   [0]:
 ID=D8B16FB9CDFF228C03B1A628B3B45620F93E320A. md=0x094df80,
 rs=0x56f2f90, ri=0xXXXYdaa472a0. Microdesc digest in RS does match. RS
 okay in networkstatus. (on Tor 0.3.5.8 )
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24,|
  033-triage-20180320, 033-removed-20180320  |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by cypherpunks):

 After syncing time in ticket:19460#comment:6 and hibernation, Tor shows
 {{{
 Tor NOTICE: Heartbeat: Tor's uptime is 13 days 0:41 hours, with 3 circuits
 open. I've sent 110.30 MB and received 728.68 MB.
 }}}
 but then
 {{{
 Tor WARN: microdesc_cache_clean(): Bug: Microdescriptor seemed very old
 (last listed 168 hours ago vs 168 hour cutoff), but is still marked as
 being held by 1 node(s). I found 1 node(s) holding it. Current
 networkstatus is 11 hours old. Hashtable badness is 0. (on Tor 0.3.2.10 )
 Tor WARN: microdesc_cache_clean(): Bug:   [0]:
 ID=0E71008524180D47796858A79EEC0F2233568B59. md=027FF798, rs=020E2B68,
 ri=. Microdesc digest in RS matches. RS okay in networkstatus. (on
 Tor 0.3.2.10 )
 Tor NOTICE: Your system clock just jumped 38542 seconds forward; assuming
 established circuits no longer work.
 Tor NOTICE: Heartbeat: Tor's uptime is 13 days 3:58 hours, with 0 circuits
 open. I've sent 110.95 MB and received 732.77 MB.
 Tor NOTICE: Average packaged cell fullness: 61.425%. TLS write overhead:
 5%
 Tor NOTICE: Tor has successfully opened a circuit. Looks like client
 functionality is working.
 }}}
 So, Tor thinks 3:17 hours = 38542 seconds and also shows this bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by arma):

 {{{
 Nov 30 08:53:25.913 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 174 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 2 hours old. Hashtable badness is 0. (on Tor
 0.3.3.0-alpha-dev 8ff60b52889ecd40)
 Nov 30 08:53:25.913 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=9695DFC35FFEB861329B9F1AB04C46397020CE31. md=0x7f2386b4d9a0, rs=(nil),
 ri=0x7f238222a380. No RS. (on Tor 0.3.3.0-alpha-dev 8ff60b52889ecd40)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 I wonder if this can happen when a relay wakes up from hibernation after a
 week or two?

 168 hours isn't very old for a microdesc any more: Tor relays used to
 change their onion keys every 7 days, forcing a microdesc hash change
 every week. But now, the expired microdesc can be listed in the new
 consensus after hibernation, because the onion keys only change every 30
 days.

 Maybe this isn't the issue, but it seems like it might be worth looking
 into.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-

Comment (by arma):

 moria1 hits this once a week or so:
 {{{
 Nov 01 15:18:22.682 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.3.3.0-alpha-dev 853bbb9112a16055)
 Nov 01 15:18:22.682 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=BB119A5A4D5DA2BBB7B796ECC50E3C0F1D4FD910. md=0x7fdea11000b0,
 rs=0x7fdea6c395c0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.3.3.0-alpha-dev 853bbb9112a16055)
 Nov 01 15:18:22.690 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 168 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.3.3.0-alpha-dev 853bbb9112a16055)
 Nov 01 15:18:22.690 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=B62A3F23955AF323A03F4ADB355C7D00594CFBD1. md=0x7fdea194a650,
 rs=0x7fdec70afbf0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.3.3.0-alpha-dev 853bbb9112a16055)
 Nov 01 15:18:22.690 [info] microdesc_cache_clean(): Removed 126/55533
 microdescriptors as old.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * cc: asn (added)
 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-24 |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 Hm, took a look at this ticket given that I have spent some time with mds
 lately. I don't entirely understand the `dc60e87d6` fix here. I think some
 more docs would be appreciated.

 Why do we call `update_microdescs_from_networkstatus()` in
 `networkstatus_note_certs_arrived()` and not in
 `networkstatus_set_current_consensus()`? Would we ever want to update our
 microdescs if we didn't actually successfuly set a consensus, and we just
 fetched some certs?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review
 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 Branch `bug7164_032` is a rebase of the older attempted fix (possibly
 irrelevant) with the other fix suggested above.

 I don't see how clearing all the md values is necessary in
 nodelist_set_consensus() -- any microdesc value not reached in the main
 loop in that function should get removed later, by nodelist_purge().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, TorCoreTeam201609   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 Duplicate in #21640, aspirationally moving this to 0.3.2, because it would
 be great to fix it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, TorCoreTeam201609   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.0.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, TorCoreTeam201609   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, TorCoreTeam201609   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-client, 025-backport, nickm-should-review, TorCoreTeam201609,
 review-group-10
 => tor-client, 025-backport, nickm-should-review, TorCoreTeam201609
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.3.0.x-final


Comment:

 If this is so pervasive, we should expect the fix to be destabilizing, and
 aim it for 0.3.0. :/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-9  |
  TorCoreTeam201609  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-client, 025-backport, nickm-should-review, review-group-8
 TorCoreTeam201609
 =>
 tor-client, 025-backport, nickm-should-review, review-group-9
 TorCoreTeam201609


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-8  |
  TorCoreTeam201609  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-client, 025-backport, nickm-should-review, review-group-8
 =>
 tor-client, 025-backport, nickm-should-review, review-group-8
 TorCoreTeam201609


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Replying to [comment:84 cypherpunks]:
 > Another problem, there are dozens relays (last time checked it was
 around 40 relays) that never rotate onion keys for some reason.

 Split off #20055 for this issue.

 The rest of this ticket seems to need a revision, based on the cypherpunks
 comments.
 (Next time, please PGP encrypt an email for vulnerabilities, or make
 plain-text comments otherwise. It helps us fix all the issues at the same
 time.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Another problem, there are dozens relays (last time checked it was around
 40 relays) that never rotate onion keys for some reason.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 > Okay. A consensus arrives

 Your case happens if consensus were set by
 networkstatus_note_certs_arrived(), it miss all update_*() functions.

 Alas, it's not last edge case that trigger thus warnings.
 nodelist_set_consensus() must to clear all node->md like it does for
 node->rs to fix all remain cases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:74 cypherpunks]:
 > U2FsdGVkX19xU5DZ+k76OvKVNZbPzyTLeVU3rQslY+Bz8xq+mXT59freOTt4KDRQ
 > ScTaE9PCTdMED5CkBlXJuTJfOCJNEO69AskcLeDTRRFT1w9W3QWgxZshpgc8T5qD
 > GwweQ02CWm/bdq0NW070xUHuno10nLbIBAO8a/bzcfSbyquibM+FIZlQTA0n0Fda
 > Qey6pv3d9y7v/Lc8OHfZUD1Vvbe9v9P5xqrpwcwkdT0klI5B5Vgaike7m25P1hDh
 > MBzO6gX3NNnA1ST5pP0qpuFgZMK79uJmbXUj0iECLs6sGD/HgY19p9Vw/T6Pt7P4
 > 8+mh5lUOzcLAX2Lc1yKZEBYIJmSnYwgWYensAepobKH785iuij/a6X4YLdJ39BCz
 > nvkKCfm4cLCLGEG+4MkrRClBN7YtpZ57K9LSyWnxTHKJinFYLpGMc9VYViScYq3E
 > Qm9xVYisuET5bD7tBjgbXCJdF67++7w=
 >
 > (openssl enc -aes-256-xts -d -base64
 > sha256(password) =
 62493873306edef2c14c567d252b5b029d67fe3119c703486209a93bb9e4117e)
 >
 > EDIT: function name copy/paste typo

 Found password
 > echo "the report of my death was an exaggeration" | openssl sha256

 Deciphered
 > get_microdesc_cache() is being called for the first time by
 nodelist_set_consensus(). md->held_by_nodes incremented by
 nodelist_set_consensus() too (nodelist_add_microdesc skip that part as no
 any nodes created yet). microdesc_cache_clean() is being called for the
 first time without held_by_nodes for any md. if no held_by_nodes then no
 bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm;

 Note that I can't really test this, I do not have a old data set of tor :S
 and using CollecTor files makes it a bit complicated since the archive of
 microdescriptors are ordered by ID and not in one single fat file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.19
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, 025-backport, nickm- |  Actual Points:
  should-review, review-group-7  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => accepted
 * owner:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  tor-client 025-backport nickm-   |Version:  Tor:
  should-review  |  0.2.4.19
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-

Comment (by cypherpunks):

 I got this when starting tor 0.2.8.6:

 {{{
 [warn] microdesc_cache_clean(): Bug: Microdescriptor seemed very old (last
 listed 3762 hours ago vs 168 hour cutoff), but is still marked as being
 held by 1 node(s). I found 1 node(s) holding it. Current networkstatus is
 1 hours old. Hashtable badness is 0. (on Tor 0.2.8.6 )
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  tor-client 025-backport nickm-   |Version:  Tor:
  should-review  |  0.2.4.19
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  tor-client 025-backport nickm-   |  0.2.4.19
  should-review  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by nickm):

 If you want me to see that, you should probably just GPG it to me. I don't
 know what password you're using.

 (And if you don't want me to see that, I don't understand what's going
 on.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  tor-client 025-backport nickm-   |  0.2.4.19
  should-review  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:72 nickm]:
 > '''If get_microdesc_cache() is being called for the first time''', it
 loads the microdescs from disk, and then calls microdesc_cache_clean(). We
 have a new consensus, but we have not yet finished
 `update_microdescs_from_networkstatus`.

 U2FsdGVkX18hzDVl4YA7do/Mz7FlVFgUkTNTrs2EJUjzR4b5iF1T/Ug4+BvQdIR/
 nsp28dO5DpevwpUVTEGVjkHXE09kgF4ug32Vu5JgG72d2/vFhhO0f/n+yWLygnTN
 T77lxi5nSCk4Wwhq/BcDUZAJ7NzbJadGSDNab11bwHBjgwWuwKvyDf7BEXHow7yG
 yU17pSMzFgBH2mdJebXwHAq6MrdvSuP3JOOSfVZVKLBKyyGX4liZsTlxWxnRlUof
 DdsPg15UvJBr/zciAzCjjZtwFezFF3fb2mpgWRS0WKDsI19D+Ws2yx3fXXJg03+g
 Qd14Ss/ar+UXS7lAbEvfs+vCMoaQbZHgPfja0OHslKB1VSsm25aVBUm/yJIe9RDI
 BSzsgE5FP4+TZ4ushziWESiHgTxD6QR5BpQptpWgPVAzRgBGwq4YXcpvO7NZMUxE
 vv710V0QjgFw3Z2Yz6/wR6bq5WYPxv0=

 (openssl enc -aes-256-xts -d -base64
 sha256(password) =
 62493873306edef2c14c567d252b5b029d67fe3119c703486209a93bb9e4117e)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  tor-client 025-backport nickm-   |  0.2.4.19
  should-review  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.2.9.x-final => Tor: 0.2.8.x-final


Comment:

 If my diagnosis is right, then to see this bug, you need to restart tor
 after exactly 7 days, give or take a couple of hours.


 I've done a fix as `bug7164_028`.  Needs review. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.9.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  tor-client 025-backport nickm-   |  0.2.4.19
  should-review  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by nickm):

 Okay.  A consensus arrives, and in directory.c, in
 connection_dir_client_reached_eof, we update the consensus and call
 "update_microdescs_from_networkstatus()", which will eventually update the
 last-listed times.  But before that function updates the last-listed
 times,  it calls get_microdesc_cache().

 '''If get_microdesc_cache() is being called for the first time''', it
 loads the microdescs from disk, and then calls microdesc_cache_clean(). We
 have a new consensus, but we have not yet finished
 `update_microdescs_from_networkstatus`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.9.x-final
 Severity:  Normal   |Version:  Tor:
 Keywords:  tor-client 025-backport nickm-   |  0.2.4.19
  should-review  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => new
 * milestone:  Tor: 0.2.??? => Tor: 0.2.9.x-final


Comment:

 Huh.  Those microdescriptors supposedly have corresponding routerstatus
 objects with matching md digests.  They shouldn't be "very old" now; we
 should consider them "last listed" one hour ago.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_revision
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.???
 Keywords:  tor-client 025-backport nickm-   |Version:  Tor:
  should-review  |  0.2.4.19
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-

Comment (by nickm):

 That was with:
 {{{
 Jul 13 11:46:37.359 [notice] Tor v0.2.8.5-rc-dev running on Linux with
 Libevent 2.0.21-stable, OpenSSL 1.1.0-pre6-dev and Zlib 1.2.8.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_revision
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.???
 Keywords:  tor-client 025-backport nickm-   |Version:  Tor:
  should-review  |  0.2.4.19
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-

Comment (by nickm):

 whoo, just hit this in 0.2.8, when starting up with a very old data
 directory.  It said:
 {{{
 Jul 13 11:46:43.000 [notice] Bootstrapped 100%: Done
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=3EFB929FA15E084A5F53C9C7A058C593A97DFD57. md=0x55b7d50ae050,
 rs=0x55b7d5443610, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=179B10784BF8955C73313CCB195904AE133E5F53. md=0x55b7d50adc20,
 rs=0x55b7d5412f20, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=1EA3292F7D9EB3A9CEBA0DE4C0C19895C7C449C5. md=0x55b7d5152820,
 rs=0x55b7d541af00, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=7C0AA4E3B73E407E9F5FEB1912F8BE26D8AA124D. md=0x55b7d4f91a30,
 rs=0x55b7d548cde0, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=E79699F226A6ED3B1D13B0F6B983D40779B8693E. md=0x55b7d50a9e90,
 rs=0x55b7d5513e50, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=F378A4DD858B6B7BBB79C6EAB1CE6912AC0FF8BC. md=0x55b7d51523b0,
 rs=0x55b7d5522a20, ri=(nil). Microdesc digest in RS matches. RS okay in
 networkstatus. (on Tor 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 1056 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 1 hours old. Hashtable badness is 0. (on Tor
 0.2.8.5-rc-dev )
 Jul 13 12:16:38.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=2679B51C906158F3DF4C59AFD73E2B1FDA6535E1. md=0x55b7d50aa890,
 rs=0x55b7d540d340, ri=(nil). Microdesc digest in RS matches. RS okay in
 

Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still 
referenced
1 node(s); held_by_nodes == 1
-+-
 Reporter:  jaj123   |  Owner:
 Type:  defect   | Status:
 Priority:  High |  needs_revision
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.???
 Keywords:  tor-client 025-backport nickm-   |Version:  Tor:
  should-review  |  0.2.4.19
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-
Changes (by teor):

 * severity:   => Normal


Comment:

 #19619 was another report of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs