[tor-commits] [Git][tpo/applications/tor-browser][base-browser-115.10.0esr-13.5-1] fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch base-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Tor Browser


Commits:
97575530 by hackademix at 2024-04-16T22:17:42+02:00
fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel 
computations

Bug 42520: Correctly record new initial window size after auto-shrinking

- - - - -


1 changed file:

- toolkit/components/resistfingerprinting/RFPHelper.sys.mjs


Changes:

=
toolkit/components/resistfingerprinting/RFPHelper.sys.mjs
=
@@ -633,9 +633,16 @@ class _RFPHelper {
   lazy.logConsole.error(e);
 }
   }
-  if (needToShrink) {
-win.shrinkToLetterbox();
-this._recordWindowSize(win);
+  if (needToShrink && win.shrinkToLetterbox()) {
+win.addEventListener(
+  "resize",
+  () => {
+// We need to record the "new" initial size in this listener
+// because resized dimensions are not immediately available.
+RFPHelper._recordWindowSize(win);
+  },
+  { once: true }
+);
   }
 });
   },
@@ -741,23 +748,30 @@ class _RFPHelper {
   }
 
   _recordWindowSize(aWindow) {
-aWindow._rfpOriginalSize = {
-  width: aWindow.outerWidth,
-  height: aWindow.outerHeight,
-  containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
-};
-log("Recording original window size", aWindow._rfpOriginalSize);
+aWindow.promiseDocumentFlushed(() => {
+  aWindow._rfpOriginalSize = {
+width: aWindow.outerWidth,
+height: aWindow.outerHeight,
+containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
+  };
+  log("Recording original window size", aWindow._rfpOriginalSize);
+});
   }
 
   // We will attach this method to each browser window. When called
   // it will instantly resize the window to exactly fit the selected
   // (possibly letterboxed) browser.
+  // Returns true if a window resize will occur, false otherwise.
   shrinkToLetterbox() {
 let { selectedBrowser } = this.gBrowser;
 let stack = selectedBrowser.closest(".browserStack");
 const outer = stack.getBoundingClientRect();
 const inner = selectedBrowser.getBoundingClientRect();
-this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+if (inner.width !== outer.witdh || inner.height !== outer.height) {
+  this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+  return true;
+}
+return false;
   }
 
   _onWindowDoubleClick(e) {



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9757553093631c9142890b0b35f7b4927d70999b

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/9757553093631c9142890b0b35f7b4927d70999b
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] add to fixup! Enable the connect assist experiments on alpha

2024-04-16 Thread Dan Ballard (@dan) via tor-commits


Dan Ballard pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project 
/ Applications / firefox-android


Commits:
3768f68b by clairehurst at 2024-04-16T14:32:55-06:00
add to fixup! Enable the connect assist experiments on alpha

- - - - -


3 changed files:

- 
android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/Settings.kt
- fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
- 
fenix/app/src/main/res/layout/tor_network_settings_beta_connection_features.xml


Changes:

=
android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/Settings.kt
=
@@ -258,7 +258,7 @@ data class DefaultSettings(
 override var cookieBannerHandlingDetectOnlyMode: Boolean = false,
 override var torSecurityLevel: Int = 4,
 override var spoofEnglish: Boolean = false,
-override var useNewBootstrap: Boolean = false,
+override var useNewBootstrap: Boolean = true,
 ) : Settings()
 
 class UnsupportedSetting {


=
fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
=
@@ -1857,16 +1857,16 @@ class Settings(private val appContext: Context) : 
PreferencesHolder {
 
 var useNewBootstrap by booleanPreference(
 appContext.getPreferenceKey(R.string.pref_key_use_new_bootstrap),
-default = false,
+default = true,
 )
 
 var useNewBootstrapNativeUi by booleanPreference(
 
appContext.getPreferenceKey(R.string.pref_key_use_new_bootstrap_with_android_native),
-default = false,
+default = true,
 )
 
 var useNewBootstrapHtmlUi by booleanPreference(
 
appContext.getPreferenceKey(R.string.pref_key_use_new_bootstrap_with_html),
-default = true
+default = false
 )
 }


=
fenix/app/src/main/res/layout/tor_network_settings_beta_connection_features.xml
=
@@ -60,7 +60,7 @@
 
app:layout_constraintTop_toBottomOf="@id/enable_beta_connection_features_summary">
 
 
 
 
 
 



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/3768f68b80b6903b886a7d0e92104c1fd018bb05

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/3768f68b80b6903b886a7d0e92104c1fd018bb05
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-115.10.0esr-13.5-1] fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch mullvad-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Mullvad Browser


Commits:
a17ec8e0 by hackademix at 2024-04-16T22:18:31+02:00
fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel 
computations

Bug 42520: Correctly record new initial window size after auto-shrinking

- - - - -


1 changed file:

- toolkit/components/resistfingerprinting/RFPHelper.sys.mjs


Changes:

=
toolkit/components/resistfingerprinting/RFPHelper.sys.mjs
=
@@ -633,9 +633,16 @@ class _RFPHelper {
   lazy.logConsole.error(e);
 }
   }
-  if (needToShrink) {
-win.shrinkToLetterbox();
-this._recordWindowSize(win);
+  if (needToShrink && win.shrinkToLetterbox()) {
+win.addEventListener(
+  "resize",
+  () => {
+// We need to record the "new" initial size in this listener
+// because resized dimensions are not immediately available.
+RFPHelper._recordWindowSize(win);
+  },
+  { once: true }
+);
   }
 });
   },
@@ -741,23 +748,30 @@ class _RFPHelper {
   }
 
   _recordWindowSize(aWindow) {
-aWindow._rfpOriginalSize = {
-  width: aWindow.outerWidth,
-  height: aWindow.outerHeight,
-  containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
-};
-log("Recording original window size", aWindow._rfpOriginalSize);
+aWindow.promiseDocumentFlushed(() => {
+  aWindow._rfpOriginalSize = {
+width: aWindow.outerWidth,
+height: aWindow.outerHeight,
+containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
+  };
+  log("Recording original window size", aWindow._rfpOriginalSize);
+});
   }
 
   // We will attach this method to each browser window. When called
   // it will instantly resize the window to exactly fit the selected
   // (possibly letterboxed) browser.
+  // Returns true if a window resize will occur, false otherwise.
   shrinkToLetterbox() {
 let { selectedBrowser } = this.gBrowser;
 let stack = selectedBrowser.closest(".browserStack");
 const outer = stack.getBoundingClientRect();
 const inner = selectedBrowser.getBoundingClientRect();
-this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+if (inner.width !== outer.witdh || inner.height !== outer.height) {
+  this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+  return true;
+}
+return false;
   }
 
   _onWindowDoubleClick(e) {



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a17ec8e069203abfe8d90c6ed7119312097a354d

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/a17ec8e069203abfe8d90c6ed7119312097a354d
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.10.0esr-13.5-1] fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch tor-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Tor Browser


Commits:
334c638e by hackademix at 2024-04-16T17:24:54+02:00
fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel 
computations

Bug 42520: Correctly record new initial window size after auto-shrinking

- - - - -


1 changed file:

- toolkit/components/resistfingerprinting/RFPHelper.sys.mjs


Changes:

=
toolkit/components/resistfingerprinting/RFPHelper.sys.mjs
=
@@ -633,9 +633,16 @@ class _RFPHelper {
   lazy.logConsole.error(e);
 }
   }
-  if (needToShrink) {
-win.shrinkToLetterbox();
-this._recordWindowSize(win);
+  if (needToShrink && win.shrinkToLetterbox()) {
+win.addEventListener(
+  "resize",
+  () => {
+// We need to record the "new" initial size in this listener
+// because resized dimensions are not immediately available.
+RFPHelper._recordWindowSize(win);
+  },
+  { once: true }
+);
   }
 });
   },
@@ -741,23 +748,30 @@ class _RFPHelper {
   }
 
   _recordWindowSize(aWindow) {
-aWindow._rfpOriginalSize = {
-  width: aWindow.outerWidth,
-  height: aWindow.outerHeight,
-  containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
-};
-log("Recording original window size", aWindow._rfpOriginalSize);
+aWindow.promiseDocumentFlushed(() => {
+  aWindow._rfpOriginalSize = {
+width: aWindow.outerWidth,
+height: aWindow.outerHeight,
+containerHeight: aWindow.gBrowser.getBrowserContainer()?.clientHeight,
+  };
+  log("Recording original window size", aWindow._rfpOriginalSize);
+});
   }
 
   // We will attach this method to each browser window. When called
   // it will instantly resize the window to exactly fit the selected
   // (possibly letterboxed) browser.
+  // Returns true if a window resize will occur, false otherwise.
   shrinkToLetterbox() {
 let { selectedBrowser } = this.gBrowser;
 let stack = selectedBrowser.closest(".browserStack");
 const outer = stack.getBoundingClientRect();
 const inner = selectedBrowser.getBoundingClientRect();
-this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+if (inner.width !== outer.witdh || inner.height !== outer.height) {
+  this.resizeBy(inner.width - outer.width, inner.height - outer.height);
+  return true;
+}
+return false;
   }
 
   _onWindowDoubleClick(e) {



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/334c638e5c21a40441674c8ffc1fadbbaff3e67d

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/334c638e5c21a40441674c8ffc1fadbbaff3e67d
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.10.0esr-13.5-1] fixup! Add TorStrings module for localization

2024-04-16 Thread Pier Angelo Vendrame (@pierov) via tor-commits


Pier Angelo Vendrame pushed to branch tor-browser-115.10.0esr-13.5-1 at The Tor 
Project / Applications / Tor Browser


Commits:
08ed48fa by Henry Wilkes at 2024-04-16T16:31:30+01:00
fixup! Add TorStrings module for localization

Bug 42521: Drop unused onboarding strings.

- - - - -


2 changed files:

- − toolkit/torbutton/chrome/locale/en-US/browserOnboarding.properties
- − toolkit/torbutton/chrome/locale/en-US/onboarding.properties


Changes:

=
toolkit/torbutton/chrome/locale/en-US/browserOnboarding.properties deleted
=
@@ -1,73 +0,0 @@
-# Copyright (c) 2019, The Tor Project, Inc.
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-onboarding.tour-tor-welcome=Welcome
-onboarding.tour-tor-welcome.title=You’re ready.
-onboarding.tour-tor-welcome.description=Tor Browser offers the highest 
standard of privacy and security while browsing the web. You’re now protected 
against tracking, surveillance, and censorship. This quick onboarding will show 
you how.
-onboarding.tour-tor-welcome.next-button=Go to Privacy
-
-onboarding.tour-tor-privacy=Privacy
-onboarding.tour-tor-privacy.title=Snub trackers and snoopers.
-onboarding.tour-tor-privacy.description=Tor Browser isolates cookies and 
deletes your browser history after your session. These modifications ensure 
your privacy and security are protected in the browser. Click ‘Tor Network’ to 
learn how we protect you on the network level.
-onboarding.tour-tor-privacy.button=Go to Tor Network
-
-onboarding.tour-tor-network=Tor Network
-onboarding.tour-tor-network.title=Travel a decentralized network.
-onboarding.tour-tor-network.description=Tor Browser connects you to the Tor 
network run by thousands of volunteers around the world. Unlike a VPN, there’s 
no single point of failure or centralized entity you need to trust in order to 
enjoy the internet privately.
-onboarding.tour-tor-network.description-para2=NEW: Tor Network Settings, 
including the ability to request bridges where Tor is blocked, can now be found 
in Preferences.
-onboarding.tour-tor-network.action-button=Adjust Your Tor Network Settings
-onboarding.tour-tor-network.button=Go to Circuit Display
-
-onboarding.tour-tor-circuit-display=Circuit Display
-onboarding.tour-tor-circuit-display.title=See your path.
-onboarding.tour-tor-circuit-display.description=For each domain you visit, 
your traffic is relayed and encrypted in a circuit across three Tor relays 
around the world. No website knows where you are connecting from. You can 
request a new circuit by clicking ‘New Circuit for this Site’ on our Circuit 
Display.
-onboarding.tour-tor-circuit-display.button=See My Path
-onboarding.tour-tor-circuit-display.next-button=Go to Security
-
-onboarding.tour-tor-security=Security
-onboarding.tour-tor-security.title=Choose your experience.
-onboarding.tour-tor-security.description=We also provide you with additional 
settings for bumping up your browser security. Our Security Settings allow you 
to block elements that could be used to attack your computer. Click below to 
see what the different options do.
-onboarding.tour-tor-security.description-suffix=Note: By default, NoScript and 
HTTPS Everywhere are not included on the toolbar, but you can customize your 
toolbar to add them.
-onboarding.tour-tor-security-level.button=See Your Security Level
-onboarding.tour-tor-security-level.next-button=Go to Experience Tips
-
-onboarding.tour-tor-expect-differences=Experience Tips
-onboarding.tour-tor-expect-differences.title=Expect some differences.
-onboarding.tour-tor-expect-differences.description=With all the security and 
privacy features provided by Tor, your experience while browsing the internet 
may be a little different. Things may be a bit slower, and depending on your 
security level, some elements may not work or load. You may also be asked to 
prove you are a human and not a robot.
-onboarding.tour-tor-expect-differences.button=See FAQs
-onboarding.tour-tor-expect-differences.next-button=Go to Onion Services
-
-onboarding.tour-tor-onion-services=Onion Services
-onboarding.tour-tor-onion-services.title=Be extra protected.
-onboarding.tour-tor-onion-services.description=Onion services are sites that 
end with a .onion that provide extra protections to publishers and visitors, 
including added safeguards against censorship. Onion services allow anyone to 
provide content and services anonymously. Click below to visit the DuckDuckGo 
onion site.
-onboarding.tour-tor-onion-services.button=Visit an Onion
-onboarding.tour-tor-onion-services.next-button=Done
-
-onboarding.overlay-icon-tooltip-updated2=See what's new\nin %S
-onboarding.tour-tor-update.prefix-new=New
-onboarding.tour-tor-update.prefix-updated=Updated
-
-onboarding.tour-tor-toolbar=Toolbar

[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-115.10.0esr-13.5-1] fixup! Base Browser strings

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch mullvad-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Mullvad Browser


Commits:
9eaf8f6d by hackademix at 2024-04-16T13:14:32+02:00
fixup! Base Browser strings

MB 288: Standardize capitalization in Letterboxing preferences

- - - - -


1 changed file:

- browser/locales/en-US/browser/base-browser.ftl


Changes:

=
browser/locales/en-US/browser/base-browser.ftl
=
@@ -84,7 +84,7 @@ letterboxing-window-size-header = Window size
 letterboxing-remember-size =
 .label = Reuse last window size when opening a new window
 .accesskey = R
-letterboxing-alignment-header = Content Alignment
+letterboxing-alignment-header = Content alignment
 letterboxing-alignment-description = Choose where you want to align the 
website’s content.
 letterboxing-alignment-top = Top
 letterboxing-alignment-middle = Middle



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/9eaf8f6d1689a9160aa813f71b3226b67aa34ea2

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/9eaf8f6d1689a9160aa813f71b3226b67aa34ea2
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.10.0esr-13.5-1] fixup! Bug 41803: Add some developer tools for working on tor-browser.

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch tor-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Tor Browser


Commits:
bbc4a77b by hackademix at 2024-04-16T13:01:03+02:00
fixup! Bug 41803: Add some developer tools for working on tor-browser.

Bug 42516: Make tb-dev worktree-compatible

- - - - -


1 changed file:

- browser/locales/en-US/browser/base-browser.ftl


Changes:

=
browser/locales/en-US/browser/base-browser.ftl
=
@@ -84,7 +84,7 @@ letterboxing-window-size-header = Window size
 letterboxing-remember-size =
 .label = Reuse last window size when opening a new window
 .accesskey = R
-letterboxing-alignment-header = Content Alignment
+letterboxing-alignment-header = Content alignment
 letterboxing-alignment-description = Choose where you want to align the 
website’s content.
 letterboxing-alignment-top = Top
 letterboxing-alignment-middle = Middle



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bbc4a77bdade246d170e0f76afb74fcbc4b75a53

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/bbc4a77bdade246d170e0f76afb74fcbc4b75a53
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.10.0esr-13.5-1] fixup! Base Browser strings

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch tor-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Tor Browser


Commits:
1f1f3ab2 by hackademix at 2024-04-16T13:09:00+02:00
fixup! Base Browser strings

MB 288: Standardize capitalization in Letterboxing preferences

- - - - -


1 changed file:

- browser/locales/en-US/browser/base-browser.ftl


Changes:

=
browser/locales/en-US/browser/base-browser.ftl
=
@@ -84,7 +84,7 @@ letterboxing-window-size-header = Window size
 letterboxing-remember-size =
 .label = Reuse last window size when opening a new window
 .accesskey = R
-letterboxing-alignment-header = Content Alignment
+letterboxing-alignment-header = Content alignment
 letterboxing-alignment-description = Choose where you want to align the 
website’s content.
 letterboxing-alignment-top = Top
 letterboxing-alignment-middle = Middle



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1f1f3ab2fe67c4f164f28717782c9dc237e2de18

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1f1f3ab2fe67c4f164f28717782c9dc237e2de18
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[tor-commits] [Git][tpo/applications/tor-browser][base-browser-115.10.0esr-13.5-1] fixup! Base Browser strings

2024-04-16 Thread ma1 (@ma1) via tor-commits


ma1 pushed to branch base-browser-115.10.0esr-13.5-1 at The Tor Project / 
Applications / Tor Browser


Commits:
e98e00fa by hackademix at 2024-04-16T13:12:56+02:00
fixup! Base Browser strings

MB 288: Standardize capitalization in Letterboxing preferences

- - - - -


1 changed file:

- browser/locales/en-US/browser/base-browser.ftl


Changes:

=
browser/locales/en-US/browser/base-browser.ftl
=
@@ -84,7 +84,7 @@ letterboxing-window-size-header = Window size
 letterboxing-remember-size =
 .label = Reuse last window size when opening a new window
 .accesskey = R
-letterboxing-alignment-header = Content Alignment
+letterboxing-alignment-header = Content alignment
 letterboxing-alignment-description = Choose where you want to align the 
website’s content.
 letterboxing-alignment-top = Top
 letterboxing-alignment-middle = Middle



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e98e00fa9e255946bc9c2b157b6340f50c9eaa0e

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e98e00fa9e255946bc9c2b157b6340f50c9eaa0e
You're receiving this email because of your account on gitlab.torproject.org.


___
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits