[jira] Created: (TORQUE-51) Wrong Link on Download Page
Wrong Link on Download Page --- Key: TORQUE-51 URL: http://issues.apache.org/jira/browse/TORQUE-51 Project: Torque Issue Type: Bug Reporter: Thoralf Rickert Priority: Trivial The is a wrong link on http://db.apache.org/torque/download.html The link to the web interface of SVN is not http:svn.apache.org/viewcvs/db/torque but http://svn.apache.org/viewcvs/db/torque -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TORQUE-49) Encoding will not be used in insert-sql if it is used in generation task
[ http://issues.apache.org/jira/browse/TORQUE-49?page=comments#action_12427744 ] Thoralf Rickert commented on TORQUE-49: --- Okay, but then is the sql output of torque incorrect because it is generated in the encoding of the xml schema. My platform encoding is cp1251 or ISO 8859-1 but the xml schema is in UTF-8. The generated sql output is still in UTF-8 and not converted to cp1251 or ISO 8859-1. If Torque should use the current platform encoding for the generated files the sql and om tasks are buggy. Both generate files in the encoding of the XML schema file. They mix the encoding of the XML file and the encoding of the Torque templates. I'Ve tried the following test: - Add a special ISO-8859-1 character (for example a german umlaut) in the Torque template (for example Peer.vm) - Add a special UTF-8 character (another umlaut) in the UTF-8 encoded XML schema (for example a table description) - Generate the Peers and Objects classes. The description of the table should be added to the classes comment - The generated Peer has a ISO-8859-1 character and a UTF-8 character. Of course this is a special condition because the torque templates are normally in english and all characters can be mapped to the ASCII encoding which is a subset of ISO-8859-1 and UTF-8. So you normally don't have problems with special characters. But the fact is that torque ignores the encoding of the XML file. It should check the encoding of the XML file and convert it to the platform encoding (or better to the Torque template encoding). I had a lot of fun in the last months with character encoding in Java IO. This isn't trivial if you don't use the current platform encoding. Unicode doesn't help if you read and write text from/to files and ignore the encoding of them. Encoding will not be used in insert-sql if it is used in generation task Key: TORQUE-49 URL: http://issues.apache.org/jira/browse/TORQUE-49 Project: Torque Issue Type: Bug Components: Generator Affects Versions: 3.2 Reporter: Thoralf Rickert Priority: Trivial My schema.xml is encoded in UTF-8 and torque generates a SQL file in UTF-8. But when I run insert-sql the TorqueSQLExec task decodes the file with the system encoding because it doesn't know that the SQL file was encoded in UTF-8. My current solution is to set the attribute encoding=UTF-8 in the torque-sql-exec task call in my build-torque.xml. But I think torque should know the encoding of the files that it generates. It could be set (for example) in the sqldb.map file or by using special filename extension like .utf8.sql -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Plans to add vendor-specific properties?
Sounds good to me. Only I'd use the format key1=value1,key2=value2 for the sqlOptions Thomas On Mon, 7 Aug 2006, Greg Monroe wrote: Well, here's my point of view on this. I think this is a common enough request that we need to think about how to support stuff like this. However, being a DB specifice issue, I'm not sure this should be embedded in the core of Torque. A solution I can see would be to do something similar to the following in the core code: 1) Modify the schema DTD to include a new attribute, sqlOptions, on all the major elements. Define the format of this to be something that allows for a a list of key/value pairs, e.g.: Table ... sqlOptions=key1, value, key1, value1 2) Then add a getSqlOptions(key) method to all the matching generator classes. This would allow DB specific templates to be created that could have code like $table.getSqlOption(key1) in them. Since options like this can be both DB and DB version specific, I'd see such templates being supplied as add-ons (using the new add-on code that I'm working on 8) ). So, if you need special DB features and someone has contributed an add-on set of templates, just use the Torque distro, specify and override directory, and put the add-on templates there. (And if no one has contributed one.. feel free to share.) This way we can semi-support DB Version X's special features, without getting the core development tied up in testing a lot of DB (and DB version) specific options support. Florian Hopf said: Hi all, I'm wondering if there are any plans to include some vendor specific properties to Torque? Currently I'd propably need support for setting the character set and the storage engine in MySQL for some tables. Though I could modify the templates for my needs quite easily I'd appreciate a statement if such a thing would possibly be included in Torque some time. The only similar reference I found is the next release section in the wiki, which contains the suggestion to include an encoding attribute to the database element. Kind regards Florian Duke CE Privacy Statement Please be advised that this e-mail and any files transmitted with it are confidential communication or may otherwise be privileged or confidential and are intended solely for the individual or entity to whom they are addressed. If you are not the intended recipient you may not rely on the contents of this email or any attachments, and we ask that you please not read, copy or retransmit this communication, but reply to the sender and destroy the email, its contents, and all copies thereof immediately. Any unauthorized dissemination, distribution or copying of this communication is strictly prohibited. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
