Re: SVN::GetRootAndHead

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev 
onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sahlberg:

Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
tortois...@googlegroups.com>:

would it work if we do both?

rev = cachedProperties.GetHeadRevision(uuid, path);
if ((rev == NO_REVISION) || (m_err != nullptr))
{
svn_error_clear(m_err);
rev = cachedProperties.GetHeadRevision(uuid, url);
}
I don't have a setup ready to test this. At least it would be better than 
before:
- if the path doesn't exist anymore, we try again with the root
- if root works, fine
- if root doesn't work either, it's no worse than before


Stefan


Agree with you that it's no worse than before. It seems to work in my 
testing. I've committed as r29691.

I've also asked on the subversion dev@ mailing list.

Kind regards,
Daniel


Turned out to be my fault altogether, based in r29499. I've reverted 
everything and will circle back to the original project monitor issue. 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegroups.com.

Re: To not delete the pathfile

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev 
onsdag 1 maj 2024 kl. 19:57:34 UTC+2 skrev Stefan:

if you set the registry DWORD value
HKCU\Software\TortoiseSVN\Debug
to 1, then TortoiseProc will show a message box on startup with the command 
line. While that message box is shown you can make a copy of the pathfile.


Clever trick, works perfectly. Thanks! 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/15a0e301-73dc-4c16-9c84-a97109a674c5n%40googlegroups.com.

Re: To not delete the pathfile

2024-05-01 Thread Stefan via TortoiseSVN-dev 
if you set the registry DWORD value
HKCU\Software\TortoiseSVN\Debug
to 1, then TortoiseProc will show a message box on startup with the command 
line. While that message box is shown you can make a copy of the pathfile.

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8806c902-b350-46ad-808c-c216cc3c0c04n%40googlegroups.com.

To not delete the pathfile

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev 
Hi,

I'm looking at the bug report that Win11 context menu only processes a 
subset of the selected items 
(https://groups.google.com/g/tortoisesvn/c/tXskNbYHCAQ/m/rIbHwMoTAgAJ?utm_medium=email&utm_source=footer).
 
I'm leaning towards a Win11 bug but to prove it I'd like to keep the path 
file created by the context menu handler.

I'm looking for a way to ignore the "deletepathfile" argument, or for the 
context menu to NOT add it to the command line, a kind of debugging option. 
Any advice?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/f193a6cc-43f5-4b01-b82c-5bd26d0a4a05n%40googlegroups.com.

Re: SVN::GetRootAndHead

2024-05-01 Thread TortoiseSVN-dev 
Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
tortoisesvn-dev@googlegroups.com>:

> would it work if we do both?
>
> rev = cachedProperties.GetHeadRevision(uuid, path);
> if ((rev == NO_REVISION) || (m_err != nullptr))
> {
> svn_error_clear(m_err);
> rev = cachedProperties.GetHeadRevision(uuid, url);
> }
> I don't have a setup ready to test this. At least it would be better than
> before:
> - if the path doesn't exist anymore, we try again with the root
> - if root works, fine
> - if root doesn't work either, it's no worse than before
>

> Stefan
>
>
Agree with you that it's no worse than before. It seems to work in my
testing. I've committed as r29691.

I've also asked on the subversion dev@ mailing list.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/CAMHy98OpkNREhjqyd4yfiY8NtM-H0Gye9FqFzc4kJ4f33v7mBg%40mail.gmail.com.