[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Correct, sorry, I forgot to change the theme. Thanks, it works now. I'm going to upload this. Will you propose a merge for the theme change? (As this is a new feature, I grant the FFe for it) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
** Branch linked: lp:~ubuntu-desktop/gtk/ubuntu -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
** Changed in: gtk+2.0 (Ubuntu) Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Fix Committed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
This bug was fixed in the package gtk+2.0 - 2.24.24-0ubuntu3 --- gtk+2.0 (2.24.24-0ubuntu3) utopic; urgency=medium * Apply patch from Adam Smith, backported from gtk+3.0, to allow windows to be dragged using blank spaces in the toolbar as well as the menubar. (LP: #1332721) * 0001-threads-Do-not-release-the-GDK-lock-if-it-hasn-t-bee.patch: Cherry-pick from upstream to work around abort() inside GLib occuring in applications that do not intialise GDK for threading right. (LP: #1374030) -- Iain Lane iain.l...@canonical.com Thu, 09 Oct 2014 12:38:20 +0100 ** Changed in: gtk+2.0 (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Fix Released Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Thanks Iain! Did you want me to raise bugs against the various theme packages or just add them to this bug? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Fix Released Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Hi Iain, I'm sorry it didn't work. As noted in comment 3, you also have to edit your gtk2 theme - did you do this? I can't give you a debdiff at the mo, but all you just need to do is remove the 062_dnd_menubar.patch and replace it with my patch. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
Re: [Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
On Mon, Sep 29, 2014 at 07:33:39PM -, Adam Smith wrote: Hi Iain, I use it with the Mate desktop, so try something like caja..but I can compile it myself, I'm not sure if the versions in the Ubuntu repo uses GTK2 or 3I'm guessing it will still be 2. It is, and I'm afraid I can't get the patch as attached to this bug to work with caja. Could you prepare a debdiff on top of the gtk+2.0 package in Utopic? I think that'd be easier at this point. If you need help you can come to #ubuntu-desktop on Freenode IRC where we hang out. Cheers, -- Iain Lane [ i...@orangesquash.org.uk ] Debian Developer [ la...@debian.org ] Ubuntu Developer [ la...@ubuntu.com ] -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
** Changed in: gtk+2.0 (Ubuntu) Assignee: (unassigned) = Iain Lane (laney) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Hi Adam, I looked at uploading this today,but I couldn't confirm it works. Can you give me an example application in the archive that I can check it out on? I tried gtk and pinta. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
s/gtk/gimp/ oops :) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
pcmanfm? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Hi Iain, I use it with the Mate desktop, so try something like caja..but I can compile it myself, I'm not sure if the versions in the Ubuntu repo uses GTK2 or 3I'm guessing it will still be 2. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
oopsnot sure why that 'can' is in post 15! -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Can you also provide an updated changelog entry for your patch? That would help in sponsoring this patch. You could also upload a 'debdiff' which shows this patch in the proper location for packaging along with the changelog diff. Thanks! -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Iain, thanks for the comment. Was it the gtkmenushell.c hunk causing the problem? I just copied and pasted that from the 062_dnd_menubar patch, but I see now that has been refreshed. Attached should be a patch that applies cleanlyI hope! It does the job of the 062_dnd_menubar patch and also adds the toolbar dragging. Sorry I haven't got around to contacting upstreamwill try to do this soon! ** Patch added: menubar-toolbar-drag-v2.patch https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+attachment/4177838/+files/menubar-toolbar-drag-v2.patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
** Patch removed: menubar-toolbar-drag-v2.patch https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+attachment/4177838/+files/menubar-toolbar-drag-v2.patch ** Patch added: menubar-toolbar-drag-v3.patch https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+attachment/4177869/+files/menubar-toolbar-drag-v3.patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1332721] Re: Add patch to allow toolbar dragging
Adam, I tried to apply this with a view to uploading but it looks as if the patch doesn't apply cleanly on top of .24 - could you please rebase on the current utopic version? A quick ping on upstream bug #611313 would be appreciated but I wouldn't block uploading this patch on that cheers! -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1332721 Title: Add patch to allow toolbar dragging Status in “gtk+2.0” package in Ubuntu: Confirmed Bug description: Ubuntu already has a patch - 062_dnd_menubar.patch - that allows the window to be dragged by clicking on empty space in the menubar. The attached patch builds on this and allows empty space in the toolbar to be also dragged. It is essentially commit 7491e9e97aa6b0f9950897c4f1282b470c79d451 that went into gtk+3.0 way back in 2010. This would make GTK2 themes behave much more like GTK3 themes. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
