[Touch-packages] [Bug 1366207] Re: qgl.h typedefs GLdouble to float instead of double
This breaks the Qt4 ABI and we are not going to do that. ** Changed in: qt4-x11 (Ubuntu) Status: New = Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to qt4-x11 in Ubuntu. https://bugs.launchpad.net/bugs/1366207 Title: qgl.h typedefs GLdouble to float instead of double Status in “qt4-x11” package in Ubuntu: Won't Fix Bug description: In qgl.h, for the OpenGL ES 2.0, GLdouble is typedef'ed to float. This causes a compile error in the armhf architcture in downstream programs including OpenSceneGraph and other programs. Recently, Qt committed a patch (https://codereview.qt-project.org/#/c/93984/1//ALL) for Qt 5 to change the typedef from float to double, since (according to the commit message), the typedef was from S60 and wasn't being used anywhere. I've backported the patch to Qt 4, but I wasn't able to do a full build for armhf; the build was taking 12+ hours for me. However, it does seem to have compiled the OpenGL source code files and a few examples related to this successfully. Therefore, I wasn't fully able to verify that this compiles successfully. This is intended to be a bugfix-only update; however, since the ABI is effectively being changed, this change might warrant some discussion here. The expectation for downstream packages on armhf is that more packages can be compiled, since some packages have this typedef error, but some packages may also fail to compile if they rely on the fact that this was a float. I'm expecting that the number for the latter case is low to 0, since this is a widening conversion. I've attached the raw patch file. This will need to be added to debian/patches. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/1366207/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1366207] Re: qgl.h typedefs GLdouble to float instead of double
Correction: the link to the actual change review is https://codereview .qt-project.org/#/c/93984/1. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to qt4-x11 in Ubuntu. https://bugs.launchpad.net/bugs/1366207 Title: qgl.h typedefs GLdouble to float instead of double Status in “qt4-x11” package in Ubuntu: Won't Fix Bug description: In qgl.h, for the OpenGL ES 2.0, GLdouble is typedef'ed to float. This causes a compile error in the armhf architcture in downstream programs including OpenSceneGraph and other programs. Recently, Qt committed a patch (https://codereview.qt-project.org/#/c/93984/1//ALL) for Qt 5 to change the typedef from float to double, since (according to the commit message), the typedef was from S60 and wasn't being used anywhere. I've backported the patch to Qt 4, but I wasn't able to do a full build for armhf; the build was taking 12+ hours for me. However, it does seem to have compiled the OpenGL source code files and a few examples related to this successfully. Therefore, I wasn't fully able to verify that this compiles successfully. This is intended to be a bugfix-only update; however, since the ABI is effectively being changed, this change might warrant some discussion here. The expectation for downstream packages on armhf is that more packages can be compiled, since some packages have this typedef error, but some packages may also fail to compile if they rely on the fact that this was a float. I'm expecting that the number for the latter case is low to 0, since this is a widening conversion. I've attached the raw patch file. This will need to be added to debian/patches. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/1366207/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1366207] Re: qgl.h typedefs GLdouble to float instead of double
It's an ABI break either way, so it's not something we'll do. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to qt4-x11 in Ubuntu. https://bugs.launchpad.net/bugs/1366207 Title: qgl.h typedefs GLdouble to float instead of double Status in “qt4-x11” package in Ubuntu: Won't Fix Bug description: In qgl.h, for the OpenGL ES 2.0, GLdouble is typedef'ed to float. This causes a compile error in the armhf architcture in downstream programs including OpenSceneGraph and other programs. Recently, Qt committed a patch (https://codereview.qt-project.org/#/c/93984/1//ALL) for Qt 5 to change the typedef from float to double, since (according to the commit message), the typedef was from S60 and wasn't being used anywhere. I've backported the patch to Qt 4, but I wasn't able to do a full build for armhf; the build was taking 12+ hours for me. However, it does seem to have compiled the OpenGL source code files and a few examples related to this successfully. Therefore, I wasn't fully able to verify that this compiles successfully. This is intended to be a bugfix-only update; however, since the ABI is effectively being changed, this change might warrant some discussion here. The expectation for downstream packages on armhf is that more packages can be compiled, since some packages have this typedef error, but some packages may also fail to compile if they rely on the fact that this was a float. I'm expecting that the number for the latter case is low to 0, since this is a widening conversion. I've attached the raw patch file. This will need to be added to debian/patches. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/1366207/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
