[Touch-packages] [Bug 1400682] Re: Add xdiagnose fallback when display-manager fails to start

2014-12-15 Thread Didier Roche
Right on the dependency, I thought only on the ubuntu destkop case, but
yeah, should downgrade to suggests :)

Nice idea on the .d! Definitively doing that then (and so, can close
this bug report) :)

Cheers,


** Changed in: systemd (Ubuntu)
   Status: New = Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1400682

Title:
  Add xdiagnose fallback when display-manager fails to start

Status in systemd package in Ubuntu:
  Invalid

Bug description:
  Attached patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1400682/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1400682] Re: Add xdiagnose fallback when display-manager fails to start

2014-12-15 Thread Martin Pitt
+xdiagnose (= 3.7),

I don't want systemd to pull in xdiagnose. This will lead to pretty much
a disaster on servers :-) This should be left to seeds.

+-Requires=multi-user.target
++Requires=multi-user.target display-manager.service
+ After=multi-user.target
+ Conflicts=rescue.target
+ Wants=display-manager.service

This now seems redundant (Wants+Requires). I think I'm okay with this,
as having a graphical target without any DM seems a bit of a corner
case. I suppose this is necessary as otherwise OnFailure= wouldn't be
called for graphical.target if display-manager.service fails?

I wonder if we could make use of the new .d/ support in 218 for this.
I. e. could the xdiagnose package just ship a /lib/systemd/system
/display-manager.service.d/xdiagnose.conf which adds the Requires= and
OnFailure=? Then we wouldn't need to teach systemd about this at all,
and xdiagnose would be self-contained.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1400682

Title:
  Add xdiagnose fallback when display-manager fails to start

Status in systemd package in Ubuntu:
  Invalid

Bug description:
  Attached patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1400682/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1400682] Re: Add xdiagnose fallback when display-manager fails to start

2014-12-15 Thread Martin Pitt
Done in https://launchpad.net/ubuntu/+source/xdiagnose/3.7.1

Thanks Didier!

** Package changed: systemd (Ubuntu) = xdiagnose (Ubuntu)

** Changed in: xdiagnose (Ubuntu)
   Status: Invalid = New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1400682

Title:
  Add xdiagnose fallback when display-manager fails to start

Status in xdiagnose package in Ubuntu:
  New

Bug description:
  Attached patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xdiagnose/+bug/1400682/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 1400682] Re: Add xdiagnose fallback when display-manager fails to start

2014-12-09 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1400682

Title:
  Add xdiagnose fallback when display-manager fails to start

Status in systemd package in Ubuntu:
  New

Bug description:
  Attached patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1400682/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp