[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
This bug was fixed in the package systemd - 229-4ubuntu21.17 --- systemd (229-4ubuntu21.17) xenial; urgency=medium [ Victor Tapia ] * d/p/stop-mount-error-propagation.patch: keep mount errors local to the failing mount point instead of blocking the processing of all mounts (LP: #1755863) [ Eric Desrochers ] * d/p/fix-egde-case-when-processing-proc-self-mountinfo.patch: Mounting any file system to a mount point in a directory that is bind mounted to itself will create an inactive mount unit. (LP: #1795764) -- Dan Streetman Thu, 28 Feb 2019 17:50:50 -0500 ** Changed in: systemd (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Released Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ...
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Changed in: systemd (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ...
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
for autopkgtest regression failure justifications, see bug 1755863 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ...
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
oops, @slashd already verified :) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ... test_dhcp6
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
root@systemd-x:/tmp# dpkg -l | grep libsystemd0 ii libsystemd0:amd64229-4ubuntu21.16 amd64systemd utility library root@systemd-x:/tmp# mkdir -p bind-test/abc root@systemd-x:/tmp# mount --bind bind-test bind-test root@systemd-x:/tmp# mount -t tmpfs tmpfs bind-test/abc root@systemd-x:/tmp# umount bind-test/abc root@systemd-x:/tmp# systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loadedinactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loadedactive mounted /tmp/bind-test root@systemd-x:/tmp# dpkg -l |grep libsystemd0 ii libsystemd0:amd64229-4ubuntu21.17 amd64systemd utility library root@systemd-x:/tmp# mkdir -p bind-test/abc root@systemd-x:/tmp# mount --bind bind-test bind-test root@systemd-x:/tmp# mount -t tmpfs tmpfs bind-test/abc root@systemd-x:/tmp# umount bind-test/abc root@systemd-x:/tmp# systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loadedactive mounted /tmp/bind-test -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
[VERIFICATION XENIAL] Using the protocol mentioned in the [Test Case] with systemd from xenial-proposed, version : 229-4ubuntu21.17. I can no longer reproduce the situation. # systemctl list-units --all | grep bind-test mnt-bind\x2dtest.mount loadedactive mounted /mnt/bind-test - Eric ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
Hello Joshua, or anyone else affected, Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu21.17 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: systemd (Ubuntu Xenial) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error:
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Changed in: systemd (Ubuntu Xenial) Assignee: Dimitri John Ledkov (xnox) => Eric Desrochers (slashd) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: In Progress Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Changed in: systemd (Ubuntu Xenial) Assignee: Eric Desrochers (slashd) => Dimitri John Ledkov (xnox) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: In Progress Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
A security fix has superseded the current SRU. The SRU will need to be restarted from scratch. debian/changelog -- systemd (229-4ubuntu21.15) xenial-security; urgency=medium * SECURITY UPDATE: memory corruption in journald via attacker controlled alloca - debian/patches/CVE-2018-16864.patch: journald: do not store the iovec entry for process commandline on the stack - CVE-2018-16864 * SECURITY UPDATE: memory corruption in journald via attacker controlled alloca - debian/patches/CVE-2018-16865_1.patch: journald: set a limit on the number of fields (1k) - debian/patches/CVE-2018-16865_2.patch: journal-remote: set a limit on the number of fields in a message - CVE-2018-16865 * SECURITY UPDATE: out-of-bounds read in journald - debian/patches/CVE-2018-16866.patch: journal: fix syslog_parse_identifier() - CVE-2018-16866 * SECURITY UPDATE: symlink mishandling in systemd-tmpfiles - debian/patches/CVE-2018-6954.patch: don't resolve pathnames when traversing recursively through directory trees - debian/patches/CVE-2018-6954_2.patch: backport the remaining patches to resolve this completely - CVE-2018-6954 * Fix LP: #1804603 - btrfs-util: unbreak tmpfiles' subvol creation - add debian/patches/btrfs-util-unbreak-tmpfiles-subvol-creation.patch - update debian/patches/series * Fix LP: #1804864 - test: Set executable bits on TEST-22-TMPFILES shell scripts - add debian/patches/test-Set-executable-bits-on-TEST-22-TMPFILES-shell-script.patch - update debian/patches/series -- Chris Coulson Thu, 10 Jan 2019 00:15:47 + -- ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-16864 ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-16865 ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-16866 ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-6954 ** Changed in: systemd (Ubuntu Xenial) Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: In Progress Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error:
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
Hi Joshua, Have you been able to test the systemd proposed package using your k8s setup reproducer ? I'll be curious to hear about the outcome before I request the release of this package to its final destination: xenial-updates and mark the end of this particular SRU. Regards, Eric -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU + + + Note: I don't know the level of adoption of Netplan in Xenial, but I suspect it is low as Netplan replaced ifupdown as the default configuration utility starting with Ubuntu 17.10 Artful only AFAIK. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ... test_dhcp6 (__main__.TestNetworkManager) ... ok test_bridge_priority (__main__.TestNetworkManager) ... ok test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... ok I *think* that these test may eventually works, but is it really worth it to retry them until success if it works fine outside the Ubuntu infra w/ the same proposed packages ? (See attachment:
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
I tested the systemd 229-4ubuntu21.11 package from xenial-proposed in Ubuntu 16.04 in KVM and also confirm I cannot reproduce the issue with this updated package: # lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 16.04.5 LTS Release:16.04 Codename: xenial # dpkg -l | grep 229-4ubuntu21.11 ii libpam-systemd:amd64 229-4ubuntu21.11 amd64system and service manager - PAM module ii libsystemd0:amd64229-4ubuntu21.11 amd64systemd utility library ii systemd 229-4ubuntu21.11 amd64system and service manager # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test root-bind\x2dtest.mount loadedactive mounted /root/bind-test +1, LGTM -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
[VERIFICATION XENIAL] I confirm that this specific bug is now fix with that proposed package. # Confirmation of the use of proposed systemd packages: ii libpam-systemd:amd64229-4ubuntu21.11 amd64system and service manager - PAM module ii libsystemd0:amd64 229-4ubuntu21.11 amd64systemd utility library ii libudev1:amd64 229-4ubuntu21.11 amd64libudev shared library ii systemd 229-4ubuntu21.11 amd64system and service manager ii systemd-sysv229-4ubuntu21.11 amd64system and service manager - SysV links ii udev229-4ubuntu21.11 amd64/dev/ and hotplug management daemon # Confirmation that I ran the test on xenial root@ubuntu:/tmp# cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.5 LTS" # Reproducer as describe in upstream bug and above in the SRU tmpl: root@ubuntu:/tmp# mkdir -p bind-test/abc root@ubuntu:/tmp# mount --bind bind-test bind-test root@ubuntu:/tmp# mount -t tmpfs tmpfs bind-test/abc root@ubuntu:/tmp# umount bind-test/abc root@ubuntu:/tmp# systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loadedactive mounted /tmp/bind-test I also did some dogfooding here and there, BUT, since systemd is a pretty critical piece, I would appreciate more feedback from other impacted users before I can proceed with the release in xenial-updates. Meaning I won't change this bug to "verification-done-xenial" until then. I'll return from vacation on the week of January 7th (mid-week) which will give us a reasonable amount of time for impacted users and other volunteers to test this new proposed package. - Eric -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU - Unless security team has some autopkgtests reports elsewhere, the only - data available I have (to compare) is if the autopkgtests were - "failling" or "passing" when 21.5 has been pushed. Since then quite a - few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ... test_dhcp6 (__main__.TestNetworkManager) ... ok test_bridge_priority (__main__.TestNetworkManager) ... ok test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... ok I *think* that these test may eventually works, but is it really worth it to retry them until success if it works fine outside the
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
Regression in autopkgtest for nplan (amd64): test log It's failling in the Ubuntu infra but passing when ran manually in my own HW, here's the full output in attachment: autopkgtest_result.txt - Eric ** Attachment added: "autopkgtest_result.txt" https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+attachment/5223032/+files/autopkgtest_result.txt -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well- known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
Regression in autopkgtest for nplan (amd64): test log It's failling in the Ubuntu infra but passing when ran manually in my own HW, here's the full output in attachment: autopkgtest_result.txt - Eric ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Unless security team has some autopkgtests reports elsewhere, the only data available I have (to compare) is if the autopkgtests were "failling" or "passing" when 21.5 has been pushed. Since then quite a few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: The test are "passing" if ran manually in my own HW : autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/adt-proposed.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img . Setting up systemd (229-4ubuntu21.11) ... Setting up nplan (0.32~16.04.6) ... Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ... test_dhcp6 (__main__.TestNetworkManager) ... ok test_bridge_priority (__main__.TestNetworkManager) ... ok
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Unless security team has some autopkgtests reports elsewhere, the only data available I have (to compare) is if the autopkgtests were "failling" or "passing" when 21.5 has been pushed. Since then quite a few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for nplan (amd64): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz Error: (Ran on autopkgtest Ubuntu infra) test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL Justification: + The test are "passing" if ran manually in my own HW : + + autopkgtest [15:29:15]: host ; command line: /usr/bin/autopkgtest nplan -U --apt-pocket=proposed --log-file /tmp/proposed2.out --- qemu /var/lib/libvirt/images/autopkgtest-xenial-amd64.img + . + Setting up systemd (229-4ubuntu21.11) ... + Setting up nplan (0.32~16.04.6) ... + Setting up network-manager (1.2.6-0ubuntu0.16.04.3) ... + + test_dhcp6 (__main__.TestNetworkManager) ... ok + test_bridge_priority (__main__.TestNetworkManager) ... ok + test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... ok + + * Regression in autopkgtest for nplan (armhf): test log
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Unless security team has some autopkgtests reports elsewhere, the only data available I have (to compare) is if the autopkgtests were "failling" or "passing" when 21.5 has been pushed. Since then quite a few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. + * Regression in autopkgtest for nplan (amd64): test log + https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/n/nplan/20181217_010129_e07e2@/log.gz + + Error: (Ran on autopkgtest Ubuntu infra) + test_bond_mode_balance_rr_pps (__main__.TestNetworkManager) ... Error: Could not create NMClient object: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL + + test_bridge_priority (__main__.TestNetworkManager) ... Error: Could not + create NMClient object: Cannot invoke method; proxy is for a well-known + name without an owner and proxy was constructed with the + G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL + + test_dhcp6 (__main__.TestNetworkManager) ... Error: Could not create + NMClient object: Cannot invoke method; proxy is for a well-known name + without an owner and proxy was constructed with the + G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag.FAIL + + Justification: + + * Regression in autopkgtest for nplan (armhf): test log + https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/armhf/n/nplan/20181217_132248_e07e2@/log.gz + + Error: + Traceback (most recent call last): + File "/home/ubuntu/autopkgtest/lib/VirtSubproc.py", line 717, in mainloop + command() + File "/home/ubuntu/autopkgtest/lib/VirtSubproc.py", line 646, in command + r = f(c, ce) + File "/home/ubuntu/autopkgtest/lib/VirtSubproc.py", line 342, in cmd_reboot + caller.hook_wait_reboot() + File "/home/ubuntu/autopkgtest/virt/autopkgtest-virt-lxd", line 230, in hook_wait_reboot + wait_booted() + File
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] Note: No autopkgtests has been reported since systemd (21.5) ... between 21.5 and now (21.11) everything released has been about security fixes : systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU systemd (229-4ubuntu21.10) xenial-security; urgency=medium systemd (229-4ubuntu21.9) xenial-security; urgency=medium systemd (229-4ubuntu21.8) xenial-security; urgency=medium systemd (229-4ubuntu21.6) xenial-security; urgency=medium systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU Unless security team has some autopkgtests reports elsewhere, the only data available I have (to compare) is if the autopkgtests were "failling" or "passing" when 21.5 has been pushed. Since then quite a few release has been uploaded with no autopkgtests report. * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz Error: FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. - * + * Regression in autopkgtest for snapd (i386): test log + https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/s/snapd/20181213_212830_ea0ac@/log.gz + + Error: + 2018-12-13 21:28:16 Failed tasks: 1 + - autopkgtest:ubuntu-16.04-i386:tests/main/dirs-not-shared-with-host:alternatives + error: unsuccessful run + + Justification: + This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. + * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] + Note: No ADT test has been reported since 21.5 ... between 21.5 and now + (21.11) everything released has been about security fixes : + + systemd (229-4ubuntu21.11) xenial; urgency=medium ==> Current SRU + systemd (229-4ubuntu21.10) xenial-security; urgency=medium + systemd (229-4ubuntu21.9) xenial-security; urgency=medium + systemd (229-4ubuntu21.8) xenial-security; urgency=medium + systemd (229-4ubuntu21.6) xenial-security; urgency=medium + systemd (229-4ubuntu21.5) xenial; urgency=medium ==> Previous SRU + + * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz Error: modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. I don't think having wifi module is relevant in s390x anyway, so most likely the module is not there on purpose for kernel w/ s390x architecture. * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz Error: FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' Justification: This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. - * Regression in autopkgtest for umockdev (i386): test log - * * * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. + I don't think having wifi module is relevant in s390x anyway, so most + likely the module is not there on purpose for s390x architecture. + * Regression in autopkgtest for systemd (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz FileNotFoundError: [Errno 2] No such file or directory: '/boot/grub/grub.cfg' This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. * Regression in autopkgtest for umockdev (i386): test log * * * * [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all |
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Pending SRU] * Regression in autopkgtest for nplan (s390x): test log https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic This above seems to be a recurrent failure since a couple of release already. This wasn't introduce by this particular SRU. + * Regression in autopkgtest for systemd (s390x): test log + https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/s/systemd/20181213_162040_4f06f@/log.gz + + FileNotFoundError: [Errno 2] No such file or directory: + '/boot/grub/grub.cfg' + + This above seems to be a recurrent failure since a couple of release + already. This wasn't introduce by this particular SRU. * Regression in autopkgtest for umockdev (i386): test log - * * * * - [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. + [Pending SRU] + + * Regression in autopkgtest for nplan (s390x): test log + https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nplan/20181023_132448_031b9@/log.gz + + modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic + modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/4.4.0-138-generic + ERROR + ERROR + + This above seems to be a recurrent failure since a couple of release + already. This wasn't introduce by this particular SRU. + [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
Hello Joshua, or anyone else affected, Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu21.11 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: systemd (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Fix Committed Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions -- Mailing list:
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] - # cd /root + # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test - root-bind\x2dtest-abc.mount loaded inactive dead /root/bind-test/abc - root-bind\x2dtest.mount loaded active mounted /root/bind-test + tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc + tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : - # cd /root + # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test - root-bind\x2dtest.mount loaded active mounted /root/bind-test + tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when processing /proc/self/mountinfo [03b8cfede] core: make sure to init mount params before calling mount_is_extrinsic() This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. Additionally, the patch got the blessing of 'xnox' who looked at it and mention it looks fine to him. [Other Info] One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic [Original Description] From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: In Progress Bug description: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest-abc.mount loaded inactive dead /tmp/bind-test/abc tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test Expected outcome (w/ the fix) : # cd /tmp # mkdir -p bind-test/abc # mount --bind bind-test bind-test # mount -t tmpfs tmpfs bind-test/abc # umount bind-test/abc # systemctl list-units --all | grep bind-test tmp-bind\x2dtest.mount loaded active mounted /tmp/bind-test [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. It is an adaptation of commits : [65d36b495] core: Fix edge case when
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: + [Impact] + + kubernetes loaded inactive dead transient mount points grows + https://github.com/kubernetes/kubernetes/issues/57345 + + [Test Case] + + # cd /tmp + # mkdir -p bind-test/abc + # mount --bind bind-test bind-test + # mount -t tmpfs tmpfs bind-test/abc + # umount bind-test/abc + # systemctl list-units --all | grep bind-test + root-bind\x2dtest-abc.mount loaded inactive dead /root/bind-test/abc + root-bind\x2dtest.mount loaded active mounted /root/bind-test + + [Regression Potential] + + This is a adapted version of 2 upstream fixes as the original upstream + commit has been made on top on 2 functions mount_setup_new_unit() & + mount_setup_existing_unit() that not yet exist systemd 229. It is easily + adaptable because the current function mount_setup_unit() is dealing + with both of at the moment instead of being individually separate in two + distinct function. + + It is an adaptation of commits : + 65d36b495 + 03b8cfede + + This patch changes mount_setup_unit() to prevent the just_mounted mount + setup flag from being overwritten if it is set to true. This will allow + all mount units created from /proc/self/mountinfo entries to be + initialised properly. + + + [Other Info] + + One line fix in https://github.com/systemd/systemd/pull/7811/files + + Referenced issue: https://github.com/systemd/systemd/issues/7798 + + Related kubernetes issue: + https://github.com/kubernetes/kubernetes/issues/57345 + + systemd v237 has this fix, but we'd like to have it fixed in 16.04. + + + It only affect systemd for Xenial, later release already has the fix: + + $ git describe --contains 65d36b495 + v237~140 + + ==> systemd | 229-4ubuntu21.4 | xenial-updates + systemd | 237-3ubuntu10.3 | bionic-updates + systemd | 239-7ubuntu9 | cosmic + + [Original Description] + From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 - - systemd v237 has this fix, but we'd like to have it fixed in 16.04. - - [Other Informations] - - It only affect systemd for Xenial, later release already has the fix: - - $ git describe --contains 65d36b495 - v237~140 - - ==> systemd | 229-4ubuntu21.4 | xenial-updates - systemd | 237-3ubuntu10.3 | bionic-updates - systemd | 239-7ubuntu9 | cosmic ** Description changed: [Impact] kubernetes loaded inactive dead transient mount points grows https://github.com/kubernetes/kubernetes/issues/57345 [Test Case] # cd /tmp - # mkdir -p bind-test/abc - # mount --bind bind-test bind-test - # mount -t tmpfs tmpfs bind-test/abc - # umount bind-test/abc - # systemctl list-units --all | grep bind-test - root-bind\x2dtest-abc.mount loaded inactive dead /root/bind-test/abc + # mkdir -p bind-test/abc + # mount --bind bind-test bind-test + # mount -t tmpfs tmpfs bind-test/abc + # umount bind-test/abc + # systemctl list-units --all | grep bind-test + root-bind\x2dtest-abc.mount loaded inactive dead /root/bind-test/abc root-bind\x2dtest.mount loaded active mounted /root/bind-test + + Expected outcome (w/ the fix) : + + # cd /tmp + # mkdir -p bind-test/abc + # mount --bind bind-test bind-test + # mount -t tmpfs tmpfs bind-test/abc + # umount bind-test/abc + # systemctl list-units --all | grep bind-test + root-bind\x2dtest.mount loaded active mounted /root/bind-test + [Regression Potential] This is a adapted version of 2 upstream fixes as the original upstream commit has been made on top on 2 functions mount_setup_new_unit() & mount_setup_existing_unit() that not yet exist systemd 229. It is easily adaptable because the current function mount_setup_unit() is dealing with both of at the moment instead of being individually separate in two distinct function. - It is an adaptation of commits : + It is an adaptation of commits : 65d36b495 03b8cfede This patch changes mount_setup_unit() to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialised properly. + [Other Info] - [Other Info] - One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
debdiff for xenial [systemd-lp1795764-xenial.debdiff] ** Patch added: "systemd-lp1795764-xenial.debdiff" https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+attachment/5221471/+files/systemd-lp1795764-xenial.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Confirmed Bug description: From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. [Other Informations] It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
** Description changed: From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. [Other Informations] It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 - ==> systemd | 229-4ubuntu21.4 | xenial-updates - systemd | 237-3ubuntu10.3 | bionic-updates - systemd | 239-7ubuntu9 | cosmic + ==> systemd | 229-4ubuntu21.4 | xenial-updates + systemd | 237-3ubuntu10.3 | bionic-updates + systemd | 239-7ubuntu9 | cosmic -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Confirmed Bug description: From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. [Other Informations] It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
I think the "|| true;" is a good test to validate but I might have to find something more viable to SRU. I'll see how upstream populate MOUNT(u)->just_mounted, and try to mimic that as well instead of forcing "true" implicitly. This is where I'm at the moment. Stay tuned. - Eric -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu. https://bugs.launchpad.net/bugs/1795764 Title: systemd: core: Fix edge case when processing /proc/self/mountinfo Status in systemd package in Ubuntu: Fix Released Status in systemd source package in Xenial: Confirmed Bug description: From the PR: Currently, if there are two /proc/self/mountinfo entries with the same mount point path, the mount setup flags computed for the second of these two entries will overwrite the mount setup flags computed for the first of these two entries. This is the root cause of issue #7798. This patch changes mount_setup_existing_unit to prevent the just_mounted mount setup flag from being overwritten if it is set to true. This will allow all mount units created from /proc/self/mountinfo entries to be initialized properly. One line fix in https://github.com/systemd/systemd/pull/7811/files Referenced issue: https://github.com/systemd/systemd/issues/7798 Related kubernetes issue: https://github.com/kubernetes/kubernetes/issues/57345 systemd v237 has this fix, but we'd like to have it fixed in 16.04. [Other Informations] It only affect systemd for Xenial, later release already has the fix: $ git describe --contains 65d36b495 v237~140 ==> systemd | 229-4ubuntu21.4 | xenial-updates systemd | 237-3ubuntu10.3 | bionic-updates systemd | 239-7ubuntu9 | cosmic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1795764] Re: systemd: core: Fix edge case when processing /proc/self/mountinfo
We cannot cherrypick the fix as is. It has been introduced upstream[1]
inside a function and structure that not yet exist in 229[1].
Instead of backporting the whole thing (which seems unnecessary) we can
possibly mimic the upstream fix.
Basically, the upstream fix adds a "|| MOUNT(u)->just_mounted;" where
just_mounted is a boolean. A boolean only has two possible values
("true" and "false").
Definition of "just_mounted" :
# src/core/mount.h
bool just_mounted:1;
Full upstream code line :
flags->just_mounted = !MOUNT(u)->from_proc_self_mountinfo ||
MOUNT(u)->just_mounted;
The current 229 (xenial code) is as follow :
MOUNT(u)->just_mounted = !MOUNT(u)->from_proc_self_mountinfo;
Considering the boolean explain above, If we add "|| true;" it should
suffice.
Full systemd xenial code line (theory):
MOUNT(u)->just_mounted = !MOUNT(u)->from_proc_self_mountinfo || true ;
A colleague of mine and myself have separately tested my theory in my PPA that
I have built, and so far it seems to work fine :
$ mount --bind bind-test bind-test
$ mount -t tmpfs tmpfs bind-test/abc
$ umount bind-test/abc
$ systemctl list-unites --all | grep bind-test
home-ubuntu-bind/x2dtest.mount loaded active mounted /home/ubuntu/bind-test
Could you please give the test package a try to make sure you arrive at the
same result as us ?
$ sudo add-apt-repository ppa:slashd/case199975
$ sudo apt-get update
$ sudo apt-get install systemd
Please allow a few hours for the package to build again.
Eric
[1] git describe --contains 65d36b495
v237~140
** Tags added: sts
** Also affects: systemd (Ubuntu Xenial)
Importance: Undecided
Status: New
** Changed in: systemd (Ubuntu Xenial)
Status: New => Confirmed
** Description changed:
From the PR:
Currently, if there are two /proc/self/mountinfo entries with the same
mount point path, the mount setup flags computed for the second of
these two entries will overwrite the mount setup flags computed for
the first of these two entries. This is the root cause of issue #7798.
This patch changes mount_setup_existing_unit to prevent the
just_mounted mount setup flag from being overwritten if it is set to
true. This will allow all mount units created from /proc/self/mountinfo
entries to be initialized properly.
One line fix in https://github.com/systemd/systemd/pull/7811/files
Referenced issue: https://github.com/systemd/systemd/issues/7798
Related kubernetes issue:
https://github.com/kubernetes/kubernetes/issues/57345
systemd v237 has this fix, but we'd like to have it fixed in 16.04.
+
+ [Other Informations]
+
+ It only affect systemd for Xenial, later release already has the fix:
+
+ $ git describe --contains 65d36b495
+ v237~140
+
+ ==> systemd | 229-4ubuntu21.4 | xenial-updates
+ systemd | 237-3ubuntu10.3 | bionic-updates
+ systemd | 239-7ubuntu9 | cosmic
** Changed in: systemd (Ubuntu)
Status: Confirmed => Fix Released
** Changed in: systemd (Ubuntu Xenial)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1795764
Title:
systemd: core: Fix edge case when processing /proc/self/mountinfo
Status in systemd package in Ubuntu:
Fix Released
Status in systemd source package in Xenial:
Confirmed
Bug description:
From the PR:
Currently, if there are two /proc/self/mountinfo entries with the same
mount point path, the mount setup flags computed for the second of
these two entries will overwrite the mount setup flags computed for
the first of these two entries. This is the root cause of issue #7798.
This patch changes mount_setup_existing_unit to prevent the
just_mounted mount setup flag from being overwritten if it is set to
true. This will allow all mount units created from /proc/self/mountinfo
entries to be initialized properly.
One line fix in https://github.com/systemd/systemd/pull/7811/files
Referenced issue: https://github.com/systemd/systemd/issues/7798
Related kubernetes issue:
https://github.com/kubernetes/kubernetes/issues/57345
systemd v237 has this fix, but we'd like to have it fixed in 16.04.
[Other Informations]
It only affect systemd for Xenial, later release already has the fix:
$ git describe --contains 65d36b495
v237~140
==> systemd | 229-4ubuntu21.4 | xenial-updates
systemd | 237-3ubuntu10.3 | bionic-updates
systemd | 239-7ubuntu9 | cosmic
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1795764/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
