[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
This bug was fixed in the package nss - 2:3.55-1ubuntu3 --- nss (2:3.55-1ubuntu3) groovy; urgency=medium * Fix FTBFS due to erroneous glibc out-of-bounds checking with gcc 10 (LP: #1897666) - debian/patches/fix-ftbfs-glibc-invalid-oob-error.patch: Disable non-null error checking on call to getcwd since this results in an erroneous warning that causes the build to fail otherwise -- Alex Murray Tue, 29 Sep 2020 10:39:29 +0930 ** Changed in: nss (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: Fix Released Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
** Changed in: nss (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: Fix Committed Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
** Changed in: nss (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: Fix Committed Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
See attached for a debdiff (note this uses ubuntu3 instead of ubuntu2 since I already burned that version in the security-proposed PPA whilst preparing this) ** Patch added: "nss_3.55-1ubuntu3.debdiff" https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+attachment/5415115/+files/nss_3.55-1ubuntu3.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: New Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
This has also been uploaded to the security-proposed PPA - https://launchpad.net/~ubuntu-security- proposed/+archive/ubuntu/ppa/+sourcepub/11635176/+listing-archive-extra -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: New Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1897666] Re: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation
The attachment "nss_3.55-1ubuntu3.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to nss in Ubuntu. https://bugs.launchpad.net/bugs/1897666 Title: FTBFS: nss for groovy ftbfs due to erroneous nonnull check arising from glibc getcwd() annotation Status in nss package in Ubuntu: New Bug description: As per the archive test rebuild done recently by doko, nss FTBFS due to a compiler warning raised by gcc-10 (and this fails the build due to the use of -Werror in CFLAGS): https://launchpad.net/ubuntu/+archive/test- rebuild-20200925-groovy/+build/20033437 nsinstall.c: In function ‘main’: nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:239:8: note: in expansion of macro ‘GETCWD’ 239 | cwd = GETCWD(0, PATH_MAX); |^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ nsinstall.c:70:16: error: argument 1 is null but the corresponding size argument 2 value is 4096 [-Werror=nonnull] 70 | #define GETCWD getcwd |^ nsinstall.c:246:13: note: in expansion of macro ‘GETCWD’ 246 | todir = GETCWD(0, PATH_MAX); | ^~ In file included from nsinstall.c:20: /usr/include/unistd.h:520:14: note: in a call to function ‘getcwd’ declared with attribute ‘write_only (1, 2)’ 520 | extern char *getcwd (char *__buf, size_t __size) __THROW __wur | ^~ cc1: all warnings being treated as errors According to the upstream bug report at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96832 this would appear to be because of the annotation of getcwd() with the access attribute. However, there seems to be some debate about the best way to resolve this (whether in glibc or in the callers of getcwd, ie nss) for now I propose to just disable this check via the use of gcc's #pragma directive. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nss/+bug/1897666/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
