[Touch-packages] [Bug 2004011] Re: Checks are not skipped when building esm packages package from source
Thanks for reporting this bug and trying to make it better. When we are talking about the Debian Policy we need to keep in mind that it is versioned. You linked a section of the Debian Policy version 4.6.2.0, so packages complaint with that version should do what is written there (to make sure which version of Debian Policy a package is complaint you need to check the Standards-Version field in debian/control). Moreover, the very first sentence of the section is: "Supporting the standardized environment variable DEB_BUILD_OPTIONS is recommended." So those options are recommended, they are not mandatory. It is not an issue if you find a package that does not support those options. src:heimdal in xenial (16.04) is compliant with Debian Policy 3.9.6, in this version we already have the nocheck option added (actually in version 3.8.1): https://www.debian.org/doc/debian-policy/upgrading- checklist.html#version-3-8-1 But again, this is recommended, not mandatory. Due to that, we will not update a package in ESM just to introduce support to nocheck. ** Changed in: heimdal (Ubuntu) Status: New => Invalid ** Changed in: heimdal (Ubuntu) Status: Invalid => Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to heimdal in Ubuntu. https://bugs.launchpad.net/bugs/2004011 Title: Checks are not skipped when building esm packages package from source Status in heimdal package in Ubuntu: Won't Fix Bug description: **Describe the bug** Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it possible to cherry-pick this commit to the ESM packages? To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2004011/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 2004011] Re: Checks are not skipped when building esm packages package from source
** Description changed: **Describe the bug** Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it - possible to cherry-pick this commit to the packages ESM? + possible to cherry-pick this commit to the ESM packages? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to heimdal in Ubuntu. https://bugs.launchpad.net/bugs/2004011 Title: Checks are not skipped when building esm packages package from source Status in heimdal package in Ubuntu: New Bug description: **Describe the bug** Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it possible to cherry-pick this commit to the ESM packages? To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2004011/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 2004011] Re: Checks are not skipped when building esm packages package from source
** Description changed: **Describe the bug** Under the policy, building deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options - However, this is what `override_dh_auto_test` target in `debian/rules` looks like in your case: + However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: - $(MAKE) check + $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. + Apparently, this has been patched: + https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 - **Expected behavior** - `override_dh_auto_test` target in `debian/rules` should normally look like this: - ``` - override_dh_auto_test: - ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) - ./run-upstream-testsuite - endif - ``` - This way checks are not run when `DEB_BUILD_OPTIONS="nocheck"` is provided. + However, the patch did not make its way to ESM packages for 16.04. Is it + possible to cherry-pick this commit to the packages? ** Description changed: **Describe the bug** - Under the policy, building deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: + Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it possible to cherry-pick this commit to the packages? ** Description changed: **Describe the bug** Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it - possible to cherry-pick this commit to the packages? + possible to cherry-pick this commit to the packages ESM? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to heimdal in Ubuntu. https://bugs.launchpad.net/bugs/2004011 Title: Checks are not skipped when building esm packages package from source Status in heimdal package in Ubuntu: New Bug description: **Describe the bug** Under the policy, building a deb package from source should not run checks when provided with env var `DEB_BUILD_OPTIONS="nocheck"`: https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options However, this is what `override_dh_auto_test` target in `debian/rules` looks like in `heimdal=1.7~git20150920+dfsg-4ubuntu1.16.04.1+esm3`: ``` override_dh_auto_test: $(MAKE) check ``` So checks are still run when `nocheck` in `DEB_BUILD_OPTIONS` is provided. Apparently, this has been patched: https://salsa.debian.org/debian/heimdal/-/commit/b1a7b04591873e7d0e88acaf24cc76073ee47fc9 However, the patch did not make its way to ESM packages for 16.04. Is it possible to cherry-pick this commit to the packages ESM? To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2004011/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
