Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On Thu, Nov 24, 2016 at 11:01:05PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote: > > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > > > The device driver code for the event log has the init functions and > > > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). > > > > > > Since the initialization functions are common with the TPM 2.0 event > > > log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > > > event log parsing logic and moves the init functions into > > > tpm_eventlog_init.c. > > > > I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > > _init thing.. > > I would rather see tpm1-eventlog.c and tpm2-eventlog.c as we already > have tpm2-cmd.c for the sake of consistency. +1 Jason -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote: > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > > The device driver code for the event log has the init functions and > > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). > > > > Since the initialization functions are common with the TPM 2.0 event > > log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > > event log parsing logic and moves the init functions into > > tpm_eventlog_init.c. > > I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > _init thing.. > > Jason I would rather see tpm1-eventlog.c and tpm2-eventlog.c as we already have tpm2-cmd.c for the sake of consistency. /Jarkko -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On 11/24/2016 10:13 PM, Jason Gunthorpe wrote: > On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote: > Since the initialization functions are common with the TPM 2.0 event log support, this patch splits tpm_eventlog.c to have only TPM 1.2 event log parsing logic and moves the init functions into tpm_eventlog_init.c. >>> >>> I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this >>> _init thing.. >> >> Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 >> event log specific parsing ? >> >> And if so, then which one should have the common functions for TPM 1.2 and >> TPM 2.0? > > Leave them in tpm_eventlog.c .. Sure. I am fine with that. I just feel that it bit of mixed up the scope of tpm_eventlog.c file, where it now also refers to TPM2, but have corresponding seq functions in separate file. Thanks & Regards, - Nayna > > Jason > -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote: > >>Since the initialization functions are common with the TPM 2.0 event > >>log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > >>event log parsing logic and moves the init functions into > >>tpm_eventlog_init.c. > > > >I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > >_init thing.. > > Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 > event log specific parsing ? > > And if so, then which one should have the common functions for TPM 1.2 and > TPM 2.0? Leave them in tpm_eventlog.c .. Jason -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On 11/24/2016 01:08 AM, Jason Gunthorpe wrote: > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: >> The device driver code for the event log has the init functions and >> TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). >> >> Since the initialization functions are common with the TPM 2.0 event >> log support, this patch splits tpm_eventlog.c to have only TPM 1.2 >> event log parsing logic and moves the init functions into >> tpm_eventlog_init.c. > > I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > _init thing.. Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 event log specific parsing ? And if so, then which one should have the common functions for TPM 1.2 and TPM 2.0 ? Thanks & Regards, - Nayna > > Jason > -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > The device driver code for the event log has the init functions and > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). > > Since the initialization functions are common with the TPM 2.0 event > log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > event log parsing logic and moves the init functions into > tpm_eventlog_init.c. I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this _init thing.. Jason -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
