Re: [Trac] Re: Ticket Reminder e-mails
I've started to put this into production on our Trac 1.4.2 server, FWIW. On Friday, March 18, 2022 at 10:52:59 AM UTC-5 Dan wrote: > I ended up testing TicketReminderPlugin with Trac 1.5.4 and made some > adjustments for that as well. My standard test installation is 1.4.2. I"m > using Ubuntu LTS under WSL. > > While I've been using Python 3 since before it came out, I really only use > it for test scripts (and now updating Trac plugins). So, some of my mods > might be improved. Let me know if you have any comments. > > Thanks again. > > - Dan > > > On Tuesday, March 15, 2022 at 2:26:55 PM UTC-5 Dan wrote: > >> On Tuesday, March 15, 2022 at 11:23:46 AM UTC-5 RjOllos wrote: >> >>> On GitHub, the workflow is to fork the repository, put your changes on a >>> branch, and then create a pull request against the source repository. >>> >> >> Thanks. I did it. >> >> - Dan >> >> -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/c5bd9d86-7c31-4215-9cdb-6e1e77b802b1n%40googlegroups.com.
Re: [Trac] Re: Ticket Reminder e-mails
I ended up testing TicketReminderPlugin with Trac 1.5.4 and made some adjustments for that as well. My standard test installation is 1.4.2. I"m using Ubuntu LTS under WSL. While I've been using Python 3 since before it came out, I really only use it for test scripts (and now updating Trac plugins). So, some of my mods might be improved. Let me know if you have any comments. Thanks again. - Dan On Tuesday, March 15, 2022 at 2:26:55 PM UTC-5 Dan wrote: > On Tuesday, March 15, 2022 at 11:23:46 AM UTC-5 RjOllos wrote: > >> On GitHub, the workflow is to fork the repository, put your changes on a >> branch, and then create a pull request against the source repository. >> > > Thanks. I did it. > > - Dan > > -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/3291c068-503f-4b0b-8d35-1e647495211cn%40googlegroups.com.
Re: [Trac] Re: Ticket Reminder e-mails
On Tuesday, March 15, 2022 at 11:23:46 AM UTC-5 RjOllos wrote: > On GitHub, the workflow is to fork the repository, put your changes on a > branch, and then create a pull request against the source repository. > Thanks. I did it. - Dan -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/99b0f70f-be1b-46bf-82fe-1975c05302d7n%40googlegroups.com.
Re: [Trac] Re: Ticket Reminder e-mails
On Tuesday, March 15, 2022 at 7:37:07 AM UTC-7 Dan wrote: > At this point I'm wondering how to contribute my modifications to > TicketReminderPlugin. For other plugins I've worked on, I just posted > patches on trac-hacks via tickets there; however, this plugin is mostly > managed on GitHub. It looks like there are a few forks as well, which I > did not investigate at first. I suppose I could post the patches or new > source code on GitHub somehow. Although I'm somewhat familiar with GitHub, > I have never really used it much. > On GitHub, the workflow is to fork the repository, put your changes on a branch, and then create a pull request against the source repository. -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/9be771e7-8e71-4114-956e-f4bdee615a0dn%40googlegroups.com.
Re: [Trac] Re: Ticket Reminder e-mails
On Monday, March 14, 2022 at 6:12:05 PM UTC-5 Jun Omae wrote: > https://trac-hacks.org/wiki/TracHtmlNotificationPlugin Thanks, Jun. But the plugin I'm actually working on is the TicketReminderPlugin https://trac-hacks.org/wiki/TicketReminderPlugin I did take some code from TracHtmlNotificationPlugin and grafted it into the reminder plugin so it could send HTML reminder e-mails, though. The source code and issues for TicketReminderPlugin are on GitHub https://github.com/trac-hacks/trac-ticketreminder/issues At this point I'm wondering how to contribute my modifications to TicketReminderPlugin. For other plugins I've worked on, I just posted patches on trac-hacks via tickets there; however, this plugin is mostly managed on GitHub. It looks like there are a few forks as well, which I did not investigate at first. I suppose I could post the patches or new source code on GitHub somehow. Although I'm somewhat familiar with GitHub, I have never really used it much. Thanks again. - Dan -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/579703ea-23fc-41ad-8060-0f3c702339aan%40googlegroups.com.
Re: [Trac] Re: Ticket Reminder e-mails
On Tue, Mar 15, 2022 at 4:43 AM Dan wrote: > It seems like the author has basically left this plugin unchanged for about > four years (the source is on gitHub), so I'm assuming he wouldn't be > interested in looking over the changes. The latest of plugin source is on trac-hacks.org: https://trac-hacks.org/wiki/TracHtmlNotificationPlugin https://trac-hacks.org/svn/trachtmlnotificationplugin https://trac-hacks.org/browser/trachtmlnotificationplugin Also, I made the repository on github.com private. -- Jun Omae (大前 潤) -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/CAEVLMag0BxUg3yN78A7myZYLD%3DDni2U2M19ai7UNAW5rPBFH-g%40mail.gmail.com.
[Trac] Re: Ticket Reminder e-mails
FWIW, I ended up just pasting in the related code from Trac and TracHtmlNotificationPlugin. Works OK as far as I can tell after limited testing, but I should clean up the code a bit. It seems like the author has basically left this plugin unchanged for about four years (the source is on gitHub), so I'm assuming he wouldn't be interested in looking over the changes. In the past, I have worked with Ryan on plugin mods, though via tickets. (Thanks very much, by the way, for all the help over the years.) I'm not sure how/where would be the best way to get the updated plugin into the Trac ecosytem. I'm kind of looking forward to (and also dreading) the port to Python 3 for all the plugins I've been using lol. Thanks! - Dan On Friday, March 11, 2022 at 10:44:31 AM UTC-6 Dan wrote: > I've been looking for a way to give reminders for tickets, and I think > TicketReminder plugin does basically what I need. I am currently using > Trac 1.4.2. However, that plugin is mostly out of date. (If there is > another one that is more maintained, please let me know.) > > I ended up getting the plugin mostly updated (substituting outdated APIs, > porting to Jinja2, and incorporating notification preferences), but I am > currently having it send e-mails via a TicketChangeEvent sent to > NotificationSystem. However, I can't figure out a way to modify the > subject line to add "Ticket Reminder" or something like that. > > Is the proper way to deal with this problem to subclass TicketChangeEvent > and TicketFormatter? I haven't tried it yet, but seems like that might > work. Unfortunately TicketFormatter has the "realm" hard-coded to > 'ticket', so it seems I can't really re-use some of the functions that I'd > like to; I'd have to re-implement them. > > I'd appreciate any words of wisdom. > > - Dan > > -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/2dd27a33-6059-4591-b075-798d205d45c7n%40googlegroups.com.
