[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added

[Berker Peksag]

Berker Peksag  added the comment:

This has already been deployed. Closing as 'resolved'.

--
status: chatting -> resolved

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/

[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added

[Maciej Szulik]

Maciej Szulik added the comment:

> So after http://psf.upfronthosting.co.za/roundup/meta/msg3305 and 
> http://psf.upfronthosting.co.za/roundup/meta/msg3306 I explicitly said "I'll 
> commit it when I get a code review, thanks!" in my earlier comment, and you 
> still did the same thing.

Berker I know, I'm terribly sorry. When I was going through those patches I was 
in a hurry going through tons of emails after my PTO :( I've noticed your 
message about committing this the moment I've pushed changes to the server :(

> I think I should spend my free time elsewhere.

Please, your help here is invaluable :)

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/

[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added

[Berker Peksag]

Berker Peksag added the comment:

Here's the second patch.

___
PSF Meta Tracker 

___diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -195,17 +195,23 @@ class Event(object):
 # create a new link
 if not title:
 title = ""
 if not status:
 status = ""
 newpr = self.db.pull_request.create(number=prid,
 title=title.encode('utf-8'), status=status.encode('utf-8'))
 prs.append(newpr)
-self.db.issue.set(id, pull_requests=prs)
+patch_keyword = self.db.keyword.lookup('patch')
+keywords = self.db.issue.get(id, 'keywords')
+if patch_keyword not in keywords:
+keywords.append(patch_keyword)
+self.db.issue.set(id, pull_requests=prs,
+  stage=self.db.stage.lookup('patch review'),
+  keywords=keywords)
 self.db.commit()
 
 def handle_update(self, prid, title, status, issue_ids):
 """
 Helper method for updating GitHub pull request.
 """
 # update handles only title changes, for now
 if not title:
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/

[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added

[Nick Coghlan]

Nick Coghlan added the comment:

Adding a note about http://psf.upfronthosting.co.za/roundup/meta/issue636: the 
"patch" keyword currently isn't being set for issues that *only* have a linked 
PR, which is throwing off both the "Open issues with patches" metrics, and the 
sidebar query for "Issues with patches". The latter isn't too much of a problem 
(since folks can just browse the open PR list directly on GitHub instead), but 
the former makes the graph at https://bugs.python.org/issue?@template=stats 
rather misleading.

Berker suggested fixing that as part of this update rather than as a standalone 
change, which seems like a good idea to me.

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/

[Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added

[Ezio Melotti]

Ezio Melotti added the comment:

I think the patch is fine, but if we are going to update the stage when a PR is 
added through the webhooks, perhaps we should do it also when it's added 
manually.

--
status: chatting -> unread

___
PSF Meta Tracker 

___
___
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/