Re: [Twisted-Python] Re-run Azure tests

2020-10-12 Thread Wilfredo Sánchez Vega 
On Oct 12, 2020, at 12:29 PM, Craig Rodrigues  wrote:
> 
> No, the re-run feature in Azure is not broken.  I've managed to do it several 
> times successfully.

  Hrm.  I’ve tried pushing that button many times and nothing happens.  So, 
while it’s great that it works for you, if it doesn’t work for other core 
developers, I think it’s fair to call it broken.

-wsv

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

2020-10-12 Thread Craig Rodrigues 
On Mon, Oct 12, 2020 at 11:36 AM Wilfredo Sánchez Vega <
wsanc...@wsanchez.net> wrote:

>
>   Craig: this does have to work around non-black output from incremental:
> https://github.com/twisted/klein/blob/master/release.py#L86
>
>
I don't need this klein workaround at the moment.  I can confirm that my
patches to incremental produce output
that is black-compatible, when I run my patched version of incremental in
the Twisted tree.
 I am going to move forward with merging my changes to incremental and
pushing out a new
incremental release.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Re-run Azure tests

2020-10-12 Thread Craig Rodrigues 
On Mon, Oct 12, 2020 at 11:12 AM Adi Roiban  wrote:

>
>> It looks like the re-run feature is broken.
>
>

No, the re-run feature in Azure is not broken.  I've managed to do it
several times successfully.
There might be some issue with your account access, but I don't know enough
about Azure
to know what your account problem might be.

In terms of moving all Azure jobs to GitHub Actions, that is certainly
something we can investigate in future,
but I don't think there is a rush to do that right away.

I have managed to successfully move all CircleCI jobs and Travis jobs to
GitHub Actions, and so far it is working
and holding up.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

2020-10-12 Thread Wilfredo Sánchez Vega 
On Sep 28, 2020, at 11:35 AM, Kyle Altendorf  wrote:
> 
> I guess this one is top-posting...  Anyways, I would personally default away 
> from CI-provider-specific solutions.  It seems like a command line tool ought 
> to suffice? 

  Certainly, it should first be possible to ship a release from the command 
line.  Then a CI solution is a mere convenience.

  I started doing this for Klein: 
https://github.com/twisted/klein/blob/master/release.py 


  (Not claiming this is the way to do it, just FYI.)

  Craig: this does have to work around non-black output from incremental: 
https://github.com/twisted/klein/blob/master/release.py#L86

-wsv

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Re-run Azure tests

2020-10-12 Thread Adi Roiban 
On Mon, 12 Oct 2020 at 11:30, Adi Roiban  wrote:

> Hi,
>
> There was a discussion over IRC about re-running failed Azure tests.
>
> I was confused, as if I go to the Azure build page, I don't see any re-run
> job option.
>
> Maarten told me that the re-run link is on the GitHub page, and not on
> Azure.
>
> See the screenshot below.
>
> I hope this helps :)
>
> Cheers
>
>
It looks like the re-run feature is broken.

I guess that we need to move all the tests that require re-run to GitHub
Actions.

Tests that don't require a re-run (documentation build or linters) can be
kept or moved to Azure to continue having many parallel builds.

-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Request for new Twisted release?

2020-10-12 Thread Craig Rodrigues 
On Sunday, October 4, 2020, Craig Rodrigues  wrote:

> On Sat, Oct 3, 2020 at 5:14 PM Glyph  wrote:
>
>>
>>
>>
>> Absolutely OK with me.  More than OK.  Please do this!  I can't wait
>> until we have the level of automation you've been working on for
>> *anybody* to cut the release.  I take it this means you'll officially be
>> the release manager for 20.10.0?
>>
>> Let me know if you need any more permission bits to make progress.
>>
>
>
> If it is OK with Amber and you, then yes, I can officially be the release
> manager for the next Twisted release,
> which will be 20.10.0.
>
> I need help with the following:
>
> *Incremental*
> I'd like to get these patches into Incremental and deploy a new
> Incremental release:
>
>- https://github.com/twisted/incremental/pull/60 , Make the output of
>Incremental compatible with black
>- https://github.com/twisted/incremental/pull/62 , Make dev, rc, post
>releases compatible with PEP440
>
>
> *PyPI*
>
> I used this GitHub Action to push to PyPI:
>
>   uses: pypa/gh-action-pypi-publish@v1.4.1
>   with:
> user: __token__
> password: ${{ secrets.pypi_password }}
> verbose: true
>
> I can confirm that this GitHub Action works, and it tries to push to PyPI:
>
> https://github.com/twisted/twisted/runs/1204812301?check_suite_focus=true
>
> It failed because the token does not exist.
>
> *What I need*
>
>1. a GitHub Secret named pypi_password , which contains a token which
>will allow me to upload to PyPI
>2. a GitHub Secret named test_pypi_password, which contains a token
>which will allow me to upload to test.pypi.org
>
>
> Thanks.
>




Glyph/Amber,

Can you help with this?

1.  Need to merge changes to github.com/twisted/incremental and push out a
new version.
2.  Need to generate a token at https://pypi.org/project/Twisted to permit
uploads
3.  Need to store token from 2. as a GitHub Secret named pypi_password in
github.com/twisted/twisted

I don’t have permissions to do these things.

—
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Re-run Azure tests

2020-10-12 Thread Adi Roiban 
Hi,

There was a discussion over IRC about re-running failed Azure tests.

I was confused, as if I go to the Azure build page, I don't see any re-run
job option.

Maarten told me that the re-run link is on the GitHub page, and not on
Azure.

See the screenshot below.

I hope this helps :)

Cheers

[image: image.png]


-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python