Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement
On Thu, Feb 25, 2021 at 7:03 PM Craig Rodrigues wrote: > > > On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff > wrote: > >> As it happens, it also fails (for an import of typing.Deque) on Python >> 3.5.3, as used by Debian oldstable. >> >> Craig, what is your intention here? I think it's ok to drop support for >> these ancient versions of Python 3.5, but please could you make sure that >> python_requires gets set to 3.5.10 if that's what's been tested against? >> > > Sigh. I can confirm that typing.Deque does not import on Python 3.5.2. > > I took an inventory of our CI, and realized that the minimum version we > are testing is *3.5.4* on Azure. > > Can you review this which bumps the minimum version to Python 3.5.4: > https://github.com/twisted/twisted/pull/1525 > > Once I get that in, I will cherry pick it to the release branch and push > out the 21.2.0 release. > Richard, As you can see by this review comment: https://github.com/twisted/twisted/pull/1525#issuecomment-786965737 Thomas Grainger and Adi Roiban have worked together to bump up the minimum Python version to 3.5.3 for this release ( https://github.com/twisted/twisted/pull/1524 ), and are not approving the PR that I have submitted in PR 1525. Even though you approved PR 1525, I cannot merge it because only PR reviews by people with write access to the Twisted repo can be merged to the Twisted repo. I am going to proceed with the release as-is with Python 3.5.3 as the minimum version. I hope that is OK for your needs. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
Thanks for the clarification. You have provided a lot of useful details. There are a lot of interconnected pieces, with multiple people working on different things. For now, I am going to proceed to finish the release as-is. The documentation may not be automatically deployed as part of the release, but I think that can be done as a follow-on task. -- Craig On Sat, Feb 27, 2021 at 4:53 PM Adi Roiban wrote: > Hi, > > Sorry for the delay. > > We did the automation and Read The Docs hosting. > > In parallel there was also the work required to host the pydoctor API docs > on Read The Docs. > > -- > > Note that https://docs.twistedmatrix.com/en/twisted-20.3.0/api 404 > > That should host the files from > https://twistedmatrix.com/documents/current/api/ > > - > > For `trunk` we have https://docs.twistedmatrix.com/en/latest/api/ > > That was the hard work done by Maarten to improve pydoctor and Twisted API > docs. > > - > > There was a plan to do a new pydoctor release over the end of the year > break... but that never happened. > > The current PR that is "breaking" API links from narrative docs to API > docs on Read The Docs version of Twisted docs is > https://github.com/twisted/twisted/pull/1496 > > But even before that PR the API docs on Read the Docs were broken, as we > had too many HTML pages and the build process on RTD > was interrupted. > > This is why I have approved the PR in the first place. > > So https://github.com/twisted/twisted/pull/1466 should also be reverted > > > > So, if for this release the "official" Twisted documentation is to be > hosted at https://twistedmatrix.com/documents/current/api/ > then https://twistedmatrix.com/trac/ticket/10068 is not a blocker. > > If the plan is to host the full and "official" Twisted documentation on > Read The Docs, the https://twistedmatrix.com/trac/ticket/10068 is a > blocker. > > And the easiest solution is to do a new pydoctor release. > > -- > > I will try to follow up with Maarten over IRC to see if we can get a new > pydoctor release. > > In theory, the pydoctor release process is automated and any other Twisted > developer from https://github.com/orgs/twisted/teams/twisted-contributors > could do a release. > > Maarten did the release work in the recent past but if he is busy, in > theory anyone could step in and help with a new pydoctor release. > > Regards > > On Sat, 20 Feb 2021 at 17:47, Craig Rodrigues > wrote: > >> Hi, >> >> I am confused. I thought that you and Thomas Graingert had completed all >> the automation and had changed the Twisted release scripts to host the >> documentation on readthedocs and that was all in place right now. >> >> Is that not the case? >> >> How much more work is necessary to completely host the next Twisted >> release's docs on readthedocs? >> >> -- >> Craig >> >> On Saturday, February 20, 2021, Adi Roiban wrote: >> >>> Hi, >>> >>> Sorry for the delay. >>> >>> This was added as a blocker due to the changes from >>> https://github.com/twisted/twisted/pull/1496 and the plan to use Read >>> The Docs to >>> host the official docs. >>> >>> This is not a blocker if the official documentation for this release >>> will continue to be hosted on the Twisted own server at >>> https://twistedmatrix.com/documents/current/ >>> >>> It's a blocker only if the official documentation is to be hosted on >>> Read The Docs at docs.twistedmatrix.com >>> >>> I have updated the ticket to no longer block the release. >>> >>> Cheers >>> >>> >>> On Sat, 20 Feb 2021 at 02:08, Craig Rodrigues >>> wrote: >>> Adi, Is there anything to be done here, or is this still a release blocker? -- Craig On Sun, Feb 14, 2021 at 4:15 PM Craig Rodrigues wrote: > Hi, > > This ticket: Use latest pydoctor release, > https://twistedmatrix.com/trac/ticket/10068 > > is marked as a release blocker. > > Has that been resolved or is there more work that needs to be done to > fix that? > > -- > Craig > >>> >>> -- >>> Adi Roiban >>> >> > > -- > Adi Roiban > ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Weekly Bug Summary
Bug summary __ Summary for 2021-02-21 through 2021-02-28 Opened Closed Total Change Enhancements: 4 1 1476 +3 Defects: 2 0 1002 +2 Tasks: 1 1 92 +0 Regressions: 1 0 1 +1 Total: 8 2 2573 +6 |== Type Changes |== Priority Changes |== Component Changes |Defect: +2 |Highest: +1 |Conch: +0 |Enhancement: +3 |Normal: +5 |Core: +5 |Release Blocker: Regression: +1 |Low: +0 |Web:+1 |Task: +0 Total Tickets Open Tickets New / Reopened Bugs __ = Highest = [#10096] CI failure on trunk re twisted.web.test.test_http.QueryArgumentsTests.testParseqs (opened by graingert) defect webhttp://twistedmatrix.com/trac/ticket/10096 = Normal = [#10095] CI failure on trunk re twisted.web.test.test_http.QueryArgumentsTests.testParseqs (opened by graingert) enhancement core http://twistedmatrix.com/trac/ticket/10095 [#10098] Bump python_requires to 3.5.3 for typing.Type (opened by graingert) enhancement core http://twistedmatrix.com/trac/ticket/10098 [#10099] Bump up minimum Python to 3.5.4 in setup.cfg (opened by rodrigc) release blocker: regression core http://twistedmatrix.com/trac/ticket/10099 [#10100] (skip) CI failure on trunk re twisted.web.test.test_http.QueryArgumentsTests.testParseqs (opened by graingert) enhancement core http://twistedmatrix.com/trac/ticket/10100 [#10101] TwistedDevelopment instructions are broken (opened by twm) defect core http://twistedmatrix.com/trac/ticket/10101 [#10102] Add towncrier tox env to help with the release (opened by adiroiban) enhancement core http://twistedmatrix.com/trac/ticket/10102 = Low = [#10097] CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead (opened by clokep) (CLOSED, fixed) taskconch http://twistedmatrix.com/trac/ticket/10097 Closed Bugs __ = Normal = [#9457 ] Twisted should declare its build-dependency on incremental in its pyproject.toml (opened by njsmith, closed by twm, duplicate) enhancement core http://twistedmatrix.com/trac/ticket/9457 = Low = [#10097] CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead (opened by clokep, closed by Tom Most , fixed) taskconch http://twistedmatrix.com/trac/ticket/10097 Ticket Lifetime Stats __ Oldest open ticket - [#50] conch command-line client doesn't work in win32 (since 2003-07-12 14:41:06). Newest open ticket - [#10102] Add towncrier tox env to help with the release (since 2021-02-27 18:05:01.954318). Mean open ticket age: 3018 days, 7:57:40.604308. Median: 2970 days, 8:27:26.981842. Standard deviation: 1501 days, 17:44:04.496844. Interquartile range: 2198 days, 17:52:45.710560. Mean time between ticket creation and ticket resolution: 617 days, 7:42:21.905608. Median: 58 days, 6:54:30. Standard deviation is 1024 days, 2:20:35.785072. The interquartile range is 812 days, 18:13:14.833986. Mean time spent in review: 101 days, 23:21:59.485327. Median: 4 days, 18:32:05. Standard deviation: 487 days, 18:37:23.148821. Interquartile range: 23 days, 20:01:40. Mean number of times a ticket is reviewed: 1.78560250391. Median: 1 Standard deviation: 1.40830413824. Interquartile range: 1. Contributor Stats __ In the last 4 weeks, 11 unique ticket reporters 5 unique ticket reviewers 6 unique ticket resolvers In the last 24 weeks, 36 unique ticket reporters 9 unique ticket reviewers 10 unique ticket resolvers In the last 48 weeks, 58 unique ticket reporters 12 unique ticket reviewers 26 unique ticket resolvers ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release instructions: `tox -e towncrier` does not work?
On Saturday, February 27, 2021, Adi Roiban wrote: > Hi, > > Sorry for the late reply. > > Here is a patch waiting for review https://github.com/twisted/ > twisted/pull/1527 > > Thanks. I have approved that. That patch won't make it into the 21.2.0 release, but it is not a release blocker since for now I can run towncrier manually. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement
On Monday, February 15, 2021, Kyle Altendorf wrote: > > > I went ahead and set pip_pre=true in pytest-twisted's tox.ini to try it > out and got warnings/errors with PyPy 3.7 about use of t.i.d.returnValue > claiming it should only be used in @inlineCallbacks decorated functions > even though the location complained about is such. Only PyPy 3.7, not PyPy > 3.6 nor CPython 3.7. Linux, macOS, and Windows all failed. > > > Ticketed as https://twistedmatrix.com/trac/ticket/10093. > > > Thanks for providing the fix for this: https://github.com/twisted/twisted/pull/1516 This fix will make it into the 21.2.0 release. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release instructions: `tox -e towncrier` does not work?
Hi, Sorry for the late reply. Here is a patch waiting for review https://github.com/twisted/twisted/pull/1527 Cheers On Mon, 15 Feb 2021 at 01:19, Craig Rodrigues wrote: > In > https://github.com/twisted/twisted/commit/0ad24679b168370bf0d695825170a7532bf0698f#diff-4fd162cb9fc2878b140dcc9d9d364f9f60d404a76ebda2c10518810ffe63852dL115 > > Adi Roiban changed one of the steps the release documentation to run a > command: > > *tox -e towncrier* > > but that tox target does not exist. > > Does Adi or someone else have that tox target in a patch lying > around somewhere? > > For now I can manually run *towncrier *manually outside of tox. > > -- > Craig > ___ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
