Re: [Twisted-Python] Post Release updates
On Sun, Feb 28, 2021 at 12:43 PM Adi Roiban wrote: > > And we have not yet decided if the trunk should be using `.dev` or .post` > :( > > According to the Twisted release process, one of the last things I need to do is bump the Twisted version: https://github.com/twisted/twisted/blob/trunk/docs/core/development/policy/release-process.rst#post-release I did not do that yet, for the very reason which you brought up. I think the instructions for bumping to `dev` are not correct, as per my interpretation of PEP440. I asked Glyph for clarification here: https://github.com/twisted/twisted/pull/1514#issuecomment-787533582 If you or anyone else has good knowledge on PEP440, and what the correct thing to do here is, feel free to add feedback in that PR! -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Twisted 21.2.0 Release Announcement
On Sun, Feb 28, 2021 at 1:55 PM Adi Roiban wrote: > > > > Hi, > > Thanks Craig for managing this release. > You are welcome Adi! I am happy to contribute my efforts to the Twisted community and to push the project along. In 2015-2016, unfortunately I lost my job. While in between jobs, I contributed a lot to the effort to port Twisted to Python 3. It was a very enjoyable experience, and I learned a lot of Python at the time. :) I joined the Python 2 porting party late, and there were others who invested a lot of time and effort into it. Amber did a heck of a lot of work before me on Python 3 porting, and did a lot of work after I contributed. I don't remember who else contributed, but there were a lot of folks including you, Jean- , Glyph, and others. The earliest Python 3 ticket I can find in the Trac is this one from 14 years ago filed by Itamar!! https://twistedmatrix.com/trac/ticket/2484 Honestly, at the time, when I was working on Python 3 porting in 2016, I wasn't even sure that Twisted would survive as a project beyond Python 2. So it is nice to see that Python 2.7 is history, and the Twisted codebase is incorporating new language features, types, etc. and is keeping up with newer Python versions. Hurray! -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
On Sun, Feb 28, 2021 at 1:50 PM Maarten ter Huurne wrote: > On Sunday, 28 February 2021 22:02:48 CET Craig Rodrigues wrote: > > That sounds like a good plan. Thanks for working on this. > > > > Keep in mind the points regarding docs raised by Glyph here: > > > > > > https://twistedmatrix.com/pipermail/twisted-python/2021-February/06543 > > 2.html > > Those are good points, but I meant API docs specifically and I don't > think there should be any overlap between the wiki and the API docs. If > I'm mistaken, please let me know. > > I think the direction that Glyph was mentioning is that if there are docs in the source tree, and duplicated docs on the wiki, we want to favor the docs in the source tree. Any duplicated docs on the wiki should either be deleted, or changed to put pointers to the docs in the source tree. With respect to API docs, I am not as familiar with the whole process, with how they are generated and what are doing with readthedocs vs. docs on twistedmatrix.com. API docs are generated and don't live in the source tree. For example: https://twistedmatrix.com/documents/current/api/twisted.html Is the long term direction to get rid of that, and point everything at readthedocs? Since you have done a lot of work in this area, can you shed some light on what you think the future direction of all this stuff should be with respect to the API docs? Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Twisted 21.2.0 Release Announcement
On Sun, 28 Feb 2021 at 10:28, Craig Rodrigues wrote: > On behalf of Twisted Matrix Laboratories, I am honored to announce the > release of Twisted 21.2.0! > > There are two major announcements for this release: > > - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python > 3.5.3 and higher only > - *This will be the last Twisted release to support Python 3.5*. > > Twisted 21.2.0 brings the following: > - twist dns --pyzone now works on Python 3 > - twisted.web.twcgi now works on Python 3 > - all tests pass on all platforms on Python 3.8, including asyncio tests > on Windows > - tests pass on Python 3.9 (thanks to Michał Górny) > - type hints, as specified in PEP 484, are now used in functions > throughout the codebase > - mypy (static type checker) is now run over the codebase during CI to > help detect problems, and help improve the use of types > - code in is now formatted with Black (thanks to Tom Most) > - many CI and automation improvements (thanks to Adi Roiban and Thomas > Grainger) > - many more fixes (225 tickets closed!) > > > You can install by running this command: > > python -m pip install Twisted==21.2.0 > > The full tarball is available at: > https://pypi.org/project/Twisted/21.2.0/#files > > The full NEWS file with all changes is at: > https://github.com/twisted/twisted/blob/twisted-21.2.0/NEWS.rst > > Hi, Thanks Craig for managing this release. Happy to finally see a brand new release. Sad to see Py2.7 go... but this is life... all good things have an end :p Looking forward to also removing Py3.5 :) Cheers -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
On Sunday, 28 February 2021 22:02:48 CET Craig Rodrigues wrote: > That sounds like a good plan. Thanks for working on this. > > Keep in mind the points regarding docs raised by Glyph here: > > > https://twistedmatrix.com/pipermail/twisted-python/2021-February/06543 > 2.html Those are good points, but I meant API docs specifically and I don't think there should be any overlap between the wiki and the API docs. If I'm mistaken, please let me know. Bye, Maarten > -- > Craig > > > On Sunday, February 28, 2021, Maarten ter Huurne > > wrote: > > However, I think that it would be preferable to get new docs out as > > soon as possible, rather than waiting for even better docs. Once > > those improvements are integrated, we could do another pydoctor > > release and update Twisted's API docs without there being a new > > Twisted release. > > > > Does this sound like a plan? ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
Hi, https://twistedmatrix.com/documents/current/ is now updated. It will continue to be the "official" documentation link for this release. We can add a redirection after getting RTD version up to the same features... maybe for the next release. Regards On Sun, 28 Feb 2021 at 21:16, Adi Roiban wrote: > Another thing that is missing from Read The Docs to get feature parity > with current documentation. > > If I go to https://docs.twistedmatrix.com/en/twisted-18.4.0/ I don't get > any warning that I am not on the latest stable version. > > RTD has something similar... but not quite what we need > [image: image.png] > But I hope that we can find a way to fix it... but first we need to fix > the "stable" version in RTD > > > Cheers > > On Sun, 28 Feb 2021 at 20:42, Adi Roiban wrote: > >> Hi, >> >> Happy to see a new version of Twisted released. >> Thanks to anyone for making it happen. >> >> - >> >> I think that https://github.com/twisted/twisted/pull/1514 should be >> merged to finalize the release process. >> >> -- >> >> And we have not yet decided if the trunk should be using `.dev` or .post` >> :( >> >> https://twistedmatrix.com/trac/ticket/9542 >> >> I am +1 for .post1 ... as it has the semantic of a post release version. >> while .dev0 is a pre-release. >> >> -- >> >> The https://twistedmatrix.com/documents/current/ documentation was not >> updated. >> But that can be solved after the release. >> I will see if I can update it tonight... and I will check over IRC to see >> if someone else has fixed it. >> First, I am looking at the Read the docs release issues... it looks like >> things are not as automated as we though :D >> >> - >> >> I have no idea why the latest tag is not visible on Read the docs >> https://readthedocs.org/projects/twisted/versions/ >> >> I have manually activated it based on the f1da tag. >> I went to >> https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 >> and then clicked "Activate" >> >> Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and >> select it as "Default" version >> and then click "Save" >> >> Then I went to https://readthedocs.org/projects/twisted/builds/ to check >> the status of the new build. >> >> I see that we now have - >> https://docs.twistedmatrix.com/en/twisted-21.2.0/ >> >> But https://docs.twistedmatrix.com/en/stable/ is still an older build :( >> >> I have no idea why... looks like stable is not active and what is >> origin/8690 >> >> [image: image.png] >> >> Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look >> like a semantic version . >> >> -- >> >> Stable was building for >> >> https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e >> >> See RTD stable build >> https://readthedocs.org/projects/twisted/builds/13125823/ >> >> So I have wiped the stable version and now it gets 404. >> >> I (or someone else from the team) will have check with Read The Docs team >> to see why we have this issue with the stable version. >> >> -- >> >> And there are a lot of versions as we have many branches on Twisted. >> >> I guess that at least the branches that were merged, could be removed >> from the main repo. >> I don't see the value for keeping them alive, >> >> That is all for now. >> -- >> Adi Roiban >> > > > -- > Adi Roiban > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement
On 28/02/2021 07:38, Craig Rodrigues wrote: Thomas Grainger and Adi Roiban have worked together to bump up the minimum Python version to 3.5.3 for this release ( https://github.com/twisted/twisted/pull/1524 ), and are not approving the PR that I have submitted in PR 1525. Even though you approved PR 1525, I cannot merge it because only PR reviews by people with write access to the Twisted repo can be merged to the Twisted repo. I am going to proceed with the release as-is with Python 3.5.3 as the minimum version. I hope that is OK for your needs. It looks to me like https://github.com/twisted/twisted/pull/1524 sets the minimum python version to 3.5.4, so I think we're good and #1525 should just be closed as a duplicate. Thanks for getting the release out! ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
Another thing that is missing from Read The Docs to get feature parity with current documentation. If I go to https://docs.twistedmatrix.com/en/twisted-18.4.0/ I don't get any warning that I am not on the latest stable version. RTD has something similar... but not quite what we need [image: image.png] But I hope that we can find a way to fix it... but first we need to fix the "stable" version in RTD Cheers On Sun, 28 Feb 2021 at 20:42, Adi Roiban wrote: > Hi, > > Happy to see a new version of Twisted released. > Thanks to anyone for making it happen. > > - > > I think that https://github.com/twisted/twisted/pull/1514 should be > merged to finalize the release process. > > -- > > And we have not yet decided if the trunk should be using `.dev` or .post` > :( > > https://twistedmatrix.com/trac/ticket/9542 > > I am +1 for .post1 ... as it has the semantic of a post release version. > while .dev0 is a pre-release. > > -- > > The https://twistedmatrix.com/documents/current/ documentation was not > updated. > But that can be solved after the release. > I will see if I can update it tonight... and I will check over IRC to see > if someone else has fixed it. > First, I am looking at the Read the docs release issues... it looks like > things are not as automated as we though :D > > - > > I have no idea why the latest tag is not visible on Read the docs > https://readthedocs.org/projects/twisted/versions/ > > I have manually activated it based on the f1da tag. > I went to > https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 > and then clicked "Activate" > > Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and > select it as "Default" version > and then click "Save" > > Then I went to https://readthedocs.org/projects/twisted/builds/ to check > the status of the new build. > > I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ > > But https://docs.twistedmatrix.com/en/stable/ is still an older build :( > > I have no idea why... looks like stable is not active and what is > origin/8690 > > [image: image.png] > > Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look > like a semantic version . > > -- > > Stable was building for > > https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e > > See RTD stable build > https://readthedocs.org/projects/twisted/builds/13125823/ > > So I have wiped the stable version and now it gets 404. > > I (or someone else from the team) will have check with Read The Docs team > to see why we have this issue with the stable version. > > -- > > And there are a lot of versions as we have many branches on Twisted. > > I guess that at least the branches that were merged, could be removed from > the main repo. > I don't see the value for keeping them alive, > > That is all for now. > -- > Adi Roiban > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
That sounds like a good plan. Thanks for working on this. Keep in mind the points regarding docs raised by Glyph here: https://twistedmatrix.com/pipermail/twisted-python/2021-February/065432.html -- Craig On Sunday, February 28, 2021, Maarten ter Huurne wrote: > > > However, I think that it would be preferable to get new docs out as soon > as possible, rather than waiting for even better docs. Once those > improvements are integrated, we could do another pydoctor release and > update Twisted's API docs without there being a new Twisted release. > > Does this sound like a plan? ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
On Sunday, 28 February 2021 19:26:16 CET I wrote: > I'll try to get a pydoctor release out today from the current master > branch. While the release publishing is automated, writing the release > notes is not, but that shouldn't take too long. pydoctor 21.2.0 is now available on PyPI: https://pypi.org/project/pydoctor Bye, Maarten ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Post Release updates
Hi, Happy to see a new version of Twisted released. Thanks to anyone for making it happen. - I think that https://github.com/twisted/twisted/pull/1514 should be merged to finalize the release process. -- And we have not yet decided if the trunk should be using `.dev` or .post` :( https://twistedmatrix.com/trac/ticket/9542 I am +1 for .post1 ... as it has the semantic of a post release version. while .dev0 is a pre-release. -- The https://twistedmatrix.com/documents/current/ documentation was not updated. But that can be solved after the release. I will see if I can update it tonight... and I will check over IRC to see if someone else has fixed it. First, I am looking at the Read the docs release issues... it looks like things are not as automated as we though :D - I have no idea why the latest tag is not visible on Read the docs https://readthedocs.org/projects/twisted/versions/ I have manually activated it based on the f1da tag. I went to https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 and then clicked "Activate" Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and select it as "Default" version and then click "Save" Then I went to https://readthedocs.org/projects/twisted/builds/ to check the status of the new build. I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ But https://docs.twistedmatrix.com/en/stable/ is still an older build :( I have no idea why... looks like stable is not active and what is origin/8690 [image: image.png] Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look like a semantic version . -- Stable was building for https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e See RTD stable build https://readthedocs.org/projects/twisted/builds/13125823/ So I have wiped the stable version and now it gets 404. I (or someone else from the team) will have check with Read The Docs team to see why we have this issue with the stable version. -- And there are a lot of versions as we have many branches on Twisted. I guess that at least the branches that were merged, could be removed from the main repo. I don't see the value for keeping them alive, That is all for now. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?
On Sunday, 28 February 2021 08:20:22 CET Craig Rodrigues wrote: > Thanks for the clarification. > > You have provided a lot of useful details. There are a lot of > interconnected pieces, with > multiple people working on different things. > > For now, I am going to proceed to finish the release as-is. > > The documentation may not be automatically deployed as part of the > release, but I think that can be done as a follow-on task. I'll try to get a pydoctor release out today from the current master branch. While the release publishing is automated, writing the release notes is not, but that shouldn't take too long. There are some improvements in the works that aren't ready to merge yet but would improve Twisted's documentation, both in presentation (better navigation and presentation of types) and in accuracy (better handling of cyclic imports, which are becoming more common with the adoption of type annotations). However, I think that it would be preferable to get new docs out as soon as possible, rather than waiting for even better docs. Once those improvements are integrated, we could do another pydoctor release and update Twisted's API docs without there being a new Twisted release. Does this sound like a plan? Bye, Maarten ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Twisted 21.2.0 Release Announcement
On behalf of Twisted Matrix Laboratories, I am honored to announce the release of Twisted 21.2.0! There are two major announcements for this release: - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python 3.5.3 and higher only - *This will be the last Twisted release to support Python 3.5*. Twisted 21.2.0 brings the following: - twist dns --pyzone now works on Python 3 - twisted.web.twcgi now works on Python 3 - all tests pass on all platforms on Python 3.8, including asyncio tests on Windows - tests pass on Python 3.9 (thanks to Michał Górny) - type hints, as specified in PEP 484, are now used in functions throughout the codebase - mypy (static type checker) is now run over the codebase during CI to help detect problems, and help improve the use of types - code in is now formatted with Black (thanks to Tom Most) - many CI and automation improvements (thanks to Adi Roiban and Thomas Grainger) - many more fixes (225 tickets closed!) You can install by running this command: python -m pip install Twisted==21.2.0 The full tarball is available at: https://pypi.org/project/Twisted/21.2.0/#files The full NEWS file with all changes is at: https://github.com/twisted/twisted/blob/twisted-21.2.0/NEWS.rst ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
