Re: [Twisted-Python] Post Release updates
On Sun, 28 Feb 2021 at 20:42, Adi Roiban wrote: > Hi, > > [snip] > > -- > > The https://twistedmatrix.com/documents/current/ documentation was not > updated. > But that can be solved after the release. > I will see if I can update it tonight... and I will check over IRC to see > if someone else has fixed it. > First, I am looking at the Read the docs release issues... it looks like > things are not as automated as we though :D > > - > > I have no idea why the latest tag is not visible on Read the docs > https://readthedocs.org/projects/twisted/versions/ > > I have manually activated it based on the f1da tag. > I went to > https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 > and then clicked "Activate" > > Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and > select it as "Default" version > and then click "Save" > > Then I went to https://readthedocs.org/projects/twisted/builds/ to check > the status of the new build. > > I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ > > But https://docs.twistedmatrix.com/en/stable/ is still an older build :( > > I have no idea why... looks like stable is not active and what is > origin/8690 > > [image: image.png] > > Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look > like a semantic version . > > -- > > Stable was building for > > https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e > > See RTD stable build > https://readthedocs.org/projects/twisted/builds/13125823/ > > So I have wiped the stable version and now it gets 404. > > I (or someone else from the team) will have check with Read The Docs team > to see why we have this issue with the stable version. > > [snip] FYI I have created this ticket to track the documentation migration progress to Read The Docs. https://twistedmatrix.com/trac/ticket/10117 We are close, but not there yet. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/incremental/pull/37, but that was after > 17.5.0. > > -- > Colin Watson (he/him) [cjwat...@debian.org] > > Colin, You are right. I have released Twisted incremental 21.3.0 which has your fixes for PEP 440 compliant post release support. https://pypi.org/project/incremental/ Thanks for submitting those fixes, and sorry it took so long for it to be released. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
On Mon, Mar 01, 2021 at 08:57:56AM -0800, Craig Rodrigues wrote:
> Unfortunately, I ran into a bug in Twisted incremental:
>
> File "/tmp/pip-req-build-zvf8johl/src/twisted/__init__.py", line 11, in
>
> from twisted._version import __version__ as version
> File "/tmp/pip-req-build-zvf8johl/src/twisted/_version.py", line 10, in
>
> __version__ = Version("Twisted", 21, 2, 0, post=0)
> TypeError: __init__() got an unexpected keyword argument 'post'
>
> I might need some help to get a fix into incremental and push that out
> later today,
> so I can complete PR 1514.
Isn't this just because incremental hasn't had a release since 17.5.0?
I added post= support way back in
https://github.com/twisted/incremental/pull/37, but that was after
17.5.0.
--
Colin Watson (he/him) [cjwat...@debian.org]
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
On Mon, Mar 1, 2021 at 2:38 AM Hynek Schlawack wrote:
>
> FWIW, I think it’s common (aka _I_ do it that way) that .post are indeed
> post-releases like a documentation update that doesn’t warrant a proper
> update. PEP 440 specifies it and RTD has good support for that. E.g.
> https://www.attrs.org/en/17.3.0.post2/
>
> IIRC Twisted doesn’t bump before the release, which makes this whole
> workflow unfeasible? But it’s something to keep in mind when deciding.
>
>
I had some questions about PEP440, so I asked for feedback from Łukasz
Langa who provided it here:
https://github.com/twisted/twisted/pull/1514#issuecomment-788059407
Basically Łukasz's feedback was that doing this:
21.2.0.rc1
21.2.0 (this is the release)
21.2.0.post0
is OK. So in PR 1514, I went with that.
Unfortunately, I ran into a bug in Twisted incremental:
File "/tmp/pip-req-build-zvf8johl/src/twisted/__init__.py", line 11, in
from twisted._version import __version__ as version
File "/tmp/pip-req-build-zvf8johl/src/twisted/_version.py", line 10, in
__version__ = Version("Twisted", 21, 2, 0, post=0)
TypeError: __init__() got an unexpected keyword argument 'post'
I might need some help to get a fix into incremental and push that out
later today,
so I can complete PR 1514.
--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
> On 28. Feb 2021, at 21:42, Adi Roiban wrote: > > And we have not yet decided if the trunk should be using `.dev` or .post` :( > > https://twistedmatrix.com/trac/ticket/9542 > > I am +1 for .post1 ... as it has the semantic of a post release version. > while .dev0 is a pre-release. FWIW, I think it’s common (aka _I_ do it that way) that .post are indeed post-releases like a documentation update that doesn’t warrant a proper update. PEP 440 specifies it and RTD has good support for that. E.g. https://www.attrs.org/en/17.3.0.post2/ IIRC Twisted doesn’t bump before the release, which makes this whole workflow unfeasible? But it’s something to keep in mind when deciding. ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
On Sun, Feb 28, 2021 at 12:43 PM Adi Roiban wrote: > > And we have not yet decided if the trunk should be using `.dev` or .post` > :( > > According to the Twisted release process, one of the last things I need to do is bump the Twisted version: https://github.com/twisted/twisted/blob/trunk/docs/core/development/policy/release-process.rst#post-release I did not do that yet, for the very reason which you brought up. I think the instructions for bumping to `dev` are not correct, as per my interpretation of PEP440. I asked Glyph for clarification here: https://github.com/twisted/twisted/pull/1514#issuecomment-787533582 If you or anyone else has good knowledge on PEP440, and what the correct thing to do here is, feel free to add feedback in that PR! -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
Hi, https://twistedmatrix.com/documents/current/ is now updated. It will continue to be the "official" documentation link for this release. We can add a redirection after getting RTD version up to the same features... maybe for the next release. Regards On Sun, 28 Feb 2021 at 21:16, Adi Roiban wrote: > Another thing that is missing from Read The Docs to get feature parity > with current documentation. > > If I go to https://docs.twistedmatrix.com/en/twisted-18.4.0/ I don't get > any warning that I am not on the latest stable version. > > RTD has something similar... but not quite what we need > [image: image.png] > But I hope that we can find a way to fix it... but first we need to fix > the "stable" version in RTD > > > Cheers > > On Sun, 28 Feb 2021 at 20:42, Adi Roiban wrote: > >> Hi, >> >> Happy to see a new version of Twisted released. >> Thanks to anyone for making it happen. >> >> - >> >> I think that https://github.com/twisted/twisted/pull/1514 should be >> merged to finalize the release process. >> >> -- >> >> And we have not yet decided if the trunk should be using `.dev` or .post` >> :( >> >> https://twistedmatrix.com/trac/ticket/9542 >> >> I am +1 for .post1 ... as it has the semantic of a post release version. >> while .dev0 is a pre-release. >> >> -- >> >> The https://twistedmatrix.com/documents/current/ documentation was not >> updated. >> But that can be solved after the release. >> I will see if I can update it tonight... and I will check over IRC to see >> if someone else has fixed it. >> First, I am looking at the Read the docs release issues... it looks like >> things are not as automated as we though :D >> >> - >> >> I have no idea why the latest tag is not visible on Read the docs >> https://readthedocs.org/projects/twisted/versions/ >> >> I have manually activated it based on the f1da tag. >> I went to >> https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 >> and then clicked "Activate" >> >> Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and >> select it as "Default" version >> and then click "Save" >> >> Then I went to https://readthedocs.org/projects/twisted/builds/ to check >> the status of the new build. >> >> I see that we now have - >> https://docs.twistedmatrix.com/en/twisted-21.2.0/ >> >> But https://docs.twistedmatrix.com/en/stable/ is still an older build :( >> >> I have no idea why... looks like stable is not active and what is >> origin/8690 >> >> [image: image.png] >> >> Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look >> like a semantic version . >> >> -- >> >> Stable was building for >> >> https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e >> >> See RTD stable build >> https://readthedocs.org/projects/twisted/builds/13125823/ >> >> So I have wiped the stable version and now it gets 404. >> >> I (or someone else from the team) will have check with Read The Docs team >> to see why we have this issue with the stable version. >> >> -- >> >> And there are a lot of versions as we have many branches on Twisted. >> >> I guess that at least the branches that were merged, could be removed >> from the main repo. >> I don't see the value for keeping them alive, >> >> That is all for now. >> -- >> Adi Roiban >> > > > -- > Adi Roiban > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Post Release updates
Another thing that is missing from Read The Docs to get feature parity with current documentation. If I go to https://docs.twistedmatrix.com/en/twisted-18.4.0/ I don't get any warning that I am not on the latest stable version. RTD has something similar... but not quite what we need [image: image.png] But I hope that we can find a way to fix it... but first we need to fix the "stable" version in RTD Cheers On Sun, 28 Feb 2021 at 20:42, Adi Roiban wrote: > Hi, > > Happy to see a new version of Twisted released. > Thanks to anyone for making it happen. > > - > > I think that https://github.com/twisted/twisted/pull/1514 should be > merged to finalize the release process. > > -- > > And we have not yet decided if the trunk should be using `.dev` or .post` > :( > > https://twistedmatrix.com/trac/ticket/9542 > > I am +1 for .post1 ... as it has the semantic of a post release version. > while .dev0 is a pre-release. > > -- > > The https://twistedmatrix.com/documents/current/ documentation was not > updated. > But that can be solved after the release. > I will see if I can update it tonight... and I will check over IRC to see > if someone else has fixed it. > First, I am looking at the Read the docs release issues... it looks like > things are not as automated as we though :D > > - > > I have no idea why the latest tag is not visible on Read the docs > https://readthedocs.org/projects/twisted/versions/ > > I have manually activated it based on the f1da tag. > I went to > https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 > and then clicked "Activate" > > Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and > select it as "Default" version > and then click "Save" > > Then I went to https://readthedocs.org/projects/twisted/builds/ to check > the status of the new build. > > I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ > > But https://docs.twistedmatrix.com/en/stable/ is still an older build :( > > I have no idea why... looks like stable is not active and what is > origin/8690 > > [image: image.png] > > Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look > like a semantic version . > > -- > > Stable was building for > > https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e > > See RTD stable build > https://readthedocs.org/projects/twisted/builds/13125823/ > > So I have wiped the stable version and now it gets 404. > > I (or someone else from the team) will have check with Read The Docs team > to see why we have this issue with the stable version. > > -- > > And there are a lot of versions as we have many branches on Twisted. > > I guess that at least the branches that were merged, could be removed from > the main repo. > I don't see the value for keeping them alive, > > That is all for now. > -- > Adi Roiban > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Post Release updates
Hi, Happy to see a new version of Twisted released. Thanks to anyone for making it happen. - I think that https://github.com/twisted/twisted/pull/1514 should be merged to finalize the release process. -- And we have not yet decided if the trunk should be using `.dev` or .post` :( https://twistedmatrix.com/trac/ticket/9542 I am +1 for .post1 ... as it has the semantic of a post release version. while .dev0 is a pre-release. -- The https://twistedmatrix.com/documents/current/ documentation was not updated. But that can be solved after the release. I will see if I can update it tonight... and I will check over IRC to see if someone else has fixed it. First, I am looking at the Read the docs release issues... it looks like things are not as automated as we though :D - I have no idea why the latest tag is not visible on Read the docs https://readthedocs.org/projects/twisted/versions/ I have manually activated it based on the f1da tag. I went to https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-21.2.0 and then clicked "Activate" Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and select it as "Default" version and then click "Save" Then I went to https://readthedocs.org/projects/twisted/builds/ to check the status of the new build. I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ But https://docs.twistedmatrix.com/en/stable/ is still an older build :( I have no idea why... looks like stable is not active and what is origin/8690 [image: image.png] Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look like a semantic version . -- Stable was building for https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa5202373236162daf94e See RTD stable build https://readthedocs.org/projects/twisted/builds/13125823/ So I have wiped the stable version and now it gets 404. I (or someone else from the team) will have check with Read The Docs team to see why we have this issue with the stable version. -- And there are a lot of versions as we have many branches on Twisted. I guess that at least the branches that were merged, could be removed from the main repo. I don't see the value for keeping them alive, That is all for now. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
