Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-30 Thread Adi Roiban 
On 29 September 2014 20:11, Glyph Lefkowitz gl...@twistedmatrix.com wrote:
 On Sep 29, 2014, at 12:31 AM, Wolfgang Rohdewald wolfgang@rohdewald.de
 wrote:

 Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:

 This week I will try to get
 https://github.com/twisted/twistedchecker/pull/71/files merged,


 which requires exactly pep8 1.5.1

 Ubuntu 14.04 installs 1.4.6
 I have the current 1.5.7

 After downgrading to 1.4.6, twistedchecker works correctly.


 The issue is actually logilab-common, not pep8 itself; twistedchecker can
 deal with more recent pep8 versions.

I got this similar error when I was using pep8 1.5.1 ... after upgrade
to 1.5.6 all was fine.

Please check latest setup.py from master... and the install line from
travis.yml

Cheers!
-- 
Adi Roiban

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Glyph 

On Sep 28, 2014, at 11:16 PM, Wolfgang Rohdewald wolfgang@rohdewald.de 
wrote:

 Am Sonntag, 28. September 2014, 17:15:37 schrieb Glyph:
 How did you install twistedchecker?
 
 installing is not even needed:
 
 git clone https://github.com/twisted/twistedchecker
 cd twistedchecker
 ~/src/Twisted/bin/trial twistedchecker
 
 trial being the latest from twisted svn trunk, I get the same error
 
 pylint --version
 No config file found, using default configuration
 pylint 0.26.0, 
 astng 0.24.3, common 0.61.0
 Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
 [GCC 4.8.2]

Hmm.

It seems as though twistedchecker does not itself have continuous integration 
set up, so I don't have any test results to look at.  It seems to be working on 
our buildbots (for now, at least) but I'm not sure why.

This week I will try to get 
https://github.com/twisted/twistedchecker/pull/71/files merged, among other 
things.

-glyph

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Wolfgang Rohdewald 
Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:
 This week I will try to get 
 https://github.com/twisted/twistedchecker/pull/71/files merged,

which requires exactly pep8 1.5.1

Ubuntu 14.04 installs 1.4.6
I have the current 1.5.7

After downgrading to 1.4.6, twistedchecker works correctly.


-- 
Wolfgang

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-29 Thread Glyph Lefkowitz 
On Sep 29, 2014, at 12:31 AM, Wolfgang Rohdewald wolfgang@rohdewald.de 
wrote:

 Am Montag, 29. September 2014, 00:07:33 schrieb Glyph:
 This week I will try to get 
 https://github.com/twisted/twistedchecker/pull/71/files merged,
 
 which requires exactly pep8 1.5.1
 
 Ubuntu 14.04 installs 1.4.6
 I have the current 1.5.7
 
 After downgrading to 1.4.6, twistedchecker works correctly.

The issue is actually logilab-common, not pep8 itself; twistedchecker can deal 
with more recent pep8 versions.

I fixed this on twistedchecker master:

https://github.com/twisted/twistedchecker/commit/a7aa84aaa190459cab77397b31ec0d67d4116e9c

More exciting, though, is Adi Roiban's contribution of Travis-CI continuous 
integration:

https://github.com/twisted/twistedchecker/pull/71

so we can pick up the pace on twistedchecker improvements a bit.  (The buildbot 
already runs straight out of Git, so improvements go live almost immediately.)

-glyph___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-28 Thread Wolfgang Rohdewald 
I am getting this traceback on about every source file like:


i5:~/ssdsrc/alt/Twisted/twisted/test (pb3) twistedchecker reflect_helper_ZDE.py
* Module reflect_helper_ZDE
W9001:  1,0: Missing copyright header
W9002:  1,0: Missing a reference to test module in header
C0103:  1,0: Invalid name reflect_helper_ZDE for type module (should match 
(([a-z_][a-z0-9_]*))$)
W9208:  1,0: Missing docstring
Traceback (most recent call last):
  File /usr/local/bin/twistedchecker, line 5, in module
pkg_resources.run_script('TwistedChecker==0.2.0', 'twistedchecker')
  File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 528, in 
run_script
self.require(requires)[0].run_script(script_name, ns)
  File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1394, in 
run_script
execfile(script_filename, namespace, namespace)
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/EGG-INFO/scripts/twistedchecker,
 line 10, in module
Runner().run(sys.argv[1:])
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/core/runner.py,
 line 325, in run
self.linter.check(args)
  File 
/usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/lint.py, line 
542, in check
self.check_astng_module(astng, walker, rawcheckers)
  File 
/usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/lint.py, line 
615, in check_astng_module
walker.walk(astng)
  File 
/usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/utils.py, 
line 553, in walk
cb(astng)
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
 line 179, in visit_module
self._runPEP8Checker(node.file)
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
 line 188, in _runPEP8Checker
recorder = PEP8WarningRecorder(file)
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
 line 49, in __init__
self.run()
  File 
/usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
 line 78, in run
pep8.Checker.check_all(self)
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
1445, in check_all
self.check_logical()
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
1338, in check_logical
for offset, text in self.run_check(check, argument_names) or ():
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
1278, in run_check
return check(*arguments)
TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)


-- 
Wolfgang

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] twistedchecker TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)

2014-09-28 Thread Glyph 
How did you install twistedchecker?

-glyph

On Sep 27, 2014, at 11:52 PM, Wolfgang Rohdewald wolfgang@rohdewald.de 
wrote:

 I am getting this traceback on about every source file like:
 
 
 i5:~/ssdsrc/alt/Twisted/twisted/test (pb3) twistedchecker 
 reflect_helper_ZDE.py
 * Module reflect_helper_ZDE
 W9001:  1,0: Missing copyright header
 W9002:  1,0: Missing a reference to test module in header
 C0103:  1,0: Invalid name reflect_helper_ZDE for type module (should match 
 (([a-z_][a-z0-9_]*))$)
 W9208:  1,0: Missing docstring
 Traceback (most recent call last):
  File /usr/local/bin/twistedchecker, line 5, in module
pkg_resources.run_script('TwistedChecker==0.2.0', 'twistedchecker')
  File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 528, in 
 run_script
self.require(requires)[0].run_script(script_name, ns)
  File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1394, in 
 run_script
execfile(script_filename, namespace, namespace)
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/EGG-INFO/scripts/twistedchecker,
  line 10, in module
Runner().run(sys.argv[1:])
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/core/runner.py,
  line 325, in run
self.linter.check(args)
  File 
 /usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/lint.py, 
 line 542, in check
self.check_astng_module(astng, walker, rawcheckers)
  File 
 /usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/lint.py, 
 line 615, in check_astng_module
walker.walk(astng)
  File 
 /usr/lib/python2.7/dist-packages/pylint-0.26.0-py2.7.egg/pylint/utils.py, 
 line 553, in walk
cb(astng)
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
  line 179, in visit_module
self._runPEP8Checker(node.file)
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
  line 188, in _runPEP8Checker
recorder = PEP8WarningRecorder(file)
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
  line 49, in __init__
self.run()
  File 
 /usr/lib/python2.7/dist-packages/TwistedChecker-0.2.0-py2.7.egg/twistedchecker/checkers/pep8format.py,
  line 78, in run
pep8.Checker.check_all(self)
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
 1445, in check_all
self.check_logical()
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
 1338, in check_logical
for offset, text in self.run_check(check, argument_names) or ():
  File /usr/lib/python2.7/dist-packages/pep8-1.5.7-py2.7.egg/pep8.py, line 
 1278, in run_check
return check(*arguments)
 TypeError: modifiedBlankLines() takes exactly 6 arguments (7 given)
 
 
 -- 
 Wolfgang
 
 ___
 Twisted-Python mailing list
 Twisted-Python@twistedmatrix.com
 http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python