[U-Boot] Too Large patch

2008-12-30 Thread kenneth johansson
I have a rather large patch that really is just one change just to a lot
of files so I do not want to split it up. 

What to do ?? It got rejected by the mail administrator.

here is the diffstat 
-
[PATCH] make make quiet

Only print out the target name during make.
For old style set V=1


Signed-off-by: kenneth johansson kenn...@southpole.se
---
 Makefile  |   34 
 api/Makefile  |2 +-
 api_examples/Makefile |2 +-
 board/AtmarkTechno/suzaku/Makefile|2 +-
 board/BuS/EB+MCF-EV123/Makefile   |2 +-
 board/LEOX/elpt860/Makefile   |2 +-
 board/MAI/AmigaOneG3SE/Makefile   |2 +-
 board/Marvell/db64360/Makefile|2 +-
 board/Marvell/db64460/Makefile|2 +-
 board/RPXClassic/Makefile |2 +-
 board/RPXlite/Makefile|2 +-
 board/RPXlite_dw/Makefile |2 +-
 board/RRvision/Makefile   |2 +-
 board/a3000/Makefile  |2 +-
 board/actux1/Makefile |2 +-
 board/actux2/Makefile |2 +-
 board/actux3/Makefile |2 +-
 board/actux4/Makefile |2 +-
 board/adder/Makefile  |2 +-
 board/ads5121/Makefile|2 +-
 board/afeb9260/Makefile   |2 +-
 board/alaska/Makefile |2 +-
 board/altera/dk1c20/Makefile  |2 +-
 board/altera/dk1s10/Makefile  |2 +-
 board/altera/ep1c20/Makefile  |2 +-
 board/altera/ep1s10/Makefile  |2 +-
 board/altera/ep1s40/Makefile  |2 +-
 board/amcc/acadia/Makefile|2 +-
 board/amcc/bamboo/Makefile|2 +-
 board/amcc/bubinga/Makefile   |2 +-
 board/amcc/canyonlands/Makefile   |2 +-
 board/amcc/ebony/Makefile |2 +-
 board/amcc/katmai/Makefile|2 +-
 board/amcc/kilauea/Makefile   |2 +-
 board/amcc/luan/Makefile  |2 +-
 board/amcc/makalu/Makefile|2 +-
 board/amcc/ocotea/Makefile|2 +-
 board/amcc/redwood/Makefile   |2 +-
 board/amcc/sequoia/Makefile   |2 +-
 board/amcc/taihu/Makefile |2 +-
 board/amcc/taishan/Makefile   |2 +-
 board/amcc/walnut/Makefile|2 +-
 board/amcc/yosemite/Makefile  |2 +-
 board/amcc/yucca/Makefile |2 +-
 board/amirix/ap1000/Makefile  |2 +-
 board/apollon/Makefile|2 +-
 board/armadillo/Makefile  |2 +-
 board/assabet/Makefile|2 +-
 board/atc/Makefile|2 +-
 board/atmel/at91cap9adk/Makefile  |2 +-
 board/atmel/at91rm9200dk/Makefile |2 +-
 board/atmel/at91sam9260ek/Makefile|2 +-
 board/atmel/at91sam9261ek/Makefile|2 +-
 board/atmel/at91sam9263ek/Makefile|2 +-
 board/atmel/at91sam9rlek/Makefile |2 +-
 board/atmel/atngw100/Makefile |2 +-
 board/atmel/atstk1000/Makefile|2 +-
 board/atum8548/Makefile   |2 +-
 board/barco/Makefile  |2 +-
 board/bc3450/Makefile |2 +-
 board/bf533-ezkit/Makefile|2 +-
 board/bf533-stamp/Makefile|2 +-
 board/bf537-stamp/Makefile|2 +-
 board/bf561-ezkit/Makefile|2 +-
 board/bmw/Makefile|2 +-
 board/c2mon/Makefile  |2 +-
 board/canmb/Makefile  |2 +-
 board/cerf250/Makefile|2 +-
 board/cm4008/Makefile |2 +-
 board/cm41xx/Makefile |2 +-
 board/cm5200/Makefile |2 +-
 board/cmc_pu2/Makefile|2 +-
 board/cmi/Makefile|2 +-
 board/cobra5272/Makefile  |2 +-
 board/cogent/Makefile |2 +-
 board/cpc45/Makefile  |2 +-
 board/cpu86/Makefile  |2 +-
 board/cpu87/Makefile  |2 +-
 board/cradle/Makefile |2 +-
 board/cray/L1/Makefile|2 +-
 board/csb226/Makefile |2 +-
 board/csb272/Makefile |2 +-
 board/csb472/Makefile |2 +-
 board/csb637/Makefile |2 +-
 board/cu824/Makefile  |2 +-
 board/dave/B2/Makefile|2 +-
 board/dave/PPChameleonEVB/Makefile|2 +-
 board/davinci/common/Makefile |2 +-
 board/davinci/dvevm/Makefile  |2 +-
 board/davinci/schmoogie/Makefile  |2 +-
 board/davinci/sffsdr/Makefile |2 +-
 board/davinci/sonata/Makefile |2 +-
 board/dbau1x00/Makefile   |2 +-
 board/delta/Makefile  |  

[U-Boot] [PATCH v4] easylogo: add optional gzip support

2008-12-30 Thread Mike Frysinger
Some images can be quite large, so add an option to compress the image data
with gzip in the U-Boot image.  Then at runtime, the board can decompress it
with the normal zlib functions.

Signed-off-by: Mike Frysinger vap...@gentoo.org
---
v4
- redo error handling

v3
- fix copyright
- free buffers on error

v2
- add error checking

 tools/easylogo/easylogo.c |   98 ++---
 1 files changed, 92 insertions(+), 6 deletions(-)

diff --git a/tools/easylogo/easylogo.c b/tools/easylogo/easylogo.c
index 00a1e4e..41e5838 100644
--- a/tools/easylogo/easylogo.c
+++ b/tools/easylogo/easylogo.c
@@ -3,15 +3,19 @@
 ** ==
 ** (C) 2000 by Paolo Scaffardi (arse...@tin.it)
 ** AIRVENT SAM s.p.a - RIMINI(ITALY)
+** (C) 2007-2008 Mike Frysinger vap...@gentoo.org
 **
 ** This is still under construction!
 */
 
+#include errno.h
 #include getopt.h
 #include stdbool.h
 #include stdio.h
 #include stdlib.h
 #include string.h
+#include unistd.h
+#include sys/stat.h
 
 #pragma pack(1)
 
@@ -49,6 +53,17 @@ typedef struct {
int width, height, pixels, bpp, pixel_size, size, palette_size, yuyv;
 } image_t;
 
+void *xmalloc (size_t size)
+{
+   void *ret = malloc (size);
+   if (!ret) {
+   fprintf (stderr, \nerror: malloc(%zu) failed: %s,
+   size, strerror(errno));
+   exit (1);
+   }
+   return ret;
+}
+
 void StringUpperCase (char *str)
 {
int count = strlen (str);
@@ -171,7 +186,7 @@ int image_load_tga (image_t * image, char *filename)
image-pixel_size = ((image-bpp - 1) / 8) + 1;
image-pixels = image-width * image-height;
image-size = image-pixels * image-pixel_size;
-   image-data = malloc (image-size);
+   image-data = xmalloc (image-size);
 
if (image-bpp != 24) {
printf (Bpp not supported: %d!\n, image-bpp);
@@ -192,7 +207,7 @@ int image_load_tga (image_t * image, char *filename)
 /* Swapping image */
 
if (!(header.ImageDescriptorByte  0x20)) {
-   unsigned char *temp = malloc (image-size);
+   unsigned char *temp = xmalloc (image-size);
int linesize = image-pixel_size * image-width;
void *dest = image-data,
*source = temp + image-size - linesize;
@@ -239,7 +254,7 @@ int image_rgb_to_yuyv (image_t * rgb_image, image_t * 
yuyv_image)
yuyv_image-pixels = yuyv_image-width * yuyv_image-height;
yuyv_image-size = yuyv_image-pixels * yuyv_image-pixel_size;
dest = (unsigned short *) (yuyv_image-data =
-  malloc (yuyv_image-size));
+  xmalloc (yuyv_image-size));
yuyv_image-palette = 0;
yuyv_image-palette_size = 0;
 
@@ -261,6 +276,8 @@ int image_rgb_to_yuyv (image_t * rgb_image, image_t * 
yuyv_image)
return 0;
 }
 
+int use_gzip = 0;
+
 int image_save_header (image_t * image, char *filename, char *varname)
 {
FILE *file = fopen (filename, w);
@@ -283,6 +300,65 @@ int image_save_header (image_t * image, char *filename, 
char *varname)
fprintf (file,  *\t\t'x'\t\tis the horizontal position\n);
fprintf (file,  *\t\t'y'\t\tis the vertical position\n */\n\n);
 
+   /*  gzip compress */
+   if (use_gzip  0x1) {
+   const char *errstr = NULL;
+   unsigned char *compressed;
+   struct stat st;
+   FILE *gz;
+   char *gzfilename = xmalloc(strlen (filename) + 20);
+   char *gzcmd = xmalloc(strlen (filename) + 20);
+
+   sprintf (gzfilename, %s.gz, filename);
+   sprintf (gzcmd, gzip  %s, gzfilename);
+   gz = popen (gzcmd, w);
+   if (!gz) {
+   errstr = \nerror: popen() failed;
+   goto done;
+   }
+   if (fwrite (image-data, image-size, 1, gz) != 1) {
+   errstr = \nerror: writing data to gzip failed;
+   goto done;
+   }
+   if (pclose (gz)) {
+   errstr = \nerror: gzip process failed;
+   goto done;
+   }
+
+   gz = fopen (gzfilename, r);
+   if (!gz) {
+   errstr = \nerror: open() on gzip data failed;
+   goto done;
+   }
+   if (stat (gzfilename, st)) {
+   errstr = \nerror: stat() on gzip file failed;
+   goto done;
+   }
+   compressed = xmalloc (st.st_size);
+   if (fread (compressed, st.st_size, 1, gz) != 1) {
+   errstr = \nerror: reading gzip data failed;
+   goto done;
+   }
+   fclose (gz);
+
+   unlink (gzfilename);
+
+   dataptr = 

[U-Boot] [PATCH] make make quiet

2008-12-30 Thread kenneth johansson
Only print out the target name during make.
For old style set V=1


Signed-off-by: kenneth johansson kenn...@southpole.se
---

For size reason this is a binary attachment. it uncompress to 
244227 bytes and max for this list is 100k




0001-make-make-quiet.patch.gz
Description: GNU Zip compressed data
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Spansion Flash File system

2008-12-30 Thread Marc Leeman
 I need to support spansion flash file system to existing uboot -  Das Uboot
 1.4.

You will not have much support for this version for development. It's
rather old.

 To this end, I would like to know more about the Spansion Flash File Systems
 that I'm considering to use:

File System?

 Software / Driver support for SPANSION 29GL256N11FFIIH0
 List of changes I need to consider.

None, that device supports CFI. It is supported out of the box.

-- 
  greetz, marc
As far as the laws of mathematics refer to reality, they are not
certain, and as far as they are certain, they do not refer to reality.
-- Albert Einstein
crichton 2.6.26 #1 PREEMPT Tue Jul 29 21:17:59 CDT 2008 GNU/Linux


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Reg. working with uboot

2008-12-30 Thread Wolfgang Denk
Dear Vanee S,

In message 60e43c2d0812291945n72ced68fr344afc9f813f4...@mail.gmail.com you 
wrote:

 I want to configure u-boot for Armadillo board. When i try make all i get
 the error
 Generating include/autoconf.mk
 arm-linux-gcc: compilation of header file requested
 make: *** [include/autoconf.mk] Error 1

Try using a more recent toolchain, and a more recent version of
U-Boot.

 in the Makefile. How to rectify this error without commenting the above
 line? im using u-boot 1.3.2 version.
 But, will this disable any of the features?

It may cause subtle failure modes as you don;t build the make
depencies corectly, then.

 And, when i make all after commenting the above line
 im get the error
 Assembler messages:
 Fatal error: Invalid -march= option: 'armv4'
 make[1]: *** [hrllo_world.o] Error 2
 make[1]: Leaving directory '/usr/eldk/usr/src/u-boot-1.3.2/examples'
 make: *** [examples] Error 2
 Pls do suggest on what needs to be done.

Try using a more recent toolchain, and a more recent version of
U-Boot.


Also, please note that you are violating quite a list of very basic
netiquqtte rules:

* You top post.
* You Full quote.
* You hijack an existing thread instead of sending a new message.

Please read http://www.netmeister.org/news/learn2quote.html

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Our business is run on trust.  We trust you will pay in advance.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Too Large patch

2008-12-30 Thread Wolfgang Denk
Dear Mike Frysinger,

In message 200812300317.55242.vap...@gentoo.org you wrote:

  I have a rather large patch that really is just one change just to a lot
  of files so I do not want to split it up.
 
  What to do ?? It got rejected by the mail administrator.
 
 summarize the change and then compress  attach

NO!!! Please read the instructions before making fals recommendations.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The one charm of marriage is that it makes a  life  of  deception  a
neccessity.- Oscar Wilde
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread Wolfgang Denk
Dear kenneth johansson,

In message 1230625526.12143.24.ca...@duo you wrote:
 
 For size reason this is a binary attachment. it uncompress to 
 244227 bytes and max for this list is 100k

BINARY ATTACHMENT IGNORED.

PLEASE READ THE INSTRUCTIONS.


Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The existence of god implies a violation of causality.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Copy environment variables to another board

2008-12-30 Thread Wolfgang Denk
Dear Giuseppe Modugno,

In message 495a0644.29557.a68...@g.modugno.elettronika.it you wrote:

 I have a board running U-Boot/Linux. U-Boot program, two U-Boot 
 environments, Linux kernel and root filesystem for Linux are stored 
 in a NOR Flash.
 
 I finished my developing process and now I want to copy the entire U-
 Boot environment to a new board. Of course, I don't want to manually 
 copy all the variables in the environment.
 
 Is there a simple way to dump the full environment in a file and copy 
 it in the new board?

Assuming both boards have the same configuration (or, more precisely,
at least the same size of environment and environment sectors),  then
you can just read the sector(s) containing the environment from their
corresponding  /dev/mtd*  devices  in  Linux and copy it to the other
system.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The great question... which I have not been able  to  answer...  is,
`What does woman want?'  - Sigmund Freud
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] Copy environment variables to another board

2008-12-30 Thread Giuseppe Modugno
I'm sorry if my question was already asked, but I didn't find an 
answer in the manual/FAQs/mailing list archive.

I have a board running U-Boot/Linux. U-Boot program, two U-Boot 
environments, Linux kernel and root filesystem for Linux are stored 
in a NOR Flash.

I finished my developing process and now I want to copy the entire U-
Boot environment to a new board. Of course, I don't want to manually 
copy all the variables in the environment.

Is there a simple way to dump the full environment in a file and copy 
it in the new board?

Thanks for your help.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread kenneth johansson
On Tue, 2008-12-30 at 11:48 +0100, Wolfgang Denk wrote:
 Dear kenneth johansson,
 
 In message 1230625526.12143.24.ca...@duo you wrote:
  
  For size reason this is a binary attachment. it uncompress to 
  244227 bytes and max for this list is 100k
 
 BINARY ATTACHMENT IGNORED.
 
 PLEASE READ THE INSTRUCTIONS.

THERE IS NO INSTRUCTIONS IN THE README IN U_BOOT FOR THE CASE LARGER
THAN 100K PATCH. 

I HAVE BETTER THING TO DO WITH MY TIME THAN HUNT AROUND YOUR WEBSITE
TRYING TO FIND INFORMATION I'M NOT EVEN SURE EXIST.



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Copy environment variables to another board

2008-12-30 Thread Giuseppe Modugno
On 30 Dec 2008 at 11:52, Wolfgang Denk wrote:
 Assuming both boards have the same configuration (or, more
precisely,
 at least the same size of environment and environment sectors),  

Yes, they are the same.


 then
 you can just read the sector(s) containing the environment from their
 corresponding  /dev/mtd*  devices  in  Linux and copy it to the other
 system.

So you're proposing to use Linux to copy U-Boot environment. But on a 
new board (picked from the shelf) I don't have Linux and I should set 
some U-Boot variables to run it.
I was thinking of a U-Boot only procedure, like md.b (to run on the 
source board) and cp.b (to run on the destination board). In this way 

I must copypaste the md.b text result from the terminal to a file, 
process it (on the computer) to have a binary content of the 
environment, download (by TFTP) it on the destination board and run 
cp.b.
What do you think about this procedure?

Another possibility is to printenv on the source board, copy the text 
result from the terminal into a text file, append setenv  at the 
top of each lines, substitute = character with space, insert the 
quotes where needed and paste the result in the terminal of the 
destination board.


Best regards,
  Giuseppe

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] make make quiet

2008-12-30 Thread kenneth johansson

Only print out the target name during make.
For old style set V=1


Signed-off-by: kenneth johansson kenn...@southpole.se
---
actual patch at
http://www.4shared.com/file/78174399/3496e05d/0001-make-make-quiet.html


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] ARM: set up endianess

2008-12-30 Thread Roman Mashak
Hello

my platform is ARM926EJS-based big-endian, therefore I have to
configure endianess via co-processor C15 registers as quickly as
possible. The best place I can see is in
$(uboot)/cpu/arm926ejs/start.s, as it is where co-processor is being
configured; here is what I came up with:

cpu_init_crit:
/*
 * flush v4 I/D caches
 */

/*
 * disable MMU stuff and caches
 */
mrc p15, 0, r0, c1, c0, 0
bic r0, r0, #0x2300 /* clear bits 13, 9:8 (--V- --RS) */
bic r0, r0, #0x0087 /* clear bits 7, 2:0 (B--- -CAM) */
orr r0, r0, #0x0002 /* set bit 2 (A) Align */
orr r0, r0, #0x1000 /* set bit 12 (I) I-Cache */
#ifdef CONFIG_ARCH_BIGENDIAN
orr r0, r0, #0x0080 /* set bit 7 (B) Endianism */
#endif
mcr p15, 0, r0, c1, c0, 0


where 'CONFIG_ARCH_BIGENDIAN' is defined in my platform's configuration.

I know that modifying platform's startup code is not encouraged. Is
there more correct approach?
Thanks.

-- 
Roman Mashak
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Copy environment variables to another board

2008-12-30 Thread Alessandro Rubini
 So you're proposing to use Linux to copy U-Boot environment. But on a 
 new board (picked from the shelf) I don't have Linux and I should set 
 some U-Boot variables to run it.

So you might prefer setting them as predefined in you configuration
file, so when the u-boot binary finds no environment on flash (crc
error) and it will use those values, until you saveenv new values.
 
 I was thinking of a U-Boot only procedure, like md.b (to run on the 
 source board) and cp.b (to run on the destination board).

You can unprotect, erase, and cp.b to the flash sector(s), once you
have the binary image of the environment. You can extract such
image from /dev/mtd in the running board and then use tftp (as you
suggested) on the new board.

hope this helps
/alessandro
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Too Large patch

2008-12-30 Thread Wolfgang Denk
Dear Mike Frysinger,

In message 200812300644.04655.vap...@gentoo.org you wrote:

 URLs rot.  mailing list archives do not.

Mailing lists archive simply disappear. Or did you succeed to search
the armboot ML archive on SourceForge lately?

Anyway - we have an official policy for handling such things.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There are some good people in it, but the orchestra as  a  whole  is
equivalent to a gang bent on destruction.  - John Cage, composer
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Is it possible to use 2GB or DDR on MPC834x?

2008-12-30 Thread Scott Wood
Valeriy Glushkov wrote:
 Hi Guys!
 
 On my mpc8347 based board I can access 1GB of DDR with mapping 4 of 256MB 
 ranges via IBAT\DBAT registers.
 
 But with the 2 GB of DDR it's impossible to map them with BATs (there are 
 only 8 BATs in the e300 core and the rest 4 of them are already used).
 
 All the mpc83xx examples in the U-boot tree seem to use =1GB of SDRAM, so 
 they use BATs to map them.
 
 Any suggestions are highly appreciated.

Why do you need to access all 2GB from u-boot?

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/1] jffs2: Fix zero sector_size when not using CONFIG_JFFS2_CMDLINE

2008-12-30 Thread Tomasz Figa
This patch fixes a bug (?) introduced after inclusion of the new JFFS2 code.

When not using CONFIG_JFFS2_CMDLINE, the code in cmd_jffs2.c doesn't fill in 
part-sector_size (keeping it as 0), but a correct value is needed by the code 
in jffs2_1pass.c. This causes all JFFS2 accesses to be in the same place of the 
memory, what obviously means impossibility to use the JFFS2 partition.

This problem is fixed in this patch by including sector size calculation in 
non-CONFIG_JFFS2_CMDLINE mtdparts_init variant.

Signed-off-by: Tomasz Figa tomasz.figa_at_gmail.com
---
diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
index 7866c80..fe0f8d7 100644
--- a/common/cmd_jffs2.c
+++ b/common/cmd_jffs2.c
@@ -1778,6 +1778,96 @@ int mtdparts_init(void)
  */
 
 /**
+ * Calculate sector size.
+ *
+ * @return sector size
+ */
+static inline u32 get_part_sector_size_nand(struct mtdids *id)
+{
+#if defined(CONFIG_JFFS2_NAND)  defined(CONFIG_CMD_NAND)
+#if defined(CONFIG_NAND_LEGACY)
+   extern struct nand_chip nand_dev_desc[CONFIG_SYS_MAX_NAND_DEVICE];
+
+   return nand_dev_desc[id-num].erasesize;
+#else
+   nand_info_t *nand;
+
+   nand = nand_info[id-num];
+
+   return nand-erasesize;
+#endif
+#else
+   BUG();
+   return 0;
+#endif
+}
+
+static inline u32 get_part_sector_size_nor(struct mtdids *id, struct 
part_info *part)
+{
+#if defined(CONFIG_CMD_FLASH)
+   extern flash_info_t flash_info[];
+   
+   u32 end_phys, start_phys, sector_size = 0, size = 0;
+   int i;
+   flash_info_t *flash;
+   
+   flash = flash_info[id-num];
+
+   start_phys = flash-start[0] + part-offset;
+   end_phys = start_phys + part-size;
+   
+   for (i = 0; i  flash-sector_count; i++) {
+   if (flash-start[i] = end_phys)
+   break;
+   
+   if (flash-start[i] = start_phys) {
+   if (i == flash-sector_count - 1) {
+   size = flash-start[0] + flash-size - 
flash-start[i];
+   } else {
+   size = flash-start[i+1] - flash-start[i];
+   }
+   
+   if (sector_size  size)
+   sector_size = size;
+   }
+   }
+
+   return sector_size;
+#else
+   BUG();
+   return 0;
+#endif
+}
+
+static inline u32 get_part_sector_size_onenand(void)
+{
+#if defined(CONFIG_CMD_ONENAND)
+   struct mtd_info *mtd;
+
+   mtd = onenand_mtd;
+
+   return mtd-erasesize;
+#else
+   BUG();
+   return 0;
+#endif
+}
+
+static inline u32 get_part_sector_size(struct mtdids *id, struct part_info 
*part)
+{
+   if (id-type == MTD_DEV_TYPE_NAND)
+   return get_part_sector_size_nand(id);
+   else if (id-type == MTD_DEV_TYPE_NOR)
+   return get_part_sector_size_nor(id, part);
+   else if (id-type == MTD_DEV_TYPE_ONENAND)
+   return get_part_sector_size_onenand();
+   else
+   DEBUGF(Error: Unknown device type.\n);
+   
+   return 0;
+}
+
+/**
  * Parse and initialize global mtdids mapping and create global
  * device/partition list.
  *
@@ -1846,6 +1936,8 @@ int mtdparts_init(void)
part-offset = 0x;
 #endif
 
+   part-sector_size = get_part_sector_size(id, part);
+
part-dev = current_dev;
INIT_LIST_HEAD(part-link);
 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Too Large patch

2008-12-30 Thread Mike Frysinger
On Tuesday 30 December 2008 09:54:38 Wolfgang Denk wrote:
 In message 200812300644.04655.vap...@gentoo.org you wrote:
  URLs rot.  mailing list archives do not.

 Mailing lists archive simply disappear. Or did you succeed to search
 the armboot ML archive on SourceForge lately?

the likely hood of a random user external URL of rotting is much higher than 
the mailing archives.  users post a file until it gets used and then they 
delete it.  if a mailing archive dies, then the whole thing goes, but 
considering the proliferation of these nowadays (gmane.org/marc/etc...), it's 
really not a big deal
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread Wolfgang Denk
Dear kenneth johansson,

In message 1230635276.17914.3.ca...@duo you wrote:

  PLEASE READ THE INSTRUCTIONS.
 
 THERE IS NO INSTRUCTIONS IN THE README IN U_BOOT FOR THE CASE LARGER
 THAN 100K PATCH. 

Let me quote the README for you:

| Submitting Patches:
| ---
| 
| Since the number of patches for U-Boot is growing, we need to
| establish some rules. Submissions which do not conform to these rules
| may be rejected, even when they contain important and valuable stuff.
| 
| Patches shall be sent to the u-boot-users mailing list.
| 
| Please see http://www.denx.de/wiki/U-Boot/Patches for details.
 

 I HAVE BETTER THING TO DO WITH MY TIME THAN HUNT AROUND YOUR WEBSITE
 TRYING TO FIND INFORMATION I'M NOT EVEN SURE EXIST.

Looks like a pretty clear hint to me. Not much hunting around needed.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
They say a little knowledge is a dangerous thing,  but it is not  one
half so bad as a lot of ignorance.   - Terry Pratchett, _Equal Rites_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] README: update mailing list name and hits to patch submission.

2008-12-30 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk w...@denx.de
---
 README |   17 +
 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/README b/README
index 2a553c2..3674ca1 100644
--- a/README
+++ b/README
@@ -3731,7 +3731,7 @@ MPC826x processors), on others (parts of) the data cache 
can be
 locked as (mis-) used as memory, etc.
 
Chris Hallinan posted a good summary of these issues to the
-   u-boot-users mailing list:
+   U-Boot mailing list:
 
Subject: RE: [U-Boot-Users] RE: More On Memory Bank x (nothingness)?
From: Chris Hallinan c...@net1plus.com
@@ -3941,7 +3941,7 @@ int main (int argc, char *argv[])
 
Download latest U-Boot source;
 
-   Subscribe to u-boot-users mailing list;
+   Subscribe to u-boot mailing list;
 
if (clueless) {
email (Hi, I am new to U-Boot, how do I get started?);
@@ -4018,10 +4018,11 @@ Since the number of patches for U-Boot is growing, we 
need to
 establish some rules. Submissions which do not conform to these rules
 may be rejected, even when they contain important and valuable stuff.
 
-Patches shall be sent to the u-boot-users mailing list.
-
 Please see http://www.denx.de/wiki/U-Boot/Patches for details.
 
+Patches shall be sent to the u-boot mailing list u-boot@lists.denx.de;
+see http://lists.denx.de/mailman/listinfo/u-boot
+
 When you send a patch, please include the following information with
 it:
 
@@ -4084,7 +4085,7 @@ Notes:
   disabled must not need more memory than the old code without your
   modification.
 
-* Remember that there is a size limit of 40 kB per message on the
-  u-boot-users mailing list. Bigger patches will be moderated. If
-  they are reasonable and not bigger than 100 kB, they will be
-  acknowledged. Even bigger patches should be avoided.
+* Remember that there is a size limit of 100 kB per message on the
+  u-boot mailing list. Bigger patches will be moderated. If they are
+  reasonable and not too big, they will be acknowledged. But patches
+  bigger than the size limit should be avoided.
-- 
1.6.0.6

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread Wolfgang Denk
Dear kenneth johansson,

In message 1230636057.17914.5.ca...@duo you wrote:
 
 Only print out the target name during make.
 For old style set V=1

What is the rationale for this patch? I can see no real advantage with
it.

If you find the make output annoying, you can silence make by passing
the -s flag.

On the other hand, your patch braks building with -s - I get:

$ make -s all
grep: writing output: Broken pipe
a - ppc_longjmp.o
a - ppc_setjmp.o
a - stubs.o
a - bzlib.o
a - bzlib_crctable.o
a - bzlib_decompress.o
a - bzlib_randtable.o
a - bzlib_huffman.o
a - crc16.o
a - crc32.o
a - ctype.o
a - display_options.o
a - div64.o
a - gunzip.o
a - lmb.o
a - ldiv.o
a - sha1.o
a - string.o
a - strmhz.o
a - vsprintf.o
a - zlib.o
a - io.o
a - firmware_sc_task_bestcomm.impl.o
a - firmware_sc_task.impl.o
a - i2c.o
a - traps.o
a - cpu.o
a - cpu_init.o
a - ide.o
a - interrupts.o
a - loadtask.o
a - pci_mpc5200.o
...

etc.

Even without -s there are some errors for example  when  I  try  to
build the TQM5200 configuration.

But most of all, your patch costs  a  lot  of  additional  processes.
Running  make  all  for  above  configuration  takes 2150 processes
without your patch, and 2410 with it. And this does  not  even  count
the additional calls to shell builtins.


Unless you have a  really  good  reason  why  this  patch  should  be
applied, I tend to reject it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Virtual means never knowing where your next byte is coming from.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-usb

2008-12-30 Thread Wolfgang Denk
Dear Remy,

In message 3efb10970812161235s530a89edq18926dde5155d...@mail.gmail.com you 
wrote:
 The following changes since commit 7f202217356f19e519e6ec57a29de9af73067037:
   Wolfgang Denk (1):
 Merge branch 'master' of ssh://gemini/home/wd/git/u-boot/master
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-usb.git master
 
 Jean-Christophe PLAGNIOL-VILLARD (1):
   usb_kbd: fix usb_kbd_deregister when DEVICE_DEREGISTER not enable
 
  common/usb_kbd.c  |4 
  include/devices.h |2 ++
  2 files changed, 6 insertions(+), 0 deletions(-)

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Pig: An animal (Porcus omnivorous) closely allied to the  human  race
by  the splendor and vivacity of its appetite, which, however, is in-
ferior in scope, for it balks at pig.- Ambrose Bierce
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: nand flash

2008-12-30 Thread Wolfgang Denk
Dear Scott,

In message 20081216211654.ga...@ld0162-tx32.am.freescale.net you wrote:
 The following changes since commit 7f202217356f19e519e6ec57a29de9af73067037:
   Wolfgang Denk (1):
 Merge branch 'master' of ssh://gemini/home/wd/git/u-boot/master
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-nand-flash.git master
 
 Scott Wood (1):
   NAND: Mark the BBT as scanned prior to calling scan_bbt.
 
  drivers/mtd/nand/nand_base.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The optimum committee has no members.
   - Norman Augustine
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread Scott Wood
Wolfgang Denk wrote:
 Dear kenneth johansson,
 
 In message 1230636057.17914.5.ca...@duo you wrote:
 Only print out the target name during make.
 For old style set V=1
 
 What is the rationale for this patch? I can see no real advantage with
 it.
 
 If you find the make output annoying, you can silence make by passing
 the -s flag.

FWIW, I like the Linux-style non-verbose but not completely silent 
output.  It shows what is being built without too much noise.  It's 
useful for sanity checking that edits got saved, dependencies are 
working, etc.

 But most of all, your patch costs  a  lot  of  additional  processes.
 Running  make  all  for  above  configuration  takes 2150 processes
 without your patch, and 2410 with it. And this does  not  even  count
 the additional calls to shell builtins.

Unix scripting is inefficient, news at 11.  What's the actual time 
difference?

-Scott

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [GIT PULL] MIPS updates

2008-12-30 Thread Wolfgang Denk
Dear Shinya Kuribayashi,

In message 4949020a.5020...@ruby.dti.ne.jp you wrote:
 Hi Wolfgang,
 
 please pull U-Boot/MIPS repository to pick up the following changes.
 
 Thanks in advance,
 
   Shinya
 
 ---
 
 The following changes since commit aced78d852d0b009e8aaa1445af8cb40861ee549:
   Wolfgang Denk (1):
 Prepare 2009.01-rc1
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-mips.git master
 
 Jean-Christophe PLAGNIOL-VILLARD (3):
   MIPS: qemu_mips: move env storage just after u-boot
   MIPS: qemu_mips: update doc to use all disk and boot linux kernel
   MIPS: qemu_mips: update doc to generate and to use qemu flash, ide file
 
  doc/README.qemu_mips|   88 
 ++-
  include/configs/qemu-mips.h |2 +-
  2 files changed, 87 insertions(+), 3 deletions(-)

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Compassion -- that's the one things no machine ever had.  Maybe it's
the one thing that keeps men ahead of them.
-- McCoy, The Ultimate Computer, stardate 4731.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Copy environment variables to another board

2008-12-30 Thread Wolfgang Denk
Dear Giuseppe Modugno,

In message 495a0ce8.31716.c07...@g.modugno.elettronika.it you wrote:

  then
  you can just read the sector(s) containing the environment from their
  corresponding  /dev/mtd*  devices  in  Linux and copy it to the other
  system.
 
 So you're proposing to use Linux to copy U-Boot environment. But on a 
 new board (picked from the shelf) I don't have Linux and I should set 
 some U-Boot variables to run it.

It is difficult to make recommendations when you're providing
inconsistent input. In your previous message you wrote:

 I have a board running U-Boot/Linux. U-Boot program, two U-Boot 
 environments, Linux kernel and root filesystem for Linux are stored 
 in a NOR Flash.

Now you claim I don't have Linux.

Can you please decide whether or not you have Linux running on that
board?

 Another possibility is to printenv on the source board, copy the text 
 result from the terminal into a text file, append setenv  at the 
 top of each lines, substitute = character with space, insert the 
 quotes where needed and paste the result in the terminal of the 
 destination board.

You could (and probaly should) put the constant part of your
definitions into the default environment, and use a script image for
the rest.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
egrep patterns are full regular expressions; it uses a fast  determi-
nistic algorithm that sometimes needs exponential space.
- unix manuals
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Please pull u-boot-mpc85xx.git

2008-12-30 Thread Wolfgang Denk
Dear Andy Fleming,

In message 1229974568-3773-1-git-send-email-aflem...@freescale.com you wrote:
 are available in the git repository at:
 
   git://www.denx.de/git/u-boot-mpc85xx.git master
 
 Dave Liu (1):
   85xx: Fix the boot window issue
 
 Haiying Wang (1):
   Set IVPR to kenrel entry point in second core boot page
 
 Kumar Gala (3):
   85xx: Add support to populate addr map based on TLB settings
   ppc: Use addrmap in virt_to_phys and map_physmem.
   NAND FSL elbc: Use virt_to_phys to determine which bank is in use
 
 Paul Gortmaker (3):
   sbc8548: don't enable the 3rd and 4th eTSEC
   sbc8548: enable command line editing by default.
   sbc8548: use proper PHY address
 
 Peter Tyser (5):
   pci/fsl_pci_init: Enable inbound PCI config cycles
   Add support for PCA953x I2C gpio devices
   XPedite5370 board support
   85xx: Enable inbound PCI config cycles for X-ES boards
   XPedite5200 board support
 
 Trent Piepho (5):
   mpc8[56]xx: Put localbus clock in device tree
   mpc8xxx: LCRR[CLKDIV] is sometimes five bits
   mpc8568: Double local bus clock divider
   mpc86xx: Double local bus clock divider
   mpc8[56]xx: Put localbus clock in sysinfo and gd
 
  MAINTAINERS |4 +
  MAKEALL |2 +
  Makefile|8 +
  README  |9 +
  board/freescale/mpc8540ads/mpc8540ads.c |2 +-
  board/freescale/mpc8541cds/mpc8541cds.c |2 +-
  board/freescale/mpc8548cds/mpc8548cds.c |2 +-
  board/freescale/mpc8555cds/mpc8555cds.c |2 +-
  board/freescale/mpc8560ads/mpc8560ads.c |2 +-
  board/freescale/mpc8568mds/mpc8568mds.c |2 +-
  board/mpc8540eval/mpc8540eval.c |2 +-
  board/pm854/pm854.c |2 +-
  board/pm856/pm856.c |2 +-
  board/sbc8548/sbc8548.c |2 +-
  board/socrates/socrates.c   |2 +-
  board/tqc/tqm85xx/tqm85xx.c |2 +-
  board/xes/common/Makefile   |   57 +++
  board/xes/common/fsl_8572_clk.c |   51 +++
  board/xes/common/fsl_85xx_ddr.c |   93 +
  board/xes/common/fsl_85xx_pci.c |  375 
  board/xes/xpedite5370/Makefile  |   45 +++
  board/xes/xpedite5370/config.mk |   35 ++
  board/xes/xpedite5370/ddr.c |  270 ++
  board/xes/xpedite5370/law.c |   54 +++
  board/xes/xpedite5370/tlb.c |   94 +
  board/xes/xpedite5370/u-boot.lds|  145 
  board/xes/xpedite5370/xpedite5370.c |  128 +++
  cpu/mpc85xx/cpu.c   |   31 +--
  cpu/mpc85xx/fdt.c   |8 +-
  cpu/mpc85xx/release.S   |1 +
  cpu/mpc85xx/speed.c |   27 ++
  cpu/mpc85xx/start.S |   16 +-
  cpu/mpc85xx/tlb.c   |   34 ++
  cpu/mpc86xx/cpu.c   |   21 +-
  cpu/mpc86xx/fdt.c   |9 +
  cpu/mpc86xx/speed.c |   19 +
  drivers/gpio/Makefile   |   47 +++
  drivers/gpio/pca953x.c  |  227 
  drivers/mtd/nand/fsl_elbc_nand.c|6 +-
  drivers/pci/fsl_pci_init.c  |   29 ++
  include/asm-ppc/fsl_lbc.h   |5 +-
  include/asm-ppc/global_data.h   |3 +
  include/asm-ppc/io.h|   12 +
  include/asm-ppc/mmu.h   |3 +
  include/configs/XPEDITE5370.h   |  589 
 +++
  include/configs/sbc8548.h   |   20 +-
  include/e500.h  |1 +
  include/mpc86xx.h   |1 +
  include/pca953x.h   |   39 ++
  lib_ppc/board.c |8 +
  50 files changed, 2467 insertions(+), 83 deletions(-)
  create mode 100644 board/xes/common/Makefile
  create mode 100644 board/xes/common/fsl_8572_clk.c
  create mode 100644 board/xes/common/fsl_85xx_ddr.c
  create mode 100644 board/xes/common/fsl_85xx_pci.c
  create mode 100644 board/xes/xpedite5370/Makefile
  create mode 100644 board/xes/xpedite5370/config.mk
  create mode 100644 board/xes/xpedite5370/ddr.c
  create mode 100644 board/xes/xpedite5370/law.c
  create mode 100644 board/xes/xpedite5370/tlb.c
  create mode 100644 board/xes/xpedite5370/u-boot.lds
  create mode 100644 board/xes/xpedite5370/xpedite5370.c
  create mode 100644 drivers/gpio/Makefile
  create mode 100644 drivers/gpio/pca953x.c
  create mode 100644 include/configs/XPEDITE5370.h
  create mode 100644 include/pca953x.h

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de

Re: [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive

2008-12-30 Thread Wolfgang Denk
Dear Mike Frysinger,

In message 1230623951-16497-1-git-send-email-vap...@gentoo.org you wrote:
 
 --- a/common/usb_storage.c
 +++ b/common/usb_storage.c
 @@ -1166,6 +1166,11 @@ int usb_stor_get_info(struct usb_device *dev,struct 
 us_data *ss,block_dev_desc_t
   /* SanDisk Corporation Cruzer Micro 20044318410546613953 */
   (dev-descriptor.idVendor == 0x0781 
dev-descriptor.idProduct == 0x5151)
 + ||
 + /* SanDisk Corporation U3 Cruzer Micro 1/4GB
 +  * Flash Drive 16244373FFB4 */
 + (dev-descriptor.idVendor == 0x0781 
 +  dev-descriptor.idProduct == 0x5406)

Please fix multiline comment style.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Even if you aren't in doubt, consider the mental welfare of the  per-
son who has to maintain the code after you, and who will probably put
parens in the wrong place.  - Larry Wall in the perl man page
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] make make quiet

2008-12-30 Thread Wolfgang Denk
Dear Scott Wood,

In message 495aa094.7030...@freescale.com you wrote:

 Unix scripting is inefficient, news at 11.  What's the actual time 
 difference?

What's the actual advantage?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
When the ax entered the forest, the trees said, The handle is one of
us!   -- Turkish proverb
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] nand potential div0

2008-12-30 Thread Ryan J M
I thought it would be better to check whether chip-ecc.size equal 0
here, I forgot to set ecc.size in board_nand_init() and it trigs a
div0 hang.

driver/mtd/nand/nand_base.c
   2786 /*
   2787  * Set the number of read / write steps for one page
depending on ECC
   2788  * mode
   2789  */
   2790 chip-ecc.steps = mtd-writesize / chip-ecc.size;
   2791 if(chip-ecc.steps * chip-ecc.size != mtd-writesize) {
   2792 printk(KERN_WARNING Invalid ecc parameters\n);
   2793 BUG();
   2794 }
   2795 chip-ecc.total = chip-ecc.steps * chip-ecc.bytes;
   2796



-- 
FIXME if it is wrong.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive

2008-12-30 Thread Bryan Wu
On Wed, Dec 31, 2008 at 6:52 AM, Wolfgang Denk w...@denx.de wrote:
 Dear Mike Frysinger,

 In message 1230623951-16497-1-git-send-email-vap...@gentoo.org you wrote:

 --- a/common/usb_storage.c
 +++ b/common/usb_storage.c
 @@ -1166,6 +1166,11 @@ int usb_stor_get_info(struct usb_device *dev,struct 
 us_data *ss,block_dev_desc_t
   /* SanDisk Corporation Cruzer Micro 20044318410546613953 */
   (dev-descriptor.idVendor == 0x0781 
dev-descriptor.idProduct == 0x5151)
 + ||
 + /* SanDisk Corporation U3 Cruzer Micro 1/4GB
 +  * Flash Drive 16244373FFB4 */
 + (dev-descriptor.idVendor == 0x0781 
 +  dev-descriptor.idProduct == 0x5406)

 Please fix multiline comment style.


But if the comment is in one line, it will exceed 80 characters.
The coding style of u-boot is the same as kernel?

-Bryan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot