Re: [U-Boot] [PATCH v1] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
-Original Message- From: l.ping...@gmail.com [mailto:l.ping...@gmail.com] On Behalf Of Remy Bohmer Sent: Saturday, July 18, 2009 2:29 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH v1] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root Hello Prafulla, 2009/7/17 Prafulla Wadaskar prafu...@marvell.com: This change is cheked in Linux source and fix found to be in sync. This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (ARM little endian board) Risk: the impact of this patch is not validated on big endian board. This need to be checked... Signed-off-by: Prafulla Wadaskar prafu...@marvell.com --- Change log: v1: le16_to_cpu macro removed for typeReq As discussed previously: Applied to u-boot-usb. Thanks! Dear Remy I could not find this patch on u-boot.git/master. I think pull request for usb (including this patch) is pending. Can you pls do the needful? Regards.. Prafulla . . Kind Regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] - save the server's mac address...
Robin,
Please keep in mind that the exact subject text becomes the changelog title:
- save the server's mac address...
looks pretty dumb. I took the liberty of cleaning it up.
Robin Getz wrote:
On Tue 21 Jul 2009 02:37, Ben Warren pondered:
Can you please re-submit using git tools?
From: Robin Getz rg...@blackfin.uclinux.org
Linux's netconsole works much better when you can pass it the MAC address of
the server. (otherwise it just uses broadcast, which everyone else on my
network complains about :)
This sets the env var serveraddr (to match ethaddr), so that you can pass
it to linux with whatever bootargs you want to
addnetconsole=set bootargs $(bootargs)
netconso...@$(ipaddr)/eth0,@$(serverip)/$(serveraddr)
Signed-of-by: Robin Getz rg...@blackfin.uclinux.org
-
Please create the patch using git tools, 'git format-patch' in
particular. It takes care of generating nice lines with three hyphens.
This one that you've created messes things up.
diff --git a/README b/README
index 4c74cb7..9071472 100644
--- a/README
+++ b/README
@@ -1184,6 +1184,11 @@ The following options need to be configured:
Defines a default value for the IP address of a TFTP
server to contact when using the tftboot command.
+ CONFIG_KEEP_SERVERADDR
+
+ Keeps the server's MAC address, in the env 'serveraddr'
+ for passing to bootargs (like Linux's netconsole option)
+
- Multicast TFTP Mode:
CONFIG_MCAST_TFTP
diff --git a/net/net.c b/net/net.c
index 7ce947d..641c37c 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1287,6 +1287,15 @@ NetReceive(volatile uchar * inpkt, int len)
/* are we waiting for a reply */
if (!NetArpWaitPacketIP || !NetArpWaitPacketMAC)
break;
+
+#ifdef CONFIG_KEEP_SERVERADDR
+ if (NetServerIP == NetArpWaitPacketIP) {
+ char buf[20];
+ sprintf(buf, %pM, arp-ar_data);
+ setenv(serveraddr, buf);
+ }
+#endif
+
#ifdef ET_DEBUG
printf(Got ARP REPLY, set server/gtwy eth addr
(%pM)\n,
arp-ar_data);
Anti-climatically...
applied to net repo.
thanks,
Ben
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
Eric Bénard wrote: Ben Warren wrote : This patch has many coding style violations that haven't been addressed, so it can't go in. Im not a fan of the piece-meal PHY implementation coding style violations should be fixed in v3 / http://www.mail-archive.com/u-boot@lists.denx.de/msg18068.html Eric Not quite. Camel-case function names like 'ks8721_IsPhyConnected' violate the coding style. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] FW: ARM Pull Request
Prafulla Wadaskar wrote: Prafulla Wadaskar (3): Marvell Sheevaplug Board support Marvell MV88F6281GTW_GE Board support Marvell RD6281A Board support Hi Ben, I think Pull request net not yet applied. This breaks build for RD6281A board. Some discussion was going for net: Kirkwood_egiga: forced interface speed config support patch inclusion. Jean has voted to keep this patch. Ref http://lists.denx.de/pipermail/u-boot/2009-July/057139.html even if wolfgang decides to skip this patch, rest other should be applied. Thanks and Regards.. Prafulla . . I'm working on the repo right now and should have another pull request soon. The 'forced interface' patch is still contentious, so isn't included. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] FW: ARM Pull Request
-Original Message- From: Ben Warren [mailto:biggerbadder...@gmail.com] Sent: Thursday, July 23, 2009 11:40 AM To: Prafulla Wadaskar Cc: Wolfgang Denk; U-Boot; Jean-Christophe PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: FW: [U-Boot] ARM Pull Request Prafulla Wadaskar wrote: Prafulla Wadaskar (3): Marvell Sheevaplug Board support Marvell MV88F6281GTW_GE Board support Marvell RD6281A Board support Hi Ben, I think Pull request net not yet applied. This breaks build for RD6281A board. Some discussion was going for net: Kirkwood_egiga: forced interface speed config support patch inclusion. Jean has voted to keep this patch. Ref http://lists.denx.de/pipermail/u-boot/2009-July/057139.html even if wolfgang decides to skip this patch, rest other should be applied. Thanks and Regards.. Prafulla . . I'm working on the repo right now and should have another pull request soon. The 'forced interface' patch is still contentious, so isn't included. Okay With this for RD6281 Build will not fail, but network will be broken. Meanwhile I will check why auto negotiation doesn't work on this board? Regards.. Prafulla . . regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] FW: ARM Pull Request
Prafulla Wadaskar wrote: -Original Message- From: Ben Warren [mailto:biggerbadder...@gmail.com] Sent: Thursday, July 23, 2009 11:40 AM To: Prafulla Wadaskar Cc: Wolfgang Denk; U-Boot; Jean-Christophe PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: FW: [U-Boot] ARM Pull Request Prafulla Wadaskar wrote: Prafulla Wadaskar (3): Marvell Sheevaplug Board support Marvell MV88F6281GTW_GE Board support Marvell RD6281A Board support Hi Ben, I think Pull request net not yet applied. This breaks build for RD6281A board. Some discussion was going for net: Kirkwood_egiga: forced interface speed config support patch inclusion. Jean has voted to keep this patch. Ref http://lists.denx.de/pipermail/u-boot/2009-July/057139.html even if wolfgang decides to skip this patch, rest other should be applied. Thanks and Regards.. Prafulla . . I'm working on the repo right now and should have another pull request soon. The 'forced interface' patch is still contentious, so isn't included. Okay With this for RD6281 Build will not fail, but network will be broken. Meanwhile I will check why auto negotiation doesn't work on this board? Seems like a good plan. Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] minor debug cleanups in ./net
Robin,
This won't apply:
bwar...@bwarren-bldsrv:~/src/u-boot-net$ git am -s --whitespace=strip
~/h_drive/patches/minor\ debug\ cleanups\ in\ ._net.eml
Applying minor debug cleanups in ./net
fatal: patch fragment without header at line 198: @@ -879,13 +856,13 @@
DhcpHandler(uchar * pkt, unsigned dest, unsigned src, unsigned len)
Patch failed at 0001.
When you have resolved this problem run git-am --resolved.
If you would prefer to skip this patch, instead run git-am --skip.
More issues below:
Robin Getz wrote:
From: Robin Getz rg...@blackfin.uclinux.org
Minor ./net cleanups - no functional changes
- change #ifdef DEBUG printf(); #endif to just debug()
- changed __FUNCTION__ to __func__
- got rid of extra whitespace between function and opening brace
- removed unnecessary braces on if statements
gcc dead code elimination should make this functionally/size equivalent
when DEBUG is not defined. (confirmed on Blackfin, with gcc 4.3.3).
Signed-off-by: Robin Getz rg...@blackfin.uclinux.org
---
snip
/* matched waiting packet's address */
if (tmp == NetArpWaitReplyIP) {
-#ifdef ET_DEBUG
- puts (Got it\n);
+ debug(Got it\n);
#endif
I'm guessing you want to remove this #endif too, right?
/* save address for later use */
memcpy(NetArpWaitPacketMAC, arp-ar_data[0],
6);
@@ -1317,16 +1295,14 @@ NetReceive(volatile uchar * inpkt, int len)
}
return;
default:
-#ifdef ET_DEBUG
- printf(Unexpected ARP opcode 0x%x\n,
ntohs(arp-ar_op));
+ debug(Unexpected ARP opcode 0x%x\n,
ntohs(arp-ar_op));
#endif
ditto
return;
}
break;
case PROT_RARP:
-#ifdef ET_DEBUG
- puts (Got RARP\n);
+ debug(Got RARP\n);
#endif
And again...
snip
This is good stuff. Please clean it up and re-submit.
regards,
Ben
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] FW: ARM Pull Request
On Thursday 23 July 2009 08:16:47 Prafulla Wadaskar wrote: I'm working on the repo right now and should have another pull request soon. The 'forced interface' patch is still contentious, so isn't included. Okay With this for RD6281 Build will not fail, but network will be broken. Meanwhile I will check why auto negotiation doesn't work on this board? Did you check if Lennert's comments are correct? Quote: Isn't it just because on the RD6281A, the first ethernet MAC of the CPU is connected to an ethernet switch chip instead of an ethernet PHY, and therefore there is no negotiation to be done? (The second MAC is connected to a PHY directly, so that one should just use autoneg.) Even on the RD6281Z, we should just force the ethernet MAC to a fixed speed/duplex, since even though PHY polling might work there, we'll be talking to the PHY corresponding to the first switch port, which means that you might not be able to tftp from the second switch port or so if there's nothing plugged into the first one. FWIW, the linux kernel port also forces 1000/full on the CPU MACs where a switch chip is connected. On those CPU MACs where there is a switch chip connected, the (R)(G)MII interface becomes purely a bus to transport packets into and out of the crossbar, one that is always up. So, is this ethernet port in question connected to switch? Then a forced link (highest speed) should be used. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fec_mxc: driver for FEC ethernet controller on i.MX27
Ilya Yanok wrote: Signed-off-by: Ilya Yanok ya...@emcraft.com --- cpu/arm926ejs/mx27/generic.c | 10 + drivers/net/Makefile |1 + drivers/net/fec_mxc.c| 742 ++ drivers/net/fec_mxc.h| 304 + include/netdev.h |1 + 5 files changed, 1058 insertions(+), 0 deletions(-) create mode 100644 drivers/net/fec_mxc.c create mode 100644 drivers/net/fec_mxc.h Applied to net repo. thanks, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request - net
Wolfgang, The following changes since commit 189eec77795553157c087cd4695fb3ce2433: Wolfgang Denk (1): Merge branch 'master' of /home/wd/git/u-boot/custodians are available in the git repository at: git://git.denx.de/u-boot-net.git master Alessio Centazzo (1): ppc4xx: Fixed compilation warning in 4xx_enet.c Andreas Pretzsch (1): smc911x: add support for LAN9221 Ben Warren (2): Add warning about upcoming removal of old Ethernet API Convert SMC911X Ethernet driver to CONFIG_NET_MULTI API David Brownell (1): rm9200 ethernet driver: board-specific quirk (csb337) Ilya Yanok (1): fec_mxc: driver for FEC ethernet controller on i.MX27 Kim Phillips (1): net: tsec - fix dereferencing type-punned pointer will break strict-aliasing rules warning Michael Zaidman (1): DHCP regression on 2009-06 Mike Frysinger (1): net: rename NetRxPkt to NetRxPacket Nobuhiro Iwamatsu (1): sh: sh_eth: Remove garbage from printf Poonam Aggrwal (1): P2020RDB Added support of Vitesse PHYs VSC8641(RGMII) and VSC8221(SGMII) Prafulla Wadaskar (1): net: phy: bugfixes: mv88E61xx multichip addressing support Richard Retanubun (1): MIIPHYBB: Return 0x if the PHY is not asserting TA. Robin Getz (2): Add DNS support Save server's MAC address in environment Simon Kagstrom (2): arm: Kirkwood: Fix compiler optimization bug for kwgbe_send arm: Kirkwood: Check the error summary bit for error detection README |5 + board/bf548-ezkit/bf548-ezkit.c |8 + board/cm-bf548/cm-bf548.c | 10 + board/freescale/mx31pdk/mx31pdk.c | 10 + board/imx31_litekit/imx31_litekit.c | 10 + board/imx31_phycore/imx31_phycore.c | 10 + board/micronas/vct/ebi_smc911x.c| 22 +- board/micronas/vct/vct.c| 10 + board/omap3/evm/evm.c | 10 + board/renesas/ap325rxa/ap325rxa.c | 10 + board/renesas/rsk7203/rsk7203.c | 17 +- common/cmd_net.c| 49 +++ cpu/arm920t/at91rm9200/ether.c | 22 +- cpu/arm926ejs/mx27/generic.c| 10 + doc/README.dns | 64 +++ drivers/net/4xx_enet.c |3 +- drivers/net/Makefile|3 +- drivers/net/fec_mxc.c | 742 +++ drivers/net/fec_mxc.h | 304 ++ drivers/net/kirkwood_egiga.c| 33 +- drivers/net/kirkwood_egiga.h|1 + drivers/net/phy/miiphybb.c |7 + drivers/net/phy/mv88e61xx.c | 18 +- drivers/net/phy/mv88e61xx.h |2 +- drivers/net/sh_eth.c|2 +- drivers/net/smc911x.c | 177 + drivers/net/smc911x.h | 170 + drivers/net/tsec.c | 57 +++- include/configs/ap325rxa.h |7 +- include/configs/bf548-ezkit.h |7 +- include/configs/cm-bf548.h |7 +- include/configs/imx31_litekit.h |7 +- include/configs/imx31_phycore.h |7 +- include/configs/mx31pdk.h |7 +- include/configs/omap3_evm.h |7 +- include/configs/rsk7203.h |7 +- include/configs/vct.h |9 +- include/net.h |9 +- include/netdev.h|2 + net/Makefile|7 +- net/bootp.c |2 +- net/dns.c | 211 ++ net/dns.h | 39 ++ net/eth.c |2 + net/net.c | 49 +++- 45 files changed, 1936 insertions(+), 236 deletions(-) create mode 100644 doc/README.dns create mode 100644 drivers/net/fec_mxc.c create mode 100644 drivers/net/fec_mxc.h create mode 100644 net/dns.c create mode 100644 net/dns.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v6] Add chip_config command for PPC4xx bootstrap configuration
This patch adds a generic command for programming I2C bootstrap
eeproms on PPC4xx. An implementation for Canyonlands board is
included.
The command name is intentionally chosen not to be PPC4xx specific.
This way other CPU's/SoC's can implement a similar command under
the same name, perhaps with a different syntax.
Usage on Canyonlands:
= chip_config
Available configurations (I2C address 0x52):
600-nor - NOR CPU: 600 PLB: 200 OPB: 100 EBC: 100
600-nand - NAND CPU: 600 PLB: 200 OPB: 100 EBC: 100
800-nor - NOR CPU: 800 PLB: 200 OPB: 100 EBC: 100
800-nand - NAND CPU: 800 PLB: 200 OPB: 100 EBC: 100
1000-nor - NOR CPU:1000 PLB: 200 OPB: 100 EBC: 100
1000-nand- NAND CPU:1000 PLB: 200 OPB: 100 EBC: 100
1066-nor - NOR CPU:1066 PLB: 266 OPB: 88 EBC: 88 ***
1066-nand- NAND CPU:1066 PLB: 266 OPB: 88 EBC: 88
= chip_config 600-nor
Using configuration:
600-nor - NOR CPU: 600 PLB: 200 OPB: 100 EBC: 100
done (dump via 'i2c md 52 0.1 10')
Reset the board for the changes to take effect
Other 4xx boards will be migrated to use this command soon
as well.
Signed-off-by: Stefan Roese s...@denx.de
Signed-off-by: Dirk Eibach eib...@gdsys.de
Acked-by: Matthias Fuchs matthias.fu...@esd.eu
---
v6:
- Update identation of chip_config struct
v5:
- Removed bogus lines from commit text
v4:
- Command name changed from cpu_config to chip_config
- Used eeprom_read/eeprom_write if available
- Added CONFIG_4xx_CONFIG_I2C_EEPROM_OFFSET
v3:
- Line length of one printf reduced
v2:
- Patch authorship changes to Stefan
- s-o-b from Dirk added
- Added current configuration detection
- Minor coding style cleanup
board/amcc/canyonlands/Makefile |5 +-
board/amcc/canyonlands/bootstrap.c | 195 --
board/amcc/canyonlands/chip_config.c | 87 +++
cpu/ppc4xx/Makefile |3 +
cpu/ppc4xx/cmd_chip_config.c | 142
include/asm-ppc/ppc4xx_config.h | 42 +++
include/configs/canyonlands.h|6 +
7 files changed, 283 insertions(+), 197 deletions(-)
delete mode 100644 board/amcc/canyonlands/bootstrap.c
create mode 100644 board/amcc/canyonlands/chip_config.c
create mode 100644 cpu/ppc4xx/cmd_chip_config.c
create mode 100644 include/asm-ppc/ppc4xx_config.h
diff --git a/board/amcc/canyonlands/Makefile b/board/amcc/canyonlands/Makefile
index 2aeead6..12f8a64 100644
--- a/board/amcc/canyonlands/Makefile
+++ b/board/amcc/canyonlands/Makefile
@@ -25,10 +25,11 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).a
-COBJS := $(BOARD).o
-COBJS += bootstrap.o
+COBJS-y:= $(BOARD).o
+COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
SOBJS := init.o
+COBJS := $(COBJS-y)
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
SOBJS := $(addprefix $(obj),$(SOBJS))
diff --git a/board/amcc/canyonlands/bootstrap.c
b/board/amcc/canyonlands/bootstrap.c
deleted file mode 100644
index 6dc2cca..000
--- a/board/amcc/canyonlands/bootstrap.c
+++ /dev/null
@@ -1,195 +0,0 @@
-/*
- * (C) Copyright 2008
- * Stefan Roese, DENX Software Engineering, s...@denx.de.
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#include common.h
-#include command.h
-#include i2c.h
-#include asm/io.h
-
-/*
- * NOR and NAND boot options change bytes 5, 6, 8, 9, 11. The
- * values are independent of the rest of the clock settings.
- */
-
-#define NAND_COMPATIBLE0x01
-#define NOR_COMPATIBLE 0x02
-
-#define I2C_EEPROM_ADDR 0x52
-
-static char *config_labels[] = {
- CPU: 600 PLB: 200 OPB: 100 EBC: 100,
- CPU: 800 PLB: 200 OPB: 100 EBC: 100,
- CPU:1000 PLB: 200 OPB: 100 EBC: 100,
- CPU:1066 PLB: 266 OPB: 88 EBC: 88,
- NULL
-};
-
-static u8 boot_configs[][17] = {
- {
- (NAND_COMPATIBLE | NOR_COMPATIBLE),
- 0x86, 0x80, 0xce, 0x1f, 0x79, 0x80, 0x00, 0xa0, 0x40, 0x08,
- 0x23, 0x50, 0x0d, 0x05, 0x00, 0x00
- },
- {
- (NAND_COMPATIBLE | NOR_COMPATIBLE),
- 0x86, 0x80, 0xba, 0x14, 0x99, 0x80, 0x00, 0xa0, 0x40, 0x08,
- 0x23, 0x50, 0x0d, 0x05,
Re: [U-Boot] FW: ARM Pull Request
-Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Thursday, July 23, 2009 11:57 AM To: u-boot@lists.denx.de Cc: Prafulla Wadaskar; Ben Warren; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] FW: ARM Pull Request On Thursday 23 July 2009 08:16:47 Prafulla Wadaskar wrote: I'm working on the repo right now and should have another pull request soon. The 'forced interface' patch is still contentious, so isn't included. Okay With this for RD6281 Build will not fail, but network will be broken. Meanwhile I will check why auto negotiation doesn't work on this board? Did you check if Lennert's comments are correct? Dear Stefan Yes, I have checked. Quote: Isn't it just because on the RD6281A, the first ethernet MAC of the CPU is connected to an ethernet switch chip instead of an ethernet PHY, and therefore there is no negotiation to be done? But auto negotiation works with other board for similar case (i.e. mv88f6281gtw_ge) Only the difference is on rd6281A multichip addressing mode is used. I cannot comment much on this at this moment, this is my observation. So I was planning to debug this part. (The second MAC is connected to a PHY directly, so that one should just use autoneg.) Yes, this is functional on egiga1 Even on the RD6281Z, we should just force the ethernet MAC to a fixed speed/duplex, since even though PHY polling might work there, we'll be talking to the PHY corresponding to the first switch port, which means that you might not be able to tftp from the second switch port or so if there's nothing plugged into the first one. FWIW, the linux kernel port also forces 1000/full on the CPU MACs where a switch chip is connected. On those CPU MACs where there is a switch chip connected, the (R)(G)MII interface becomes purely a bus to transport packets into and out of the crossbar, one that is always up. So, is this ethernet port in question connected to switch? Then a forced link (highest speed) should be used. This is what I was trying to do, but it was through CONGIF_ options and that is applied to both ports, in case we need to force link speed then I need to provide some configurable interface for u-boot kirkwood egiga driver. Regards.. Prafulla . . Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] minor debug cleanups in ./net
On Thu 23 Jul 2009 02:27, Ben Warren pondered:
Robin,
This won't apply:
bwar...@bwarren-bldsrv:~/src/u-boot-net$ git am -s --whitespace=strip
~/h_drive/patches/minor\ debug\ cleanups\ in\ ._net.eml
Applying minor debug cleanups in ./net
fatal: patch fragment without header at line 198: @@ -879,13 +856,13 @@
DhcpHandler(uchar * pkt, unsigned dest, unsigned src, unsigned len)
Patch failed at 0001.
When you have resolved this problem run git-am --resolved.
If you would prefer to skip this patch, instead run git-am --skip.
OK - this is on
git remote -v
origin git://git.denx.de/u-boot-net.git
git log --max-count=1
commit 97cfe86163505ea18e7ff7b71e78df5bb03dad57
(Is there a better way to tell if git is up to date?)
---
From: Robin Getz rg...@blackfin.uclinux.org
Minor ./net cleanups - no functional changes
- change #ifdef DEBUG printf(); #endif to just debug()
- changed __FUNCTION__ to __func__
- got rid of extra whitespace between function and opening brace
- removed unnecessary braces on if statements
gcc dead code elimination should make this functionally/size equivalent
when DEBUG is not defined. (confirmed on Blackfin, with gcc 4.3.3).
Signed-off-by: Robin Getz rg...@blackfin.uclinux.org
---
diff --git a/net/Makefile b/net/Makefile
index 835a04a..ff87d87 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -23,7 +23,7 @@
include $(TOPDIR)/config.mk
-# CFLAGS += -DET_DEBUG -DDEBUG
+# CFLAGS += -DDEBUG
LIB= $(obj)libnet.a
diff --git a/net/bootp.c b/net/bootp.c
index d5f9c4b..0799ae2 100644
--- a/net/bootp.c
+++ b/net/bootp.c
@@ -8,17 +8,6 @@
* Copyright 2000-2004 Wolfgang Denk, w...@denx.de
*/
-#if 0
-#define DEBUG 1 /* general debug */
-#define DEBUG_BOOTP_EXT 1 /* Debug received vendor fields */
-#endif
-
-#ifdef DEBUG_BOOTP_EXT
-#define debug_ext(fmt,args...) printf (fmt ,##args)
-#else
-#define debug_ext(fmt,args...)
-#endif
-
#include common.h
#include command.h
#include net.h
@@ -107,7 +96,7 @@ static int BootpCheckPkt(uchar *pkt, unsigned dest, unsigned
src, unsigned len)
retval = -6;
}
- debug (Filtering pkt = %d\n, retval);
+ debug(Filtering pkt = %d\n, retval);
return retval;
}
@@ -129,7 +118,7 @@ static void BootpCopyNetParams(Bootp_t *bp)
if (strlen(bp-bp_file) 0)
copy_filename (BootFile, bp-bp_file, sizeof(BootFile));
- debug (Bootfile: %s\n, BootFile);
+ debug(Bootfile: %s\n, BootFile);
/* Propagate to environment:
* don't delete exising entry when BOOTP / DHCP reply does
@@ -156,7 +145,7 @@ static void BootpVendorFieldProcess (u8 * ext)
{
int size = *(ext + 1);
- debug_ext ([BOOTP] Processing extension %d... (%d bytes)\n, *ext,
+ debug([BOOTP] Processing extension %d... (%d bytes)\n, *ext,
*(ext + 1));
NetBootFileSize = 0;
@@ -255,7 +244,7 @@ static void BootpVendorProcess (u8 * ext, int size)
{
u8 *end = ext + size;
- debug_ext ([BOOTP] Checking extension (%d bytes)...\n, size);
+ debug([BOOTP] Checking extension (%d bytes)...\n, size);
while ((ext end) (*ext != 0xff)) {
if (*ext == 0) {
@@ -269,34 +258,27 @@ static void BootpVendorProcess (u8 * ext, int size)
}
}
-#ifdef DEBUG_BOOTP_EXT
- puts ([BOOTP] Received fields: \n);
+ debug([BOOTP] Received fields: \n);
if (NetOurSubnetMask)
- printf (NetOurSubnetMask : %pI4\n, NetOurSubnetMask);
+ debug(NetOurSubnetMask : %pI4\n, NetOurSubnetMask);
if (NetOurGatewayIP)
- printf (NetOurGatewayIP: %pI4, NetOurGatewayIP);
+ debug(NetOurGatewayIP : %pI4, NetOurGatewayIP);
- if (NetBootFileSize) {
- printf (NetBootFileSize : %d\n, NetBootFileSize);
- }
+ if (NetBootFileSize)
+ debug(NetBootFileSize : %d\n, NetBootFileSize);
- if (NetOurHostName[0]) {
- printf (NetOurHostName : %s\n, NetOurHostName);
- }
+ if (NetOurHostName[0])
+ debug(NetOurHostName : %s\n, NetOurHostName);
- if (NetOurRootPath[0]) {
- printf (NetOurRootPath : %s\n, NetOurRootPath);
- }
+ if (NetOurRootPath[0])
+ debug(NetOurRootPath : %s\n, NetOurRootPath);
- if (NetOurNISDomain[0]) {
- printf (NetOurNISDomain : %s\n, NetOurNISDomain);
- }
+ if (NetOurNISDomain[0])
+ debug(NetOurNISDomain : %s\n, NetOurNISDomain);
- if (NetBootFileSize) {
- printf (NetBootFileSize: %d\n, NetBootFileSize);
- }
-#endif /* DEBUG_BOOTP_EXT */
+ if (NetBootFileSize)
+ debug(NetBootFileSize: %d\n, NetBootFileSize);
}
/*
* Handle a BOOTP received packet.
@@ -307,7 +289,7 @@ BootpHandler(uchar * pkt, unsigned dest, unsigned src,
unsigned len)
Re: [U-Boot] FW: ARM Pull Request
On Thursday 23 July 2009 08:44:57 Prafulla Wadaskar wrote:
So, is this ethernet port in question connected to switch?
Then a forced link
(highest speed) should be used.
This is what I was trying to do,
but it was through CONGIF_ options and that is applied to both ports,
in case we need to force link speed then I need to provide some
configurable interface for u-boot kirkwood egiga driver.
We have such an interface in the PPC4xx ethernet driver:
drivers/net/4xx_enet.c:
/*+
* Fixed PHY (PHY-less) support for Ethernet Ports.
**/
/*
* Some boards do not have a PHY for each ethernet port. These ports
* are known as Fixed PHY (or PHY-less) ports. For such ports, set
* the appropriate CONFIG_PHY_ADDR equal to CONFIG_FIXED_PHY and
* then define CONFIG_SYS_FIXED_PHY_PORTS to define what the speed and
* duplex should be for these ports in the board configuration
* file.
*
* For Example:
* #define CONFIG_FIXED_PHY 0x
*
* #define CONFIG_PHY_ADDRCONFIG_FIXED_PHY
* #define CONFIG_PHY1_ADDR 1
* #define CONFIG_PHY2_ADDR CONFIG_FIXED_PHY
* #define CONFIG_PHY3_ADDR 3
*
* #define CONFIG_SYS_FIXED_PHY_PORT(devnum,speed,duplex) \
* {devnum, speed, duplex},
*
* #define CONFIG_SYS_FIXED_PHY_PORTS \
* CONFIG_SYS_FIXED_PHY_PORT(0,1000,FULL) \
* CONFIG_SYS_FIXED_PHY_PORT(2,100,HALF)
*/
#ifndef CONFIG_FIXED_PHY
#define CONFIG_FIXED_PHY0x /* Fixed PHY (PHY-less) */
#endif
#ifndef CONFIG_SYS_FIXED_PHY_PORTS
#define CONFIG_SYS_FIXED_PHY_PORTS /* default is an empty array */
#endif
struct fixed_phy_port {
unsigned int devnum;/* ethernet port */
unsigned int speed; /* specified speed 10,100 or 1000 */
unsigned int duplex;/* specified duplex FULL or HALF */
};
static const struct fixed_phy_port fixed_phy_port[] = {
CONFIG_SYS_FIXED_PHY_PORTS /* defined in board configuration file
*/
};
And include/configs/canyonlands.h:
#define CONFIG_FIXED_PHY0x
#define CONFIG_PHY_ADDR CONFIG_FIXED_PHY
#define CONFIG_SYS_FIXED_PHY_PORT(devnum, speed, duplex) \
{devnum, speed, duplex}
#define CONFIG_SYS_FIXED_PHY_PORTS \
CONFIG_SYS_FIXED_PHY_PORT(0, 1000, FULL)
It's definitely not perfect but perhaps you could re-use it for your problem
as well.
Best regards,
Stefan
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] ppc4xx: Add chip_config command to AMCC Kilauea eval board
This patch removes the alterpll command and replaces it with the now
ppc4xx standard chip_config command to configure the I2C bootstrap
EEPROM.
Signed-off-by: Stefan Roese s...@denx.de
---
v2:
- Update identation of chip_config struct
board/amcc/kilauea/Makefile |4 +-
board/amcc/kilauea/chip_config.c | 73 ++
board/amcc/kilauea/cmd_pll.c | 297 --
include/configs/kilauea.h|6 +
4 files changed, 82 insertions(+), 298 deletions(-)
create mode 100644 board/amcc/kilauea/chip_config.c
delete mode 100644 board/amcc/kilauea/cmd_pll.c
diff --git a/board/amcc/kilauea/Makefile b/board/amcc/kilauea/Makefile
index df0a68f..751e9f3 100644
--- a/board/amcc/kilauea/Makefile
+++ b/board/amcc/kilauea/Makefile
@@ -25,8 +25,10 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).a
-COBJS = $(BOARD).o cmd_pll.o
+COBJS-y:= $(BOARD).o
+COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
+COBJS := $(COBJS-y)
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS))
diff --git a/board/amcc/kilauea/chip_config.c b/board/amcc/kilauea/chip_config.c
new file mode 100644
index 000..9a3fc15
--- /dev/null
+++ b/board/amcc/kilauea/chip_config.c
@@ -0,0 +1,73 @@
+/*
+ * (C) Copyright 2009
+ * Stefan Roese, DENX Software Engineering, s...@denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#include common.h
+#include asm/ppc4xx_config.h
+
+struct ppc4xx_config ppc4xx_config_val[] = {
+ {
+ 333-nor,NOR CPU: 333 PLB: 166 OPB: 83 EBC: 83,
+ {
+ 0x8c, 0x12, 0xec, 0x12, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+ {
+ 400-133-nor, NOR CPU: 400 PLB: 133 OPB: 66 EBC: 66,
+ {
+ 0x8e, 0x0e, 0xe8, 0x13, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+ {
+ 400-nor, NOR CPU: 400 PLB: 200 OPB: 100 EBC: 100,
+ {
+ 0x8e, 0x0e, 0xe8, 0x12, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+ {
+ 533-nor, NOR CPU: 533 PLB: 177 OPB: 88 EBC: 88,
+ {
+ 0x8e, 0x43, 0x60, 0x13, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+ {
+ 600-nor, NOR CPU: 600 PLB: 200 OPB: 100 EBC: 100,
+ {
+ 0x8d, 0x02, 0x34, 0x13, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+ {
+ 666-nor, NOR CPU: 666 PLB: 222 OPB: 111 EBC: 111,
+ {
+ 0x8d, 0x03, 0x78, 0x13, 0x98, 0x00, 0x0a, 0x00,
+ 0x40, 0x08, 0x23, 0x50, 0x00, 0x05, 0x00, 0x00
+ }
+ },
+};
+
+int ppc4xx_config_count = ARRAY_SIZE(ppc4xx_config_val);
diff --git a/board/amcc/kilauea/cmd_pll.c b/board/amcc/kilauea/cmd_pll.c
deleted file mode 100644
index 9bae67e..000
--- a/board/amcc/kilauea/cmd_pll.c
+++ /dev/null
@@ -1,297 +0,0 @@
-/*
- * (C) Copyright 2000, 2001
- * Wolfgang Denk, DENX Software Engineering, w...@denx.de.
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite
Re: [U-Boot] [PATCH] ppc4xx: Replace 4xx lowercase SPR references
Hi Wolfgang, Matthias is not available for 2 days, so I'll answer instead. On Wednesday 22 July 2009 17:42:40 Wolfgang Denk wrote: Dear Matthias Fuchs, In message 200907221727.56402.matthias.fu...@esd.eu you wrote: Signed-off-by: Matthias Fuchs matthias.fu...@esd.eu .. board/esd/pmc440/pmc440.c |2 +- board/mpl/mip405/mip405.c |2 +- board/mpl/pip405/pip405.c |2 +- board/netstal/hcu5/hcu5.c |8 +- board/netstal/hcu5/sdram.c |4 +- board/netstal/mcu25/mcu25.c |2 +- cpu/ppc4xx/cpu.c|8 +- cpu/ppc4xx/cpu_init.c |2 +- cpu/ppc4xx/interrupts.c | 18 ++-- cpu/ppc4xx/speed.c |3 +- cpu/ppc4xx/start.S | 206 +- include/asm-ppc/processor.h | 46 ++ include/ppc405.h| 55 include/ppc440.h| 93 --- post/cpu/ppc4xx/fpu.c |6 +- 15 files changed, 178 insertions(+), 279 deletions(-) I understand the include/asm-ppc/processor.h changes are in sync with the Linux version of this file? No, it's not in sync with the Linux version. Reason is, that the Linux version you are referring to was an very old arch/ppc version. The current arch/powerpc version is completely different. No SPRN defines in this file any more. But I'll double check the new defines in processor.h before applying this patch. If so: Acked-by: Wolfgang Denk w...@denx.de I hope you don't withdraw your Acked-by now. I would really like to apply this patch soon. Thanks. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Use do_div from div64.h for vsprintf
On Wednesday 22 July 2009 17:51:56 Dirk Behme wrote: Use do_div from div64.h for vsprintf in case of 64bit division. For 32bit division, do_div from div64.h can't be used as it needs a 64bit parameter. Signed-off-by: Dirk Behme dirk.be...@googlemail.com CC: Simon Kagstrom simon.kagst...@netinsight.net I just did some testing on the image size effect of this patch. All this is done on Canyonlands (PPC4xx): a) Without 64bit printf support, without this patch b) With 64bit printf support, without this patch c) With 64bit printf support, with this patch Image-type Image-size --- a 351028 b 352536 c 351400 So without this patch the 64bit printf support increases the image size by 5390 bytes and with this patch by only 984 bytes. So ack from me for this patch: Acked-by: Stefan Roese s...@denx.de Thanks. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] kirkwood sheevaplug - broken build using git.denx.de/u-boot.git
Hi all, I've tried to build u-boot for sheevaplug from git.denx.de/u-boot.git Is this expected to work or are there some missing dependencies or what am I doing wrong? (The same happens on u-boot-arm custodian tree. Only Prafullas tree from git.marvell.com allows me to build u-boot for sheevaplug.) The build gives me following error (without any prior warnings!): make[1]: Verlasse Verzeichnis '/home/dieter/git/u-boot/u-boot.git/cpu/arm926ejs' UNDEF_SYM=`arm-none-linux-gnueabi-objdump -x board/Marvell/sheevaplug/libsheevaplug.a lib_generic/libgeneric.a lib_generic/lzma/liblzma.a lib_generic/lzo/liblzo.a cpu/arm926ejs/libarm926ejs.a cpu/arm926ejs/kirkwood/libkirkwood.a lib_arm/libarm.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a fs/yaffs2/libyaffs2.a fs/ubifs/libubifs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/fpga/libfpga.a drivers/gpio/libgpio.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mmc/libmmc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/onenand/libonenand.a drivers/mtd/ubi/libubi.a drivers/mtd/spi/libspi_flash.a drivers/net/libnet.a drivers/net/phy/libphy.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/twserial/libtws.a drivers/usb/gadget/libusb_gadget.a drivers/usb/host/libusb_host.a drivers/usb/musb/libusb_musb.a drivers/video/libvideo.a drivers/watchdog/libwatchdog.a common/libcommon.a libfdt/libfdt.a api/libapi.a post/libpost.a | sed -n -e 's/.*\(__u_boot_cmd_.*\)/-u\1/p'|sort|uniq`; cd /home/dieter/git/u-boot/u-boot.git arm-none-linux-gnueabi-ld -Bstatic -T /home/dieter/git/u-boot/u-boot.git/cpu/arm926ejs/u-boot.lds -Ttext 0x0060 $UNDEF_SYM cpu/arm926ejs/start.o --start-group lib_generic/libgeneric.a lib_generic/lzma/liblzma.a lib_generic/lzo/liblzo.a cpu/arm926ejs/libarm926ejs.a cpu/arm926ejs/kirkwood/libkirkwood.a lib_arm/libarm.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a fs/yaffs2/libyaffs2.a fs/ubifs/libubifs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/fpga/libfpga.a drivers/gpio/libgpio.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mmc/libmmc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/onenand/libonenand.a drivers/mtd/ubi/libubi.a drivers/mtd/spi/libspi_flash.a drivers/net/libnet.a drivers/net/phy/libphy.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/twserial/libtws.a drivers/usb/gadget/libusb_gadget.a drivers/usb/host/libusb_host.a drivers/usb/musb/libusb_musb.a drivers/video/libvideo.a drivers/watchdog/libwatchdog.a common/libcommon.a libfdt/libfdt.a api/libapi.a post/libpost.a board/Marvell/sheevaplug/libsheevaplug.a --end-group -L /opt/Orion-SDK/armel-2.0/tools/gcc/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.0 -lgcc -Map u-boot.map -o u-boot arm-none-linux-gnueabi-ld: ERROR: Source object /opt/Orion-SDK/armel-2.0/tools/gcc/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.0/libgcc.a(_lshrdi3.o) has EABI version 4, but target u-boot has EABI version 0 arm-none-linux-gnueabi-ld: failed to merge target specific data of file /opt/Orion-SDK/armel-2.0/tools/gcc/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.0/libgcc.a(_lshrdi3.o) make: *** [u-boot] Fehler 1 Used gcc is: arm-none-linux-gnueabi-gcc (GCC) 4.2.0 20070413 (prerelease) Any hints are very welcome. Many thanks, Dieter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] FW: ARM Pull Request
On Wed, Jul 22, 2009 at 11:44:57PM -0700, Prafulla Wadaskar wrote: Isn't it just because on the RD6281A, the first ethernet MAC of the CPU is connected to an ethernet switch chip instead of an ethernet PHY, and therefore there is no negotiation to be done? But auto negotiation works with other board for similar case (i.e. mv88f6281gtw_ge) Only the difference is on rd6281A multichip addressing mode is used. I cannot comment much on this at this moment, this is my observation. So I was planning to debug this part. In single-chip address mode, you'll still only be talking to one of the five PHYs that the switch chip has, and things like forcing link modes or checking whether the link is up will only work on one of the five ports. So if you're checking the PHY registers to make sure the link is up before you e.g. start sending DHCP requests, then that won't do what you want even though it will appear to work in single-chip address mode. If you're providing a way to force certain ports to certain speeds from the uboot command line, then you should ideally just implement multi-chip addressing mode and allow access to the individual PHYs, I guess. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] kirkwood sheevaplug - broken build using git.denx.de/u-boot.git
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Dieter Kiermaier Sent: Thursday, July 23, 2009 2:13 PM To: u-boot@lists.denx.de Subject: [U-Boot] kirkwood sheevaplug - broken build using git.denx.de/u-boot.git Hi all, I've tried to build u-boot for sheevaplug from git.denx.de/u-boot.git Is this expected to work or are there some missing dependencies or what am I doing wrong? Dear Dieter No it will not work at this moment. (The same happens on u-boot-arm custodian tree. Only Prafullas tree from git.marvell.com allows me to build u-boot for sheevaplug.) I have added few patches and u-boot-kw.git at git.marvell.com is full functional for sheevaplug. It is also in sync with latest u-boot.git/master Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] kirkwood sheevaplug - broken build using git.denx.de/u-boot.git
Hi Prafulla, -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Dieter Kiermaier Sent: Thursday, July 23, 2009 2:13 PM To: u-boot@lists.denx.de Subject: [U-Boot] kirkwood sheevaplug - broken build using git.denx.de/u-boot.git Hi all, I've tried to build u-boot for sheevaplug from git.denx.de/u-boot.git Is this expected to work or are there some missing dependencies or what am I doing wrong? Dear Dieter No it will not work at this moment. ok (The same happens on u-boot-arm custodian tree. Only Prafullas tree from git.marvell.com allows me to build u-boot for sheevaplug.) I have added few patches and u-boot-kw.git at git.marvell.com is full functional for sheevaplug. It is also in sync with latest u-boot.git/master Thanks, so I've overseen this. I thought I've looked at it before I start trying denx u-boot.git because I missed some patches. Sorry for the noise, Dieter Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] How to start U-Boot for i.MX31 NAND out of RedBoot (out of RAM)
Hi 2009/7/22 Ulrich Gerster gerst...@dhbw-loerrach.de: Hello Magnus Lilja lilja.mag...@gmail.com 14.07.09 19.43 Uhr Hi 2009/7/14 Ulrich Gerster gerst...@dhbw-loerrach.de: Hello. Magnus Lilja lilja.mag...@gmail.com 14.07.09 16.03 Uhr I used the patch from you out of this posting: [U-Boot-Users] [PATCH RFC 3/5] i.MX31: Add i.MX31 NAND Flash Controller driver. http://lists.denx.de/pipermail/u-boot/2008-August/038239.html They should work, or not? Do they require something else? I haven't tried that driver on a recent U-boot so I don't know if (or how) it will work when applied to a recent U-Boot. I'm using the u-boot master release of middle of June. How can I ensure that your patch is working? Or how do I know what is missing that it works? You need to use either a debugger or add printf's to see what's going on (to the mxc_nd.c or whatever the file is called. I have the drivers working now. But there's a little problem left. When I try to use u-boot to update itself (write itself from RAM to Flash) it seems that it overwrites the out of band information too. That's normal since writing new data means writing a new error correcting code. So when I try to reboot nothing is working because every program assumes that the first blocks are bad. Do you have a suggestion how to fix that issue? Not sure that I understand what every program assumes... means. But my guess is that the OOB layout may be different in nand_spl/nand_boot_fsl_nfc.c compared to drivers/mtd/nand/mxc_nd.c so the nand_spl may interpret the OOB information that mxc_nd.c has written in a different way. This is especially true for large page NAND since the i.MX31 controller uses a non-standard layout, for small page NAND there should be no problem (although I don't know if nand_spl has been tested on small page nand yet). /Magnus ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 v6] Make libgcc inclusion from common Makefile overridable by platform config file
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1247135043-3494-1-git-send-email-plagn...@jcrosoft.com you wrote: This patch allows to override the libgcc Makefile inclusion from the toplevel Makefile by the arch config.mk files. This is in preparation for the ARM architecture to move away from including libgcc functions and only using self-contained U-Boot functions as done in Linux. Currently all the ARM boards that use NAND are broken due to the addition of 64 Bit device size support. In the past we have seen similar problems with different tool chains due to EABI and FPU for example. With this patch and this one: ARM: Don't include libgcc anymore we move away from all these problems on ARM since we don't include any functions from libgcc anymore. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Acked-by: Mike Frysinger vap...@gentoo.org As discussed before, I rejected this patch because it seems wrong to me 1) to assume that all ARM tool chains have a broken/unusable implementation of the libgcc runtime support library, 2) I don't want to make a workaround for a broken tool chain the default setting, and 3) we should not restrict this to the ARM architecture but allow the same for other architectures as well. I suggested another approach in http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/63156/focus=63550 but no one commented on this. As there are some people suffereing from the current situation and no progress has been visible for some time, I wll soon post a patch that implements my proposal. Hope this allows to bring this topic to an end. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de But it's real. And if it's real it can be affected ... we may not be able to break it, but, I'll bet you credits to Navy Beans we can put a dent in it. -- deSalle, Catspaw, stardate 3018.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
Dear Prafulla Wadaskar, In message 73173d32e9439e4abb5151606c3e19e202de13b...@sc-vexch1.marvell.com you wrote: The arm build is broken at this moment on u-boot.git/master I have tested for kirkwood boards using nand (i.e. Sheevaplug and RD6281A) same should be the case for other ARM boards using NAND flash. The following patches from jean needed for successful build. But those cannot be applied cleanly. http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=5b30fe639c3ca0141d78820be74ce26120056116 http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=009130ac00f4679516c6bb5a20f9a97eec98e6bc These have been rejected and will NOT make it into mainline. I will post a different solution soon. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The optimum committee has no members. - Norman Augustine ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc4xx: Replace 4xx lowercase SPR references
Dear Stefan Roese, In message 200907230930.08298...@denx.de you wrote: No, it's not in sync with the Linux version. Reason is, that the Linux version you are referring to was an very old arch/ppc version. The current arch/powerpc version is completely different. No SPRN defines in this file any more. No, I did use the current code from arch/powerpc/include; I just didn't mention that it's split there into several files like asm/reg.h, asm/reg_booke.h etc. But I'll double check the new defines in processor.h before applying this patch. OK, that's all I wanted to make sure :-) I hope you don't withdraw your Acked-by now. I would really like to apply this patch soon. I still ACK it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The first thing we do is kill all the lawyers. (Shakespeare. II Henry VI, Act IV, scene ii) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Make linking against libgcc configurable
Many (especially ARM) tool chains seem to come with broken or otherwise unusable (for the purposes of builing U-Boot) run-time support libraries `libgcc.a'. By using the USE_PRIVATE_LIBGCC setting we allow to use alternative libraries instead. USE_PRIVATE_LIBGCC can either be set as an environment variable in the shell, or as a command line argument when running make, i. e. $ make USE_PRIVATE_LIBGCC=yes or $ USE_PRIVATE_LIBGCC=yes $ export USE_PRIVATE_LIBGCC $ make The value of USE_PRIVATE_LIBGCC is the name of the directory which contains the alternative run-time support library `libgcc.a'. The special value yes selects the directory $(OBJTREE)/lib_$(ARCH) . Note that not all architectures provide an alternative `libgcc.a' in their lib_$(ARCH) directories - so far, only ARM does. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Prafulla Wadaskar prafu...@marvell.com cc: Stefan Roese s...@denx.de --- Makefile| 12 +++- board/trab/Makefile |4 +--- lib_arm/Makefile| 31 +++ 3 files changed, 35 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 25a6254..7c99ac2 100644 --- a/Makefile +++ b/Makefile @@ -247,7 +247,17 @@ LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).a LIBBOARD := $(addprefix $(obj),$(LIBBOARD)) # Add GCC lib -PLATFORM_LIBS += -L $(shell dirname `$(CC) $(CFLAGS) -print-libgcc-file-name`) -lgcc +ifdef USE_PRIVATE_LIBGCC +ifeq ($(USE_PRIVATE_LIBGCC), yes) +PLATFORM_LIBGCC = -L $(OBJTREE)/lib_$(ARCH) -lgcc +else +PLATFORM_LIBGCC = -L $(USE_PRIVATE_LIBGCC) -lgcc +endif +else +PLATFORM_LIBGCC = -L $(shell dirname `$(CC) $(CFLAGS) -print-libgcc-file-name`) -lgcc +endif +PLATFORM_LIBS += $(PLATFORM_LIBGCC) +export PLATFORM_LIBS ifeq ($(CONFIG_NAND_U_BOOT),y) NAND_SPL = nand_spl diff --git a/board/trab/Makefile b/board/trab/Makefile index 3a92c0d..2afad88 100644 --- a/board/trab/Makefile +++ b/board/trab/Makefile @@ -36,8 +36,6 @@ SOBJS := $(addprefix $(obj),$(SOBJS)) OBJS_FKT := $(addprefix $(obj),$(COBJS_FKT)) -gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`) - LOAD_ADDR = 0xc10 # @@ -52,7 +50,7 @@ $(obj)trab_fkt.srec: $(OBJS_FKT) $(LIB) -L$(obj)../../examples/standalone -lstubs \ -L$(obj)../../lib_generic -lgeneric \ $(obj)../../lib_arm/div0.o \ - $(obj)../../lib_arm/_*.o + $(PLATFORM_LIBS) $(OBJCOPY) -O srec $(:.o=) $@ $(obj)trab_fkt.bin:$(obj)trab_fkt.srec diff --git a/lib_arm/Makefile b/lib_arm/Makefile index 4469361..30922a6 100644 --- a/lib_arm/Makefile +++ b/lib_arm/Makefile @@ -24,13 +24,17 @@ include $(TOPDIR)/config.mk LIB= $(obj)lib$(ARCH).a +LIBGCC = $(obj)libgcc.a -SOBJS-y+= _ashldi3.o -SOBJS-y+= _ashrdi3.o -SOBJS-y+= _divsi3.o -SOBJS-y+= _modsi3.o -SOBJS-y+= _udivsi3.o -SOBJS-y+= _umodsi3.o +GLSOBJS+= _ashldi3.o +GLSOBJS+= _ashrdi3.o +GLSOBJS+= _lshrdi3.o +GLSOBJS+= _divsi3.o +GLSOBJS+= _modsi3.o +GLSOBJS+= _udivsi3.o +GLSOBJS+= _umodsi3.o + +GLCOBJS+= div0.o COBJS-y+= board.o COBJS-y+= bootm.o @@ -38,16 +42,27 @@ COBJS-y += cache.o ifndef CONFIG_SYS_NO_CP15_CACHE COBJS-y+= cache-cp15.o endif -COBJS-y+= div0.o COBJS-y+= interrupts.o COBJS-y+= reset.o -SRCS := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c) +SRCS := $(GLSOBJS:.o=.S) $(GLCOBJS:.o=.c) \ + $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c) OBJS := $(addprefix $(obj),$(SOBJS-y) $(COBJS-y)) +LGOBJS := $(addprefix $(obj),$(GLSOBJS)) \ + $(addprefix $(obj),$(GLCOBJS)) + +ifdef USE_PRIVATE_LIBGCC +all: $(LIB) $(LIBGCC) +else +all: $(LIB) +endif $(LIB):$(obj).depend $(OBJS) $(AR) $(ARFLAGS) $@ $(OBJS) +$(LIBGCC): $(obj).depend $(LGOBJS) + $(AR) $(ARFLAGS) $@ $(LGOBJS) + # # defines $(obj).depend target -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] Make linking against libgcc configurable
Many (especially ARM) tool chains seem to come with broken or otherwise unusable (for the purposes of builing U-Boot) run-time support libraries `libgcc.a'. By using the USE_PRIVATE_LIBGCC setting we allow to use alternative libraries instead. USE_PRIVATE_LIBGCC can either be set as an environment variable in the shell, or as a command line argument when running make, i. e. $ make USE_PRIVATE_LIBGCC=yes or $ USE_PRIVATE_LIBGCC=yes $ export USE_PRIVATE_LIBGCC $ make The value of USE_PRIVATE_LIBGCC is the name of the directory which contains the alternative run-time support library `libgcc.a'. The special value yes selects the directory $(OBJTREE)/lib_$(ARCH) . Note that not all architectures provide an alternative `libgcc.a' in their lib_$(ARCH) directories - so far, only ARM does. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Prafulla Wadaskar prafu...@marvell.com cc: Stefan Roese s...@denx.de --- v2: Removed crap left over from testing. Makefile| 12 +++- board/trab/Makefile |4 +--- lib_arm/Makefile| 30 ++ 3 files changed, 34 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 25a6254..7c99ac2 100644 --- a/Makefile +++ b/Makefile @@ -247,7 +247,17 @@ LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).a LIBBOARD := $(addprefix $(obj),$(LIBBOARD)) # Add GCC lib -PLATFORM_LIBS += -L $(shell dirname `$(CC) $(CFLAGS) -print-libgcc-file-name`) -lgcc +ifdef USE_PRIVATE_LIBGCC +ifeq ($(USE_PRIVATE_LIBGCC), yes) +PLATFORM_LIBGCC = -L $(OBJTREE)/lib_$(ARCH) -lgcc +else +PLATFORM_LIBGCC = -L $(USE_PRIVATE_LIBGCC) -lgcc +endif +else +PLATFORM_LIBGCC = -L $(shell dirname `$(CC) $(CFLAGS) -print-libgcc-file-name`) -lgcc +endif +PLATFORM_LIBS += $(PLATFORM_LIBGCC) +export PLATFORM_LIBS ifeq ($(CONFIG_NAND_U_BOOT),y) NAND_SPL = nand_spl diff --git a/board/trab/Makefile b/board/trab/Makefile index 3a92c0d..2afad88 100644 --- a/board/trab/Makefile +++ b/board/trab/Makefile @@ -36,8 +36,6 @@ SOBJS := $(addprefix $(obj),$(SOBJS)) OBJS_FKT := $(addprefix $(obj),$(COBJS_FKT)) -gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`) - LOAD_ADDR = 0xc10 # @@ -52,7 +50,7 @@ $(obj)trab_fkt.srec: $(OBJS_FKT) $(LIB) -L$(obj)../../examples/standalone -lstubs \ -L$(obj)../../lib_generic -lgeneric \ $(obj)../../lib_arm/div0.o \ - $(obj)../../lib_arm/_*.o + $(PLATFORM_LIBS) $(OBJCOPY) -O srec $(:.o=) $@ $(obj)trab_fkt.bin:$(obj)trab_fkt.srec diff --git a/lib_arm/Makefile b/lib_arm/Makefile index 4469361..241782c 100644 --- a/lib_arm/Makefile +++ b/lib_arm/Makefile @@ -24,13 +24,16 @@ include $(TOPDIR)/config.mk LIB= $(obj)lib$(ARCH).a +LIBGCC = $(obj)libgcc.a -SOBJS-y+= _ashldi3.o -SOBJS-y+= _ashrdi3.o -SOBJS-y+= _divsi3.o -SOBJS-y+= _modsi3.o -SOBJS-y+= _udivsi3.o -SOBJS-y+= _umodsi3.o +GLSOBJS+= _ashldi3.o +GLSOBJS+= _ashrdi3.o +GLSOBJS+= _divsi3.o +GLSOBJS+= _modsi3.o +GLSOBJS+= _udivsi3.o +GLSOBJS+= _umodsi3.o + +GLCOBJS+= div0.o COBJS-y+= board.o COBJS-y+= bootm.o @@ -38,16 +41,27 @@ COBJS-y += cache.o ifndef CONFIG_SYS_NO_CP15_CACHE COBJS-y+= cache-cp15.o endif -COBJS-y+= div0.o COBJS-y+= interrupts.o COBJS-y+= reset.o -SRCS := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c) +SRCS := $(GLSOBJS:.o=.S) $(GLCOBJS:.o=.c) \ + $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c) OBJS := $(addprefix $(obj),$(SOBJS-y) $(COBJS-y)) +LGOBJS := $(addprefix $(obj),$(GLSOBJS)) \ + $(addprefix $(obj),$(GLCOBJS)) + +ifdef USE_PRIVATE_LIBGCC +all: $(LIB) $(LIBGCC) +else +all: $(LIB) +endif $(LIB):$(obj).depend $(OBJS) $(AR) $(ARFLAGS) $@ $(OBJS) +$(LIBGCC): $(obj).depend $(LGOBJS) + $(AR) $(ARFLAGS) $@ $(LGOBJS) + # # defines $(obj).depend target -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: add _lshrdi3.S
Dear Heiko Schocher, In message 4a684908.8070...@invitel.hu you wrote: Signed-off-by: Heiko Schocher h...@denx.de --- lib_arm/Makefile |1 + lib_arm/_lshrdi3.S | 46 ++ 2 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 lib_arm/_lshrdi3.S Why should we add this? Where it is needed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The nice thing about standards is that there are so many to choose from. - Andrew S. Tanenbaum ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: add _lshrdi3.S
Hello Wolfgang, Wolfgang Denk wrote: In message 4a684908.8070...@invitel.hu you wrote: Signed-off-by: Heiko Schocher h...@denx.de --- lib_arm/Makefile |1 + lib_arm/_lshrdi3.S | 46 ++ 2 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 lib_arm/_lshrdi3.S Why should we add this? Where it is needed? This is needed for the upcoming suen3 support. Maybe I sould have written this in the commit message? This board uses NAND, and if I compile it, I get this errors: [...@pollux u-boot]$ make mrproper [...@pollux u-boot]$ make suen3_config Configuring for suen3 board... [...@pollux u-boot]$ make USE_PRIVATE_LIBGCC=yes -s all drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' /home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_base.c:2198: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_read_oob': /home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_base.c:1519: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o): In function `search_bbt': /home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_bbt.c:482: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o):/home/hs/keymile/suen3/u-boot/drivers/mtd/nand/nand_bbt.c:413: more undefined references to `__lshrdi3' follow make: *** [u-boot] Fehler 1 [...@pollux u-boot]$ above patch fixes this. And I thought better to post such a fix immediately ... bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Hi Wolfgang, buid on meesc board (arm) is still broken. It's roughly the same problem, as Heiko Schocher reported in 4a6854b1.5000...@denx.de. But his patch doesn't fix the problem either. dani...@debby:~/git/u-boot$ make USE_PRIVATE_LIBGCC=yes ... drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2198: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_read_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:1519: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o): In function `search_bbt': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:482: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o):/data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:413: more undefined references to `__lshrdi3' follow lib_generic/libgeneric.a(vsprintf.o): In function `put_dec': /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__umoddi3' /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__udivdi3' lib_generic/libgeneric.a(vsprintf.o): In function `number': /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:306: undefined reference to `__lshrdi3' make: *** [u-boot] Error 1 Best regards, Daniel Wolfgang Denk wrote: Many (especially ARM) tool chains seem to come with broken or otherwise unusable (for the purposes of builing U-Boot) run-time support libraries `libgcc.a'. By using the USE_PRIVATE_LIBGCC setting we allow to use alternative libraries instead. USE_PRIVATE_LIBGCC can either be set as an environment variable in the shell, or as a command line argument when running make, i. e. $ make USE_PRIVATE_LIBGCC=yes or $ USE_PRIVATE_LIBGCC=yes $ export USE_PRIVATE_LIBGCC $ make The value of USE_PRIVATE_LIBGCC is the name of the directory which contains the alternative run-time support library `libgcc.a'. The special value yes selects the directory $(OBJTREE)/lib_$(ARCH) . Note that not all architectures provide an alternative `libgcc.a' in their lib_$(ARCH) directories - so far, only ARM does. Signed-off-by: Wolfgang Denk w...@denx.de ... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] http client?
I played around with setting the TFTP block size very large, like 16K,
primarily to reduce the required number of ACK's. It actually appeared as
though uboot was processing the additional frames correctly but without
doing a memory comparison I'm not sure. Here were a few bad side effects
though...
- blksize set to 16K, when fetching a 10 byte file it thinks it's
downloading a 6000 byte file
- The last packet appears to mess things up. The majority of the
transfer goes very well and then at the very end it hangs. Likely the
portion of tftp.c that checks when the file is completed.
UDP packets are either not fragmented or very easy to re-assemble. When
doing a tcpdump the udp packets go out as 1500 byte chunks. A 16K tftp block
gets broken into 11 consecutive packets and requires only 1 ACK. Because
packets can come in out of order and uboot is not very network oriented, I
would suggest just dumping the entire block if a packet comes in out of
order and re-request that block.
Anyways, you can jump right in by setting the blksize to a large number and
see how it behaves.
When I looked at the RFC data
it appears that the overhead of IP fragmentation and reassembly
(which does add overhead as the number of gateways increases) may be
worth the time...
Just tried it: U-Boot doesn't support reassembly, it seems.
I don't think anyone said it did.
net.c confirms it:
/* Can't deal with fragments */
if (ip-ip_off htons(IP_OFFS | IP_FLAGS_MFRAG)) {
return;
}
I don't think it's worth adding.
This is based on ... ?
If it reduces download time by 1/2 (1432 byte block size == 13.70 seconds,
4096 byte block size == 6.85 seconds) it might be worth the complexity...
At least worth it enough to give it a try, gather some results, and then
make a decision.
-Robin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Hello Daniel, Daniel Gorsulowski wrote: buid on meesc board (arm) is still broken. It's roughly the same problem, as Heiko Schocher reported in 4a6854b1.5000...@denx.de. But his patch doesn't fix the problem either. dani...@debby:~/git/u-boot$ make USE_PRIVATE_LIBGCC=yes ... drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2198: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_read_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:1519: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o): In function `search_bbt': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:482: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o):/data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:413: more undefined references to `__lshrdi3' follow lib_generic/libgeneric.a(vsprintf.o): In function `put_dec': /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__umoddi3' /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__udivdi3' Maybe you need also this fix from Dirk Behme http://lists.denx.de/pipermail/u-boot/2009-July/057265.html I see on this Hardware is CONFIG_SYS_64BIT_VSPRINTF activated ... so I think, the above patch will fix this. Can you give this a try? bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Hello Heiko, Dirks patch reduces the errors, but I still get: drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2198: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_read_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:1519: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o): In function `search_bbt': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:482: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o):/data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:413: more undefined references to `__lshrdi3' follow make: *** [u-boot] Error 1 I noticed, that lib_arm/_lshrdi3.a is not beeing compiled. So i added 'GLSOBJS += _lshrdi3.S' to lib_arm/Makefile (this line is missing in your patch, i guess). But _lshrdi3.a still does not compile. So I took a look at lib_arm/.depend: _ashldi3.o: _ashldi3.S _ashrdi3.o: _ashrdi3.S _divsi3.o: _divsi3.S _lshrdi3.o: _lshrdi3.S _modsi3.o: _modsi3.S _udivsi3.o: _udivsi3.S _umodsi3.o: _umodsi3.S I have no explanation for that, do you have? bye, Daniel Heiko Schocher wrote: Hello Daniel, Daniel Gorsulowski wrote: buid on meesc board (arm) is still broken. It's roughly the same problem, as Heiko Schocher reported in 4a6854b1.5000...@denx.de. But his patch doesn't fix the problem either. dani...@debby:~/git/u-boot$ make USE_PRIVATE_LIBGCC=yes ... drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2198: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_read_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:1519: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o): In function `search_bbt': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:482: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_bbt.o):/data/home/danielg/git/u-boot/drivers/mtd/nand/nand_bbt.c:413: more undefined references to `__lshrdi3' follow lib_generic/libgeneric.a(vsprintf.o): In function `put_dec': /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__umoddi3' /data/home/danielg/git/u-boot/lib_generic/vsprintf.c:242: undefined reference to `__udivdi3' Maybe you need also this fix from Dirk Behme http://lists.denx.de/pipermail/u-boot/2009-July/057265.html I see on this Hardware is CONFIG_SYS_64BIT_VSPRINTF activated ... so I think, the above patch will fix this. Can you give this a try? bye Heiko ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Sorry, it was my misstake. By cp and applying yout patch I missed the changes in lib_arm/Makefile. But as i wrote, _lshrdi3.a does not compile. Daniel Daniel Gorsulowski wrote: So i added 'GLSOBJS += _lshrdi3.S' to lib_arm/Makefile (this line is missing in your patch, i guess). But _lshrdi3.a still does not compile. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] ubi attaching error (UBI error: ubi_read_volume_table)
Hi All, I am using flex-onenand for my u-boot. i have added the patch for flex-onenand and UBI and UBIFS published by kyungmin park. I have done following steps: 1. first command # onenand erase 0x4 0x20 2. second command # mtdparts default 3. third commad # mtdparts 4. forth command # ubi part u-boot (i got error UBI error: ubi_read_volume_table: the layout volume was not found attach_by_scanning-4 UBI error: ubi_init: cannot attach mtd1 UBI error: ubi_init: UBI error: cannot initialize UBI, error -22 UBI init error -22 ) a) first command out put 1. # mtdparts default ---mtdparts_init--- last_ids : onenand0=onenand env_ids : onenand0=onenand last_parts: mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) env_parts : mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) last_partition : onenand0,0 env_partition : NULL no partition variable set, setting... --- current_save --- = partition onenand0,0 --- index partitions --- --- mtd_part_info: partition number 0 for device onenand0 (onenand) = mtddevnum 0, = mtddevname u-boot 2. second command output # mtdparts ---mtdparts_init--- last_ids : onenand0=onenand env_ids : onenand0=onenand last_parts: mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) env_parts : mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) last_partition : onenand0,0 env_partition : onenand0,0 ---list_partitions--- device onenand0 onenand, # parts = 6 #: namesizeoffset mask_flags 0: u-boot 0x0020 0x0004 0 1: params 0x0004 0x0024 0 2: kernel 0x0020 0x0028 0 3: rootfs 0x0100 0x0048 0 4: fs 0x0200 0x0148 0 5: ubifs 0x3c48 0x0348 0 --- mtd_part_info: partition number 0 for device onenand0 (onenand) active partition: onenand0,0 - (u-boot) 0x0020 @ 0x0004 defaults: mtdids : onenand0=onenand mtdparts: mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs),3 2m(fs),-(ubifs) 3. Third command output # ubi part u-boot ---mtdparts_init--- last_ids : onenand0=onenand env_ids : onenand0=onenand last_parts: mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) env_parts : mtdparts=onenand:2...@256k(u-boot),256k(params),2m(kernel),16m(rootfs) ,32m(fs),-(ubifs) last_partition : onenand0,0 env_partition : onenand0,0 448 do_ubi -1454 do_ubi -2466 do_ubi -5--- find_dev_and_part --- id = u-boot --- find_dev_and_part --- id = u-boot Creating 1 MTD partitions on onenand0: 0x%lx-0x%lx : UBI: attaching mtd1 to ubi0 ubi_attach_mtd_dev UBI: min_io_size 2048 UBI: hdrs_min_io_size 512 UBI: ec_hdr_alsize512 UBI: vid_hdr_alsize 512 UBI: vid_hdr_offset 512 UBI: vid_hdr_aloffset 512 UBI: vid_hdr_shift0 UBI: leb_start2048 UBI: physical eraseblock size: 131072 bytes (128 KiB) UBI: logical eraseblock size:129024 bytes UBI: smallest flash I/O unit:2048 UBI: sub-page size: 512 UBI: VID header offset: 512 (aligned 512) UBI: data offset:2048 UBI error: ubi_read_volume_table: the layout volume was not found attach_by_scanning-4 UBI error: ubi_init: cannot attach mtd1 UBI error: ubi_init: UBI error: cannot initialize UBI, error -22 UBI init error -22 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] MPC8360ERDK - DDR Controller and DDR2 Memory initialization/configuration
Hi, For the MPC8360ERDK, U-Boot configures the Micron DDR2 chips (in MPC8360ERDK.h) inconsistently with the chip's data sheet specifications (e.g., for the -3 speed grade part, the CAS Latency is specified to be 5, but the software uses 3). I'm looking for any information/input as to how the DDR controller and DDR2 chip settings were derived since most of the settings don't match the chip's specifications. I notice that a lot of the U-Boot settings are 2 clock cycles less than what is specified for the chip. Is this merely a coincedence or is there an inherent 2 clock cycle delay in the hardware? Any help is greatly appreciated. Thanks. Christopher M. Fairfax Sr. Software Engineer Rockwell Collins +1 540-428-3344 +1 540-428-3301 cmfai...@rockwellcollins.com This message contains PRIVILEGED AND PROPRIETARY INFORMATION intended solely for the use of the addressee(s) named above. Any disclosure, distribution, copying or use of the information by others is strictly prohibited. If you have received this message in error, please advise the sender by immediate reply and delete the original message. Thank you. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] 85xx: Fix mapping of 0xfffffxxx when CONFIG_MP
On Jul 22, 2009, at 10:47 AM, Peter Tyser wrote: Hi Kumar, I understand what the patch does. It just removes the capability of soft-resetting a core back into the boot translation code. I understand your problem I'm just not keen on solving it by completely disabling boot translation. We had a similar memory map and I moved away from it because of the reset vector issues. Additionally, things like 4G of memory also start creeping up. I'm not super familiar with how the MP support in U-Boot is used. Would you be resetting a secondary core for debug purposes? Or is there an example of when you'd reset one in normal operation? I thought normal operation was to use the cpu release command, or to let the OS manually take the secondary cores out of their wait loops. What if I spruced up cpu_reset() to temporarily re-enable boot page translation, then disabled it again? (And maybe re-initialized the cpus MP table so that it could properly ack the primary core similar to in pq3_mp_up(). It seems somewhat dirty to me to constantly keep boot page translation enabled, even when its not needed. Especially since it would require us to change our memory map, environment variable scripts, documentation, etc on all our boards:) I'd be happy to look into an alternate workaround if you have an idea for a cleaner implementation. The idea is after u-boot if you soft-reset a core that it would go back into the spin table code. U-boot is long gone at this point. Are there common scenarios where a core would be reset after its already booted an OS? If an OS did need to soft-reset a secondary core, shouldn't the OS be responsible for ensuring boot page translation is enabled, its translating to the proper location, etc? For example, I imagine non-Linux OSes bring up secondary cores in different manners and some wouldn't re-utilize U-Boot's boot page code located in SDRAM at all, thus they wouldn't want the boot page translation always enabled. It just seems less than ideal to have a chunk of memory space that somewhat magically accesses a completely different, unintuitive address space. Someone else ran into the same issue already: http://www.mail-archive.com/u-boot@lists.denx.de/msg08361.html I realize there's a tradeoff between keeping the translation enabled vs disabled, I'm just not familiar with how OSes utilize the secondary cores to know what the downsides of disabling translation are... Any feedback on my last email above, or is disabling boot page translation just a no-go? It is at this point. Or is there an more ideal alternative? I really don't want to change up the memory map on all our Freescale boards, documentation, dts files, etc because of an optional 4KB chunk of memory space:) I'm more than willing to implement a different workaround if it means we can keep our current memory map... I'd be fine if we want to add a CONFIG_ option to do the disable so board ports that need/want it can do it. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] uec: Fix compile warning
On Jul 23, 2009, at 12:55 AM, Ben Warren wrote: Kumar Gala wrote: cpu.c: In function 'cpu_eth_init': cpu.c:371: warning: implicit declaration of function 'uec_standard_init' Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- include/netdev.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/netdev.h b/include/netdev.h index aed5c4c..92eceb1 100644 --- a/include/netdev.h +++ b/include/netdev.h @@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis); int eepro100_initialize(bd_t *bis); int eth_3com_initialize (bd_t * bis); int fec_initialize (bd_t *bis); +int uec_standard_init(bd_t *bis); int greth_initialize(bd_t *bis); void gt6426x_eth_initialize(bd_t *bis); int inca_switch_initialize(bd_t *bis); I'm not sure why I applied this - the prototype is already there and this is not sorted alphabetically. Anyway, reverted and you shouldn't get the warning. I think part of that was because Wolfgang already applied a similar fix himself. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] include/asm-ppc/immap_86xx.h
On Jul 22, 2009, at 10:16 AM, David Updegraff wrote:
Hi.
I think there is a small offset bug in here.. unless there is an
errata
that I have missed there should be no pad between srds1cr0,1. Anyone
know for sure?
--- a/include/asm-ppc/immap_86xx.h
+++ b/include/asm-ppc/immap_86xx.h
@@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
uintlbcdllcr; /* 0xe0e20 - LBC DLL control
register */
charres13a[224];
uintsrds1cr0; /* 0xe0f04 - SerDes1 control
register 0 */
- charres13b[4];
+ //char res13b[4];
uintsrds1cr1; /* 0xe0f08 - SerDes1 control
register 1 */
charres14[24];
I've verified and the manual is correct and the code is wrong. If you
send a proper patch I'll apply it.
- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Hello Daniel, Daniel Gorsulowski wrote: Sorry, it was my misstake. By cp and applying yout patch I missed the changes in lib_arm/Makefile. But as i wrote, _lshrdi3.a does not compile. Why do you use cp, and not better tools? Compiling the meesc board with actual u-boot and the patches from Wolfgang, Dirk and me, works fine for me: [...@pollux u-boot]$ make mrproper [...@pollux u-boot]$ make meesc_config Configuring for meesc board... [...@pollux u-boot]$ make USE_PRIVATE_LIBGCC=yes -s all [...@pollux u-boot]$ [...@pollux u-boot]$ ls -al u-boot.bin -rwxrwxr-x 1 hs hs 136820 23. Jul 17:25 u-boot.bin [...@pollux u-boot]$ [...@pollux u-boot]$ git log commit 21fd74874f0f7d95509c726162da213dcc6e7db1 Author: Heiko Schocher h...@denx.de Date: Thu Jul 23 13:18:40 2009 +0200 arm: add _lshrdi3.S Signed-off-by: Heiko Schocher h...@denx.de commit de463168e15733fd1f66f472399f7b93758f6a9e Author: Wolfgang Denk w...@denx.de Date: Thu Jul 23 13:15:59 2009 +0200 Make linking against libgcc configurable Many (especially ARM) tool chains seem to come with broken or otherwise unusable (for the purposes of builing U-Boot) run-time support libraries `libgcc.a'. By using the USE_PRIVATE_LIBGCC setting we allow to use alternative libraries instead. USE_PRIVATE_LIBGCC can either be set as an environment variable in the shell, or as a command line argument when running make, i. e. $ make USE_PRIVATE_LIBGCC=yes or $ USE_PRIVATE_LIBGCC=yes $ export USE_PRIVATE_LIBGCC $ make The value of USE_PRIVATE_LIBGCC is the name of the directory which contains the alternative run-time support library `libgcc.a'. The special value yes selects the directory $(OBJTREE)/lib_$(ARCH) . Note that not all architectures provide an alternative `libgcc.a' in their lib_$(ARCH) directories - so far, only ARM does. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Prafulla Wadaskar prafu...@marvell.com cc: Stefan Roese s...@denx.de commit 6da36a407c7e0d48789f10338477a3a8f612301f Author: Dirk Behme dirk.be...@googlemail.com Date: Wed Jul 22 17:51:56 2009 +0200 Use do_div from div64.h for vsprintf Use do_div from div64.h for vsprintf in case of 64bit division. For 32bit division, do_div from div64.h can't be used as it needs a 64bit parameter. Signed-off-by: Dirk Behme dirk.be...@googlemail.com CC: Simon Kagstrom simon.kagst...@netinsight.net commit 189eec77795553157c087cd4695fb3ce2433 Merge: faca03c... 84efbf4... Author: Wolfgang Denk w...@denx.de Date: Thu Jul 23 01:00:17 2009 +0200 Merge branch 'master' of /home/wd/git/u-boot/custodians commit 84efbf4d144ff8aaed3cca036aebb1fe69eff3f4 Merge: 49a7720... 57215cd... Author: Wolfgang Denk w...@denx.de Date: Thu Jul 23 00:59:37 2009 +0200 Merge branch 'master' of git://git.denx.de/u-boot-arm bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now? Or do you have more stuff queued? If so, when will it be ready for pulling? My list of pending OMAP3 patches: 1. [PATCHv3 2-5/5] clean up omap3 configuration structs http://lists.denx.de/pipermail/u-boot/2009-May/052943.html http://lists.denx.de/pipermail/u-boot/2009-May/052945.html http://lists.denx.de/pipermail/u-boot/2009-May/052944.html http://lists.denx.de/pipermail/u-boot/2009-May/052946.html 2. [PATCH 1-6/6]OMAP i2c and twl4030 http://lists.denx.de/pipermail/u-boot/2009-June/055072.html http://lists.denx.de/pipermail/u-boot/2009-June/055073.html http://lists.denx.de/pipermail/u-boot/2009-June/055074.html http://lists.denx.de/pipermail/u-boot/2009-June/055075.html http://lists.denx.de/pipermail/u-boot/2009-June/055076.html http://lists.denx.de/pipermail/u-boot/2009-June/055077.html 3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt v7_flush_dcache_all http://lists.denx.de/pipermail/u-boot/2009-July/055543.html http://lists.denx.de/pipermail/u-boot/2009-July/055544.html - Older patch applied, but this is still expected to be applied 4. PATCH: (Updated) Fix examples for OMAP3 boards... http://lists.denx.de/pipermail/u-boot/2009-July/056270.html Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] How to start U-Boot for i.MX31 NAND out of RedBoot (out of RAM)
Hi 2009/7/23 Ulrich Gerster gerst...@dhbw-loerrach.de: Not sure that I understand what every program assumes... means. I try to explain my problem in more detail. I had a working u-boot programed in NAND-Flash. Then I wanted to update it. I used the nand write command and wrote a the new image in the NAND-Flash. When I then restarted the Board U-Boot wasn't responding. Then I loaded RedBoot to RAM using a BDI. But when I was trying to access NAND-Flash with RedBoot (factive nand) RedBoot was freezing. The only chance I had was to clear the the NAND and the OOB. After I did that I was able to access the NAND-Flash with RedBoot. After that I programed the same u-boot image in the NAND-Flash using the RedBoot fis write command. The result was a working u-boot. Seems like nand_spl and redboot are compatible with each other but not the U-boot mxc_nand-driver. Have you compared the data in the flash before and after using U-boot to update it? But my guess is that the OOB layout may be different in nand_spl/nand_boot_fsl_nfc.c compared to drivers/mtd/nand/mxc_nd.c so the nand_spl may interpret the OOB information that mxc_nd.c has written in a different way. Ok. So I should compare this. Which function does take care for that? Don't remember, look for bad block or OOB-layout. This is especially true for large page NAND since the i.MX31 controller uses a non-standard layout, for small page NAND there should be no problem (although I don't know if nand_spl has been tested on small page nand yet). So now it is tested. I'm using small page nand with (512 + 16 spare) Bytes. Do you think it is a problem of the nand_spl or the nand driver? Hmm, my first guess would be a problem with nand_spl. /Magnus ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Make linking against libgcc configurable
Dear Daniel Gorsulowski, In message 4a686566@esd.eu you wrote: buid on meesc board (arm) is still broken. It's roughly the same problem, as Heiko Schocher reported in 4a6854b1.5000...@denx.de. But his patch doesn't fix the problem either. dani...@debby:~/git/u-boot$ make USE_PRIVATE_LIBGCC=yes ... drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_do_write_oob': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2019: undefined reference to `__lshrdi3' drivers/mtd/nand/libnand.a(nand_base.o): In function `nand_erase_nand': /data/home/danielg/git/u-boot/drivers/mtd/nand/nand_base.c:2199: undefined reference to `__lshrdi3' Well, my patch makes the use of libgcc configurable - it does not attempt to fix any remaining problems in the private ARM implementation of this library - I think Jean-Christophe has a full port of the related Linux code ready available, and I think he should rebase and post this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When a man sits with a pretty girl for an hour, it seems like a minute. But let him sit on a hot stove for a minute -- and it's lon- ger than any hour. That's relativity. -- Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] How to start U-Boot for i.MX31 NAND out of RedBoot (out of RAM)
Hi, maybe this is too off-topic, but maybe it helps: I am currently proting U-Boot to a MPC512x design (with NAND boot). AFAIK the NFC is similar on MPX512x and iMX.31, The MPC512x nand flash driver, that is now available in U-Boot seems to maintain the ECC by software. I could use it to read/write the NAND. But: The ECC stored is incompatible to the ECC that is optionally calculated by the NFC HW. When after a reset, the NFC HW extracts the first sector from NAND, it detects an unrecoverable ECC error and avoid to let it execute. For my MPC512x, I currently went back to my private, hacked driver (which uses HW ECC). I willt ry to adapt the mpc512x_nfc driver to support HW ECC, at least as an option. The problem is, that if the way to store ECC is changed on only part of the SW environment (e.g. only in U-Boot, but not in Linux), some strange effects may come up :-) So: Maybe you have the same problem on iMX.31? wkr, Thomas. Magnus Lilja wrote: Hi 2009/7/23 Ulrich Gerster gerst...@dhbw-loerrach.de: Not sure that I understand what every program assumes... means. I try to explain my problem in more detail. I had a working u-boot programed in NAND-Flash. Then I wanted to update it. I used the nand write command and wrote a the new image in the NAND-Flash. When I then restarted the Board U-Boot wasn't responding. Then I loaded RedBoot to RAM using a BDI. But when I was trying to access NAND-Flash with RedBoot (factive nand) RedBoot was freezing. The only chance I had was to clear the the NAND and the OOB. After I did that I was able to access the NAND-Flash with RedBoot. After that I programed the same u-boot image in the NAND-Flash using the RedBoot fis write command. The result was a working u-boot. Seems like nand_spl and redboot are compatible with each other but not the U-boot mxc_nand-driver. Have you compared the data in the flash before and after using U-boot to update it? But my guess is that the OOB layout may be different in nand_spl/nand_boot_fsl_nfc.c compared to drivers/mtd/nand/mxc_nd.c so the nand_spl may interpret the OOB information that mxc_nd.c has written in a different way. Ok. So I should compare this. Which function does take care for that? Don't remember, look for bad block or OOB-layout. This is especially true for large page NAND since the i.MX31 controller uses a non-standard layout, for small page NAND there should be no problem (although I don't know if nand_spl has been tested on small page nand yet). So now it is tested. I'm using small page nand with (512 + 16 spare) Bytes. Do you think it is a problem of the nand_spl or the nand driver? Hmm, my first guess would be a problem with nand_spl. /Magnus ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Embedded Brains GmbH Thomas DoerflerObere Lagerstrasse 30 D-82178 Puchheim Germany email: thomas.doerf...@embedded-brains.de Phone: +49-89-18908079-2 Fax: +49-89-18908079-9 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
Dear Giuseppe CONDORELLI, In message 1248339285-19580-1-git-send-email-giuseppe.condore...@st.com you wrote: This patch updates zlib to the latest stable version. Only relevant zlib parts were ported to u-boot tree, as already did for the current zlib (0.95). New zlib guarantees a faster inflate performances other then others improvements as explained at www.zlib.net Signed-off-by: Giuseppe Condorelli giuseppe.condore...@st.com Reviewed-by: Angelo Castello angelo.caste...@st.com --- include/u-boot/zlib.h | 718 ++--- lib_generic/zlib.c| 3931 + 2 files changed, 2464 insertions(+), 2185 deletions(-) Applied, thanks. [This time it seems to compile without issues.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are two kinds of people, those who do the work and those who take the credit. Try to be in the first group; there is less competition there.- Indira Gandhi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090722234335.gi19...@game.jcrosoft.org you wrote: Or do you have mnore stuff queued? If so, when will it be ready for pulling? Ilya Yanok patch which need ack from Scoot and Ben a at91rm9200 cleanup which cant wait a after rc1 as I want to test it on rm9200ek this WE and maybe few other fix patch we can be handle later Um... nothing else? What about all the pending OMAP3 patches? but I would like we include Alessandro patch and Prafulla kwimage for this release not necessarely before rc1 Please leave the kwimage patch for me; this is not ARM related, but affects pretty much global code only. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A conservative is a man who believes that nothing should be done for the first time. - Alfred E. Wiggam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] unassigned-patches/39
Synopsis: [U-Boot][PATCH] DHCP regression on 2009-06 State-Changed-From-To: open-closed State-Changed-By: wd State-Changed-When: Thu, 23 Jul 2009 19:25:27 +0200 State-Changed-Why: Fixed by commit 09133f8580f0106429ba3600f1855bd3577ae58b ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - net
Dear Ben Warren, In message 4a68041f.60...@gmail.com you wrote: The following changes since commit 189eec77795553157c087cd4695fb3ce2433: Wolfgang Denk (1): Merge branch 'master' of /home/wd/git/u-boot/custodians are available in the git repository at: git://git.denx.de/u-boot-net.git master Alessio Centazzo (1): ppc4xx: Fixed compilation warning in 4xx_enet.c Andreas Pretzsch (1): smc911x: add support for LAN9221 Ben Warren (2): Add warning about upcoming removal of old Ethernet API Convert SMC911X Ethernet driver to CONFIG_NET_MULTI API David Brownell (1): rm9200 ethernet driver: board-specific quirk (csb337) Ilya Yanok (1): fec_mxc: driver for FEC ethernet controller on i.MX27 Kim Phillips (1): net: tsec - fix dereferencing type-punned pointer will break strict-aliasing rules warning Michael Zaidman (1): DHCP regression on 2009-06 Mike Frysinger (1): net: rename NetRxPkt to NetRxPacket Nobuhiro Iwamatsu (1): sh: sh_eth: Remove garbage from printf Poonam Aggrwal (1): P2020RDB Added support of Vitesse PHYs VSC8641(RGMII) and VSC8221(SGMII) Prafulla Wadaskar (1): net: phy: bugfixes: mv88E61xx multichip addressing support Richard Retanubun (1): MIIPHYBB: Return 0x if the PHY is not asserting TA. Robin Getz (2): Add DNS support Save server's MAC address in environment Simon Kagstrom (2): arm: Kirkwood: Fix compiler optimization bug for kwgbe_send arm: Kirkwood: Check the error summary bit for error detection README |5 + board/bf548-ezkit/bf548-ezkit.c |8 + board/cm-bf548/cm-bf548.c | 10 + board/freescale/mx31pdk/mx31pdk.c | 10 + board/imx31_litekit/imx31_litekit.c | 10 + board/imx31_phycore/imx31_phycore.c | 10 + board/micronas/vct/ebi_smc911x.c| 22 +- board/micronas/vct/vct.c| 10 + board/omap3/evm/evm.c | 10 + board/renesas/ap325rxa/ap325rxa.c | 10 + board/renesas/rsk7203/rsk7203.c | 17 +- common/cmd_net.c| 49 +++ cpu/arm920t/at91rm9200/ether.c | 22 +- cpu/arm926ejs/mx27/generic.c| 10 + doc/README.dns | 64 +++ drivers/net/4xx_enet.c |3 +- drivers/net/Makefile|3 +- drivers/net/fec_mxc.c | 742 +++ drivers/net/fec_mxc.h | 304 ++ drivers/net/kirkwood_egiga.c| 33 +- drivers/net/kirkwood_egiga.h|1 + drivers/net/phy/miiphybb.c |7 + drivers/net/phy/mv88e61xx.c | 18 +- drivers/net/phy/mv88e61xx.h |2 +- drivers/net/sh_eth.c|2 +- drivers/net/smc911x.c | 177 + drivers/net/smc911x.h | 170 + drivers/net/tsec.c | 57 +++- include/configs/ap325rxa.h |7 +- include/configs/bf548-ezkit.h |7 +- include/configs/cm-bf548.h |7 +- include/configs/imx31_litekit.h |7 +- include/configs/imx31_phycore.h |7 +- include/configs/mx31pdk.h |7 +- include/configs/omap3_evm.h |7 +- include/configs/rsk7203.h |7 +- include/configs/vct.h |9 +- include/net.h |9 +- include/netdev.h|2 + net/Makefile|7 +- net/bootp.c |2 +- net/dns.c | 211 ++ net/dns.h | 39 ++ net/eth.c |2 + net/net.c | 49 +++- 45 files changed, 1936 insertions(+), 236 deletions(-) create mode 100644 doc/README.dns create mode 100644 drivers/net/fec_mxc.c create mode 100644 drivers/net/fec_mxc.h create mode 100644 net/dns.c create mode 100644 net/dns.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de grep me no patterns and I'll tell you no lines. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] 85xx: Fix mapping of 0xfffffxxx when CONFIG_MP
Any feedback on my last email above, or is disabling boot page translation just a no-go? It is at this point. Or is there an more ideal alternative? I really don't want to change up the memory map on all our Freescale boards, documentation, dts files, etc because of an optional 4KB chunk of memory space:) I'm more than willing to implement a different workaround if it means we can keep our current memory map... I'd be fine if we want to add a CONFIG_ option to do the disable so board ports that need/want it can do it. OK, that sounds good. I'll implement and test. Thanks, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Query on USB function(device) working in MPC8280
Dear All, i have written driver for USB function(device) in code warrior for MPC8280,i am facing problem in configuration stage,when i connect it to the host PC through USB cable .device descriptor is happening host is setting the address but device configuration is not happening properly...it hangs in USB busy handler. below is the output of the snippet in hyperterminal for usb debugging Debug statements GetDescriptor request length = 0x40 Device Descriptor... In TX bd status = 3ec0 In TX USB event register = 109 Recieved PID token = 0xbc40 bd status = 3ec0 USB:SetAddress 10 bd status = 3800 In TX bd status = 3ac0 In TX USB event register = 108 GetDescriptor request length = 0x12 Device Descriptor... In TX bd status = 3ec0 In TX USB event register = 109 Recieved PID token = 0xbc40 bd status = 3ec0 In USB_BUSY HANDLER : 0x108 In TX bd status = 3ec0 In TX USB event register = 10c Recieved PID token = 0xbc40 bd status = 3ec0 In USB_BUSY HANDLER : 0x0 In TX bd status = 3ec0 In TX USB event register = 10d Recieved PID token = 0xbc40 bd status = 3ec0 In USB_BUSY HANDLER : 0x108 In TX bd status = 3ec0 In TX USB event register = 108 Recieved PID token = 0xbc40 bd status = 3ec0 it hangs in usb busy handler , i think am missing somthing in PID data toggling synchronization between MPC8280 and host. please help me out to sort this issue am testing in FreeScale Code Warrior IDE waiting for the reply ASAP Regards, Gurumurthy___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Query on USB function(device) working in MPC8280
Dear GurumurthyGowdar, In message 20090723180205.20843.qm...@f4mail201.rediffmail.com you wrote: i have written driver for USB function(device) in code warrior for MPC8280,i am facing problem in configuration stage,when i connect it to the host PC through USB cable .device descriptor is happening host is setting the address but device confi guration is not happening properly...it hangs in USB busy handler. I cannot help it, but I cannot see any relation to U-Boot in your posting. You seem to be off topic here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nature is very un-American. Nature never hurries. - William George Jordan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Query on USB function(device) working in MPC8280
ok please let me know is there anyway i can test working of USB function(device) in U-boot 1.3.1. currently U-boot is working fine in board. how to add this USB function command in U-boot. i need to add config commands for usb to work. later how i can test working of usb in U-boot because i have never tested USB in U-boot. Regards, Gurumurthy On Thu, 23 Jul 2009 23:51:35 +0530 wrote Dear GurumurthyGowdar, In message you wrote: i have written driver for USB function(device) in code warrior for MPC8280,i am facing problem in configuration stage,when i connect it to the host PC through USB cable .device descriptor is happening host is setting the address but device confi guration is not happening properly...it hangs in USB busy handler. I cannot help it, but I cannot see any relation to U-Boot in your posting. You seem to be off topic here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nature is very un-American. Nature never hurries. - William George Jordan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc: Unlock cache-as-ram in a consistent manner
Dear Peter Tyser, In message 1247269570-11406-1-git-send-email-pty...@xes-inc.com you wrote: Previously, non-e500 architectures only unlocked their data cache which was used as early RAM when booting to Linux using the bootm command. This change causes all PPC boards with CONFIG_SYS_INIT_RAM_LOCK defined to unlock their data cache during U-Boot's initialization. This improves U-Boot performance and provides a common cache state when booting to different OSes. Signed-off-by: Peter Tyser pty...@xes-inc.com --- I've tested this on 86xx boards, it'd be great if someone could test on 83xx and 74xx/7xx. 85xx boards should not be affected by this change. This change assumes http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/63423 has already been applied, or the lib/ppc patches in the diffs below can be changed to lib_ppc. Peter lib/ppc/board.c |6 +++--- lib/ppc/bootm.c |9 - 2 files changed, 3 insertions(+), 12 deletions(-) Applied. Hm... tested on TQM834x - it's still booting, but flash recognition stopped working: OLD: U-Boot 2008.10-00085-g13f9496-dirty (Oct 22 2008 - 00:28:08) MPC83XX Reset Status: CPU: e300c1, MPC8349E, Rev: 1.1 at 533.328 MHz, CSB: 266.664 MHz Board: TQM834x PCI1: 32 bit, 33 MHz I2C: ready DTT: 1 is 32 C DRAM: 256 MB FLASH: 32 MB PCI: Bus Dev VenId DevId Class Int 00 0b 104c ac55 0607 ff 00 0b 104c ac55 0607 ff ... NEW: U-Boot 2009.06-00513-g982adfc (Jul 23 2009 - 20:46:38) MPC83XX Reset Status: Software Hard, External/Internal Soft, External/Internal Hard CPU: e300c1, MPC8349E, Rev: 1.1 at 533.328 MHz, CSB: 266.664 MHz Board: TQM834x PCI1: 32 bit, 33 MHz I2C: ready DRAM: 256 MB FLASH: ## Unknown FLASH on Bank 1 - Size = 0x0200 = 0 MB 32 MB PCI: Bus Dev VenId DevId Class Int 00 0b 104c ac55 0607 ff 00 0b 104c ac55 0607 ff = fli Bank # 1: missing or unknown FLASH type Probably because of caching? I can't do anything right now as I cannot reprogram the flash any more. Need to attach a BDI when I'm bck in the office tomorrow morning. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The one charm of marriage is that it makes a life of deception a neccessity.- Oscar Wilde ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] Add error checking for unsupported OS types.
Dear Detlev Zundel, In message 1247493679-18702-2-git-send-email-...@denx.de you wrote: Signed-off-by: Detlev Zundel d...@denx.de --- common/cmd_bootm.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 8 Catfish = 1 Octo-puss ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Re-add support for image type 'Standalone Program'
Dear Detlev Zundel, In message 1247493679-18702-3-git-send-email-...@denx.de you wrote: Support for this type was lost during the bootm refactoring. Signed-off-by: Detlev Zundel d...@denx.de --- common/cmd_bootm.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A Vulcan can no sooner be disloyal than he can exist without breathing. -- Kirk, The Menagerie, stardate 3012.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator: Fix gcc 4.4 compiler warning
Dear Kumar Gala, In message 1247495041-8605-1-git-send-email-ga...@kernel.crashing.org you wrote: biosemu.c: In function 'BE_setVGA': biosemu.c:147: warning: dereferencing type-punned pointer will break strict-aliasing rules Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- drivers/bios_emulator/biosemu.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An Elephant is a mouse with an Operating System. - Knuth ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ahci: Fix gcc 4.4 compiler warning
Dear Kumar Gala, In message 1247495041-8605-2-git-send-email-ga...@kernel.crashing.org you wrote: ahci.c: In function 'ata_scsiop_read_capacity10': ahci.c:616: warning: dereferencing type-punned pointer will break strict-aliasing rules Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- drivers/block/ahci.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How come everyone's going so slow if it's called rush hour? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dlmalloc: Ignore gcc4.4 compiler warnings
Dear Kumar Gala,
In message 1247495041-8605-3-git-send-email-ga...@kernel.crashing.org you
wrote:
The version of dlmalloc we are using generates a fair number of warnings
of the following form:
warning: dereferencing pointer '({anonymous})' does break strict-aliasing
rules
Trying to fix these is just paper taping over the issue and we really
just need to look into a new malloc implementation. So we disable these
particular warning checks for dlmalloc.c only.
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
Well, if you think fixing the problems is paper taping over the
issue, then how do you call NOT fixing the problems and shutting off
the warnings?
NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If something is different, it's either better or worse, and usually
both.- Larry Wall
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] PPC440GX TLB setting problem.
Hi all, I'm working on trying to get VxWorks to boot on a PPC440GX processor using U-Boot, using an ALPR board. In order to boot VxWorks properly (it expects caching on the SDRAM to be disabled), I created a new board directory and such (based on the ALPR board), and then changed the TLB settings in init.S. My problem is that when my new U-Boot has booted, the TLBs are not configured as I have programmed them. I verified this using a BDI debugger. The TLB settings are still the same as the settings the original ALPR U-Boot used. I'm really at a loss here. It seems that no matter what I try (I tried quite a few variantions of the TLB settings), the TLB settings won't change. So now I several, related, questions: - What could be the cause of this? Have I done something wrong? - Is U-Boot reconfiguring the TLBs after init.S has executed? - If so, how can I control those TLBs? Here's a code snippet from my init.S: /*** *** * TLB TABLE * * This table is used by the cpu boot code to setup the initial tlb * entries. Rather than make broad assumptions in the cpu source tree, * this table lets each board set things up however they like. * * Pointer to the table is returned in r1 * */ /* Updated to reflect TLB entries in VxWorks. */ .section .bootpg,ax .globl tlbtab tlbtab: tlbtab_start tlbentry( CFG_SDRAM_BASE, SZ_256M, 0x, 0, AC_R|AC_W|AC_X|SA_G|SA_I ) tlbentry( 0x8000, SZ_256M, 0x, 0, AC_R|AC_W|AC_X|SA_I ) tlbentry( CFG_PERIPHERAL_BASE, SZ_256M, 0x4000, 1, AC_R|AC_W|SA_G|SA_I ) tlbentry( 0xf000, SZ_256M, 0xf000, 1, AC_R|AC_W|AC_X|SA_G|SA_I ) tlbentry( CFG_ISRAM_BASE, SZ_256K, 0x8000, 0, AC_R|AC_W|AC_X ) #ifdef CFG_INIT_RAM_DCACHE /* TLB-entry for init-ram in dcache (SA_I must be turned off!) */ tlbentry( CFG_INIT_RAM_ADDR, SZ_64K, CFG_INIT_RAM_ADDR, 0, AC_R|AC_W|AC_X|SA_G ) #endif tlbtab_end And here's the BDI's listing of the TLBs after U-Boot has booted (no auto boot): - TARGET: processing target startup - TARGET: processing target startup passed ALPRgo ALPRhalt Core number : 0 Core state: debug mode Debug entry cause : JTAG stop request Current PC: 0x0ffe372c Current CR: 0x28dcff82 Current MSR : 0x00029000 Current LR: 0x0ffe378c ALPRtlb 0 15 IDX TID EPN SIZE VTS RPN USER WIMGE USRSVC 0 : 00 ff00 16MB V0 - 1_ff00 U: -I-G- XWRXWR 1 : 00 e000 256MB V0 - 1_4000 U: -I-G- -WR-WR 2 : 00 c000 4KB V0 - 0_8000 U: - XWRXWR 3 : 00 c0001000 4KB V0 - 0_80001000 U: - XWRXWR 4 : 00 256MB V0 - 0_ U: ---G- XWRXWR 5 : 00 d000 256MB V0 - 2_ U: -I-G- -WR-WR 6 : 00 8000 256MB V0 - 3_8000 U: -I-G- -WR-WR 7 : 00 9000 256MB V0 - 3_9000 U: -I-G- -WR-WR 8 : 00 a000 256MB V0 - 3_a000 U: -I-G- -WR-WR 9 : 00 f000 4KB V0 - 1_f000 U: -I-G- XWRXWR 10 : 00 1KB -0 - 0_ U: - -- 11 : 00 1KB -0 - 0_ U: - -- 12 : 00 1KB -0 - 0_ U: - -- 13 : 00 1KB -0 - 0_ U: - -- 14 : 00 1KB -0 - 0_ U: - -- 15 : 00 1KB -0 - 0_ U: - -- ALPR Thanks in advance! Met vriendelijke groet, With kind regards, Wouter Eckhardt Engineer wouter.eckha...@prodrive.nl tel. +31 40 2676187 Prodrive B.V. Postbus 28030 5602 JA Eindhoven Ekkersrijt 5025 5692 EB Son The Netherlands tel. +31 40 2676200 fax: +31 40 2676201 www.prodrive.nl Disclaimer: The information contained in this email, including any attachments is confidential and is for the sole use of the intended recipient(s). Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please notify the sender immediately by replying to this message and destroy all copies of this message and any attachments. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] update config for mvBC-P (MPC5200)
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz, In message 1247835024.3953.43.ca...@swa-m460 you wrote: This patch adds I2C support for mvBC-P and defines flash layout matching the shipped product. Signed-off-by: André Schwarz andre.schw...@matrix-vision.de --- include/configs/MVBC_P.h | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is better to have tried and failed than to have failed to try, but the result's the same. - Mike Dennison ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] create and use common code for Matrix Vision boards
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz, In message 1247842785.3953.90.ca...@swa-m460 you wrote: This patch adds and uses common code for all Matrix Vision boards. Signed-off-by: Andr=C3=A9 Schwarz andre.schw...@matrix-vision.de --- Heiko's comments have been addressed and common/mv_common.h has been included where needed. board/matrix_vision/common/Makefile| 54 ++ board/matrix_vision/common/mv_common.c | 125 board/matrix_vision/common/mv_common.h | 25 +++ board/matrix_vision/mvbc_p/mvbc_p.c| 76 +--- board/matrix_vision/mvblm7/mvblm7.c| 38 +++--- board/matrix_vision/mvblm7/pci.c | 35 ++ include/configs/MVBC_P.h | 14 +++- include/configs/MVBLM7.h | 49 + 8 files changed, 254 insertions(+), 162 deletions(-) Sorry, this patch doesn't apply: /home/wd/git/u-boot/work/.git/rebase-apply/patch:179: trailing whitespace. error: patch failed: include/configs/MVBC_P.h:68 error: include/configs/MVBC_P.h: patch does not apply fatal: sha1 information is lacking or useless (board/matrix_vision/mvbc_p/mvbc_p.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001. Please clean up and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de panic: can't find / ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
On 18:21 Thu 23 Jul , Dirk Behme wrote: Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now? Or do you have more stuff queued? If so, when will it be ready for pulling? My list of pending OMAP3 patches: 1. [PATCHv3 2-5/5] clean up omap3 configuration structs http://lists.denx.de/pipermail/u-boot/2009-May/052943.html http://lists.denx.de/pipermail/u-boot/2009-May/052945.html http://lists.denx.de/pipermail/u-boot/2009-May/052944.html http://lists.denx.de/pipermail/u-boot/2009-May/052946.html NACK I've already explain why I'll not change my mind 2. [PATCH 1-6/6]OMAP i2c and twl4030 http://lists.denx.de/pipermail/u-boot/2009-June/055072.html http://lists.denx.de/pipermail/u-boot/2009-June/055073.html http://lists.denx.de/pipermail/u-boot/2009-June/055074.html http://lists.denx.de/pipermail/u-boot/2009-June/055075.html http://lists.denx.de/pipermail/u-boot/2009-June/055076.html http://lists.denx.de/pipermail/u-boot/2009-June/055077.html this will no go through arm but i2c tree 3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt v7_flush_dcache_all http://lists.denx.de/pipermail/u-boot/2009-July/055543.html http://lists.denx.de/pipermail/u-boot/2009-July/055544.html change requested Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch] bootelf should allow arguments passing to called program
Dear =?ISO-8859-15?Q?Thomas_D=F6rfler?=, In message 4a633b8e.8060...@embedded-brains.de you wrote: The bootelf command is written to pass the command line arguments to the called program, but the command list entry limits the number of arguments to 2 (including the command itself and the image address). Changing the command list entry allows passing command line arguments to the called program. Signed-off-by: Thomas Doerfler thomas.doerf...@embedded-brains.de --- diff --git a/common/cmd_elf.c b/common/cmd_elf.c index abec7dd..e67938f 100644 --- a/common/cmd_elf.c +++ b/common/cmd_elf.c @@ -311,9 +311,10 @@ unsigned long load_elf_image (unsigned long addr) /* == */ Line wrapped. Sorry, your mailer wrapped long lines: Applying: bootelf should allow arguments passing to called program fatal: corrupt patch at line 9 Patch failed at 0001. Please clean up and resubmit. Use git-send-email to submit the patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To live is always desirable. -- Eleen the Capellan, Friday's Child, stardate 3498.9 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] unify HOST_CFLAGS and HOSTCFLAGS
Dear Mike Frysinger, In message 1248031023-31706-1-git-send-email-vap...@gentoo.org you wrote: The top build system sets up HOSTCFLAGS a bit and exports it, but other places use HOST_CFLAGS instead. Unify the two as HOSTCFLAGS so that the values stay in sync. Signed-off-by: Mike Frysinger vap...@gentoo.org --- Makefile |2 +- board/fads/config.mk |2 +- board/netstar/Makefile |8 board/spc1920/config.mk |2 +- board/xilinx/ml300/Makefile |2 +- board/xilinx/ppc405-generic/Makefile |2 +- board/xilinx/ppc440-generic/Makefile |2 +- cpu/ixp/npe/Makefile |2 +- drivers/bios_emulator/Makefile |2 +- drivers/net/sk98lin/Makefile |2 +- rules.mk |2 +- tools/Makefile | 12 ++-- tools/gdb/Makefile |2 +- tools/imls/Makefile |4 ++-- 14 files changed, 23 insertions(+), 23 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Any sufficiently advanced technology is indistinguishable from magic. Clarke's Third Law - _Profiles of the Future_ (1962; rev. 1973) ``Hazards of Prophecy: The Failure of Imagination'' ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers
Dear Thomas Dörfler, In message 4a637b05.4030...@embedded-brains.de you wrote: But I doubt that (re-)calling mpc512x_fec_init_phy before a MII command is run is really a good idea. Using the same code for initial init and repeated init makes sense, but this function in its current implementation also resets the PHY, which forces a new line negotiation to occur. IMHO this is NOT needed when we e.g. query the PHY status and it would even be contraproductive, if we would change some PHY register settings, because these changes would also be reset. Agreed. What COULD make sense is to extract the MII speed register setting operation from mpc512x_fec_init_phy() and move it to the mpc512x_fec_mii_read/write functions. because this is where it is really needed. Does this make sense to you? Yes, it does. But we should double-check if setting the MII_SPEED register is all that should be (re-) initialized. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de We all agree on the necessity of compromise. We just can't agree on when it's necessary to compromise. - Larry Wall in 1991nov13.194420.28...@netlabs.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_tsi148: General cleanup
Dear pty...@xes-inc.com, In message 1248144698-27023-1-git-send-email-pty...@xes-inc.com you wrote: From: Peter Tyser pty...@gmail.com - Fix command help message - Disable DEBUG by default - Fix whitespace issues - Fix lines 80 characters Signed-off-by: Peter Tyser pty...@gmail.com --- common/cmd_tsi148.c | 85 ++ 1 files changed, 44 insertions(+), 41 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Certainly there are things in life that money can't buy, but it's very funny - Did you ever try buying them without money? - Ogden Nash ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Remove static declaration from gunzip_bmp()
Dear Mark Jackson, In message 4a6598dd.2090...@mimc.co.uk you wrote: This patch removes the static declaration from gunzip_bmp() Without it, the gunzip_bmp() function is not visible to common/lcd.c and fails to compile with an error. Signed-off-by: Mark Jackson m...@mimc.co.uk --- common/cmd_bmp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de We, the unwilling, led by the unknowing, are doing the impossible for the ungrateful. We have done so much, for so long, with so little, we are now qualified to do anything with nothing. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 V2] update the EB+MCF-EV123 board support
Dear Jens Scharsig,
In message h447jv$vm...@ger.gmane.org you wrote:
This patch updates the support for EB+MCF-EV123 board and needs the [PATCH
1/2 V2] new video driver for bus vcxk framebuffers
Please restrict the line length of the commit message to 70 characters
or less.
...
+#if defined(CONFIG_VIDEO)
+
+/*
+ h* EB+CPU5282-T1/drv_video_init
+ * FUNCTION
+ ***
+*/
Incorrect multi-line comment style.
+int drv_video_init (void)
+{
+ char *s;
+ unsigned long splash;
+
+ printf(Init Video as );
+
+ if ((s = getenv (displaywidth)) != NULL)
+ {
+ display_width = simple_strtoul (s, NULL, 10);
+ }
+ else
+ {
+ display_width=256;
+ }
+ if ((s = getenv (displayheight)) != NULL)
+ {
+ display_height = simple_strtoul (s, NULL, 10);
+ }
+ else
+ {
+ display_height=256;
+ }
Incorrect brace style.
+ printf(%lu x %lu pixel matrix\n,display_width,display_height);
Please s/,/, /g
Please clean up and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
News is what a chap who doesn't care much about anything wants to
read. And it's only news until he's read it. After that it's dead.
- Evelyn Waugh _Scoop_ (1938) bk. 1, ch. 5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc: Unlock cache-as-ram in a consistent manner
On Thu, 23 Jul 2009 21:01:01 +0200 Wolfgang Denk w...@denx.de wrote: FLASH: ## Unknown FLASH on Bank 1 - Size = 0x0200 = 0 MB 32 MB PCI: Bus Dev VenId DevId Class Int 00 0b 104c ac55 0607 ff 00 0b 104c ac55 0607 ff = fli Bank # 1: missing or unknown FLASH type Probably because of caching? ahem, I just noticed I accidentally broke the TQM8349 with commit 9993e19 (but pci still works?) - anyway, can you tell me if this fixes it?: diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h index 492bdcc..da08b7c 100644 --- a/include/configs/TQM834x.h +++ b/include/configs/TQM834x.h @@ -250,7 +250,7 @@ extern int tqm834x_num_flash_banks; #define CONFIG_PCI_SCAN_SHOW/* show pci devices on startup */ /* PCI1 host bridge */ -#define CONFIG_SYS_PCI1_MEM_BASE 0x8000 +#define CONFIG_SYS_PCI1_MEM_BASE 0x9000 #define CONFIG_SYS_PCI1_MEM_PHYS CONFIG_SYS_PCI1_MEM_BASE #define CONFIG_SYS_PCI1_MEM_SIZE 0x1000 /* 256M */ #define CONFIG_SYS_PCI1_MMIO_BASE (CONFIG_SYS_PCI1_MEM_BASE + CONFIG_SYS_PCI1_MEM_SIZE) Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 V2] new video driver for bus vcxk framebuffers
Dear Jens Scharsig,
In message 4a65a19e.6060...@bus-elektronik.de you wrote:
This patch adds a new video driver
...
+int vcxk_display_bitmap (ulong addr, int x, int y)
+{
...
+ if ((bmp-header.signature[0] == 'B')
+ (bmp-header.signature[1] == 'M'))
+ {
+ compression = le32_to_cpu (bmp-header.compression);
+ width= le32_to_cpu (bmp-header.width);
+ height = le32_to_cpu (bmp-header.height);
+ bpp = le16_to_cpu (bmp-header.bit_count);
+
+ dataptr = (unsigned char *) bmp +
+ le32_to_cpu(bmp-header.data_offset);
+
+ if (display_width (width + x))
+ {
+ cp_width = display_width - x;
+ }
+ else
+ {
+ cp_width = width;
+ }
+ if (display_height (height + y))
+ {
+ cp_height = display_height - y;
+ }
+ else
+ {
+ cp_height = height;
+ }
...
Incorrect brace style.
...
+ switch (bpp)
+ {
+ case 1:
+ for (ycnt = cp_height;ycnt 0; ycnt--)
+ {
+ lineptr = dataptr;
+ for (xcnt = 0;xcnt cp_width; xcnt++)
+ {
+ if ((*lineptr (xcnt % 8))
+ 0x80) {
+ vcxk_setpixel(xcnt,
+ ycnt - 1,
+ 0xFF);
+ } else {
+ vcxk_setpixel(xcnt,
+ ycnt-1,0);
+ }
Quoting the CodingStyle:
Now, some people will claim that having 8-character
indentations makes the code move too far to the right, and
makes it hard to read on a 80-character terminal screen. The
answer to that is that if you need more than 3 levels of
indentation, you're screwed anyway, and should fix your
program.
Please clean up and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Shakespeare's Law of Prototyping: (Hamlet III, iv, 156-160)
O, throw away the worser part of it,
And live the purer with the other half.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] export SPI functions to standalone apps
Dear Mike Frysinger, In message 1248230340-26252-1-git-send-email-vap...@gentoo.org you wrote: While we're here, fix the broken #ifdef handling in _exports.h. ... diff --git a/include/_exports.h b/include/_exports.h index af43885..ba3920e 100644 --- a/include/_exports.h +++ b/include/_exports.h @@ -1,3 +1,6 @@ +/* You do not need to use #ifdef around functions that may not exist + * in the final configuration (such as i2c). + */ Incorrect multi-line comment style. Please cleanup and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Two wrongs don't make a right, but three rights make a left. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add WATCHDOG_RESET to allow LZMA kernel decompression on slow machines
Dear rhabarber1848, In message h46pl1$hb...@ger.gmane.org you wrote: Signed-off-by: rhabarber1848 rhabarber1...@web.de --- lib_generic/lzma/LzmaDec.c | 26 ++ lib_generic/lzma/LzmaTools.c |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib_generic/lzma/LzmaDec.c b/lib_generic/lzma/LzmaDec.c index 89d934a..acffb14 100644 --- a/lib_generic/lzma/LzmaDec.c +++ b/lib_generic/lzma/LzmaDec.c @@ -1,6 +1,9 @@ /* LzmaDec.c -- LZMA Decoder 2008-11-06 : Igor Pavlov : Public domain */ +#include config.h +#include common.h +#include watchdog.h #include LzmaDec.h #include string.h @@ -156,6 +159,8 @@ static int MY_FAST_CALL LzmaDec_DecodeReal(CLzmaDec *p, SizeT limit, const Byte ^^ Line wrapped. Applying: add WATCHDOG_RESET to allow LZMA kernel decompression on slow machines fatal: corrupt patch at line 21 Patch failed at 0001. Please make sure your mailer does not mess up your postings. Please use git-send-email to submit patches. Please clean up and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Politician: An eel in the fundamental mud upon which the superstructure of organized society is reared. When he wriggles he mistakes the agitation of his tail for the trembling of the edifice. As compared with the statesman, he suffers the disadvantage of being alive. - Ambrose Bierce ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Less verbose output when loading vxworks 6.x images
Dear Niklaus Giger,
In message 200907221629.09703.rg...@blackfin.uclinux.org Robin Getz wrote:
+#ifdef DEBUG
if (strtab) {
printf (%sing %s @ 0x%08lx (%ld bytes)\n,
(shdr-sh_type == SHT_NOBITS) ?
@@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr)
(unsigned long) shdr-sh_addr,
(long) shdr-sh_size);
}
+#endif
if (shdr-sh_type == SHT_NOBITS) {
memset ((void *)shdr-sh_addr, 0,
shdr-sh_size);
its better to remove the ifdef, and replace the printf() with debug() (IMHO).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Just think of a computer as hardware you can program.
- Nigel de la Tierre
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] Add chip_config command for PPC4xx bootstrap configuration
Dear Stefan Roese, In message 1248331200-3505-1-git-send-email...@denx.de you wrote: This patch adds a generic command for programming I2C bootstrap eeproms on PPC4xx. An implementation for Canyonlands board is included. The command name is intentionally chosen not to be PPC4xx specific. This way other CPU's/SoC's can implement a similar command under the same name, perhaps with a different syntax. Usage on Canyonlands: = chip_config Available configurations (I2C address 0x52): 600-nor - NOR CPU: 600 PLB: 200 OPB: 100 EBC: 100 600-nand - NAND CPU: 600 PLB: 200 OPB: 100 EBC: 100 800-nor - NOR CPU: 800 PLB: 200 OPB: 100 EBC: 100 800-nand - NAND CPU: 800 PLB: 200 OPB: 100 EBC: 100 1000-nor - NOR CPU:1000 PLB: 200 OPB: 100 EBC: 100 1000-nand- NAND CPU:1000 PLB: 200 OPB: 100 EBC: 100 1066-nor - NOR CPU:1066 PLB: 266 OPB: 88 EBC: 88 *** 1066-nand- NAND CPU:1066 PLB: 266 OPB: 88 EBC: 88 = chip_config 600-nor Using configuration: 600-nor - NOR CPU: 600 PLB: 200 OPB: 100 EBC: 100 done (dump via 'i2c md 52 0.1 10') Reset the board for the changes to take effect Other 4xx boards will be migrated to use this command soon as well. Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Dirk Eibach eib...@gdsys.de Acked-by: Matthias Fuchs matthias.fu...@esd.eu --- v6: - Update identation of chip_config struct v5: - Removed bogus lines from commit text v4: - Command name changed from cpu_config to chip_config - Used eeprom_read/eeprom_write if available - Added CONFIG_4xx_CONFIG_I2C_EEPROM_OFFSET v3: - Line length of one printf reduced v2: - Patch authorship changes to Stefan - s-o-b from Dirk added - Added current configuration detection - Minor coding style cleanup board/amcc/canyonlands/Makefile |5 +- board/amcc/canyonlands/bootstrap.c | 195 -- board/amcc/canyonlands/chip_config.c | 87 +++ cpu/ppc4xx/Makefile |3 + cpu/ppc4xx/cmd_chip_config.c | 142 include/asm-ppc/ppc4xx_config.h | 42 +++ include/configs/canyonlands.h|6 + 7 files changed, 283 insertions(+), 197 deletions(-) delete mode 100644 board/amcc/canyonlands/bootstrap.c create mode 100644 board/amcc/canyonlands/chip_config.c create mode 100644 cpu/ppc4xx/cmd_chip_config.c create mode 100644 include/asm-ppc/ppc4xx_config.h Ackeds-by: Wolfgang Denk w...@denx.de Stefan, can you please run this through your ppc4xx repo? This seems to make most sense to me, as 4xx will be the first (and so far only) user. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Work 8 hours, sleep 8 hours; but not the same 8 hours. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090723191505.ga9...@game.jcrosoft.org you wrote: My list of pending OMAP3 patches: 1. [PATCHv3 2-5/5] clean up omap3 configuration structs http://lists.denx.de/pipermail/u-boot/2009-May/052943.html http://lists.denx.de/pipermail/u-boot/2009-May/052945.html http://lists.denx.de/pipermail/u-boot/2009-May/052944.html http://lists.denx.de/pipermail/u-boot/2009-May/052946.html NACK I've already explain why I'll not change my mind Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables? We don't have any such requirements on local names; I just re-read Chapter 4: Naming of the CodingStyle, and cannot find any such restrictions or even hints either. So if this is the only reason for your reject, I would like to ask you to reconsider. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 8 Catfish = 1 Octo-puss ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Blackfin: restore EVT1 handling in linker script
Sadly, the Blackfin linker script unification lost a small #ifdef logic
needed on older parts. Restore that CONFIG_BFIN_BOOTROM_USES_EVT1 logic.
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
lib_blackfin/u-boot.lds.S |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/lib_blackfin/u-boot.lds.S b/lib_blackfin/u-boot.lds.S
index 4755153..3604b78 100644
--- a/lib_blackfin/u-boot.lds.S
+++ b/lib_blackfin/u-boot.lds.S
@@ -46,12 +46,19 @@
# define L1_DATA_B_SRAM_SIZE 0
#endif
+/* The 0xC offset is so we don't clobber the tiny LDR jump block. */
+#ifdef CONFIG_BFIN_BOOTROM_USES_EVT1
+# define L1_CODE_ORIGIN L1_INST_SRAM
+#else
+# define L1_CODE_ORIGIN L1_INST_SRAM + 0xC
+#endif
+
OUTPUT_ARCH(bfin)
MEMORY
{
ram : ORIGIN = CONFIG_SYS_MONITOR_BASE, LENGTH =
CONFIG_SYS_MONITOR_LEN
- l1_code : ORIGIN = L1_INST_SRAM,LENGTH = L1_INST_SRAM_SIZE
+ l1_code : ORIGIN = L1_CODE_ORIGIN, LENGTH = L1_INST_SRAM_SIZE
l1_data : ORIGIN = L1_DATA_B_SRAM, LENGTH = L1_DATA_B_SRAM_SIZE
}
--
1.6.3.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] export SPI functions to standalone apps
While we're here, fix the broken #ifdef handling in _exports.h.
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
v3
- tweak code style
common/exports.c |8
include/_exports.h | 14 ++
include/exports.h |3 ++-
3 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/common/exports.c b/common/exports.c
index ec4656b..b3b6e1f 100644
--- a/common/exports.c
+++ b/common/exports.c
@@ -38,4 +38,12 @@ void jumptable_init (void)
gd-jt[XF_i2c_write] = (void *) i2c_write;
gd-jt[XF_i2c_read] = (void *) i2c_read;
#endif
+#ifdef CONFIG_CMD_SPI
+ gd-jt[XF_spi_init] = (void *) spi_init;
+ gd-jt[XF_spi_setup_slave] = (void *) spi_setup_slave;
+ gd-jt[XF_spi_free_slave] = (void *) spi_free_slave;
+ gd-jt[XF_spi_claim_bus] = (void *) spi_claim_bus;
+ gd-jt[XF_spi_release_bus] = (void *) spi_release_bus;
+ gd-jt[XF_spi_xfer] = (void *) spi_xfer;
+#endif
}
diff --git a/include/_exports.h b/include/_exports.h
index af43885..f3df568 100644
--- a/include/_exports.h
+++ b/include/_exports.h
@@ -1,3 +1,7 @@
+/*
+ * You do not need to use #ifdef around functions that may not exist
+ * in the final configuration (such as i2c).
+ */
EXPORT_FUNC(get_version)
EXPORT_FUNC(getc)
EXPORT_FUNC(tstc)
@@ -14,13 +18,15 @@ EXPORT_FUNC(vprintf)
EXPORT_FUNC(do_reset)
EXPORT_FUNC(getenv)
EXPORT_FUNC(setenv)
-#ifdef CONFIG_HAS_UID
EXPORT_FUNC(forceenv)
-#endif
EXPORT_FUNC(simple_strtoul)
EXPORT_FUNC(simple_strtol)
EXPORT_FUNC(strcmp)
-#if defined(CONFIG_CMD_I2C)
EXPORT_FUNC(i2c_write)
EXPORT_FUNC(i2c_read)
-#endif
+EXPORT_FUNC(spi_init)
+EXPORT_FUNC(spi_setup_slave)
+EXPORT_FUNC(spi_free_slave)
+EXPORT_FUNC(spi_claim_bus)
+EXPORT_FUNC(spi_release_bus)
+EXPORT_FUNC(spi_xfer)
diff --git a/include/exports.h b/include/exports.h
index 0620e9e..16ea03a 100644
--- a/include/exports.h
+++ b/include/exports.h
@@ -33,6 +33,7 @@ void forceenv (char *varname, char *varvalue);
int i2c_write (uchar, uint, int , uchar* , int);
int i2c_read (uchar, uint, int , uchar* , int);
#endif
+#include spi.h
void app_startup(char **);
@@ -46,7 +47,7 @@ enum {
XF_MAX
};
-#define XF_VERSION 4
+#define XF_VERSION 5
#if defined(CONFIG_I386)
extern gd_t *global_data;
--
1.6.3.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM Pull Request
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090723202252.ga9...@game.jcrosoft.org you wrote: Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables? not because I do not like it because there are not safe and must be omap3 specific and not generic for soc specific struct We don't make any such restrictions in other, similar header files. Adding (artifical) prefixes like omap3_ as you requested just makes it more likely thatthe some declarations and code will be repeated elsewhere, just with a different name. If you have a specific example, where you see existing or even likely name conflicts, then please show it. Otherwise I suggest we just leave the code as is. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to one instruction which doesn't work. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] atmel_df_pow2: standalone to convert dataflashes to pow2
Atmel DataFlashes by default operate with pages that are slightly bigger
than normal binary sizes (i.e. many are 1056 byte pages rather than 1024
bytes). However, they also have a power of 2 mode where the pages show
up with the normal binary size. The latter mode is required in order to
boot with a Blackfin processor, so many people wish to convert their
DataFlashes on their development systems to this mode. This standalone
application does just that.
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
examples/standalone/.gitignore |1 +
examples/standalone/Makefile|4 +
examples/standalone/atmel_df_pow2.c | 209 +++
3 files changed, 214 insertions(+), 0 deletions(-)
create mode 100644 examples/standalone/atmel_df_pow2.c
diff --git a/examples/standalone/.gitignore b/examples/standalone/.gitignore
index 0d1864c..7b783fc 100644
--- a/examples/standalone/.gitignore
+++ b/examples/standalone/.gitignore
@@ -1,4 +1,5 @@
/82559_eeprom
+/atmel_df_pow2
/hello_world
/interrupt
/mem_to_mem_idma2intr
diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile
index dbcfa92..9f67afd 100644
--- a/examples/standalone/Makefile
+++ b/examples/standalone/Makefile
@@ -86,6 +86,10 @@ ELF = hello_world
SREC = hello_world.srec
BIN= hello_world.bin
+ELF+= atmel_df_pow2
+SREC += atmel_df_pow2.srec
+BIN+= atmel_df_pow2.bin
+
ifeq ($(CPU),mpc8xx)
ELF+= test_burst
SREC += test_burst.srec
diff --git a/examples/standalone/atmel_df_pow2.c
b/examples/standalone/atmel_df_pow2.c
new file mode 100644
index 000..db0cd69
--- /dev/null
+++ b/examples/standalone/atmel_df_pow2.c
@@ -0,0 +1,209 @@
+/*
+ * atmel_df_pow2.c - convert Atmel Dataflashes to Power of 2 mode
+ *
+ * Copyright 2009 Analog Devices Inc.
+ *
+ * Licensed under the 2-clause BSD.
+ */
+
+#include common.h
+#include exports.h
+
+#define CMD_ID0x9f
+#define CMD_STAT 0xd7
+#define CMD_CFG 0x3d
+
+static int flash_cmd(struct spi_slave *slave, uchar cmd, uchar *buf, int len)
+{
+ buf[0] = cmd;
+ return spi_xfer(slave, 8 * len, buf, buf, SPI_XFER_BEGIN |
SPI_XFER_END);
+}
+
+static int flash_status(struct spi_slave *slave)
+{
+ uchar buf[2];
+ if (flash_cmd(slave, CMD_STAT, buf, sizeof(buf)))
+ return -1;
+ return buf[1];
+}
+
+static int flash_set_pow2(struct spi_slave *slave)
+{
+ int ret;
+ uchar buf[4];
+
+ buf[1] = 0x2a;
+ buf[2] = 0x80;
+ buf[3] = 0xa6;
+
+ ret = flash_cmd(slave, CMD_CFG, buf, sizeof(buf));
+ if (ret)
+ return ret;
+
+ /* wait Tp, or 6 msec */
+ udelay(6000);
+
+ ret = flash_status(slave);
+ if (ret == -1)
+ return 1;
+
+ return ret 0x1 ? 0 : 1;
+}
+
+static int flash_check(struct spi_slave *slave)
+{
+ int ret;
+ uchar buf[4];
+
+ ret = flash_cmd(slave, CMD_ID, buf, sizeof(buf));
+ if (ret)
+ return ret;
+
+ if (buf[1] != 0x1F) {
+ printf(atmel flash not found (id[0] = %#x)\n, buf[1]);
+ return 1;
+ }
+
+ if ((buf[2] 5) != 0x1) {
+ printf(AT45 flash not found (id[0] = %#x)\n, buf[2]);
+ return 2;
+ }
+
+ return 0;
+}
+
+static char *getline(void)
+{
+ static char buffer[100];
+ char c;
+ size_t i;
+
+ i = 0;
+ while (1) {
+ buffer[i] = '\0';
+
+ c = getc();
+
+ switch (c) {
+ case '\r': /* Enter/Return key */
+ case '\n':
+ puts(\n);
+ return buffer;
+
+ case 0x03: /* ^C - break */
+ return NULL;
+
+ case 0x5F:
+ case 0x08: /* ^H - backspace */
+ case 0x7F: /* DEL - backspace */
+ if (i) {
+ puts(\b \b);
+ i--;
+ }
+ break;
+
+ default:
+ /* Ignore control characters */
+ if (c 0x20)
+ break;
+ /* Queue up all other characters */
+ buffer[i++] = c;
+ printf(%c, c);
+ break;
+ }
+ }
+}
+
+int atmel_df_pow2(int argc, char *argv[])
+{
+ /* Print the ABI version */
+ app_startup(argv);
+ if (XF_VERSION != get_version()) {
+ printf(Expects ABI version %d\n, XF_VERSION);
+ printf(Actual U-Boot ABI version %lu\n, get_version());
+ printf(Can't run\n\n);
+ return 1;
+ }
+
+ spi_init();
+
+ while (1) {
+ struct spi_slave *slave;
+ char *line, *p;
+ int bus, cs, status;
+
+
Re: [U-Boot] [PATCH] Using I/O accessor instead of volatile pointers in SMC911x driver
Wolfgang Denk wrote: Dear Matthias Weisser, In message 1248250473-12694-1-git-send-email-matthias.weis...@graf-syteco.de you wrote: Volatile pointer usage caused lockup with arm-gcc 4.3.2 Using I/O accessor fixed that. Hm... -return *(volatile u32*)addr; +return readl(addr); On big-endian systems like PowerPC, readl() is a byte-swapping (little-endian) input function, which means that your patch changes the byte order of all I/O operations. Yeah, that's why I left these alone when re-working this driver. I don't know what the correct approach is when using memory-mapped devices that could in theory go on the local bus of any processor. Most people I know would hook them up according to the native endianness. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] Less verbose output when loading vxworks 6.x images
Loading vxWorks 5.x images resulted just into 3 or 4 lines of output.
With vxWorks 6.x and the new GCC it emits about 30 lines, which is
far too noisy in my opinion.
Signed-off-by: Niklaus Giger niklaus.gi...@member.fsf.org
---
common/cmd_elf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/cmd_elf.c b/common/cmd_elf.c
index abec7dd..63f6fe7 100644
--- a/common/cmd_elf.c
+++ b/common/cmd_elf.c
@@ -287,7 +287,7 @@ unsigned long load_elf_image (unsigned long addr)
}
if (strtab) {
- printf (%sing %s @ 0x%08lx (%ld bytes)\n,
+ debug(%sing %s @ 0x%08lx (%ld bytes)\n,
(shdr-sh_type == SHT_NOBITS) ?
Clear : Load,
strtab[shdr-sh_name],
--
1.6.3.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD
On 02:17 Thu 23 Jul , Ilya Yanok wrote:
Hi Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
+static int imx27lite_devices_init(void)
+{
+ struct gpio_regs *regs = (struct gpio_regs *)IMX_GPIO_BASE;
+ int i;
+ unsigned int mode[] = {
+ PD0_AIN_FEC_TXD0,
+ PD1_AIN_FEC_TXD1,
+ PD2_AIN_FEC_TXD2,
+ PD3_AIN_FEC_TXD3,
+ PD4_AOUT_FEC_RX_ER,
+ PD5_AOUT_FEC_RXD1,
+ PD6_AOUT_FEC_RXD2,
+ PD7_AOUT_FEC_RXD3,
+ PD8_AF_FEC_MDIO,
+ PD9_AIN_FEC_MDC | GPIO_PUEN,
+ PD10_AOUT_FEC_CRS,
+ PD11_AOUT_FEC_TX_CLK,
+ PD12_AOUT_FEC_RXD0,
+ PD13_AOUT_FEC_RX_DV,
+ PD14_AOUT_FEC_CLR,
+ PD15_AOUT_FEC_COL,
+ PD16_AIN_FEC_TX_ER,
+ PF23_AIN_FEC_TX_EN,
+ PE12_PF_UART1_TXD,
+ PE13_PF_UART1_RXD,
+ PB4_PF_SD2_D0,
+ PB5_PF_SD2_D1,
+ PB6_PF_SD2_D2,
+ PB7_PF_SD2_D3,
+ PB8_PF_SD2_CMD,
+ PB9_PF_SD2_CLK,
+ (GPIO_PORTC | GPIO_OUT | GPIO_PUEN | GPIO_GPIO | 31),
+ };
+
+ for (i = 0; i ARRAY_SIZE(mode); i++)
+ imx_gpio_mode(mode[i]);
you do not answer about my api comment?
Sorry, I forgot to write a separate mail to ask you.
do you plan to create one for device init?
What kind of API you expect me to create here? It's just IO pins
initialization...
do as at91, davinci all related init for rs232, usb, net in one function
per init
Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
On 22:24 Wed 22 Jul , Ben Warren wrote: Jean-Christophe PLAGNIOL-VILLARD wrote: -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y)) all: $(obj).depend $(LIB) diff --git a/cpu/arm920t/at91rm9200/ks8721.c b/cpu/arm920t/at91rm9200/ks8721.c new file mode 100644 index 000..703e58c --- /dev/null +++ b/cpu/arm920t/at91rm9200/ks8721.c @@ -0,0 +1,244 @@ +/* + * (C) Copyright 2006 + * Author : Eric Benard (Eukrea Electromatique) + * based on dm9161.c which is : + * (C) Copyright 2003 + * Author : Hamid Ikdoumi (Atmel) I'm not a fan of this implementation at all but as I've not yet finish the rm9200 cleanup I'll ack this ben what do you think? ben please note that the rm9200 cleanup will introduce a phylib support Ben ping Best Regards, J. This patch has many coding style violations that haven't been addressed, so it can't go in. Im not a fan of the piece-meal PHY implementation either, but realize that a real PHY lib isn't imminent, unless your rm2000 implementation is useful across architectures. it will be a generic implementation as we need it also for other soc and arch for our boards. Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
Jean-Christophe PLAGNIOL-VILLARD wrote: On 22:24 Wed 22 Jul , Ben Warren wrote: Jean-Christophe PLAGNIOL-VILLARD wrote: -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y)) all: $(obj).depend $(LIB) diff --git a/cpu/arm920t/at91rm9200/ks8721.c b/cpu/arm920t/at91rm9200/ks8721.c new file mode 100644 index 000..703e58c --- /dev/null +++ b/cpu/arm920t/at91rm9200/ks8721.c @@ -0,0 +1,244 @@ +/* + * (C) Copyright 2006 + * Author : Eric Benard (Eukrea Electromatique) + * based on dm9161.c which is : + * (C) Copyright 2003 + * Author : Hamid Ikdoumi (Atmel) I'm not a fan of this implementation at all but as I've not yet finish the rm9200 cleanup I'll ack this ben what do you think? ben please note that the rm9200 cleanup will introduce a phylib support Ben ping Best Regards, J. This patch has many coding style violations that haven't been addressed, so it can't go in. Im not a fan of the piece-meal PHY implementation either, but realize that a real PHY lib isn't imminent, unless your rm2000 implementation is useful across architectures. it will be a generic implementation as we need it also for other soc and arch for our boards. Best Regards, J. Good. Can't wait. Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] document network driver framework
On 21:04 Sat 18 Jul , Mike Frysinger wrote: Signed-off-by: Mike Frysinger vap...@gentoo.org --- Ben: some things to note: - i adopted Jean's proposed naming scheme in the CONFIG section - i deprecated calling the driver-specific entry point xxx_initialization() in favor of xxx_register() because the former is way too confusing with everyone also having xxx_init() doc/README.drivers.eth | 199 1 files changed, 199 insertions(+), 0 deletions(-) create mode 100644 doc/README.drivers.eth diff --git a/doc/README.drivers.eth b/doc/README.drivers.eth new file mode 100644 index 000..00b4eb1 --- /dev/null +++ b/doc/README.drivers.eth @@ -0,0 +1,199 @@ +--- + Ethernet Driver Guide +--- + +The networking stack in Das U-Boot is designed for multiple network devices +to be easily added and controlled at runtime. This guide is meant for people +who wish to review the net driver stack with an eye towards implementing your +own ethernet device driver. Here we will describe a new pseudo 'APE' driver. + + + CONFIG Options + + +The common config defines your device should respect (if applicable): + CONFIG_MII - configure in MII mode + CONFIG_RMII - configure in RMII mode how will you deal you on your board you have a MII and a RMII chip used I think need to be configure via drivers specifc CONFIG if your driver can not deal with 2 different instance config or via driver init param + + CONFIG_CMD_MII - support the MII command + +If you want to add config options specific to your driver, you should use the +naming convention: + CONFIG_NET_DRIVERNAME_OPTION +For example, if the APE driver could operate in either 16bit or 32bit mode, +there would probably be the option: + CONFIG_NET_APE_32BIT - operate in 32bit mode rather than 16bit default + +And to control whether your driver is even enabled, you should use: + CONFIG_SYS_NET_DRIVERNAME In my proposition CONFIG_SYS_ will be not use for driver enabling but for hardware specific information +So the APE driver would look like: + CONFIG_SYS_NET_APE so it will be CONFIG_NET_APE + +-- + Driver Functions +-- + +All functions you will be implementing in this document have the return value +meaning of 0 for success and non-zero for failure. + snip + + CONFIG_CMD_MII + + +If your device supports banging arbitrary values on the MII bus (pretty much +every device does), you should add support for the mii command. Doing so is +fairly trivial and makes debugging mii issues a lot easier at runtime. + +After you have called eth_register() in your driver's register function, add +a call to miiphy_register() like so: +#ifdef CONFIG_CMD_MII + miiphy_register(dev-name, mii_read, mii_write); +#endif + +And then define the mii_read and mii_write functions if you haven't already. +Their syntax is straightforward: + int mii_read(char *devname, uchar addr, uchar reg, ushort *val); + int mii_write(char *devname, uchar addr, uchar reg, ushort val); + +The read function should read the register 'reg' from the phy at address 'addr' +and store the result in the pointer 'val'. The implementation for the write +function should logically follow. we will rewrite this api when we will push the phylib Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] arm/board.c: avoid ifdef using weak default functions
On 19:19 Wed 22 Jul , Alessandro Rubini wrote: From: Alessandro Rubini rub...@gnudd.com While it's a matter of personal taste, I prefer to avoid ifdef when possible. For example, I don't like to add BOARD_LATE_INIT in the config file just to have my board_late_init() function called. This patch (not meant to be applied mainstram, jsut for discussion) tries to simplify and make more readable the code in lib_arm/board.c. If this is considered useful it can be done more seriously to all platforms, and allow over time to remove defines in the class of BOARD_LATE_INIT. A serious reordering will definitely need more time, and this is just a quick hack to show the idea; some things are suboptimal like the arm_pci_init() thing which has to remain an ifdef and should be fixed in a different way (I think all init function should return int and print their own messages, to simplify this factoring out, but again it's a matter of personal taste). About the use of weak, I first converted .a to .o, but then found it works nonetheless, and led functions are already weak ones in this file. Is the idea worth pursuing? Or does it conflich with other work in progress? I've already send an RFC about initcall I'm not in favor a weak function as it will increase the size of U-Boot and will not be easy to use as we seen a lots of time due to compiler issue so I think the initcall mecansim will be more generic, more easier to use and smaller than the current implementation (already tested) Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] unable to see jffs2 partition
Hi all, I've been trying unsuccessfully to see my jffs2 partition I've created by the mtdtools under linux. If their a known issue with this? Is their a size limit? Maybe the way it's created? I do not have a problem with this partition from linux but also never looked at it from the u-boot. I can change partitions but ls shows partition is empty when their are files. ... #define CONFIG_CMD_JFFS21 /** JFFS2 Support */ #define CONFIG_CMD_MTDPARTS 1 #define CONFIG_JFFS2_CMDLINE1 #undef CONFIG_CMD_FLASH #define CONFIG_JFFS2_NAND 1 #define CONFIG_JFFS2_DEVnand0 #define CONFIG_JFFS2_PART_OFFSET0x0 #define CONFIG_JFFS2_PART_SIZE 0x500 #define MTDPARTS_DEFAULTmtdparts=nand:80M(IMGS),-(DATA) #define MTDIDS_DEFAULT nand0=nand ... Thanks, E! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] unable to see jffs2 partition
On Thursday 23 July 2009 04:57:19 pm E Robertson wrote: Hi all, I've been trying unsuccessfully to see my jffs2 partition I've created by the mtdtools under linux. If their a known issue with this? Is their a size limit? Maybe the way it's created? I do not have a problem with this partition from linux but also never looked at it from the u-boot. I can change partitions but ls shows partition is empty when their are files. ... #define CONFIG_CMD_JFFS21 /** JFFS2 Support */ #define CONFIG_CMD_MTDPARTS 1 #define CONFIG_JFFS2_CMDLINE1 #undef CONFIG_CMD_FLASH #define CONFIG_JFFS2_NAND 1 #define CONFIG_JFFS2_DEVnand0 #define CONFIG_JFFS2_PART_OFFSET0x0 #define CONFIG_JFFS2_PART_SIZE 0x500 #define MTDPARTS_DEFAULTmtdparts=nand:80M(IMGS),-(DATA) #define MTDIDS_DEFAULT nand0=nand ... Thanks, E! Forget to add I'm using 03.09 git source on SAM9263 SoC. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] lcd.h: define extern vidinfo_t for all cases
On 14:09 Tue 21 Jul , Alessandro Rubini wrote: From: Alessandro Rubini rub...@gnudd.com include/lcd.h has different vidinfo for different platforms, and several extern declaration, but one for the default case was missing. This makes them a single extern declaration for everyone. Signed-off-by: Alessandro Rubini rub...@gnudd.com --- include/lcd.h |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) Acked-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] document network driver framework
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090723214946.ge9...@game.jcrosoft.org you wrote: +And to control whether your driver is even enabled, you should use: + CONFIG_SYS_NET_DRIVERNAME In my proposition CONFIG_SYS_ will be not use for driver enabling but for hardware specific information Enabling or disabling a driver i ssomething that a dumb user can do, so it should be done using CONFIG_DRIVERNAME as in CONFIG_E1000, CONFIG_EEPRO100, etc. +So the APE driver would look like: + CONFIG_SYS_NET_APE so it will be CONFIG_NET_APE No. It should be CONFIG_APE Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Niklaus Wirth has lamented that, whereas Europeans pronounce his name correctly (Ni-klows Virt), Americans invariably mangle it into (Nick- les Worth). Which is to say that Europeans call him by name, but Americans call him by value. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-usb
The following changes since commit 28958b8bea4c66629c5a22fd3c8b0d49df90383d: Wolfgang Denk (1): Coding Style cleanup; update CHANGELOG. are available in the git repository at: git://git.denx.de/u-boot-usb.git master Prafulla Wadaskar (1): usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root drivers/usb/host/ehci-hcd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arm nomadik: add gpio support
On 13:02 Sun 19 Jul , Alessandro Rubini wrote: From: Alessandro Rubini rub...@unipv.it Signed-off-by: Alessandro Rubini rub...@unipv.it Acked-by: Andrea Gallo andrea.ga...@stericsson.com --- board/st/nhk8815/Makefile |2 +- board/st/nhk8815/gpio.c | 99 + board/st/nhk8815/gpio.h | 42 +++ 3 files changed, 142 insertions(+), 1 deletions(-) create mode 100644 board/st/nhk8815/gpio.c create mode 100644 board/st/nhk8815/gpio.h I guess this is soc dependent so please move it to cpu/arm926ejs/nomadik for .c and to include/asm-arm/arch-nomadik otherwise fine Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] document network driver framework
Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090723214946.ge9...@game.jcrosoft.org you wrote: +And to control whether your driver is even enabled, you should use: + CONFIG_SYS_NET_DRIVERNAME In my proposition CONFIG_SYS_ will be not use for driver enabling but for hardware specific information Enabling or disabling a driver i ssomething that a dumb user can do, so it should be done using CONFIG_DRIVERNAME as in CONFIG_E1000, CONFIG_EEPRO100, etc. Fine with me, although I understand the argument that it doesn't convey enough information, especially when dealing with devices that are more obscure than Intel E1000. CONFIG_SYS_APE is definitely wrong, I think CONFIG_NET_APE should be for networking features such as selectable protocols. Maybe a compromise if one is needed would be CONFIG_NETDEV_APE ? Or is it too verbose? regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Make include/common.h usable by assembler code
Commit 70ebf316 factored out the ROUND() macro into include/common.h, not realizing that the primary use of this macro on AT91 systems was in start.S where common.h was not included, and could not be included because it contains a lot of C code which the assembler doesn't understand. This patch wraps such code in common.h in a #ifndef __ASSEMBLY__ construct, and then adds an include to cpu/arm926ejs/start.S thus solving the problem. Signed-off-by: Wolfgang Denk w...@denx.de --- cpu/arm926ejs/start.S |1 + include/common.h | 37 - 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/cpu/arm926ejs/start.S b/cpu/arm926ejs/start.S index 0275b66..8043322 100644 --- a/cpu/arm926ejs/start.S +++ b/cpu/arm926ejs/start.S @@ -32,6 +32,7 @@ #include config.h +#include common.h #include version.h #if defined(CONFIG_OMAP1610) diff --git a/include/common.h b/include/common.h index 6e689b2..ee174bb 100644 --- a/include/common.h +++ b/include/common.h @@ -27,6 +27,8 @@ #undef _LINUX_CONFIG_H #define _LINUX_CONFIG_H 1 /* avoid reading Linux autoconf.h file */ +#ifndef __ASSEMBLY__ /* put C only stuff in this section */ + typedef unsigned char uchar; typedef volatile unsigned long vu_long; typedef volatile unsigned short vu_short; @@ -105,6 +107,9 @@ typedef volatile unsigned char vu_char; #ifdef CONFIG_BLACKFIN #include asm/blackfin.h #endif +#ifdef CONFIG_STATUS_LED +#include status_led.h +#endif #include part.h #include flash.h @@ -636,11 +641,9 @@ intdisable_ctrlc (int);/* 1 to disable, 0 to enable Control-C detect */ /* * STDIO based functions (can always be used) */ - /* serial stuff */ void serial_printf (const char *fmt, ...) __attribute__ ((format (__printf__, 1, 2))); - /* stdin */ intgetc(void); inttstc(void); @@ -660,7 +663,6 @@ voidvprintf(const char *fmt, va_list args); /* * FILE based functions (can only be used AFTER relocation!) */ - #define stdin 0 #define stdout 1 #define stderr 2 @@ -682,14 +684,26 @@ int fgetc(int file); intpcmcia_init (void); -#ifdef CONFIG_STATUS_LED -# include status_led.h -#endif /* * Board-specific Platform code can reimplement show_boot_progress () if needed */ void show_boot_progress(int val); +/* Multicore arch functions */ +#ifdef CONFIG_MP +int cpu_status(int nr); +int cpu_reset(int nr); +int cpu_release(int nr, int argc, char *argv[]); +#endif + +#endif /* __ASSEMBLY__ */ + +/* Put only stuff here that the assembler can digest */ + +#ifdef CONFIG_POST +#define CONFIG_HAS_POST +#endif + #ifdef CONFIG_INIT_CRITICAL #error CONFIG_INIT_CRITICAL is deprecated! #error Read section CONFIG_SKIP_LOWLEVEL_INIT in README. @@ -705,15 +719,4 @@ void show_boot_progress(int val); #define ALIGN(x,a) __ALIGN_MASK((x),(typeof(x))(a)-1) #define __ALIGN_MASK(x,mask) (((x)+(mask))~(mask)) -/* Multicore arch functions */ -#ifdef CONFIG_MP -int cpu_status(int nr); -int cpu_reset(int nr); -int cpu_release(int nr, int argc, char *argv[]); -#endif - -#ifdef CONFIG_POST -#define CONFIG_HAS_POST -#endif - #endif /* __COMMON_H_ */ -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 1/2] Add support for Eukrea CPU9260 SBC
On 23:45 Sat 18 Jul , Eric Benard wrote: CPUAT91 is built around Atmel's AT91SAM9260 and has up to 64MB of NOR flash, up to 128MB of SDRAM, up to 2GB of NAND and includes a 10/100 Ethernet PHY in RMII mode. v4 : do the commit before generating/sending the patch ;-) v3 : fix Makefile (run mkconfig after config.h configuration) Signed-off-by: Eric Benard e...@eukrea.com --- MAINTAINERS|4 + MAKEALL|1 + Makefile | 13 ++ board/eukrea/cpu9260/Makefile | 59 +++ board/eukrea/cpu9260/config.mk |1 + board/eukrea/cpu9260/cpu9260.c | 211 +++ board/eukrea/cpu9260/cpu9260_led.c | 46 + include/configs/cpu9260.h | 335 8 files changed, 670 insertions(+), 0 deletions(-) create mode 100644 board/eukrea/cpu9260/Makefile create mode 100644 board/eukrea/cpu9260/config.mk create mode 100644 board/eukrea/cpu9260/cpu9260.c create mode 100644 board/eukrea/cpu9260/cpu9260_led.c create mode 100644 include/configs/cpu9260.h diff --git a/MAINTAINERS b/MAINTAINERS index 575a7ec..b8d701a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -515,6 +515,10 @@ Dirk Behme dirk.be...@gmail.com omap3_beagleARM CORTEX-A8 (OMAP3530 SoC) +Eric Benard e...@eukrea.com + + cpu9260 ARM926EJS (AT91SAM9260 SoC) + Rishi Bhattacharya ri...@ti.com omap5912osk ARM926EJS diff --git a/MAKEALL b/MAKEALL index 020ff73..bdc80fa 100755 --- a/MAKEALL +++ b/MAKEALL @@ -592,6 +592,7 @@ LIST_at91= \ at91sam9m10g45ek\ at91sam9rlek\ cmc_pu2 \ + cpu9260 \ csb637 \ kb9202 \ meesc \ diff --git a/Makefile b/Makefile index 090e645..8c4178f 100644 --- a/Makefile +++ b/Makefile @@ -2813,6 +2813,19 @@ at91sam9rlek_config: unconfig fi; @$(MKCONFIG) -a at91sam9rlek arm arm926ejs at91sam9rlek atmel at91 +cpu9260_64m_config \ +cpu9260_config : unconfig + @if [ $(findstring _64m,$@) ] ; then \ + echo #define CONFIG_SYS_SDRC_CR_VAL CONFIG_SYS_SDRC_CR_VAL_64MB \ + $(obj)include/config.h ; \ + $(XECHO) ... CPU9260 with 64MB SDRAM ; \ + else \ + echo #define CONFIG_SYS_SDRC_CR_VAL CONFIG_SYS_SDRC_CR_VAL_128MB \ + $(obj)include/config.h ; \ + $(XECHO) ... CPU9260 with 128MB SDRAM ; \ + fi; + @$(MKCONFIG) -a cpu9260 arm arm926ejs cpu9260 eukrea at91 + meesc_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs meesc esd at91 diff --git a/board/eukrea/cpu9260/Makefile b/board/eukrea/cpu9260/Makefile new file mode 100644 index 000..5b1acdc --- /dev/null +++ b/board/eukrea/cpu9260/Makefile @@ -0,0 +1,59 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# (C) Copyright 2008 +# Stelian Pop stelian@leadtechdesign.com +# Lead Tech Design www.leadtechdesign.com +# Ilko Iliev www.ronetix.at +# +# (C) Copyright 2009 +# Eric Benard e...@eukrea.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS-y += $(BOARD).o +COBJS-y += $(BOARD)_led.o please keep the same way as all other at91sam COBJS-y += led.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y) $(SOBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/eukrea/cpu9260/config.mk b/board/eukrea/cpu9260/config.mk new file mode
Re: [U-Boot] [PATCH 2/2] document network driver framework
Dear Ben Warren, In message 4a68e0c1.2000...@gmail.com you wrote: Enabling or disabling a driver i ssomething that a dumb user can do, so it should be done using CONFIG_DRIVERNAME as in CONFIG_E1000, CONFIG_EEPRO100, etc. Fine with me, although I understand the argument that it doesn't convey enough information, especially when dealing with devices that are more obscure than Intel E1000. CONFIG_SYS_APE is definitely wrong, I think I understand the argument, too. But then I find it extremely useful to use the very same config names as Linux, and Linux uses CONFIG_E100, CONFIG_NATSEMI, CONFIG_NE2K_PCI, CONFIG_8139CP, CONFIG_TLAN, CONFIG_ATP, CONFIG_E1000, ... CONFIG_NET_APE should be for networking features such as selectable protocols. Maybe a compromise if one is needed would be CONFIG_NETDEV_APE ? Or is it too verbose? I think we should remain compatible with Linux here, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Little known fact about Middle Earth: The Hobbits had a very sophi- sticated computer network! It was a Tolkien Ring... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Add support for Eukrea CPUAT91 SBC
--- a/MAKEALL +++ b/MAKEALL @@ -587,11 +587,12 @@ LIST_at91= \ at91sam9260ek \ at91sam9261ek \ at91sam9263ek \ - at91sam9g10ek \ + at91sam9g10ek \ please do not touch non related part to your patch please fix it in an other patch at91sam9g20ek \ at91sam9m10g45ek\ at91sam9rlek\ cmc_pu2 \ + cpuat91 \ csb637 \ kb9202 \ meesc \ diff --git a/Makefile b/Makefile index 090e645..3b348d9 100644 --- a/Makefile +++ b/Makefile @@ -2683,6 +2683,18 @@ at91rm9200ek_config: unconfig cmc_pu2_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200 +cpuat91_ram_config \ +cpuat91_config : unconfig + @mkdir -p $(obj)include + @if [ $(findstring _ram_,$@) ] ; then \ + echo #define CONFIG_CPUAT91_RAM 1 $(obj)include/config.h ; \ same as other patch no need please define the #define CONFIG_SKIP_LOWLEVEL_INIT #define CONFIG_SKIP_RELOCATE_UBOOT here + $(XECHO) ... CPUAT91 configured for RAM ; \ + else \ + echo #define CONFIG_BOOTDELAY 1 $(obj)include/config.h ;\ + $(XECHO) ... CPUAT91 configured for Flash ;\ + fi; + @$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200 + csb637_config: unconfig @$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200 diff --git a/board/eukrea/cpuat91/Makefile b/board/eukrea/cpuat91/Makefile new file mode 100644 index 000..08a90dc --- /dev/null +++ b/board/eukrea/cpuat91/Makefile @@ -0,0 +1,50 @@ +# +# (C) Copyright 2003-2006 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS:= cpuat91.o please be consistant with your other patch $(BOARD) + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + snip + +#endif /* CONFIG_CMD_NET */ +#endif /* CONFIG_DRIVER_ETHER */ diff --git a/cpu/arm920t/at91rm9200/Makefile b/cpu/arm920t/at91rm9200/Makefile index 73aeeac..114d8ad 100644 --- a/cpu/arm920t/at91rm9200/Makefile +++ b/cpu/arm920t/at91rm9200/Makefile @@ -31,14 +31,15 @@ COBJS += bcm5221.o COBJS+= dm9161.o COBJS+= ether.o COBJS+= i2c.o +COBJS-$(CONFIG_KS8721_PHY) += ks8721.o COBJS+= lxt972.o COBJS+= reset.o COBJS+= spi.o COBJS+= timer.o COBJS+= usb.o -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y)) please switch all to COBJS-y all: $(obj).depend $(LIB) you have also some whitespace in your patch please fix Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU
On 17:30 Wed 22 Jul , Thomas Petazzoni wrote: The Calao USB A9263 board is a board manufactured and sold by Calao Systems http://www.calao-systems.com. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, etc. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com --- please no RE in the subject This new version includes the following changes : * Copyright header on config.mk, by suggestion of Peter Tyser * Updated copyright informations in all new files * Use get_ram_size(), as suggested by Wolfgang Denk * Do some cleanup of useless comments, re-indent definitions to avoid long lines, etc. * Add entry to MAINTAINERS I'm still including the definition of ROUND() in the board configuration file, since Wolfgang's patch has yet been merged to the Git tree (and I don't think sending a patch that doesn't compile against the current Git tree is useful). MAINTAINERS |4 MAKEALL |1 Makefile |3 board/calao/usb-a9263/Makefile| 58 +++ board/calao/usb-a9263/config.mk | 24 board/calao/usb-a9263/partition.c | 38 +++ board/calao/usb-a9263/usb-a9263.c | 194 ++ include/configs/usb-a9263.h | 185 8 files changed, 507 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 575a7ec..5c37647 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -624,6 +624,10 @@ Peter Pearse peter.pea...@arm.com versatile ARM926EJ-S versatile ARM926EJ-S +Thomas Petazzoni thomas.petazz...@free-electrons.com + + usb-a9263 ARM926EJS (AT91SAM9263 SoC) + Dave Peverley dpever...@mpc-data.co.uk omap730p2 ARM926EJS snip diff --git a/board/calao/usb-a9263/usb-a9263.c b/board/calao/usb-a9263/usb-a9263.c new file mode 100644 index 000..7cf1925 --- /dev/null +++ b/board/calao/usb-a9263/usb-a9263.c @@ -0,0 +1,194 @@ +/* + * (C) Copyright 2007-2009 + * Stelian Pop stelian@leadtechdesign.com + * Lead Tech Design www.leadtechdesign.com + * Thomas Petazzoni, Free Electrons, thomas.petazz...@free-electrons.com + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include common.h +#include asm/sizes.h +#include asm/arch/at91sam9263.h +#include asm/arch/at91sam9263_matrix.h please #include asm/arch/at91sam9_matrix.h +#include asm/arch/at91sam9_smc.h +#include asm/arch/at91_common.h +#include asm/arch/at91_pmc.h +#include asm/arch/at91_rstc.h +#include asm/arch/clk.h +#include asm/arch/gpio.h +#include asm/arch/io.h +#include asm/arch/hardware.h +#if defined(CONFIG_RESET_PHY_R) defined(CONFIG_MACB) +#include net.h +#endif +#include netdev.h + +DECLARE_GLOBAL_DATA_PTR; + +/* - */ +/* + * Miscelaneous platform dependent initialisations + */ + + +#include asm/arch/at91sam9263.h no please do not include it here but in the correctly file need + +/* ARM asynchronous clock */ +#define AT91_MAIN_CLOCK 1200/* 12 MHz crystal */ +#define CONFIG_SYS_HZ1000 + +#define CONFIG_ARM926EJS 1 /* This is an ARM926EJS Core*/ +#define CONFIG_AT91SAM9263 1 /* It's an Atmel AT91SAM9263 SoC*/ +#define CONFIG_CALAO_USB_A9263 1 /* on an Calao USB A 9263 Board */ +#define CONFIG_ARCH_CPU_INIT +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff */ + +#define CONFIG_CMDLINE_TAG 1 /* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG1 + +#define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_SKIP_RELOCATE_UBOOT + +/* + * Hardware drivers + */ +#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART31 /* USART 3 is DBGU */ + +/* LCD */ +#undef CONFIG_LCD + +#define
Re: [U-Boot] arm: pRAM support?
On 07:49 Wed 22 Jul , Heiko Schocher wrote: Hello Andreas, Andreas Huber wrote: We are using the pRAM feature (CONFIG_PRAM) on the PPC architecture. As we are switching to an ARM architecture (Kirkwood) I am wondering if there is an equivalent U-Boot feature for this (CONFIG_PRAM did not work). As this functionality uses RAM at the end of RAM, it should be possible to add this also to ARM plattforms. Jean-Christophe, Prafulla, are there any objections on it? just one requirement it must be ARM generic and not board or soc specific Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Add support for Eukrea CPUAT91 SBC
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090723222713.gc24...@game.jcrosoft.org you wrote: --- a/Makefile +++ b/Makefile @@ -2683,6 +2683,18 @@ at91rm9200ek_config : unconfig cmc_pu2_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200 +cpuat91_ram_config \ +cpuat91_config : unconfig + @mkdir -p $(obj)include + @if [ $(findstring _ram_,$@) ] ; then \ + echo #define CONFIG_CPUAT91_RAM 1 $(obj)include/config.h ; \ same as other patch no need please define the #define CONFIG_SKIP_LOWLEVEL_INIT #define CONFIG_SKIP_RELOCATE_UBOOT here No. Not here, i. e. not in the Makefile. We don't want tens of lines of scripts per board in the top level Makefile. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you die, the first thing you lose is your life. The next thing is the illusions. - Terry Pratchett, _Pyramids_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
