Re: [U-Boot] [PATCH] [MPC837x v2] Make it work again with USB.
Kim, > On Tue, 16 Nov 2010 13:37:50 +0100 > Andre Schwarz wrote: > > > USB register range IMMR+0x00-0xff is reserved and hangs the CPU. > > > > Signed-off-by: Andre Schwarz > > --- > > nack, 837x has a usb controller at IMMR+0x23000. yes - but offset 0x00-0xff is explicitly reserved regarding to the manual. Don't know whether it is a "should not" or "must not be touched". All I can see is a CPU hang with arbiter event register reporting a timeout on 0xe0023000. Check to see whether there is an invalid USB clock setting in the SCCR? All clocks are turned on except SEC and 2nd TSEC. After all USB is running fine with this patch, i.e. there can hardly be a missing clock. Please re-think you NAK. -- Gruß, André Schwarz MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ARMV7: OMAP4: twl6030 add battery charging support
From: Balaji T K
Add battery charging support twl6030 driver.
Add support for battery voltage and current measurements.
Add command to get battery status and start/stop battery charging from USB.
Signed-off-by: Balaji T K
Tested-by: Steve Sakoman
---
board/ti/sdp4430/Makefile |2 +-
board/ti/sdp4430/cmd_bat.c | 58 ++
board/ti/sdp4430/sdp.c |4 +
drivers/power/twl6030.c | 124 ++-
include/configs/omap4_sdp4430.h |1 +
include/twl6030.h | 45 +-
6 files changed, 229 insertions(+), 5 deletions(-)
create mode 100644 board/ti/sdp4430/cmd_bat.c
diff --git a/board/ti/sdp4430/Makefile b/board/ti/sdp4430/Makefile
index bce8534..f1ee544 100644
--- a/board/ti/sdp4430/Makefile
+++ b/board/ti/sdp4430/Makefile
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).o
-COBJS := sdp.o
+COBJS := sdp.o cmd_bat.o
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/ti/sdp4430/cmd_bat.c b/board/ti/sdp4430/cmd_bat.c
new file mode 100644
index 000..fe33538
--- /dev/null
+++ b/board/ti/sdp4430/cmd_bat.c
@@ -0,0 +1,58 @@
+/*
+ * Copyright (C) 2010 Texas Instruments
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include
+#include
+
+#ifdef CONFIG_CMD_BAT
+#include
+
+int do_vbat(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+ if (argc == 2) {
+ if (strncmp(argv[1], "startcharge", 12) == 0)
+ twl6030_start_usb_charging();
+ else if (strncmp(argv[1], "stopcharge", 11) == 0)
+ twl6030_stop_usb_charging();
+ else if (strncmp(argv[1], "status", 7) == 0) {
+ twl6030_get_battery_voltage();
+ twl6030_get_battery_current();
+ } else {
+ goto bat_cmd_usage;
+ }
+ } else {
+ goto bat_cmd_usage;
+ }
+ return 0;
+
+bat_cmd_usage:
+ return cmd_usage(cmdtp);
+}
+
+U_BOOT_CMD(
+ bat, 2, 1, do_vbat,
+ "battery charging, voltage/current measurements",
+ "status - display battery voltage and current\n"
+ "bat startcharge - start charging via USB\n"
+ "bat stopcharge - stop charging\n"
+);
+#endif /* CONFIG_BAT_CMD */
diff --git a/board/ti/sdp4430/sdp.c b/board/ti/sdp4430/sdp.c
index 01d5ce4..b13c4c5 100644
--- a/board/ti/sdp4430/sdp.c
+++ b/board/ti/sdp4430/sdp.c
@@ -23,6 +23,7 @@
* MA 02111-1307 USA
*/
#include
+#include
#include
#include
@@ -63,6 +64,9 @@ int board_eth_init(bd_t *bis)
*/
int misc_init_r(void)
{
+#ifdef CONFIG_TWL6030_POWER
+ twl6030_init_battery_charging();
+#endif
return 0;
}
diff --git a/drivers/power/twl6030.c b/drivers/power/twl6030.c
index cf1da6b..fef57b4 100644
--- a/drivers/power/twl6030.c
+++ b/drivers/power/twl6030.c
@@ -36,6 +36,54 @@ static inline int twl6030_i2c_read_u8(u8 chip_no, u8 *val,
u8 reg)
return i2c_read(chip_no, reg, 1, val, 1);
}
+static int twl6030_gpadc_read_channel(u8 channel_no)
+{
+ u8 lsb = 0;
+ u8 msb = 0;
+ int ret = 0;
+
+ ret = twl6030_i2c_read_u8(TWL6030_CHIP_ADC, &lsb,
+ GPCH0_LSB + channel_no * 2);
+ if (ret)
+ return ret;
+
+ ret = twl6030_i2c_read_u8(TWL6030_CHIP_ADC, &msb,
+ GPCH0_MSB + channel_no * 2);
+ if (ret)
+ return ret;
+
+ return (msb << 8) | lsb;
+}
+
+static int twl6030_gpadc_sw2_trigger(void)
+{
+ u8 val;
+ int ret = 0;
+
+ ret = twl6030_i2c_write_u8(TWL6030_CHIP_ADC, CTRL_P2_SP2, CTRL_P2);
+ if (ret)
+ return ret;
+
+ /* Waiting until the SW1 conversion ends*/
+ val = CTRL_P2_BUSY;
+
+ while (!((val & CTRL_P2_EOCP2) && (!(val & CTRL_P2_BUSY {
+ ret = twl6030_i2c_read_u8(TWL6030_CHIP_ADC, &val, CTRL_P2);
+ if (ret)
+ return ret;
+ udelay(1000);
+ }
+
+ return 0;
+}
+
+void twl6030_stop_usb_charging(void)
+{
+ twl6030_i2c_write_u8(TWL6030_CHIP
Re: [U-Boot] [PATCH 3/3 V6] Add board support for hawkboard
> > The patch adds basic board support for TI's OMAP-L138 based > Hawkboard. This board is pretty similar to the da850 EVM. Support for > nand and network access is added in this version. > > The following bootup procedure is used. > > At reset, the Rom Boot Loader(RBL), initialises the ddr and the nand > controllers and copies the second stage bootloader(nand_spl) to > RAM. The secondary bootloader then copies u-boot from a predefined > location in the nand flash to the RAM, and passes control to the > u-boot image. > > Three config options are supported > * hawkboard_config - Used to create the u-boot.bin. Tftp the > u-boot.bin image to the RAM from u-boot, and flash to the nand flash > at address 0xe. > > * hawkboard_nand_config - Used to generate the secondary > bootloader(nand_spl) image. This creates an elf file u-boot-spl > under nand_spl/. Create an AIS signed image using this file, and > flash it to the nand flash at address 0x2. The ais file should > fit in one block. > > * hawkboard_uart_config - This is same as the first image, but with > the TEXT_BASE as expected by the RBL(0xc108). Create the AIS > Signed bin, as use the normal UART boot procedure to boot the image. > > Signed-off-by: Sughosh Ganu > Signed-off-by: Ben Gardiner > --- > Changes since V5 > * Patch based off Ben Gardiner's tree, with merge issues fixed by Ben. This patch did not apply. > +} > diff --git a/boards.cfg b/boards.cfg > index 08e531e..3f2cbd7 100644 > --- a/boards.cfg > +++ b/boards.cfg > @@ -372,6 +372,9 @@ davinci_sffsdrarm arm926ejs sffsdr > davinci davinci > davinci_sonata arm arm926ejs sonata davinci > davinci > da830evm arm arm926ejs da8xxevmdavinci davinci > da850evm arm arm926ejs da8xxevmdavinci davinci > +hawkboardarm arm926ejs da8xxevmdavinci davinci > hawkboard:SYS_TEXT_BASE=0xc118 > +hawkboard_nand arm arm926ejs da8xxevmdavinci > davinci > hawkboard:SYS_TEXT_BASE=0xc108,NAND_U_BOOT > +hawkboard_uart arm arm926ejs da8xxevmdavinci > davinci > hawkboard:SYS_TEXT_BASE=0xc108 I believe Wolfgang just sent a patch where he got rid of these SYS_TEXT_BASE and then replaced them with CONFIG_SYS_TEXT_BASE in the config.h files. I don't think that patch is in Wolfgang's next branch though Please keep this in mind and resubmit after rebasing with u-boot-ti/next --Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3 V6] Remove board_init_f function from nand_boot.c
> > Remove the board_init_f function from nand_spl/nand_boot.c. This > function is to be defined by all boards using the nand_spl > functionality in their individual board directory. > > Currently this function was being used by the smdk6400 board. Added > the board specific function definition. > > Signed-off-by: Sughosh Ganu > Acked-by: Scott Wood Pushed to u-boot-ti/next http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=45b8679c81e1cb150f84e4d57a22428f49154f49 Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3 V6] Move and rename common headers from under board/davinci.
> > Move the davinci common headers to the architecture specific > include file path. > > Signed-off-by: Sughosh Ganu > --- > Changes since V5 > * Based off Ben Gardiner's tree, no changes in the patch > > .../arm/include/asm/arch-davinci/da8xx_common.h|0 > .../arm/include/asm/arch-davinci/davinci_misc.h|0 > board/davinci/common/misc.c|2 +- > board/davinci/da8xxevm/common.c|2 +- > board/davinci/da8xxevm/da830evm.c |4 ++-- > board/davinci/da8xxevm/da850evm.c |4 ++-- > board/davinci/dm355evm/dm355evm.c |2 +- > board/davinci/dm355leopard/dm355leopard.c |2 +- > board/davinci/dm365evm/dm365evm.c |2 +- > board/davinci/dvevm/dvevm.c|2 +- > board/davinci/schmoogie/schmoogie.c|2 +- > board/davinci/sffsdr/sffsdr.c |2 +- > board/davinci/sonata/sonata.c |2 +- > 13 files changed, 13 insertions(+), 13 deletions(-) > rename board/davinci/da8xxevm/common.h => arch/arm/include/asm/arch- > davinci/da8xx_common.h (100%) > rename board/davinci/common/misc.h => arch/arm/include/asm/arch- > davinci/davinci_misc.h (100%) Pushed to u-boot-ti/next http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=d7f9b503a8d1ae2acab9dea6b9c0cb55d8d3e0af Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ti/master
Wolfgang, Please pull this patch to your master. With this one more ARM board builds Thanks, Sandeep The following changes since commit d0d2271f8c62e830ec65fb069b6d12dd708e3e2f: Wolfgang Denk (1): Prepare v2010.12-rc2 are available in the git repository at: git://git.denx.de/u-boot-ti.git master Dirk Behme (1): OMAP4: SDP4430: Disable CMD_NFS include/configs/omap4_sdp4430.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4] ARM: Use consistent assembler syntax
Signed-off-by: Gray Remlin --- v4 Rebase against v2010.12-rc2 v3 Subject line correction change to patch v2 v2 Fix all occurrences, not just those under arm926ejs v1 Fix syntax of two assembler instructions preventing assembly arch/arm/cpu/arm1136/start.S |2 +- arch/arm/cpu/arm926ejs/start.S |2 +- arch/arm/cpu/armv7/start.S |2 +- arch/arm/cpu/pxa/start.S |4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S index eec8bee..f6e3bd3 100644 --- a/arch/arm/cpu/arm1136/start.S +++ b/arch/arm/cpu/arm1136/start.S @@ -233,7 +233,7 @@ fixabs: mov r1, r1, LSR #4 /* r1 <- symbol index in .dynsym */ add r1, r10, r1 /* r1 <- address of symbol in table */ ldr r1, [r1, #4]/* r1 <- symbol value */ - add r1, r9 /* r1 <- relocated sym addr */ + add r1, r1, r9 /* r1 <- relocated sym addr */ b fixnext fixrel: /* relative fix: increase location by offset */ diff --git a/arch/arm/cpu/arm926ejs/start.S b/arch/arm/cpu/arm926ejs/start.S index 6dcc9b4..b27ac47 100644 --- a/arch/arm/cpu/arm926ejs/start.S +++ b/arch/arm/cpu/arm926ejs/start.S @@ -238,7 +238,7 @@ fixabs: mov r1, r1, LSR #4 /* r1 <- symbol index in .dynsym */ add r1, r10, r1 /* r1 <- address of symbol in table */ ldr r1, [r1, #4]/* r1 <- symbol value */ - add r1, r9 /* r1 <- relocated sym addr */ + add r1, r1, r9 /* r1 <- relocated sym addr */ b fixnext fixrel: /* relative fix: increase location by offset */ diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index 2dfdafe..02fa53c 100644 --- a/arch/arm/cpu/armv7/start.S +++ b/arch/arm/cpu/armv7/start.S @@ -208,7 +208,7 @@ fixabs: mov r1, r1, LSR #4 /* r1 <- symbol index in .dynsym */ add r1, r10, r1 /* r1 <- address of symbol in table */ ldr r1, [r1, #4]/* r1 <- symbol value */ - add r1, r9 /* r1 <- relocated sym addr */ + add r1, r1, r9 /* r1 <- relocated sym addr */ b fixnext fixrel: /* relative fix: increase location by offset */ diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S index ae358a5..4310a3f 100644 --- a/arch/arm/cpu/pxa/start.S +++ b/arch/arm/cpu/pxa/start.S @@ -272,7 +272,7 @@ copy_loop: add r3, r3, r0 /* r3 <- rel dyn end in FLASH */ fixloop: ldr r0, [r2]/* r0 <- location to fix up, IN FLASH! */ - add r0, r9 /* r0 <- location to fix up in RAM */ + add r0, r0, r9 /* r0 <- location to fix up in RAM */ ldr r1, [r2, #4] and r8, r1, #0xff cmp r8, #23 /* relative fixup? */ @@ -286,7 +286,7 @@ fixabs: mov r1, r1, LSR #4 /* r1 <- symbol index in .dynsym */ add r1, r10, r1 /* r1 <- address of symbol in table */ ldr r1, [r1, #4]/* r1 <- symbol value */ - add r1, r9 /* r1 <- relocated sym addr */ + add r1, r1, r9 /* r1 <- relocated sym addr */ b fixnext fixrel: /* relative fix: increase location by offset */ -- 1.7.2.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] at91rm9200ek: add configure target for RAM boot
Dear Reinhard Meyer, Am 08.11.2010 um 09:24 schrieb Reinhard Meyer: > Dear Andreas Bießmann, >> This patch also removes now unnecessary config.mk in board directory and make >> usage of new features in boards.cfg. >> >> Signed-off-by: Andreas Bießmann >> --- >> board/atmel/at91rm9200ek/config.mk |2 -- >> boards.cfg |3 ++- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> delete mode 100644 board/atmel/at91rm9200ek/config.mk > V4 of this patch applied to u-boot-atmel/at91-next does this patch go into v2010.12 ? boards.cfg have changed and this patch will not longer apply cleanly, do you need an update? regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Added PCI_DEVICE_ID_PLX_9030.
Dear Horst Kronstorfer, In message <1272969456-12085-1-git-send-email-hkron...@frequentis.com> you wrote: > Added PCI device ID for the PLXTech PCI 9030 bridge. > > Signed-off-by: Horst Kronstorfer > --- > include/pci_ids.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Applied, sorry this took so long. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If you believe that feeling bad or worrying long enough will change a past or future event, then you are residing on another planet with a different reality system. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Remove duplicate #defines in atngw100.h and mimc200.h
Dear Semih Hazar, In message <4b2a2d0a.6090...@indefia.com> you wrote: > > Two configuration include files had duplicate CONFIG_DOS_PARTITION > definitions with the same value. > > This patch does not effect anything, just trims unnecessary text. > > Signed-off-by: Semih Hazar > --- > include/configs/atngw100.h |2 -- > include/configs/mimc200.h |2 -- > 2 files changed, 0 insertions(+), 4 deletions(-) Applied, thanks. Sorry this took so long. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ATTENTION: Despite Any Other Listing of Product Contents Found Here- on, the Consumer is Advised That, in Actuality, This Product Consists Of 99.99% Empty Space. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ext2: constify file/dir names
Dear Mike Frysinger, In message <1287573489-6816-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > fs/ext2/ext2fs.c |4 ++-- > include/ext2fs.h |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "No one talks peace unless he's ready to back it up with war." "He talks of peace if it is the only way to live." -- Colonel Green and Surak of Vulcan, "The Savage Curtain", stardate 5906.5. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] stdio: constify "name" arg in public api
Dear Mike Frysinger, In message <1287573483-6777-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > common/console.c|4 ++-- > common/stdio.c |4 ++-- > include/common.h|2 +- > include/iomux.h |2 +- > include/stdio_dev.h |4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "No one talks peace unless he's ready to back it up with war." "He talks of peace if it is the only way to live." -- Colonel Green and Surak of Vulcan, "The Savage Curtain", stardate 5906.5. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart
Dear Mike Frysinger, In message <1287573475-6737-1-git-send-email-vap...@gentoo.org> you wrote: > Use the new helper func to clean up duplicate logic handling of the > autostart env var. > > Signed-off-by: Mike Frysinger > --- > common/cmd_fdc.c |3 +-- > common/cmd_fdos.c |2 +- > common/cmd_ide.c |2 +- > common/cmd_nand.c |4 ++-- > common/cmd_net.c |2 +- > common/cmd_scsi.c |2 +- > common/cmd_usb.c |2 +- > 7 files changed, 8 insertions(+), 9 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Work 8 hours, sleep 8 hours; but not the same 8 hours. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ctype: constify lookup table
Dear Mike Frysinger, In message <1287573465-6697-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > include/linux/ctype.h |2 +- > lib/ctype.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Either one of us, by himself, is expendable. Both of us are not. -- Kirk, "The Devil in the Dark", stardate 3196.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] image: constify lookup tables
Dear Mike Frysinger, In message <1287573459-6658-1-git-send-email-vap...@gentoo.org> you wrote: > These are pure lookup tables -- no need to be writable. > > Signed-off-by: Mike Frysinger > --- > common/image.c | 14 +++--- > include/image.h |4 ++-- > 2 files changed, 9 insertions(+), 9 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de KLB is an acronym for `Known Lazy Bastard', aka non-FAQ reader, aka person who would rather make someone take their time to explain something basic than look it up in a FAQ. -- Tom Christiansen in <6aq547$mn...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_itest: constify & localize op table
Dear Mike Frysinger, In message <1287573453-6619-1-git-send-email-vap...@gentoo.org> you wrote: > No one else needs this table. While we're here, use the standard > ARRAY_SIZE helper macro. > > Signed-off-by: Mike Frysinger > --- > common/cmd_itest.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A direct quote from the Boss: "We passed over a lot of good people to get the ones we hired." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_date: constify
Dear Mike Frysinger, In message <1287573443-6578-1-git-send-email-vap...@gentoo.org> you wrote: > Many strings in this file need not be writable. > > Signed-off-by: Mike Frysinger > --- > common/cmd_date.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Most people would like to be delivered from temptation but would like it to keep in touch." - Robert Orben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] string_to_ip: constify "s" arg
Dear Mike Frysinger, In message <1287573418-6533-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > include/net.h |2 +- > lib/net_utils.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Of all possible committee reactions to any given agenda item, the reaction that will occur is the one which will liberate the greatest amount of hot air.-- Thomas L. Martin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] string_to_VLAN: constify "var" arg
Dear Mike Frysinger, In message <1287573408-6494-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > include/net.h |2 +- > net/net.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If a person (a) is poorly, (b) receives treatment intended to make him better, and (c) gets better, then no power of reasoning known to medical science can convince him that it may not have been the treatment that restored his health. - Sir Peter Medawar, The Art of the Soluble ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] copy_filename: constify "src" arg
Dear Mike Frysinger, In message <1287573400-6455-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > include/net.h |2 +- > net/net.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Intuition, however illogical, is recognized as a command prerogative. -- Kirk, "Obsession", stardate 3620.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] autocomplete: remove runtime handler install
Dear Mike Frysinger, In message <1287561159-9517-1-git-send-email-vap...@gentoo.org> you wrote: > Rather than add runtime overhead of installing completion handlers, do it > statically at build time. This requires a new build time helper macro to > declare a command and the completion handler at the same time. Then we > convert the env related funcs over to this. > > This gives an opportunity to also unify the U_BOOT_CMD macros. > > Signed-off-by: Mike Frysinger > --- > common/cmd_nvedit.c | 20 > common/command.c| 24 > common/main.c |4 > include/command.h | 30 ++ > 4 files changed, 30 insertions(+), 48 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "In Christianity neither morality nor religion come into contact with reality at any point." - Friedrich Nietzsche ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] do_reset: unify duplicate prototypes
Dear Mike Frysinger, In message <1287560477-3668-1-git-send-email-vap...@gentoo.org> you wrote: > The duplication of the do_reset prototype has gotten out of hand, > and they're not all in sync. Unify them all in command.h. > > Signed-off-by: Mike Frysinger > --- > api/api.c |3 --- > arch/m68k/cpu/mcf5227x/cpu.c |2 +- > arch/m68k/cpu/mcf523x/cpu.c|2 +- > arch/m68k/cpu/mcf52x2/cpu.c| 14 +++--- > arch/m68k/cpu/mcf532x/cpu.c|2 +- > arch/m68k/cpu/mcf5445x/cpu.c |2 +- > arch/m68k/cpu/mcf547x_8x/cpu.c |2 +- > arch/nios2/cpu/cpu.c |2 +- > arch/powerpc/cpu/mpc85xx/cpu.c |2 +- > arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c |1 - > arch/powerpc/lib/bootm.c |1 - > board/eltec/bab7xx/bab7xx.c|3 ++- > board/esd/apc405/apc405.c |1 - > board/esd/ar405/ar405.c|2 -- > board/esd/ash405/ash405.c |1 - > board/esd/canbt/canbt.c|4 > board/esd/cpci405/cpci405.c|1 - > board/esd/cpciiser4/cpciiser4.c|3 --- > board/esd/du405/du405.c|3 --- > board/esd/hh405/hh405.c|1 - > board/esd/pci405/pci405.c |1 - > board/esd/plu405/plu405.c |1 - > board/esd/tasreg/tasreg.c |1 - > board/esd/voh405/voh405.c |1 - > board/esd/wuh405/wuh405.c |2 -- > board/freescale/m5249evb/m5249evb.c|4 > board/funkwerk/vovpn-gw/vovpn-gw.c |2 +- > board/prodrive/pdnb3/pdnb3.c |3 --- > board/sacsng/sacsng.c |2 -- > .../xilinx/microblaze-generic/microblaze-generic.c |3 ++- > board/zeus/zeus.c |1 - > common/cmd_boot.c |2 -- > common/cmd_bootm.c |1 - > common/hush.c |4 +--- > common/main.c |4 > include/command.h |1 + > include/exports.h |1 - > lib/vsprintf.c |2 -- > 38 files changed, 21 insertions(+), 67 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "I knew then (in 1970) that a 4-kbyte minicomputer would cost as much as a house. So I reasoned that after college, I'd have to live cheaply in an apartment and put all my money into owning a computer." - Apple co-founder Steve Wozniak, EE Times, June 6, 1988, pg 45 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] do_bootd: unify duplicate prototypes
Dear Mike Frysinger, In message <1287560186-31701-1-git-send-email-vap...@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > common/hush.c |4 > common/main.c |2 -- > include/command.h |3 +++ > 3 files changed, 3 insertions(+), 6 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de We are Microsoft. Unix is irrelevant. Openness is futile. Prepare to be assimilated. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] do_bootm: unify duplicate prototypes
Dear Mike Frysinger, In message <1287560139-31658-1-git-send-email-vap...@gentoo.org> you wrote: > The duplication of the do_bootm prototype has gotten out of hand, > and they're pretty much all outdated (wrt constness). Unify them > all in command.h. > > Signed-off-by: Mike Frysinger > --- > board/barco/barco.c|1 - > board/cm5200/fwupdate.c|1 - > board/esd/common/cmd_loadpci.c |1 - > board/esd/cpci750/cpci750.c|1 - > board/esd/pci405/cmd_pci405.c |2 -- > board/pn62/cmd_pn62.c |2 -- > common/cmd_fdc.c |1 - > common/cmd_fdos.c |1 - > common/cmd_ide.c |1 - > common/cmd_nand.c |1 - > common/cmd_net.c |2 -- > common/cmd_scsi.c |1 - > common/cmd_usb.c |1 - > include/command.h |2 ++ > 14 files changed, 2 insertions(+), 16 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Every little picofarad has a nanohenry all its own. - Don Vonada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] command_t: punt unused type
Dear Mike Frysinger, In message <1287560109-31612-1-git-send-email-vap...@gentoo.org> you wrote: > The recent command clean up to constify the argv option to command funcs > missed the command_t type itself. This is probably because there are no > build time warnings from it because no one is actually using this thing. > So just punt it rather than fix it. > > Signed-off-by: Mike Frysinger > --- > include/command.h |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Die Freiheit des Menschen liegt nicht darin, dass er tun kann, was er will, sondern darin, dass er nicht tun muss, was er nicht will. -- Jean-Jacques Rousseau ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_mii: localize & constify local funcs/data
Dear Mike Frysinger, In message <1287551208-22052-1-git-send-email-vap...@gentoo.org> you wrote: > No need for these structures to be writable or global. > > While we're here, also drop local versions of the ARRAY_SIZE macro. > > Signed-off-by: Mike Frysinger > --- > common/cmd_mii.c | 68 +++-- > 1 files changed, 30 insertions(+), 38 deletions(-) Applied to "next" branch, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Life sucks, but it's better than the alternative." - Peter da Silva ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver
Dear Stephan Linz, In message <1290419192-13422-2-git-send-email-l...@li-pro.net> you wrote: > * avoid using link variable uninitialized > * avoid using phy_addr variable with invalid value > * reorganize phy control: first looking for phy than link > * return with error (result value 0) if no phy/link was found > * fix boolean mistake in wait for link: wait as long as we got > phy register 1 has no link indication (BMSR != 0x24) > * expand the 'first run' flag handling in ll_temac_init() in > respect to possible error detection in xps_ll_temac_phy_ctrl() > > Signed-off-by: Stephan Linz > --- > drivers/net/xilinx_ll_temac.c | 52 > ++--- > 1 files changed, 38 insertions(+), 14 deletions(-) Please merges these fixzes into the next submission of the LL TEMAC driver. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A committee is a life form with six or more legs and no brain. -- Lazarus Long, "Time Enough For Love" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] net: Add LL TEMAC driver to u-boot
Dear Michal Simek,
sorry for the long delay. We're still lacking a (new) network
custodian...
In message <1280753377-2894-4-git-send-email-mon...@monstr.eu> you wrote:
> Add Xilinx LL Temac driver to u-boot.
>
> Signed-off-by: Michal Simek
> +++ b/drivers/net/xilinx_ll_temac.c
> @@ -0,0 +1,561 @@
> +/*
> + *
Drop blank line.
> + * Copyright (C) 2008 - 2009 Michal Simek
> + * June 2008 Microblaze optimalization, FIFO mode support
2009? Not 2010 ?
> +/* XPS_LL_TEMAC direct registers definition */
> +#define TEMAC_RAF0 (dev->iobase + 0x00)
> +#define TEMAC_TPF0 (dev->iobase + 0x04)
> +#define TEMAC_IFGP0 (dev->iobase + 0x08)
> +#define TEMAC_IS0(dev->iobase + 0x0c)
> +#define TEMAC_IP0(dev->iobase + 0x10)
> +#define TEMAC_IE0(dev->iobase + 0x14)
> +
> +#define TEMAC_MSW0 (dev->iobase + 0x20)
> +#define TEMAC_LSW0 (dev->iobase + 0x24)
> +#define TEMAC_CTL0 (dev->iobase + 0x28)
> +#define TEMAC_RDY0 (dev->iobase + 0x2c)
Please use a C struct to describe the register layout.
> +/* XPS_LL_TEMAC indirect registers offset definition */
> +
> +#define RCW0 0x200
> +#define RCW1 0x240
> +#define TC 0x280
> +#define FCC 0x2c0
> +#define EMMC 0x300
> +#define PHYC 0x320
> +#define MC 0x340
> +#define UAW0 0x380
> +#define UAW1 0x384
> +#define MAW0 0x388
> +#define MAW1 0x38c
> +#define AFM 0x390
> +#define TIS 0x3a0
> +#define TIE 0x3a4
> +#define MIIMWD 0x3b0
> +#define MIIMAI 0x3b4
Ditto.
> + out_be32((u32 *)TEMAC_LSW0, phy_data);
> + out_be32((u32 *)TEMAC_CTL0, CNTLREG_WRITE_ENABLE_MASK | MIIMWD);
> + out_be32((u32 *)TEMAC_LSW0, (phy_addr << 5) | (reg_addr));
> + out_be32((u32 *)TEMAC_CTL0, \
> + CNTLREG_WRITE_ENABLE_MASK | MIIMAI | (emac << 10));
> + while (!(in_be32((u32 *)TEMAC_RDY0) & XTE_RSE_MIIM_WR_MASK))
The need to have all these casts should ring some alarm bell to you.
Please use a proper C struct instead.
> + out_be32((u32 *)TEMAC_LSW0, reg_data);
> + out_be32((u32 *)TEMAC_CTL0, \
> + CNTLREG_WRITE_ENABLE_MASK | (emac << 10) | reg_offset);
Drop the backslash.
> + debug ("%d: 0x%x ", j, result);
> + }
> + debug ("\n");
No spaces between function name and '('. Please fix globally.
Consider running your patch through checkpatch...
> + while (retries-- &&
> + ((xps_ll_temac_hostif_get(dev, 0, phy_addr, 1) & 0x24) == 0x24))
> + ;
Bad indentation.
> + if (i == 0x7c0a3) {
...
> + if (i == 0x1410cc2) {
Please use self-explaining symbolic names for these magic numbers,
and/or add sufficient comments what these mean.
> +static void debugll(int count)
> +{
> + printf ("%d fifo isr 0x%08x, fifo_ier 0x%08x, fifo_rdfr 0x%08x, "
> + "fifo_rdfo 0x%08x fifo_rlr 0x%08x\n", count, ll_fifo->isr, \
> + ll_fifo->ier, ll_fifo->rdfr, ll_fifo->rdfo, ll_fifo->rlf);
Drop the backslash. Please check & fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
What can it profit a man to gain the whole world and to come to his
property with a gastric ulcer, a blown prostate, and bifocals?
-- John Steinbeck, _Cannery Row_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2 ] [NEXT] Remove redundant config.mk files
Recent cleanup actions resulted in a number of config.mk files that contained only redundant entries like PLATFORM_CPPFLAGS += -I$(TOPDIR) or settings of variables that were not used anywhere in the code, like TEXT_END = 0xfe08 Remove these unnecessary files. Signed-off-by: Wolfgang Denk Cc: Scott McNutt Cc: Wolfgang Wegner Cc: Josef Wagner Cc: Tolunay Orkun Cc: Frank Panno Cc: Heiko Schocher Cc: Brad Kemp --- arch/nios2/cpu/config.mk | 24 board/astro/mcf5373l/config.mk | 25 - board/atc/config.mk| 28 board/cmi/config.mk| 28 board/cpc45/config.mk | 28 board/cpu86/config.mk | 28 board/cpu87/config.mk | 28 board/csb272/config.mk | 31 --- board/csb472/config.mk | 31 --- board/ep8260/config.mk | 28 board/genietv/config.mk| 24 board/icu862/config.mk | 28 board/ids8247/config.mk| 27 --- board/mpl/pati/config.mk | 24 board/pm826/config.mk | 27 --- board/pm828/config.mk | 27 --- board/ppmc7xx/config.mk| 26 -- board/ppmc8260/config.mk | 32 board/siemens/SCM/config.mk| 27 --- board/tqc/tqm8260/config.mk| 27 --- board/tqc/tqm8272/config.mk| 27 --- board/westel/amx860/config.mk | 24 22 files changed, 0 insertions(+), 599 deletions(-) delete mode 100644 arch/nios2/cpu/config.mk delete mode 100644 board/astro/mcf5373l/config.mk delete mode 100644 board/atc/config.mk delete mode 100644 board/cmi/config.mk delete mode 100644 board/cpc45/config.mk delete mode 100644 board/cpu86/config.mk delete mode 100644 board/cpu87/config.mk delete mode 100644 board/csb272/config.mk delete mode 100644 board/csb472/config.mk delete mode 100644 board/ep8260/config.mk delete mode 100644 board/genietv/config.mk delete mode 100644 board/icu862/config.mk delete mode 100644 board/ids8247/config.mk delete mode 100644 board/mpl/pati/config.mk delete mode 100644 board/pm826/config.mk delete mode 100644 board/pm828/config.mk delete mode 100644 board/ppmc7xx/config.mk delete mode 100644 board/ppmc8260/config.mk delete mode 100644 board/siemens/SCM/config.mk delete mode 100644 board/tqc/tqm8260/config.mk delete mode 100644 board/tqc/tqm8272/config.mk delete mode 100644 board/westel/amx860/config.mk diff --git a/arch/nios2/cpu/config.mk b/arch/nios2/cpu/config.mk deleted file mode 100644 index f228d72..000 --- a/arch/nios2/cpu/config.mk +++ /dev/null @@ -1,24 +0,0 @@ -# -# (C) Copyright 2000 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -PLATFORM_RELFLAGS += diff --git a/board/astro/mcf5373l/config.mk b/board/astro/mcf5373l/config.mk deleted file mode 100644 index ad63dd1..000 --- a/board/astro/mcf5373l/config.mk +++ /dev/null @@ -1,25 +0,0 @@ -# -# (C) Copyright 2000-2003 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# Coldfire contribution by Bernhard Kuhn -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General
[U-Boot] [PATCH 2/2] [NEXT] Move LDSCRIPT definitions to board config files.
Recent cleanup actions resulted in a number of config.mk files that contained only LDSCRIPT definitions. Move these into th respective board config files and remove the now empty config.mk files. Signed-off-by: Wolfgang Denk Cc: Matthias Fuchs Cc: Detlev Zundel Cc: Heiko Schocher Cc: Andre Schwarz Cc: Peter De Schrijver --- board/amirix/ap1000/config.mk | 25 - board/esd/dasa_sim/config.mk| 25 - board/inka4x0/config.mk | 27 --- board/manroland/uc101/config.mk | 24 board/matrix_vision/mvsmr/config.mk | 24 board/ml2/config.mk | 25 - board/mousse/config.mk | 27 --- board/rsdproto/config.mk| 28 include/configs/AP1000.h|1 + include/configs/DASA_SIM.h |1 + include/configs/ML2.h |1 + include/configs/MOUSSE.h|1 + include/configs/MVSMR.h |1 + include/configs/inka4x0.h |1 + include/configs/rsdproto.h |1 + include/configs/uc101.h |1 + 16 files changed, 8 insertions(+), 205 deletions(-) delete mode 100644 board/amirix/ap1000/config.mk delete mode 100644 board/esd/dasa_sim/config.mk delete mode 100644 board/inka4x0/config.mk delete mode 100644 board/manroland/uc101/config.mk delete mode 100644 board/matrix_vision/mvsmr/config.mk delete mode 100644 board/ml2/config.mk delete mode 100644 board/mousse/config.mk delete mode 100644 board/rsdproto/config.mk diff --git a/board/amirix/ap1000/config.mk b/board/amirix/ap1000/config.mk deleted file mode 100644 index 2d075b6..000 --- a/board/amirix/ap1000/config.mk +++ /dev/null @@ -1,25 +0,0 @@ -# -# (C) Copyright 2000 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -# Use board specific linker script -LDSCRIPT := $(SRCTREE)/board/amirix/ap1000/u-boot.lds diff --git a/board/esd/dasa_sim/config.mk b/board/esd/dasa_sim/config.mk deleted file mode 100644 index a92d9a9..000 --- a/board/esd/dasa_sim/config.mk +++ /dev/null @@ -1,25 +0,0 @@ -# -# (C) Copyright 2000 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -# Use board specific linker script -LDSCRIPT := $(SRCTREE)/board/esd/dasa_sim/u-boot.lds diff --git a/board/inka4x0/config.mk b/board/inka4x0/config.mk deleted file mode 100644 index a42d124..000 --- a/board/inka4x0/config.mk +++ /dev/null @@ -1,27 +0,0 @@ -# -# (C) Copyright 2004 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software
[U-Boot] (no subject)
Dear Kyungmin Park & Minkyu Kang, "onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If the hours are long enough and the pay is short enough, someone will say it's women's work. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Rename RESET_VECTOR_ADDRESS ?
Dear Andy & Kumar, a number of boards define RESET_VECTOR_ADDRESS in their config.mk files: board/freescale/corenet_ds/config.mk board/freescale/mpc8536ds/config.mk board/freescale/mpc8572ds/config.mk board/freescale/p1022ds/config.mk board/freescale/p1_p2_rdb/config.mk board/freescale/p2020ds/config.mk The only place where RESET_VECTOR_ADDRESS ever gets used is in the respective u-boot.lds linker script. Do you see any reason why we should not move these RESET_VECTOR_ADDRESS settings into the board config files? The linker script just needs to include "config.h", and we could remove all the config.mk files above. What do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never call a man a fool. Borrow from him. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] (no subject)
Dear Reinhard, "arch/arm/cpu/arm926ejs/at91/config.mk" contains only PLATFORM_CPPFLAGS += $(call cc-option,-mtune=arm926ejs,) This looks as if it was not really specific to AT91, so maybe we should move that into "arch/arm/cpu/arm926ejs/config.mk" instead (and then remove "arch/arm/cpu/arm926ejs/at91/config.mk") ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Democracy is mob rule, but with income taxes. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci: DM355 Leopard : Fix for ARM Relocation support
Dear s-paul...@ti.com, In message <1290901811-6793-1-git-send-email-s-paul...@ti.com> you wrote: > From: Sandeep Paulraj > > Fix for ARM Relocation support > > > Signed-off-by: Sandeep Paulraj > --- > include/configs/davinci_dm355leopard.h |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de For every complex problem, there is a solution that is simple, neat, and wrong. -- H. L. Mencken ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cfi_flash: fix bug introduced while recent change to flash_get_size()
Dear Anatolij Gustschin,
In message <1290906813-12017-1-git-send-email-ag...@denx.de> you wrote:
> commit ec50a8e389863ac35bfd9d9a2e8b30187318e59e
> "cfi_flash: handle 'chip size exceeds address window' situation"
> added 3rd argument to flash_get_size() but didn't fix all the
> function calls from the board specific code. Many boards have
> their own flash_get_size() definitions in the board code and
> use them there, but some boards (e.g. tqm834x, tqm85xx, pdm360ng)
> use flash_get_size() from the cfi_flash.c driver.
>
> The bug shows up if the value of the "max_size" argument (which
> is not defined when calling the function with two arguments)
> happens to be less than "info->size". In this case on the
> affected boards we end up with a bank of reduced size and
> in the worst case might even be not able to update U-Boot or
> to boot the kernel from flash:
>
> => fli
>
> Bank # 1: CFI conformant FLASH (32 x 16) Size: 0 kB in 1 Sectors
> AMD Standard command set, Manufacturer ID: 0x01, Device ID: 0x227E
> Erase timeout: 4096 ms, write timeout: 1 ms
> Buffer write timeout: 3 ms, buffer size: 64 bytes
>
> Sector Start Addresses:
> F000 RO
>
> Bank # 2: CFI conformant FLASH (32 x 16) Size: 128 MB in 512 Sectors
> AMD Standard command set, Manufacturer ID: 0x01, Device ID: 0x227E
> Erase timeout: 4096 ms, write timeout: 1 ms
> Buffer write timeout: 3 ms, buffer size: 64 bytes
>
> Sector Start Addresses:
> F800F804F808F80CF810
> F814F818F81CF820F824
> ...
>
> E.g., updating U-Boot is not possible now:
>
> => protect off ${u-boot_addr} +${u-boot_size}
> Error: end address (0xf007) not in flash!
> Bad address format
> => era ${u-boot_addr} +${u-boot_size}
> Error: end address (0xf007) not in flash!
> Bad address format
>
> This patch removes the 3rd argument of flash_get_size() again
> and sets "max_size" in the function itself instead of passing
> it as a function argument.
>
> Signed-off-by: Anatolij Gustschin
> ---
> Probably we should put the prototype of flash_get_size() into
> include/flash.h and not use prototype definitions in the
> board code. This could prevent such a nasty bug (compile time
> errors would show it). But I'm not sure here, need to look
> more at the code.
>
> drivers/mtd/cfi_flash.c |7 ---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
Hope this is ok with your, Stefan - I just wanted to have this in
-rc2.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
C++ was an interesting and valuable experiment, but we've learned its
lessons and it's time to move on.
- Peter Curran in
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci DM365: Fix for ARM Relocation support
Dear s-paul...@ti.com, In message <1290901822-6834-1-git-send-email-s-paul...@ti.com> you wrote: > From: Sandeep Paulraj > > Fix for ARM Relocation support > > > Signed-off-by: Sandeep Paulraj > --- > include/configs/davinci_dm365evm.h |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You don't have to worry about me. I might have been born yesterday... but I stayed up all night. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci DM355: Fix for ARM Relocation support
Dear s-paul...@ti.com, In message <1290901789-6744-1-git-send-email-s-paul...@ti.com> you wrote: > > Fix for ARM Relocation support > > > Signed-off-by: Sandeep Paulraj > --- > include/configs/davinci_dm355evm.h |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Fascinating is a word I use for the unexpected. -- Spock, "The Squire of Gothos", stardate 2124.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] OMAP4: SDP4430: Disable CMD_NFS
From: Dirk Behme This patch fixes the SDB4430 build after commit 6d8962e814c15807dd6ac5757904be2a02d187b8 by explicitly disabling CMD_NFS. >From the commit message for "Switch from archive libraries to partial linking": This commit reveals board configurations that exclude some features but include source files that depend these disabled features in the build, resulting in undefined symbols. Known such cases include: - disabling CMD_NET but not CMD_NFS; - enabling CONFIG_OF_LIBFDT but not CONFIG_QE. Signed-off-by: Dirk Behme --- This fix is identical to what was done for Panda: http://git.denx.de/?p=u-boot.git;a=commitdiff;h=8721e95b16024f0a92ccc1cd85aecf6672fe9499 include/configs/omap4_sdp4430.h |1 + 1 file changed, 1 insertion(+) Index: u-boot.git/include/configs/omap4_sdp4430.h === --- u-boot.git.orig/include/configs/omap4_sdp4430.h +++ u-boot.git/include/configs/omap4_sdp4430.h @@ -139,6 +139,7 @@ /* Disabled commands */ #undef CONFIG_CMD_NET +#undef CONFIG_CMD_NFS #undef CONFIG_CMD_FPGA /* FPGA configuration Support */ #undef CONFIG_CMD_IMLS /* List all found images*/ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/24] e1000: fix compile warning
Hello.
On 25-11-2010 19:00, Wolfgang Denk wrote:
> Get rid of compiler warning:
> e1000.c: In function 'e1000_transmit':
> e1000.c:5028: warning: passing argument 1 of 'virt_to_phys' discards
> qualifiers from pointer target type
> Signed-off-by: Wolfgang Denk
[...]
> diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
> index 60b04c2..5f390bd 100644
> --- a/drivers/net/e1000.c
> +++ b/drivers/net/e1000.c
> @@ -5018,6 +5018,7 @@ TRANSMIT - Transmit a frame
> static int
> e1000_transmit(struct eth_device *nic, volatile void *packet, int length)
> {
> + void * nv_packet = (void *)packet;
I suspect checkpatch.pl would complain about the space following *...
WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix compiler warning in fdt_support.c
On 11/28/2010 06:42 AM, Wolfgang Denk wrote: > Dear dirk.be...@googlemail.com, > > In message<1290367174-380-1-git-send-email-dirk.be...@gmail.com> you wrote: >> From: Dirk Behme >> >> Fix compiler warning >> >> fdt_support.c: In function 'of_bus_default_count_cells': >> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards >> qualifiers from pointer target type >> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards >> qualifiers from pointer target type >> >> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'. >> >> Signed-off-by: Dirk Behme >> >> --- >> >> Found while building 'omap3_beagle'. > > Applied, thank. > > Gerry, hope this is OK with you. Yes, thanks. > Best regards, > Wolfgang Denk Best regards, gvb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [GIT PULL] mpc83xx: misc. fixes
Wolfgang Denk, Please pull: The following changes since commit 844f07d8a1f1330c97631b23fbf6425db2dc1508: Coding Style (white space) cleanup (2010-11-27 23:35:14 +0100) are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git master Joakim Tjernlund (2): mpc83xx: remove some dead code, saving space mpc83xx: Make it boot again Stefan Popa (1): mpc83xx: Fix for MPC8360 ATM Quad OC3 External Phys arch/powerpc/cpu/mpc83xx/start.S | 15 --- include/configs/MPC8360EMDS.h|4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci DM355: Fix for ARM Relocation support
Dear "Paulraj, Sandeep", In message <0554bef07d437848af01b9c9b5f0bc5dbd4fa...@dlee01.ent.ti.com> you wrote: > > I have sent three patches. > > Is it OK if I send a pull request immediately? under normal condistions we should wait a couple of days. But in this specific case your patches un-break boards, so they are obvious improvements and pretty urgent as well. This is reason enough toi shorten the time limits. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de At the source of every error which is blamed on the computer you will find at least two human errors, including the error of blaming it on the computer. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/master
Dear Stefan Roese, In message <201011281134.49822...@denx.de> you wrote: > Hi Wolfgang, > > The following changes since commit 844f07d8a1f1330c97631b23fbf6425db2dc1508: > > Coding Style (white space) cleanup (2010-11-27 23:35:14 +0100) > > are available in the git repository at: > git://www.denx.de/git/u-boot-ppc4xx.git master > > Stefan Roese (2): > ppc4xx/POST: Handle cached SDRAM correctly in Denali (440EPx) ECC POST > ppc4xx: Flush complete dcache in relocate_code() > > arch/powerpc/cpu/ppc4xx/start.S | 13 +++-- > post/cpu/ppc4xx/denali_ecc.c|4 > 2 files changed, 11 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Genius doesn't work on an assembly line basis. You can't simply say, "Today I will be brilliant." -- Kirk, "The Ultimate Computer", stardate 4731.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE
Dear "Paulraj, Sandeep", In message <0554bef07d437848af01b9c9b5f0bc5dbcfdd...@dlee01.ent.ti.com> you wrote: > > I was going to send a pull request for this along with > my 3 patches > > Are you going to pull the 3 patches i sent yesterday or do you want a pull = > request > > my patches will result in more boards building If I have your "go" I can apply these directly, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Until you walk a mile in another man's moccasins, you can't imagine the smell. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again
Kim Phillips wrote on 2010/11/28 17:31:25: > > On Tue, 23 Nov 2010 12:38:57 -0600 > Scott Wood wrote: > > > On Tue, 23 Nov 2010 19:16:01 +0100 > > Joakim Tjernlund wrote: > > > > > Could we have an ACK before relese please? > > > > > > > After the removal of COLD/WARM start flags my mpc8321 > > > > board didn't boot anymore. > > > > Trial and error suggests that map/remap_flash_by_xxx needs > > > > to wait after updating LBLAWAR1 to make sure the the change has > > > > reached the HW before continuing with the code that depends on it. > > > > Final fix suggested by Scott Wood. > > > > > > > > Signed-off-by: Joakim Tjernlund > > > > --- > > > > > > > > v2: Final adjustmenst based on inpt from Scott Wood. > > > > arch/powerpc/cpu/mpc83xx/start.S |8 > > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > ACK > > > > -Scott > > applied. BTW, there was one named powerpc: fix mpc8315erdb and mpc8313erdb NAND linker script which I think you should consider. I don't really care as I don't use these boards, I just noticed it by chance. Jocke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/25 V4] 83xx: Cleanup for partial linking and --gc-sections
Dear Kim Phillips, In message <20101128091146.c48b5185.kim.phill...@freescale.com> you wrote: > From: Wolfgang Denk > > Signed-off-by: Wolfgang Denk > Cc: Haiying Wang > Signed-off-by: Kim Phillips > --- > Changes since V2: > - fixed nand_spl/*/u-boot.lds as pointed out by Haiying > > Changes since V3: > - included the simpc8313 board Sorry, too late. I want to get out -rc2 this night, so I pulled that stuff already. Please submit as incremental patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The light at the end of the tunnel is usually a "No Exit" sign. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again
Kim Phillips wrote on 2010/11/28 17:31:25: > > On Tue, 23 Nov 2010 12:38:57 -0600 > Scott Wood wrote: > > > On Tue, 23 Nov 2010 19:16:01 +0100 > > Joakim Tjernlund wrote: > > > > > Could we have an ACK before relese please? > > > > > > > After the removal of COLD/WARM start flags my mpc8321 > > > > board didn't boot anymore. > > > > Trial and error suggests that map/remap_flash_by_xxx needs > > > > to wait after updating LBLAWAR1 to make sure the the change has > > > > reached the HW before continuing with the code that depends on it. > > > > Final fix suggested by Scott Wood. > > > > > > > > Signed-off-by: Joakim Tjernlund > > > > --- > > > > > > > > v2: Final adjustmenst based on inpt from Scott Wood. > > > > arch/powerpc/cpu/mpc83xx/start.S |8 > > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > ACK > > > > -Scott > > applied. > > Thanks everyone. Finally, thanks. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.
Kim Phillips wrote on 2010/11/28 16:12:21: > > On Wed, 24 Nov 2010 22:59:55 +0100 > Wolfgang Denk wrote: > > > Dear Joakim Tjernlund, > > > > In message > > > > you wrote: > > > > > >Are you planning to apply some of my earlier patches(not this RFC > > > series) > > >or are you waiting for Freescale to Ack/pick up? So far nobody > > >has said anything. > > > > I think these are all on Freescale's (Kim Phillips') list. > > outside of the PIC ones, which I believe are still outstanding, I have: > > Thu Nov 4 15:45:12 2010 +0100 "mpc83xx: Make it boot again" > > -- which looks like it has comments that haven't been addressed What comments would that be? There are none. Jocke PS. The last version has this fix for the problem in case you are looking at an old one. + /* Wait for HW to catch up */ + lwz r4, LBLAWAR1(r3) + twi 0,r4,0 + isync ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again
On Tue, 23 Nov 2010 12:38:57 -0600 Scott Wood wrote: > On Tue, 23 Nov 2010 19:16:01 +0100 > Joakim Tjernlund wrote: > > > Could we have an ACK before relese please? > > > > > After the removal of COLD/WARM start flags my mpc8321 > > > board didn't boot anymore. > > > Trial and error suggests that map/remap_flash_by_xxx needs > > > to wait after updating LBLAWAR1 to make sure the the change has > > > reached the HW before continuing with the code that depends on it. > > > Final fix suggested by Scott Wood. > > > > > > Signed-off-by: Joakim Tjernlund > > > --- > > > > > > v2: Final adjustmenst based on inpt from Scott Wood. > > > arch/powerpc/cpu/mpc83xx/start.S |8 > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > ACK > > -Scott applied. Thanks everyone. Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mpc83xx: remove some dead code, saving space
On Tue, 23 Nov 2010 19:33:43 +0100 Joakim Tjernlund wrote: > Signed-off-by: Joakim Tjernlund > --- applied. Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.
On Wed, 24 Nov 2010 22:59:55 +0100 Wolfgang Denk wrote: > Dear Joakim Tjernlund, > > In message > you > wrote: > > > >Are you planning to apply some of my earlier patches(not this RFC series) > >or are you waiting for Freescale to Ack/pick up? So far nobody > >has said anything. > > I think these are all on Freescale's (Kim Phillips') list. outside of the PIC ones, which I believe are still outstanding, I have: Thu Nov 4 15:45:12 2010 +0100 "mpc83xx: Make it boot again" -- which looks like it has comments that haven't been addressed and: Tue Nov 23 19:33:43 2010 +0100 "mpc83xx: remove some dead code, saving space" -- which I've applied. Please let me know what else is needed, if anything. Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
On Sun, 28 Nov 2010 09:06:37 +0800 Baidu Boy wrote: > This patch fix a problem for the pcie enumeration for mpc83xx cpus.Without > this > we will not get correct value in hose->regions[...]. > > The pointer *reg in function mpc83xx_pcie_init_bus() shall not be changed. > Because we will use this pointer as a parameter to call function > mpc83xx_pcie_register_hose(). > > Signed-off-by: Baidu Boy > --- doesn't apply: Applying: mpc83xx:pcie:bugfix for mpc83xx pcie enumeration fatal: corrupt patch at line 13 please resubmit. Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 15/25 V4] 83xx: Cleanup for partial linking and --gc-sections
From: Wolfgang Denk
Signed-off-by: Wolfgang Denk
Cc: Haiying Wang
Signed-off-by: Kim Phillips
---
Changes since V2:
- fixed nand_spl/*/u-boot.lds as pointed out by Haiying
Changes since V3:
- included the simpc8313 board
arch/powerpc/cpu/mpc83xx/u-boot.lds | 53 --
nand_spl/board/freescale/mpc8313erdb/u-boot.lds |7 ++-
nand_spl/board/freescale/mpc8315erdb/u-boot.lds |7 ++-
nand_spl/board/sheldon/simpc8313/u-boot.lds |9 ++--
4 files changed, 23 insertions(+), 53 deletions(-)
diff --git a/arch/powerpc/cpu/mpc83xx/u-boot.lds
b/arch/powerpc/cpu/mpc83xx/u-boot.lds
index 0b74a13..81a7ace 100644
--- a/arch/powerpc/cpu/mpc83xx/u-boot.lds
+++ b/arch/powerpc/cpu/mpc83xx/u-boot.lds
@@ -1,5 +1,5 @@
/*
- * (C) Copyright 2006
+ * (C) Copyright 2006-2010
* Wolfgang Denk, DENX Software Engineering, w...@denx.de.
*
* See file CREDITS for list of people who contributed to this
@@ -25,41 +25,13 @@ OUTPUT_ARCH(powerpc)
SECTIONS
{
/* Read-only sections, merged into text segment: */
- . = + SIZEOF_HEADERS;
- .interp : { *(.interp) }
- .hash : { *(.hash) }
- .dynsym: { *(.dynsym)}
- .dynstr: { *(.dynstr)}
- .rel.text : { *(.rel.text) }
- .rela.text : { *(.rela.text) }
- .rel.data : { *(.rel.data) }
- .rela.data : { *(.rela.data) }
- .rel.rodata: { *(.rel.rodata)}
- .rela.rodata : { *(.rela.rodata) }
- .rel.got : { *(.rel.got) }
- .rela.got : { *(.rela.got) }
- .rel.ctors : { *(.rel.ctors) }
- .rela.ctors: { *(.rela.ctors)}
- .rel.dtors : { *(.rel.dtors) }
- .rela.dtors: { *(.rela.dtors)}
- .rel.bss : { *(.rel.bss) }
- .rela.bss : { *(.rela.bss) }
- .rel.plt : { *(.rel.plt) }
- .rela.plt : { *(.rela.plt) }
- .init : { *(.init) }
- .plt : { *(.plt) }
.text :
{
-arch/powerpc/cpu/mpc83xx/start.o (.text)
-*(.text)
-*(.got1)
+arch/powerpc/cpu/mpc83xx/start.o (.text*)
+*(.text*)
. = ALIGN(16);
-*(.eh_frame)
*(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
}
- .fini : { *(.fini)} =0
- .ctors : { *(.ctors) }
- .dtors : { *(.dtors) }
/* Read-write section, merged into data segment: */
. = (. + 0x0FFF) & 0xF000;
@@ -67,23 +39,19 @@ SECTIONS
PROVIDE (erotext = .);
.reloc :
{
-*(.got)
+KEEP(*(.got))
_GOT2_TABLE_ = .;
-*(.got2)
+KEEP(*(.got2))
_FIXUP_TABLE_ = .;
-*(.fixup)
+KEEP(*(.fixup))
}
__got2_entries = (_FIXUP_TABLE_ - _GOT2_TABLE_) >> 2;
__fixup_entries = (. - _FIXUP_TABLE_) >> 2;
.data:
{
-*(.data)
-*(.data1)
-*(.sdata)
-*(.sdata2)
-*(.dynamic)
-CONSTRUCTORS
+*(.data*)
+*(.sdata*)
}
_edata = .;
PROVIDE (edata = .);
@@ -109,9 +77,8 @@ SECTIONS
__bss_start = .;
.bss (NOLOAD) :
{
- *(.sbss) *(.scommon)
- *(.dynbss)
- *(.bss)
+ *(.bss*)
+ *(.sbss*)
*(COMMON)
. = ALIGN(4);
}
diff --git a/nand_spl/board/freescale/mpc8313erdb/u-boot.lds
b/nand_spl/board/freescale/mpc8313erdb/u-boot.lds
index ad82589..138e427 100644
--- a/nand_spl/board/freescale/mpc8313erdb/u-boot.lds
+++ b/nand_spl/board/freescale/mpc8313erdb/u-boot.lds
@@ -30,7 +30,6 @@ SECTIONS
.text : {
*(.text*)
. = ALIGN(16);
- *(.eh_frame)
*(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
}
@@ -39,13 +38,15 @@ SECTIONS
*(.data*)
*(.sdata*)
_GOT2_TABLE_ = .;
- *(.got2)
+ KEEP(*(.got2))
__got2_entries = (. - _GOT2_TABLE_) >> 2;
}
. = ALIGN(8);
__bss_start = .;
- .bss (NOLOAD) : { *(.*bss) }
+ .bss (NOLOAD) : {
+ *(.*bss)
+ }
_end = .;
}
ENTRY(_start)
diff --git a/nand_spl/board/freescale/mpc8315erdb/u-boot.lds
b/nand_spl/board/freescale/mpc8315erdb/u-boot.lds
index ad82589..138e427 100644
--- a/nand_spl/board/freescale/mpc8315erdb/u-boot.lds
+++ b/nand_spl/board/freescale/mpc8315erdb/u-boot.lds
@@ -30,7 +30,6 @@ SECTIONS
.text : {
*(.text*)
. = ALIGN(16);
- *(.eh_frame)
*(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
}
@@ -39,13 +38,15 @@ SECTIONS
*(.data*)
*(.sdata*)
_GOT2_TABLE_ = .;
- *(.got2)
+ KEEP(*(.got2))
__got2_entries = (. - _GOT2_TABLE_) >> 2;
}
. = ALIGN(8);
__bss_start = .;
- .bss (NOLOAD) : { *(.*bss) }
+ .bss (NOLOAD) : {
+ *(.*bss)
+ }
_end = .;
}
ENTRY(_start)
diff --git a/nand_spl/board/
Re: [U-Boot] [PATCH] Fix for MPC8360 ATM Quad OC3 External Phys
On Fri, 26 Nov 2010 01:35:23 -0700 "Popa Stefan-R89990" wrote: > * Changed the CS4 and CS5 addresses on Local Bus for matching the PMC0 > and PMC1 addresses. > > Signed-off-by: Stefan Popa > --- doesn't apply: [u-boot master]$ git am -s -3 369 Applying: Fix for MPC8360 ATM Quad OC3 External Phys fatal: patch fragment without header at line 19: @@ -294,13 +294,13 @@ Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Fix for MPC8360 ATM Quad OC3 External Phys When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". applied manually, please make sure your next patch doesn't get mangled next time - try emailing it to yourself, and if that doesn't work, well, email me directly since I'm aware of a couple of issues with freescale smtp servers. Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [MPC837x v2] Make it work again with USB.
On Tue, 16 Nov 2010 13:37:50 +0100 Andre Schwarz wrote: > USB register range IMMR+0x00-0xff is reserved and hangs the CPU. > > Signed-off-by: Andre Schwarz > --- nack, 837x has a usb controller at IMMR+0x23000. Check to see whether there is an invalid USB clock setting in the SCCR? Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
On Fri, 22 Oct 2010 11:21:46 +0200 Andre Schwarz wrote: > diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h > index 28e0d1b..431e102 100644 > --- a/include/configs/MVBLM7.h > +++ b/include/configs/MVBLM7.h > @@ -348,7 +348,7 @@ > #define CONFIG_SYS_SCCR_TSEC1CM 1 > #define CONFIG_SYS_SCCR_TSEC2CM 1 > > -#define CONFIG_SYS_SICRH 0x1fff8003 > +#define CONFIG_SYS_SICRH 0x1fef0003 please use SICRH_* defines to compose this value, as is done for SICRL. Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE
>Applied, thanks. > >Sandeep - hope this is OK with your. >Best regards, >Wolfgang Denk no problem. I was going to send a pull request for this along with my 3 patches Are you going to pull the 3 patches i sent yesterday or do you want a pull request my patches will result in more boards building Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix compiler warning in fdt_support.c
Dear dirk.be...@googlemail.com, In message <1290367174-380-1-git-send-email-dirk.be...@gmail.com> you wrote: > From: Dirk Behme > > Fix compiler warning > > fdt_support.c: In function 'of_bus_default_count_cells': > fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards > qualifiers from pointer target type > fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards > qualifiers from pointer target type > > be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'. > > Signed-off-by: Dirk Behme > > --- > > Found while building 'omap3_beagle'. Applied, thank. Gerry, hope this is OK with you. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I object to intellect without discipline; I object to power without constructive purpose. -- Spock, "The Squire of Gothos", stardate 2124.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE
Dear Thomas Weber, In message <1290066325-1612-1-git-send-email-we...@corscience.de> you wrote: > This patch fixes the issue by defining and using > CONFIG_SYS_INIT_RAM_SIZE and CONFIG_SYS_INIT_RAM_ADDR. > > This patch adopts the > commit 31bfcf1c5776df3d90286aa15104c45096d53dc6 > from Steve Sakoman and Sandeep Paulraj on Devkit8000. > > Signed-off-by: Thomas Weber > --- > include/configs/devkit8000.h |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) Applied, thanks. Sandeep - hope this is OK with your. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What about WRITING it first and rationalizing it afterwords? :-) - Larry Wall in <8...@jpl-devvax.jpl.nasa.gov> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ppc4xx/master
Hi Wolfgang, The following changes since commit 844f07d8a1f1330c97631b23fbf6425db2dc1508: Coding Style (white space) cleanup (2010-11-27 23:35:14 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git master Stefan Roese (2): ppc4xx/POST: Handle cached SDRAM correctly in Denali (440EPx) ECC POST ppc4xx: Flush complete dcache in relocate_code() arch/powerpc/cpu/ppc4xx/start.S | 13 +++-- post/cpu/ppc4xx/denali_ecc.c|4 2 files changed, 11 insertions(+), 6 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc4xx: Flush complete dcache in relocate_code()
On Friday 26 November 2010 15:45:34 Stefan Roese wrote: > When the cache is enabled in SDRAM we need to flush not only the global > data area but also the bd_info struct in relocate_code. This patch now > flushed the complete dcache (all dcache lines) via flush_dcache() instead > of adding a flush_dcache_range() call for bd_info since this is faster. Applied to u-boot-ppc4xx/master. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc4xx/POST: Handle cached SDRAM correctly in Denali (440EPx) ECC POST
On Friday 26 November 2010 15:45:22 Stefan Roese wrote: > This patch fixes a problem in the Denali (440EPx) SDRAM ECC POST test. > When cache is enabled in the SDRAM area, the values written to SDRAM > need to be flushed from cache to SDRAM using the dcfb instruction. > > Without this patch the POST ECC test failed. Now its working again on > platforms with cache enabled in SDRAM. Applied to u-boot-ppc4xx/master. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix compiler warning in fdt_support.c
Le 21/11/2010 20:19, dirk.be...@googlemail.com a écrit :
> From: Dirk Behme
>
> Fix compiler warning
>
> fdt_support.c: In function 'of_bus_default_count_cells':
> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards
> qualifiers from pointer target type
> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards
> qualifiers from pointer target type
>
> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.
>
> Signed-off-by: Dirk Behme
>
> ---
>
> Found while building 'omap3_beagle'.
>
> common/fdt_support.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: u-boot.git/common/fdt_support.c
> ===
> --- u-boot.git.orig/common/fdt_support.c
> +++ u-boot.git/common/fdt_support.c
> @@ -954,7 +954,7 @@ static void of_bus_default_count_cells(v
> if (addrc) {
> prop = fdt_getprop(blob, parentoffset, "#address-cells", NULL);
> if (prop)
> - *addrc = be32_to_cpup(prop);
> + *addrc = be32_to_cpup((u32 *)prop);
> else
> *addrc = 2;
> }
> @@ -962,7 +962,7 @@ static void of_bus_default_count_cells(v
> if (sizec) {
> prop = fdt_getprop(blob, parentoffset, "#size-cells", NULL);
> if (prop)
> - *sizec = be32_to_cpup(prop);
> + *sizec = be32_to_cpup((u32 *)prop);
> else
> *sizec = 1;
> }
Maybe we could pull this patch in? That will raise the count of ARM
boards building clean.
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
