Re: [U-Boot] b reset does not work in u-boot_v2010.12-rc3 with eldk4.2
- Original Message - From: Wolfgang Denk w...@denx.de To: MrGates 120368...@qq.com Cc: u-boot@lists.denx.de Sent: Saturday, January 08, 2011 7:41 PM Subject: Re: [U-Boot] b reset does not work in u-boot_v2010.12-rc3 with eldk4.2 Dear MrGates, please always keep the mailing list on cc: OK, i will. In message d9d3b66c8a5547e0ba21713b70c8e...@microsoft you wrote: These indicate that in start.S,first instruction:b reset not jump success What do you mean by that statement? I am sorry that i have no clear. I mean that b resetstatement does not jump to the lable reset at line 104 of start.S correctly. If you want to execute machine instructions one by one you should use stepi instead of step. The process just go from one instruction to the next. You are running series of step commands - you are asking the debugger to go from one instruction to the next, and this is what it does. What else would you expect? Maybe i misunderstand the use of step command of arm-linux-gdb. I want gdb to simulate the execution sequence of my u-boot. gdb does not simulate, it actually runs the code. And the step command runs the code until it reaches a new source line. Yes,you are right. If you want to step on machine instruction level you should use stepi instead. You may also want to read the documentation, for example this section of the DULG: http://www.denx.de/wiki/view/DULG/DebuggingTricks I have seen that above. What may be the problem?any suggestions is appreciate. Where exactly do you see a problem? compile success.But when i burn u-boot.bin into my NOR flash(sst39vf3201).Nothing happened. So i would like to use arm-linux-gdb(eldk-4.2) with simulating. Debugging is indeed a good idea in such a situation. Note that gdb does not simulate. You will need a JTAG adapter to debug on the real hardware. I use SkyEye 1.2.5 cooperates with arm-linux-gdb . Now the serial still no output information. I thought the u-boot has failed before relocation. I do not know where maybe wrong. I have checked configs/xxx.h ,start.S many times. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The only way to learn a new programming language is by writing pro- grams in it.- Brian Kernighan o ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] uboot load ftb
Dear =?UTF-8?B?5byg5oms?=, In message aanlktinux-nmpundbm=scyeahckbad9=dx8b3ro7g...@mail.gmail.com you wrote: i trying to sue the kernel's Makefile rule, but the issue is not solved. WARNING: could not set linux,stdout-path FDT_ERR_NOTFOUND. ERROR: /chosen node create failed - must RESET the board to recover. Well, seems your device tree has some problem. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never give in. Never give in. Never. Never. Never. - Winston Churchill ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] ea20: build fixes
On 01/11/2011 08:48 PM, Ben Gardiner wrote: There are two separate issues causing failure of ea20 builds. I discovered them while trying to build a da850evm load with RMII support. The second patch affects all boards that could use CONFIG_DRIVER_TI_EMAC_USE_RMII of which ea20 is the only one set default in u-boot. The first patch fixes the second problem I ran into trying to build ea20 after developping the RMII patch. Ben Gardiner (2): ea20: fix libea20.o not found ea20: fix undefined PHY_* errors board/davinci/ea20/Makefile |2 +- drivers/net/davinci_emac.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Hi Ben, thanks for discovering this issue and to fix it ! Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] ea20: fix libea20.o not found
On 01/11/2011 08:48 PM, Ben Gardiner wrote: This patch fixes ea20 after commit 6d8962e814c15807dd6ac5757904be2a02d187b8 where $(obj)lib$(BOARD).a was changed to $(obj)lib$(BOARD).o in almost all the Makefiles except ea20, probably due to merge path of the changes in 2010.12. Signed-off-by: Ben Gardinerbengardi...@nanometrics.ca CC: Sebastien Carlier sebastien.carl...@gmail.com --- board/davinci/ea20/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by : Stefano Babic sba...@denx.de Regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Problem booting linux with device tree table
2011/1/12 Wolfgang Denk w...@denx.de: Dear =?UTF-8?B?5byg5oms?=, In message aanlktinvninbre--k=a+j_p8yjrr8jvahomjt7fy=...@mail.gmail.com you wrote: i use dtc compiler with following command: dtc -R 8 -b 0 -O dtb -I dts -S 0x3000 -o my.dtb my.dts Booting process gives following error and reset the board. WARNING: could not create /chosen FDT_ERR_NOSPACE. Well, this is a pretty descriptive message, isn;t it? You don;t reserve enough space i your device tree. somebody advises me to add a chosen node in my DTS file, but The issue is not solved. Instead of yousing your custom dtc command, you should use the kernel's default rule which should work better. Now you've posted the same question 3 times. I hope this is enough. sorry, :-( i firstly use the maillist. I will be carefull next time thanks again for your time replaying to the e-mail Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The use of anthropomorphic terminology when dealing with computing systems is a symptom of professional immaturity. -- Edsger Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][v3] PBL: add support for boot from SPI flash.
Dear Shaohui Xie, In message 1294817626-4727-1-git-send-email-b21...@freescale.com you wrote: PBL(pre-boot loader): SPI flash used as RCW(Reset Configuration Word) and PBI(pre-boot initialization) source, CPC(CoreNet Platform Cache) used as 1M SRAM where PBL will copy whole U-BOOT image to, U-boot can boot from CPC after PBL completes RCW and PBI phases. Signed-off-by: Chunhe Lan b25...@freescale.com Signed-off-by: Mingkai Hu mingkai...@freescale.com Signed-off-by: Shaohui Xie b21...@freescale.com --- Use CONFIG_RAMBOOT_PBL instead of CONFIG_PBL_BOOT_INDIRECT according to Kumar's comment. CONFIG_RAMBOOT_PBL needs to be documented in the README! diff --git a/board/freescale/corenet_ds/config.mk b/board/freescale/corenet_ds/config.mk index 15bbf20..918775d 100644 --- a/board/freescale/corenet_ds/config.mk +++ b/board/freescale/corenet_ds/config.mk @@ -24,4 +24,10 @@ # P4080DS board # +ifeq ($(CONFIG_RAMBOOT_PBL), y) +RESET_VECTOR_ADDRESS = 0xfffc +endif + +ifndef RESET_VECTOR_ADDRESS RESET_VECTOR_ADDRESS = 0xeffc +endif Do we really need this? Can this not be moved into the board config file, so we gan delete the config.mk ? /* TLB 1 */ /* *I*** - Covers boot page */ +#if defined(CONFIG_SYS_RAMBOOT) defined(CONFIG_SYS_INIT_L3_ADDR) + /* *I*G - L3SRAM. When L3 is used as 1M SRAM, the address of the + * SRAM is at 0xfff0, it covered the 0xf000. + * */ Incorrect multiline comment style. Please fix globally. --- a/include/configs/corenet_ds.h +++ b/include/configs/corenet_ds.h @@ -28,6 +28,10 @@ #include ../board/freescale/common/ics307_clk.h +#ifdef CONFIG_RAMBOOT_PBL +#define CONFIG_RAMBOOT_TEXT_BASE0xfff8 +#endif Why is this needed? You already set SYS_TEXT_BASE to that value. @@ -62,11 +66,17 @@ #ifdef CONFIG_SYS_NO_FLASH #define CONFIG_ENV_IS_NOWHERE #else -#define CONFIG_ENV_IS_IN_FLASH Why remove the CONFIG_ENV_IS_IN_FLASH here, but leave the CONFIG_ENV_IS_NOWHERE above? #define CONFIG_FLASH_CFI_DRIVER #define CONFIG_SYS_FLASH_CFI #endif +#if defined(CONFIG_RAMBOOT_PBL) + #define CONFIG_ENV_IS_NOWHERE 1 /* Store ENV in memory only */ +#else + #define CONFIG_ENV_IS_IN_FLASH + #define CONFIG_ENV_ADDR (CONFIG_SYS_MONITOR_BASE - CONFIG_ENV_SECT_SIZE) +#endif See previous comment. This should be cleaned up. For example, move this block up, and set CONFIG_SYS_NO_FLASH instead. +#define CONFIG_SYS_L3_SIZE (1024 10) +#define CONFIG_SYS_INIT_L3_END (CONFIG_SYS_INIT_L3_ADDR + CONFIG_SYS_L3_SIZE) + + +/* Drop one of the blank lines, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A meeting is an event at which the minutes are kept and the hours are lost. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] b reset does not work in u-boot_v2010.12-rc3 with eldk4.2
Dear MrGates, In message 745589936d574232be24ea063064b...@mrgates you wrote: [ lots of unrelated quote deleted] Please restrict your quoting to the relevant parts; see http://www.netmeister.org/news/learn2quote.html I use SkyEye 1.2.5 cooperates with arm-linux-gdb . Now the serial still no output information. I thought the u-boot has failed before relocation. I do not know where maybe wrong. I have checked configs/xxx.h ,start.S many times. Are you sure you are really debugging a problem with U-Boot? Maybe there is some problem with SkyEye and/or how you configured it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nobody goes to that restaurant anymore. It's too crowded. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] b reset does not work in u-boot_v2010.12-rc3 with eldk4.2
Dear Wolfgang Denk, I Think i am debugging on u-boot.Because i am upgrading u-boot from v1.1.2 to v2010.12-rc3. I have tried to run u-boot on skyeye 1.2.5 ,and that works fine. Two version of U-boot are base on the same hardwares: CPU: S3c44b0 FLash: SST30vf3201 (4MByte) Net Adapter: RTL8019 SDRAM:H57V2562GTR (32MByte) U-boot v1.1.2 is old ,and it also works fine on this hardware environment. Best Regrads MrGates - Original Message - From: Wolfgang Denk w...@denx.de To: MrGates 120368...@qq.com Cc: u-boot@lists.denx.de Sent: Wednesday, January 12, 2011 4:14 PM Subject: Re: [U-Boot] b reset does not work in u-boot_v2010.12-rc3 with eldk4.2 Dear MrGates, In message 745589936d574232be24ea063064b...@mrgates you wrote: [ lots of unrelated quote deleted] Please restrict your quoting to the relevant parts; see http://www.netmeister.org/news/learn2quote.html I use SkyEye 1.2.5 cooperates with arm-linux-gdb . Now the serial still no output information. I thought the u-boot has failed before relocation. I do not know where maybe wrong. I have checked configs/xxx.h ,start.S many times. Are you sure you are really debugging a problem with U-Boot? Maybe there is some problem with SkyEye and/or how you configured it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nobody goes to that restaurant anymore. It's too crowded. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
Rather than defining it config.mk we can set it in config.h and remove config.mk from several boards that don't need it. We mimic what 4xx does and introduce CONFIG_RESET_VECTOR_ADDRESS for config.h to set. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc/cpu/mpc85xx/u-boot.lds |8 +++- board/freescale/corenet_ds/config.mk | 27 --- board/freescale/mpc8536ds/config.mk | 14 +- board/freescale/mpc8572ds/config.mk |2 -- board/freescale/p1022ds/config.mk| 10 -- board/freescale/p1_p2_rdb/config.mk | 12 board/freescale/p2020ds/config.mk| 26 -- include/configs/MPC8536DS.h |6 ++ include/configs/MPC8572DS.h |4 include/configs/P1022DS.h|4 include/configs/P1_P2_RDB.h |6 ++ include/configs/P2020DS.h|4 include/configs/corenet_ds.h |4 13 files changed, 36 insertions(+), 91 deletions(-) delete mode 100644 board/freescale/corenet_ds/config.mk delete mode 100644 board/freescale/p1022ds/config.mk delete mode 100644 board/freescale/p2020ds/config.mk diff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds b/arch/powerpc/cpu/mpc85xx/u-boot.lds index 67d7763..b931897 100644 --- a/arch/powerpc/cpu/mpc85xx/u-boot.lds +++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds @@ -1,5 +1,5 @@ /* - * Copyright 2007-2009 Freescale Semiconductor, Inc. + * Copyright 2007-2009, 2011 Freescale Semiconductor, Inc. * * See file CREDITS for list of people who contributed to this * project. @@ -20,9 +20,15 @@ * MA 02111-1307 USA */ +#include config.h/* CONFIG_BOARDDIR */ + #ifndef RESET_VECTOR_ADDRESS +#ifdef CONFIG_RESET_VECTOR_ADDRESS +#define RESET_VECTOR_ADDRESS CONFIG_RESET_VECTOR_ADDRESS +#else #define RESET_VECTOR_ADDRESS 0xfffc #endif +#endif OUTPUT_ARCH(powerpc) diff --git a/board/freescale/corenet_ds/config.mk b/board/freescale/corenet_ds/config.mk deleted file mode 100644 index 15bbf20..000 --- a/board/freescale/corenet_ds/config.mk +++ /dev/null @@ -1,27 +0,0 @@ -# -# Copyright 2007-2009 Freescale Semiconductor, Inc. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -# -# P4080DS board -# - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/mpc8536ds/config.mk b/board/freescale/mpc8536ds/config.mk index b7deb4a..228d8c0 100644 --- a/board/freescale/mpc8536ds/config.mk +++ b/board/freescale/mpc8536ds/config.mk @@ -1,5 +1,5 @@ # -# Copyright 2008 Freescale Semiconductor. +# Copyright 2008, 2011 Freescale Semiconductor. # # See file CREDITS for list of people who contributed to this # project. @@ -28,15 +28,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -ifeq ($(CONFIG_SDCARD), y) -RESET_VECTOR_ADDRESS = 0xf8fc -endif - -ifeq ($(CONFIG_SPIFLASH), y) -RESET_VECTOR_ADDRESS = 0xf8fc -endif - -ifndef RESET_VECTOR_ADDRESS -RESET_VECTOR_ADDRESS = 0xeffc -endif diff --git a/board/freescale/mpc8572ds/config.mk b/board/freescale/mpc8572ds/config.mk index 7fd6412..53fda6f 100644 --- a/board/freescale/mpc8572ds/config.mk +++ b/board/freescale/mpc8572ds/config.mk @@ -28,5 +28,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/p1022ds/config.mk b/board/freescale/p1022ds/config.mk deleted file mode 100644 index a953fdd..000 --- a/board/freescale/p1022ds/config.mk +++ /dev/null @@ -1,10 +0,0 @@ -# -# Copyright 2010 Freescale Semiconductor, Inc. -# -# This program is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by the Free -# Software Foundation; either version 2 of the License, or (at your option) -# any later version. -# - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/p1_p2_rdb/config.mk b/board/freescale/p1_p2_rdb/config.mk index eececaa..d57b50e 100644 --- a/board/freescale/p1_p2_rdb/config.mk +++ b/board/freescale/p1_p2_rdb/config.mk @@ -29,15 +29,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -ifeq
Re: [U-Boot] [PATCH][v3] PBL: add support for boot from SPI flash.
On Jan 12, 2011, at 2:10 AM, Wolfgang Denk wrote: diff --git a/board/freescale/corenet_ds/config.mk b/board/freescale/corenet_ds/config.mk index 15bbf20..918775d 100644 --- a/board/freescale/corenet_ds/config.mk +++ b/board/freescale/corenet_ds/config.mk @@ -24,4 +24,10 @@ # P4080DS board # +ifeq ($(CONFIG_RAMBOOT_PBL), y) +RESET_VECTOR_ADDRESS = 0xfffc +endif + +ifndef RESET_VECTOR_ADDRESS RESET_VECTOR_ADDRESS = 0xeffc +endif Do we really need this? Can this not be moved into the board config file, so we gan delete the config.mk ? I'll post a cleanup patch that should handle this bit for us on all 85xx boards that need it. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
Dear Kumar Gala, In message 1294822268-22266-1-git-send-email-ga...@kernel.crashing.org you wrote: #ifndef RESET_VECTOR_ADDRESS +#ifdef CONFIG_RESET_VECTOR_ADDRESS +#define RESET_VECTOR_ADDRESS CONFIG_RESET_VECTOR_ADDRESS +#else #define RESET_VECTOR_ADDRESS 0xfffc #endif +#endif In which case is the #ifndef RESET_VECTOR_ADDRESS needed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Severe culture shock results when experts from another protocol suite [...] try to read OSI documents. The term osified is used to refer to such documents. [...] Any relationship to the word ossified is purely intentional.- Marshall T. Rose ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - microblaze
Michal Simek wrote: Dear Wolfgang, please pull the following changes. Ping. Michal Thanks, Michal The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: Mike Frysinger (1): asm-offsets: generate bd_t size are available in the git repository at: git://www.denx.de/git/u-boot-microblaze.git master Michal Simek (2): microblaze: Disabling interrupt should return 1 if was enabled microblaze: Fix bd_info pointer arch/microblaze/cpu/interrupts.c |5 - arch/microblaze/lib/board.c |8 +--- include/configs/microblaze-generic.h |8 3 files changed, 13 insertions(+), 8 deletions(-) -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7
On Saturday 08 January 2011 07:36 PM, Albert ARIBAUD wrote: Le 08/01/2011 14:17, Aneesh V a écrit : snip.. +/* some utility macros */ +#define mask(start, end) \ + (((1 ((end) - (start) + 1)) - 1) (start)) + +#define mask_n_get(reg, start, end) \ + (((reg) mask(start, end)) (start)) Seeing as these functions are only used in the ARMv7 cache C file, they should be moved there. I plan to use a modified version of mask_n_get() and its set couterpart mask_n_set() in my subsequent works in more files. Can I keep it here itself or should I move it to an OMAP specific header file or can I move it to a more generic header file? Please suggest. They're very generic actually. I think they should go to a gereric bit manipulation header, and be named a... bit... more explicitly. For instance, the name 'mask' does not show that the macro creates a range of 'one' bits from start to end. What I need is something like below: #define get_bit_field(nr, start, mask)\ (((nr) (mask)) (start)) #define set_bit_field(nr, start, mask, val)\ (nr) = ((nr) ~(mask)) | (((val) (start)) (mask)) Can these go in a generic header? If so, can I add them to include/linux/bitops.h Best regards, Aneesh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] xilinx_ppc_boards: Change address of RESET_VECTOR
Old address of RESET_VECTOR were overwritten by the bss sector, making impossible its run from xmd. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- boards.cfg | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/boards.cfg b/boards.cfg index 94b8745..2ba603d 100644 --- a/boards.cfg +++ b/boards.cfg @@ -675,9 +675,9 @@ yellowstone powerpc ppc4xx yosemiteamcc yosemite powerpc ppc4xx yosemiteamcc - yosemite:YOSEMITE yuccapowerpc ppc4xx - amcc AP1000 powerpc ppc4xx ap1000 amirix -fx12mm powerpc ppc4xx fx12mm avnet - fx12mm:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x03FC,INIT_TLB=board/xilinx/ppc405-generic/init.o +fx12mm powerpc ppc4xx fx12mm avnet - fx12mm:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410,INIT_TLB=board/xilinx/ppc405-generic/init.o fx12mm_flash powerpc ppc4xx fx12mm avnet - fx12mm:SYS_TEXT_BASE=0xF7F6,RESET_VECTOR_ADDRESS=0xF7FC,INIT_TLB=board/xilinx/ppc405-generic/init.o -v5fx30teval powerpc ppc4xx v5fx30teval avnet - v5fx30teval:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x03FC,BOOT_FROM_XMD=1,INIT_TLB=board/xilinx/ppc440-generic/init.o +v5fx30teval powerpc ppc4xx v5fx30teval avnet - v5fx30teval:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410,BOOT_FROM_XMD=1,INIT_TLB=board/xilinx/ppc440-generic/init.o v5fx30teval_flashpowerpc ppc4xx v5fx30teval avnet - v5fx30teval:SYS_TEXT_BASE=0xF7F6,RESET_VECTOR_ADDRESS=0xF7FC,INIT_TLB=board/xilinx/ppc440-generic/init.o CRAYL1 powerpc ppc4xx L1 cray CATcenterpowerpc ppc4xx PPChameleonEVB dave - CATcenter:PPCHAMELEON_MODULE_MODEL=1 @@ -736,11 +736,11 @@ p3p440 powerpc ppc4xx - prodriv KAREFpowerpc ppc4xx karef sandburst METROBOX powerpc ppc4xx metrobox sandburst xpedite1000 powerpc ppc4xx - xes -ml507powerpc ppc4xx ml507 xilinx - ml507:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x03FC,BOOT_FROM_XMD=1,INIT_TLB=board/xilinx/ppc440-generic/init.o +ml507powerpc ppc4xx ml507 xilinx - ml507:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410,BOOT_FROM_XMD=1,INIT_TLB=board/xilinx/ppc440-generic/init.o ml507_flash powerpc ppc4xx ml507 xilinx - ml507:SYS_TEXT_BASE=0xF7F6,RESET_VECTOR_ADDRESS=0xF7FC,INIT_TLB=board/xilinx/ppc440-generic/init.o -xilinx-ppc405-genericpowerpc ppc4xx ppc405-generic xilinx - xilinx-ppc405-generic:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x03FC +xilinx-ppc405-genericpowerpc ppc4xx ppc405-generic xilinx - xilinx-ppc405-generic:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410 xilinx-ppc405-generic_flash powerpc ppc4xx ppc405-generic xilinx - xilinx-ppc405-generic:SYS_TEXT_BASE=0xF7F6,RESET_VECTOR_ADDRESS=0xF7FC -xilinx-ppc440-genericpowerpc ppc4xx ppc440-generic xilinx - xilinx-ppc440-generic:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x03FC,BOOT_FROM_XMD=1 +xilinx-ppc440-genericpowerpc ppc4xx ppc440-generic xilinx - xilinx-ppc440-generic:SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410,BOOT_FROM_XMD=1 xilinx-ppc440-generic_flash powerpc ppc4xx ppc440-generic xilinx - xilinx-ppc440-generic:SYS_TEXT_BASE=0xF7F6,RESET_VECTOR_ADDRESS=0xF7FC rsk7203 sh sh2 rsk7203 renesas- mpr2 sh sh3 mpr2- - -- 1.7.2.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Hello Wolfgang,
Wolfgang Denk wrote:
In message 1294816806-32614-2-git-send-email...@denx.de you wrote:
Global question: do we really need an CONFIG_DIGSY_REV5? Is there not
a way to determine the revision by probing the hardware? For example,
the RTC's show up at different addresses on the bus - but ther emight
be even easier ways?
Good question ... as I know, there is no possibility to detect the
hardware on an other way then over the RTC ... and I don;t want to
go this way ... what if the RTC is not responding?
diff --git a/board/digsy_mtc/digsy_mtc.c b/board/digsy_mtc/digsy_mtc.c
index cc6087b..2b0c574 100644
--- a/board/digsy_mtc/digsy_mtc.c
+++ b/board/digsy_mtc/digsy_mtc.c
#endif /* CONFIG_IDE_RESET */
+#endif /* CONFIG_CMD_IDE */
This looks wrong to me. You did not add a matching #if or
#ifdef anywhere?
The #endif is actual on the wrong place ...
+/* Update the Flash Baseaddr settings */
+int update_flash_size (int flash_size)
+{
+volatile struct mpc5xxx_mmap_ctl *mm =
+(struct mpc5xxx_mmap_ctl *) CONFIG_SYS_MBAR;
+flash_info_t*dev;
+int i;
+int size = 0;
+unsigned long base = 0x0;
+u32 *cs_reg = (u32 *)mm-cs0_start;
+
+for (i = 0; i 2; i++) {
+dev = flash_info[i];
+
+if (dev-size) {
+/* calculate new base addr for this chipselect */
+base -= dev-size;
+out_be32(cs_reg, START_REG(base));
+cs_reg++;
+out_be32(cs_reg, STOP_REG(base, dev-size));
+cs_reg++;
+/* recalculate the sectoraddr in the cfi driver */
+size += flash_get_size(base, i);
+}
+}
+#if defined(CONFIG_DIGSY_REV5)
+gd-bd-bi_flashstart = base;
+#endif
Why is this #if needed? Why not always set bi_flashstart ?
It is set in arch/powerpc/lib/board.c before calling update_flash_size(),
so this adaption is only needed, if the baseaddr is changing on different
flash sizes, what is valid for the rev5 board ...
void ft_board_setup(void *blob, bd_t *bd)
{
ft_cpu_setup(blob, bd);
+/* remove RTC */
+#if defined(CONFIG_DIGSY_REV5)
+ft_delete_node(blob, dallas,ds1339);
+#else
+ft_delete_node(blob, mc,rv3029c2);
+#endif
You should add a comment here what you are doing, and why.
Ok, you are right. (In the DTS there are two RTC nodes defined, and this
code removes the not existing one in the dts)
ft_delete_node() returns int - why do you ignore the return codes?
You are right, add a warning, thanks.
+#if defined(CONFIG_SYS_UPDATE_FLASH_SIZE)
+ft_adapt_flash_base(blob);
+#endif
ft_adapt_flash_base() returns int - why do you ignore the return code?
Yep, add here also a warning.
}
#endif /* defined(CONFIG_OF_LIBFDT) defined(CONFIG_OF_BOARD_SETUP) */
-
-#endif /* CONFIG_CMD_IDE */
Ah! So this is a bug fix?
Yep. Should I seperate this in an extra patch?
diff --git a/board/digsy_mtc/is45s16800a2.h b/board/digsy_mtc/is45s16800a2.h
new file mode 100644
index 000..029e6cd
--- /dev/null
+++ b/board/digsy_mtc/is45s16800a2.h
@@ -0,0 +1,27 @@
+/*
+ * (C) Copyright 2004-2009
+ * Mark Jonas, Freescale Semiconductor, mark.jo...@motorola.com.
Are you sure that Mark wrote any of this code?
No, I just copied this from board/digsy_mtc/is42s16800a-7t.h,
so add my name to it.
diff --git a/boards.cfg b/boards.cfg
index 94b8745..9e1fc14 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -241,6 +241,9 @@ cm5200 powerpc mpc5xxx
digsy_mtcpowerpc mpc5xxx digsy_mtc
digsy_mtc_LOWBOOTpowerpc mpc5xxx digsy_mtc -
- digsy_mtc:SYS_TEXT_BASE=0xFF00
digsy_mtc_RAMBOOTpowerpc mpc5xxx digsy_mtc -
- digsy_mtc:SYS_TEXT_BASE=0x0010
+digsy_mtc_rev5 powerpc mpc5xxx digsy_mtc -
- digsy_mtc:DIGSY_REV5
+digsy_mtc_rev5_LOWBOOT powerpc mpc5xxx digsy_mtc -
- digsy_mtc:SYS_TEXT_BASE=0xFF00,DIGSY_REV5
+digsy_mtc_rev5_RAMBOOT powerpc mpc5xxx digsy_mtc -
- digsy_mtc:SYS_TEXT_BASE=0x0010,DIGSY_REV5
Do we really need all these 6 configurations for the digsy_mtc board?
Are all of them actively being used?
Good question, I just used digsy_mtc_rev5, digsy_mtc_rev5_RAMBOOT,
maybe the LOWBOOT case could be deleted.
diff --git a/doc/README.cfi b/doc/README.cfi
new file mode 100644
index 000..fa35108
--- /dev/null
+++ b/doc/README.cfi
@@ -0,0 +1,15 @@
+known issues:
+
+using M29W128GH from Numonyx:
+
+You need to add a board specific flash_cmd_reset() function
+for this chip to work correctly. Something like this should
+work (tested on the digsy_mtc board):
+
+void
Re: [U-Boot] [PATCH][v3] PBL: add support for boot from SPI flash.
--- Use CONFIG_RAMBOOT_PBL instead of CONFIG_PBL_BOOT_INDIRECT according to Kumar's comment. CONFIG_RAMBOOT_PBL needs to be documented in the README! [Xie Shaohui] OK, I'll submit a patch of README. /* TLB 1 */ /* *I*** - Covers boot page */ +#if defined(CONFIG_SYS_RAMBOOT) defined(CONFIG_SYS_INIT_L3_ADDR) +/* *I*G - L3SRAM. When L3 is used as 1M SRAM, the address of the + * SRAM is at 0xfff0, it covered the 0xf000. + * */ Incorrect multiline comment style. Please fix globally. [Xie Shaohui] OK. --- a/include/configs/corenet_ds.h +++ b/include/configs/corenet_ds.h @@ -28,6 +28,10 @@ #include ../board/freescale/common/ics307_clk.h +#ifdef CONFIG_RAMBOOT_PBL +#define CONFIG_RAMBOOT_TEXT_BASE0xfff8 +#endif Why is this needed? You already set SYS_TEXT_BASE to that value. [Xie Shaohui] You are right; this is not needed after boards.cfg is used. @@ -62,11 +66,17 @@ #ifdef CONFIG_SYS_NO_FLASH #define CONFIG_ENV_IS_NOWHERE #else -#define CONFIG_ENV_IS_IN_FLASH Why remove the CONFIG_ENV_IS_IN_FLASH here, but leave the CONFIG_ENV_IS_NOWHERE above? #define CONFIG_FLASH_CFI_DRIVER #define CONFIG_SYS_FLASH_CFI #endif +#if defined(CONFIG_RAMBOOT_PBL) +#define CONFIG_ENV_IS_NOWHERE 1 /* Store ENV in memory only */ +#else +#define CONFIG_ENV_IS_IN_FLASH +#define CONFIG_ENV_ADDR (CONFIG_SYS_MONITOR_BASE - CONFIG_ENV_SECT_SIZE) +#endif See previous comment. This should be cleaned up. For example, move this block up, and set CONFIG_SYS_NO_FLASH instead. [Xie Shaohui] OK, I'll clean up these codes. +#define CONFIG_SYS_L3_SIZE (1024 10) +#define CONFIG_SYS_INIT_L3_END (CONFIG_SYS_INIT_L3_ADDR + +CONFIG_SYS_L3_SIZE) + + +/* Drop one of the blank lines, please. [Xie Shaohui] OK. Thanks. Best Regards, Shaohui Xie ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
On Jan 12, 2011, at 2:59 AM, Wolfgang Denk wrote: Dear Kumar Gala, In message 1294822268-22266-1-git-send-email-ga...@kernel.crashing.org you wrote: #ifndef RESET_VECTOR_ADDRESS +#ifdef CONFIG_RESET_VECTOR_ADDRESS +#define RESET_VECTOR_ADDRESSCONFIG_RESET_VECTOR_ADDRESS +#else #define RESET_VECTOR_ADDRESS 0xfffc #endif +#endif In which case is the #ifndef RESET_VECTOR_ADDRESS needed? I don't think there is any, I was mimicing what is in the 4xx/u-boot.lds - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
Rather than defining it config.mk we can set it in config.h and remove config.mk from several boards that don't need it. We mimic what 4xx does and introduce CONFIG_RESET_VECTOR_ADDRESS for config.h to set. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc/cpu/mpc85xx/u-boot.lds |8 +++- board/freescale/corenet_ds/config.mk | 27 --- board/freescale/mpc8536ds/config.mk | 14 +- board/freescale/mpc8572ds/config.mk |2 -- board/freescale/p1022ds/config.mk| 10 -- board/freescale/p1_p2_rdb/config.mk | 12 board/freescale/p2020ds/config.mk| 26 -- include/configs/MPC8536DS.h |6 ++ include/configs/MPC8572DS.h |4 include/configs/P1022DS.h|4 include/configs/P1_P2_RDB.h |6 ++ include/configs/P2020DS.h|4 include/configs/corenet_ds.h |4 13 files changed, 36 insertions(+), 91 deletions(-) delete mode 100644 board/freescale/corenet_ds/config.mk delete mode 100644 board/freescale/p1022ds/config.mk delete mode 100644 board/freescale/p2020ds/config.mk diff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds b/arch/powerpc/cpu/mpc85xx/u-boot.lds index 67d7763..b931897 100644 --- a/arch/powerpc/cpu/mpc85xx/u-boot.lds +++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds @@ -1,5 +1,5 @@ /* - * Copyright 2007-2009 Freescale Semiconductor, Inc. + * Copyright 2007-2009, 2011 Freescale Semiconductor, Inc. * * See file CREDITS for list of people who contributed to this * project. @@ -20,9 +20,15 @@ * MA 02111-1307 USA */ +#include config.h/* CONFIG_BOARDDIR */ + #ifndef RESET_VECTOR_ADDRESS +#ifdef CONFIG_RESET_VECTOR_ADDRESS +#define RESET_VECTOR_ADDRESS CONFIG_RESET_VECTOR_ADDRESS +#else #define RESET_VECTOR_ADDRESS 0xfffc #endif +#endif OUTPUT_ARCH(powerpc) diff --git a/board/freescale/corenet_ds/config.mk b/board/freescale/corenet_ds/config.mk deleted file mode 100644 index 15bbf20..000 --- a/board/freescale/corenet_ds/config.mk +++ /dev/null @@ -1,27 +0,0 @@ -# -# Copyright 2007-2009 Freescale Semiconductor, Inc. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -# -# P4080DS board -# - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/mpc8536ds/config.mk b/board/freescale/mpc8536ds/config.mk index b7deb4a..228d8c0 100644 --- a/board/freescale/mpc8536ds/config.mk +++ b/board/freescale/mpc8536ds/config.mk @@ -1,5 +1,5 @@ # -# Copyright 2008 Freescale Semiconductor. +# Copyright 2008, 2011 Freescale Semiconductor. # # See file CREDITS for list of people who contributed to this # project. @@ -28,15 +28,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -ifeq ($(CONFIG_SDCARD), y) -RESET_VECTOR_ADDRESS = 0xf8fc -endif - -ifeq ($(CONFIG_SPIFLASH), y) -RESET_VECTOR_ADDRESS = 0xf8fc -endif - -ifndef RESET_VECTOR_ADDRESS -RESET_VECTOR_ADDRESS = 0xeffc -endif diff --git a/board/freescale/mpc8572ds/config.mk b/board/freescale/mpc8572ds/config.mk index 7fd6412..53fda6f 100644 --- a/board/freescale/mpc8572ds/config.mk +++ b/board/freescale/mpc8572ds/config.mk @@ -28,5 +28,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/p1022ds/config.mk b/board/freescale/p1022ds/config.mk deleted file mode 100644 index a953fdd..000 --- a/board/freescale/p1022ds/config.mk +++ /dev/null @@ -1,10 +0,0 @@ -# -# Copyright 2010 Freescale Semiconductor, Inc. -# -# This program is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by the Free -# Software Foundation; either version 2 of the License, or (at your option) -# any later version. -# - -RESET_VECTOR_ADDRESS = 0xeffc diff --git a/board/freescale/p1_p2_rdb/config.mk b/board/freescale/p1_p2_rdb/config.mk index eececaa..d57b50e 100644 --- a/board/freescale/p1_p2_rdb/config.mk +++ b/board/freescale/p1_p2_rdb/config.mk @@ -29,15 +29,3 @@ ifeq ($(CONFIG_NAND), y) LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds endif endif - -ifeq
Re: [U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
Dear Kumar Gala, In message 1294824140-22519-1-git-send-email-ga...@kernel.crashing.org you wrote: Rather than defining it config.mk we can set it in config.h and remove config.mk from several boards that don't need it. We mimic what 4xx does and introduce CONFIG_RESET_VECTOR_ADDRESS for config.h to set. Signed-off-by: Kumar Gala ga...@kernel.crashing.org What's this? A resubmit of the previous posting? Or a new version? With any changes? Which changes? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Insufficient facts always invite danger. -- Spock, Space Seed, stardate 3141.9 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Dear Heiko Schocher,
In message 4d2d7122.60...@denx.de you wrote:
Global question: do we really need an CONFIG_DIGSY_REV5? Is there not
a way to determine the revision by probing the hardware? For example,
the RTC's show up at different addresses on the bus - but ther emight
be even easier ways?
Good question ... as I know, there is no possibility to detect the
hardware on an other way then over the RTC ... and I don;t want to
go this way ... what if the RTC is not responding?
Maybe you can ask the hardware guys again?
+ for (i = 0; i 2; i++) {
+ dev = flash_info[i];
+
+ if (dev-size) {
+ /* calculate new base addr for this chipselect */
+ base -= dev-size;
+ out_be32(cs_reg, START_REG(base));
+ cs_reg++;
+ out_be32(cs_reg, STOP_REG(base, dev-size));
+ cs_reg++;
+ /* recalculate the sectoraddr in the cfi driver */
+ size += flash_get_size(base, i);
+ }
+ }
+#if defined(CONFIG_DIGSY_REV5)
+ gd-bd-bi_flashstart = base;
+#endif
Why is this #if needed? Why not always set bi_flashstart ?
It is set in arch/powerpc/lib/board.c before calling update_flash_size(),
so this adaption is only needed, if the baseaddr is changing on different
flash sizes, what is valid for the rev5 board ...
It may not be needed, but I think it should compute the same result,
so you should be able to omit the #if and the #endif.
If you should compute a different result, then I'd wonder if the code
is actually correct?
-#endif /* CONFIG_CMD_IDE */
Ah! So this is a bug fix?
Yep. Should I seperate this in an extra patch?
At least mention it in the commit message.
Hmm.. I have only one flash on the !rev5 board, so I need this
differentiation here, or?
Yes.
Hmm.. after looking in code, can your proposal work?:
Is flash_info[0].size valid, when the cfi driver detects the flash?
For the probing, a temporary address can be used. You set up the
final mapping only after the sizes are knows, similar to what we do
when we have several banks of RAM.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
People are always a lot more complicated than you think. It's very
important to remember that. - Terry Pratchett, _Truckers_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add the MX53 boot image support. This patch has been tested on Freescale MX53EVK board and MX51EVK board. Signed-off-by: Jason Liu r64...@freescale.com Tested on vision2 board, too. Tested-by: Stefano Babic sba...@denx.de Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 1/8] MX5: Add initial support for MX53 processor
On 01/04/2011 09:27 AM, Jason Liu wrote: Add initial support for Freescale MX53 processor, - Add the iomux support and the pin definition, - Add the regs definition, clean up some unused def from mx51, - Add the low level init support, make use the freq input of setup_pll macro --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/8] fec_mxc: add support for MX53 processor
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add FEC support for Freescale MX53 processor Signed-off-by: Jason Liu r64...@freescale.com --- drivers/net/fec_mxc.c |2 +- drivers/net/fec_mxc.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 3/8] serial_mxc: add support for MX53 processor
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add UART support for Freescale MX53 processor Signed-off-by: Jason Liu r64...@freescale.com --- drivers/serial/serial_mxc.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 4/8] mxc_gpio: add support for MX53 processor
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add mxc_gpio support for Freescale MX53 processor Signed-off-by: Jason Liu r64...@freescale.com --- Changes for v2 - put this patch into the same patchset with MX53 support as Stefano comments, --- drivers/gpio/mxc_gpio.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 5/8] mxc_i2c: add support for MX53 processor
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add I2C support for Freescale MX53 processor Signed-off-by: Jason Liu r64...@freescale.com --- Changes for v2: -address the comments of Heiko, add #if defined(CONFIG_MX31) to avoid break MX31 build. Move CONFIG_HARD_I2C to the top of the file and fix the error message from: #error define CONFIG_SYS_I2C_PORT to use the I2C driver to #error define CONFIG_SYS_I2C_MXxx_PORTx to use the I2C driver Changes for v3: -address the comments from Albert, change #ifdef to #if defined() for the sake of homogeneity --- drivers/i2c/mxc_i2c.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 6/8] fsl_pmic: add I2C interface support
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add I2C interface for fsl_pmic driver support Signed-off-by: Jason Liu r64...@freescale.com --- Changes for v2: - Address the comments from Stefano, - factor out the param_check in pmic_reg for both spi/i2c - Address the comments from Stefano, - Remvove call i2c_init again - Fix one logic path for pmic_read issue. Here the pmic dump command output: MX53EVK U-Boot pmic dump 4 PMIC ID: 0x45d0 [Rev: 2.0] 0x00: 00015088 00ff 00395208 4081 --- drivers/misc/fsl_pmic.c | 45 - 1 files changed, 40 insertions(+), 5 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support
On 01/04/2011 09:27 AM, Jason Liu wrote: This patch add the MX53 boot image support. This patch has been tested on Freescale MX53EVK board and MX51EVK board. Signed-off-by: Jason Liu r64...@freescale.com --- Changes for v2: - Address the following comments from Stefano, - Get rid of #ifdef in the imximage.h and .c file and use the runtime check for imximage version - Document the IMXIMAGE_VERSION definiton in doc/README.imximage - Move mx53evk/config.mk and mx53evk/imximage.cfg to MX53EVK board support patch. Changes for v3: - Address the following comments from Stefano, - Not change the mx51evk file. The code should take VERSION=1 as default, and we do not need to change the actual boards. - add a note in the documentation and raise an error in code if the VERSION command is read after any other suitable commands. - Change command IMXIMAGE_VERSION simply to IMAGE_VERSION - Need recognize the version directly from its structure and not storing the version into the header when do header verify and print. - Use function pointer to simpliy the code when the version of header is recognized --- doc/README.imximage | 12 ++- tools/imximage.c| 421 --- tools/imximage.h| 110 +++--- 3 files changed, 433 insertions(+), 110 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 8/8] MX5:MX53: add initial support for MX53EVK board
On 01/04/2011 09:27 AM, Jason Liu wrote: Add initial support for MX53EVK board support. FEC, SD/MMC, UART, I2C, have been supported. Signed-off-by: Jason Liu r64...@freescale.com --- Changes for v2: -Address the comments from Stefano, Albert and Wolfgang, -remove the ivt.S file and use imximage.cfg instead, -remove the ivt link to u-boot -Address the comments from Stefano, -Correct the copyright issue, -Use mxc_get_gpio() and mxc_set_gpio() accessors. -Get rid of system_rev, -use i2c enumeration value (0,1,..N) instead of BASE address, -use fsl_pmic i2c interface, -Add comments for why manage the pmic in a different way for TO2 -Remove the comments from configs/mx53evk.h, - /* - * Disabled for now due to build problems under Debian and a significant - * increase in the final file size: 144260 vs. 109536 Bytes. - */ -Address the comments from Wolfgang, -Move CONFIG_SYS_TEXT_BASE to board config file, -Remove the comments from configs/mx53evk.h - /* size in bytes reserved for initial data */ #define BOARD_LATE_INIT -Change the comments, * Hardware drivers to * UART drivers Changes for v3: - Address the comments from Stefano, - put uart and fec iomux setting to board_early_init_f so that uart can print out the early information such as uboot banner and cpuinfo etc. - Put maintainer name to ARM list, - Use Macro instead of constant value for PMIC, - Remove CONFIG_I2C_MXC and BOARD_LATE_INIT, - Add config.mk and imximage.cfg files to this patch, Changes for v4: - Address the comments from Stefano, - Maintain the list *alfabetically* sorted of MAINTAINERS - Multiline comment issue in configs/mx53evk.h file. --- MAINTAINERS |4 + board/freescale/mx53evk/Makefile | 48 board/freescale/mx53evk/config.mk| 25 +++ board/freescale/mx53evk/imximage.cfg | 112 ++ board/freescale/mx53evk/mx53evk.c| 397 ++ boards.cfg |1 + include/configs/mx53evk.h| 193 + include/mc13892.h|5 + 8 files changed, 785 insertions(+), 0 deletions(-) Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Hi Wolfgang, Dear Heiko Schocher, In message 4d2d7122.60...@denx.de you wrote: Global question: do we really need an CONFIG_DIGSY_REV5? Is there not a way to determine the revision by probing the hardware? For example, the RTC's show up at different addresses on the bus - but ther emight be even easier ways? Good question ... as I know, there is no possibility to detect the hardware on an other way then over the RTC ... and I don;t want to go this way ... what if the RTC is not responding? Maybe you can ask the hardware guys again? We did this and we are sure that there is no better way. Cheers Detlev -- When you loosen yourself from all the obvious delusions - religion, ideology, Communism - you're still left with the myth of your own goodness. Which is the final delusion. -- Philip Roth -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Hello Heiko, [...] diff --git a/boards.cfg b/boards.cfg index 94b8745..9e1fc14 100644 --- a/boards.cfg +++ b/boards.cfg @@ -241,6 +241,9 @@ cm5200 powerpc mpc5xxx digsy_mtcpowerpc mpc5xxx digsy_mtc digsy_mtc_LOWBOOT powerpc mpc5xxx digsy_mtc - - digsy_mtc:SYS_TEXT_BASE=0xFF00 digsy_mtc_RAMBOOT powerpc mpc5xxx digsy_mtc - - digsy_mtc:SYS_TEXT_BASE=0x0010 +digsy_mtc_rev5 powerpc mpc5xxx digsy_mtc - - digsy_mtc:DIGSY_REV5 +digsy_mtc_rev5_LOWBOOT powerpc mpc5xxx digsy_mtc - - digsy_mtc:SYS_TEXT_BASE=0xFF00,DIGSY_REV5 +digsy_mtc_rev5_RAMBOOT powerpc mpc5xxx digsy_mtc - - digsy_mtc:SYS_TEXT_BASE=0x0010,DIGSY_REV5 Do we really need all these 6 configurations for the digsy_mtc board? Are all of them actively being used? Good question, I just used digsy_mtc_rev5, digsy_mtc_rev5_RAMBOOT, maybe the LOWBOOT case could be deleted. Yes, the LOWBOOT cases can be removed. The hardware can not be configured in a way to use them. Cheers Detlev -- We can forgive a man for making a useful thing as long as he does not admire it. The only excuse for making a useless thing is that one admires it intensely. --- Oscar Wilde -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Hello Wolfgang,
Wolfgang Denk wrote:
In message 4d2d7122.60...@denx.de you wrote:
Global question: do we really need an CONFIG_DIGSY_REV5? Is there not
a way to determine the revision by probing the hardware? For example,
the RTC's show up at different addresses on the bus - but ther emight
be even easier ways?
Good question ... as I know, there is no possibility to detect the
hardware on an other way then over the RTC ... and I don;t want to
go this way ... what if the RTC is not responding?
Maybe you can ask the hardware guys again?
Ok. done. As Detlev mentioned in the meantime the LOWBOOT cases
can be removed, done.
+ for (i = 0; i 2; i++) {
+ dev = flash_info[i];
+
+ if (dev-size) {
+ /* calculate new base addr for this chipselect */
+ base -= dev-size;
+ out_be32(cs_reg, START_REG(base));
+ cs_reg++;
+ out_be32(cs_reg, STOP_REG(base, dev-size));
+ cs_reg++;
+ /* recalculate the sectoraddr in the cfi driver */
+ size += flash_get_size(base, i);
+ }
+ }
+#if defined(CONFIG_DIGSY_REV5)
+ gd-bd-bi_flashstart = base;
+#endif
Why is this #if needed? Why not always set bi_flashstart ?
It is set in arch/powerpc/lib/board.c before calling update_flash_size(),
so this adaption is only needed, if the baseaddr is changing on different
flash sizes, what is valid for the rev5 board ...
It may not be needed, but I think it should compute the same result,
so you should be able to omit the #if and the #endif.
If you should compute a different result, then I'd wonder if the code
is actually correct?
Yep, you are right, the #if ... #endif is not needed here.
-#endif /* CONFIG_CMD_IDE */
Ah! So this is a bug fix?
Yep. Should I seperate this in an extra patch?
At least mention it in the commit message.
Ok, add this to the commit message.
Hmm.. I have only one flash on the !rev5 board, so I need this
differentiation here, or?
Yes.
Hmm.. after looking in code, can your proposal work?:
Is flash_info[0].size valid, when the cfi driver detects the flash?
For the probing, a temporary address can be used. You set up the
final mapping only after the sizes are knows, similar to what we do
when we have several banks of RAM.
But thats exactly what I do with the defines in include/configs/digsy_mtc.h
#define CONFIG_SYS_FLASH_BASE 0xFE00
#define CONFIG_SYS_FLASH_BASE_CS1 0xFC00
#define CONFIG_SYS_MAX_FLASH_BANKS 2
#define CONFIG_SYS_FLASH_BANKS_LIST { CONFIG_SYS_FLASH_BASE_CS1, \
CONFIG_SYS_FLASH_BASE}
and after detecting the real size through the cfi driver on this
temporary addresses, the flash_info gets updated with the new baseaddr
through the call:
int update_flash_size (int flash_size)
[...]
if (dev-size) {
/* calculate new base addr for this chipselect */
base -= dev-size;
[...]
/* recalculate the sectoraddr in the cfi driver */
size += flash_get_size(base, i);
so after that, flash_info has the right values and I update the chip
selects in board specific code ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init
Hello.
On 11-01-2011 17:52, seedshope wrote:
Since SDRAM init function have already change, So the SDRAM
initial function must be change.
Signed-off-by: seedshopebocui...@gmail.com
diff --git a/board/samsung/smdk6400/smdk6400.c
b/board/samsung/smdk6400/smdk6400.c
index 35aa40b..52b44a8 100644
--- a/board/samsung/smdk6400/smdk6400.c
+++ b/board/samsung/smdk6400/smdk6400.c
@@ -78,10 +78,18 @@ int board_init(void)
return 0;
}
-int dram_init(void)
+void dram_init_banksize(void)
{
+ DECLARE_GLOBAL_DATA_PTR;
+
gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+}
+
+int dram_init(void)
+{
+ gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+ CONFIG_MAX_RAM_BANK_SIZE);
Please indent that line more to the right, preferrebly start it under
'(volatile long *)'.
WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC] ARM: mx31pdk: Use the new relocation scheme
Hi,
I am trying to make the new relocation scheme to work on the mx31pdk board.
With this patch applied the mx31pdk build works, but not able to get a U-boot
prompt yet.
I copied the nand_spl/board/karo/tx25/u-boot.lds to the mx31pdk one.
I am not certain whether the CONFIG_SYS_TEXT_BASE should be changed or not:
ifdef CONFIG_NAND_SPL
CONFIG_SYS_TEXT_BASE = 0x87ec
else
CONFIG_SYS_TEXT_BASE = 0x87f0
endif
If anyone has any comments/suggestions I will appreciate it.
Thanks,
Fabio Estevam
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
arch/arm/cpu/arm1136/start.S|4 +-
board/freescale/mx31pdk/mx31pdk.c | 10 -
include/configs/mx31pdk.h |6 +++
nand_spl/board/freescale/mx31pdk/u-boot.lds | 59 +++---
4 files changed, 68 insertions(+), 11 deletions(-)
diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 9a6f6cb..85b5e44 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -271,8 +271,8 @@ clbss_l:str r2, [r0]/* clear loop...
*/
ldr r0, _nand_boot_ofs
adr r1, _start
add pc, r0, r1
-_nand_boot_ofs
- : .word nand_boot - _start
+_nand_boot_ofs:
+ .word nand_boot - _start
#else
jump_2_ram:
ldr r0, _board_init_r_ofs
diff --git a/board/freescale/mx31pdk/mx31pdk.c
b/board/freescale/mx31pdk/mx31pdk.c
index 9f47169..2756e5a 100644
--- a/board/freescale/mx31pdk/mx31pdk.c
+++ b/board/freescale/mx31pdk/mx31pdk.c
@@ -33,10 +33,16 @@ DECLARE_GLOBAL_DATA_PTR;
int dram_init(void)
{
+ /* dram_init must store complete ramsize in gd-ram_size */
+ gd-ram_size = get_ram_size((volatile void *)CONFIG_SYS_SDRAM_BASE,
+ PHYS_SDRAM_1_SIZE);
+ return 0;
+}
+
+void dram_init_banksize(void)
+{
gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
-
- return 0;
}
int board_init(void)
diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index 3b90a01..e3f8b9f 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -155,6 +155,12 @@
#define PHYS_SDRAM_1 CSD0_BASE
#define PHYS_SDRAM_1_SIZE (128 * 1024 * 1024)
+#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_RAM_ADDR IRAM_BASE_ADDR
+#define CONFIG_SYS_INIT_RAM_SIZE IRAM_SIZE
+#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE -
GENERATED_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR(CONFIG_SYS_INIT_RAM_ADDR +
CONFIG_SYS_GBL_DATA_OFFSET)
+
/*---
* FLASH and environment organization
*/
diff --git a/nand_spl/board/freescale/mx31pdk/u-boot.lds
b/nand_spl/board/freescale/mx31pdk/u-boot.lds
index edd8430..ff289fb 100644
--- a/nand_spl/board/freescale/mx31pdk/u-boot.lds
+++ b/nand_spl/board/freescale/mx31pdk/u-boot.lds
@@ -1,3 +1,25 @@
+/*
+ * (C) Copyright 2009
+ * Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
OUTPUT_FORMAT(elf32-littlearm, elf32-littlearm, elf32-littlearm)
OUTPUT_ARCH(arm)
ENTRY(_start)
@@ -19,18 +41,41 @@ SECTIONS
.rodata : { *(.rodata) }
. = ALIGN(4);
- .data : { *(.data) }
+ .data : {
+ *(.data)
+ }
. = ALIGN(4);
- .got : { *(.got) }
-
- . = .;
__u_boot_cmd_start = .;
.u_boot_cmd : { *(.u_boot_cmd) }
__u_boot_cmd_end = .;
. = ALIGN(4);
- __bss_start = .;
- .bss : { *(.bss) }
- _end = .;
+
+ .rel.dyn : {
+ __rel_dyn_start = .;
+ *(.rel*)
+ __rel_dyn_end = .;
+ }
+
+ .dynsym : {
+ __dynsym_start = .;
+ *(.dynsym)
+ }
+
+ .bss __rel_dyn_start (OVERLAY) : {
+ __bss_start = .;
+ *(.bss)
+. = ALIGN(4);
+ _end = .;
+ }
+
+ /DISCARD/ : { *(.bss*) }
+ /DISCARD/ : { *(.dynstr*) }
+ /DISCARD/ : { *(.dynsym*) }
+
Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling
On 11.01.2011 3:31, Mike Frysinger wrote: it isnt a problem to have the parens, and it keeps things sane if someone does something like: #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 This would be a violation of basic rules of defensive coding. Please drop these parens. i dont see how these two statements are compatible. defensive coding would mean i keep the parens. I think Wolfgang meant that defining a macro without parens would be a violation -- which should be fixed, not worked around. -mike WBR, Sergei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Hi Wolfgang Heiko,
On Wednesday 12 January 2011 08:59:20 Wolfgang Denk wrote:
diff --git a/doc/README.cfi b/doc/README.cfi
new file mode 100644
index 000..fa35108
--- /dev/null
+++ b/doc/README.cfi
@@ -0,0 +1,15 @@
+known issues:
+
+using M29W128GH from Numonyx:
+
+You need to add a board specific flash_cmd_reset() function
+for this chip to work correctly. Something like this should
+work (tested on the digsy_mtc board):
+
+void flash_cmd_reset(flash_info_t *info)
+{
+flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
+}
Stefan, can you please send an explicit ACK for this part?
If we put something like this into this new README, we should make the
description a bit better. Something like:
--- snip ---
The common CFI driver provides this weak default implementation for
flash_cmd_reset():
void __flash_cmd_reset(flash_info_t *info)
{
/*
* We do not yet know what kind of commandset to use, so we issue
* the reset command in both Intel and AMD variants, in the hope
* that AMD flash roms ignore the Intel command.
*/
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
flash_write_cmd(info, 0, 0, FLASH_CMD_RESET);
}
void flash_cmd_reset(flash_info_t *info)
__attribute__((weak,alias(__flash_cmd_reset)));
Some flash chips seems to have trouble with this reset sequence. In this case
the board specific code can override this weak default version with a board
specific function. For example the digsy_mtc board equipped with the M29W128GH
from Numonyx needs this version to function properly:
void flash_cmd_reset(flash_info_t *info)
{
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
}
--- snip ---
Heiko, if nobody objects then please include this version into your next patch
version. Here my:
Signed-off-by: Stefan Roese s...@denx.de
Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc5200, digsy_mtc: add support for rev5 board version
Dear Heiko Schocher, In message 4d2d81c3.7010...@denx.de you wrote: Maybe you can ask the hardware guys again? Ok. done. As Detlev mentioned in the meantime the LOWBOOT cases can be removed, done. Thanks. For the probing, a temporary address can be used. You set up the final mapping only after the sizes are knows, similar to what we do when we have several banks of RAM. But thats exactly what I do with the defines in include/configs/digsy_mtc.h Ah, OK. did not notice that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Use C++ to confuse your enemies; use C to produce stable code. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc4xx: Add DLVision-10G board support
Hi Dirk,
On Monday 10 January 2011 13:33:23 Dirk Eibach wrote:
Board support for the Guntermann Drunck DLVision-10G.
A few comments below...
Signed-off-by: Dirk Eibach eib...@gdsys.de
---
MAINTAINERS|1 +
arch/powerpc/include/asm/global_data.h |3 +
board/gdsys/405ep/405ep.c | 38 +-
board/gdsys/405ep/Makefile |1 +
board/gdsys/405ep/dlvision-10g.c | 126 +
board/gdsys/common/fpga.h |8 +
boards.cfg |1 +
include/configs/dlvision-10g.h | 242
8 files changed, 417 insertions(+), 3
deletions(-)
create mode 100644 board/gdsys/405ep/dlvision-10g.c
create mode 100644 include/configs/dlvision-10g.h
diff --git a/MAINTAINERS b/MAINTAINERS
index ba83f71..a13812a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -142,6 +142,7 @@ Dirk Eibach eib...@gdsys.de
devconcenterPPC460EX
dlvisionPPC405EP
+ dlvision-10gPPC405EP
gdppc440etx PPC440EP/GR
intip PPC460EX
io PPC405EP
diff --git a/arch/powerpc/include/asm/global_data.h
b/arch/powerpc/include/asm/global_data.h index 2e218de..4068e85 100644
--- a/arch/powerpc/include/asm/global_data.h
+++ b/arch/powerpc/include/asm/global_data.h
@@ -172,6 +172,9 @@ typedef struct global_data {
#if defined(CONFIG_LWMON) || defined(CONFIG_LWMON5)
unsigned long kbd_status;
#endif
+#ifdef CONFIG_405EP
+ unsigned fpga_state;
+#endif
fpga_state doesn't seem to be 405EP specific.
#if defined(CONFIG_WD_MAX_RATE)
unsigned long long wdt_last;/* trace watch-dog triggering rate */
#endif
diff --git a/board/gdsys/405ep/405ep.c b/board/gdsys/405ep/405ep.c
index d3bd233..c2d9455 100644
--- a/board/gdsys/405ep/405ep.c
+++ b/board/gdsys/405ep/405ep.c
@@ -26,6 +26,7 @@
#include asm/processor.h
#include asm/io.h
#include asm/ppc4xx-gpio.h
+#include asm/global_data.h
#include ../common/fpga.h
@@ -36,8 +37,27 @@
#define REFLECTION_TESTPATTERN 0xdede
#define REFLECTION_TESTPATTERN_INV (~REFLECTION_TESTPATTERN 0x)
+DECLARE_GLOBAL_DATA_PTR;
+
+int get_fpga_state(void)
+{
+ return gd-fpga_state;
+}
+
+void print_fpga_state(void)
+{
+ if (gd-fpga_state FPGA_STATE_DONE_FAILED)
+ puts( Waiting for FPGA-DONE timed out.\n);
+ if (gd-fpga_state FPGA_STATE_REFLECTION_FAILED)
+ puts( FPGA reflection test failed.\n);
+}
+
int board_early_init_f(void)
{
+ unsigned ctr;
+
+ gd-fpga_state = 0;
+
mtdcr(UIC0SR, 0x); /* clear all ints */
mtdcr(UIC0ER, 0x); /* disable all ints */
mtdcr(UIC0CR, 0x); /* set all to be non-critical */
@@ -66,10 +86,16 @@ int board_early_init_f(void)
/*
* wait for fpga-done
- * fail ungraceful if fpga is not configuring properly
*/
- while (!(in_le16((void *)LATCH2_BASE) 0x0010))
- ;
+#warning this will not work for dlvision-10g
Hmmm. Can't you handle this better? Remove this code for the dlvision-10g?
+ ctr = 0;
+ while (!(in_le16((void *)LATCH2_BASE) 0x0010)) {
+ udelay(10);
+ if (ctr++ 5) {
+ gd-fpga_state |= FPGA_STATE_DONE_FAILED;
+ break;
+ }
+ }
/*
* setup io-latches for boot (stop reset)
@@ -82,11 +108,17 @@ int board_early_init_f(void)
* wait for fpga out of reset
* fail ungraceful if fpga is not working properly
*/
+ ctr = 0;
while (1) {
fpga_set_reg(CONFIG_SYS_FPGA_RFL_LOW, REFLECTION_TESTPATTERN);
if (fpga_get_reg(CONFIG_SYS_FPGA_RFL_HIGH) ==
REFLECTION_TESTPATTERN_INV)
break;
+ udelay(10);
+ if (ctr++ 5) {
+ gd-fpga_state |= FPGA_STATE_REFLECTION_FAILED;
+ break;
+ }
}
return 0;
diff --git a/board/gdsys/405ep/Makefile b/board/gdsys/405ep/Makefile
index ed31207..169418c 100644
--- a/board/gdsys/405ep/Makefile
+++ b/board/gdsys/405ep/Makefile
@@ -27,6 +27,7 @@ LIB = $(obj)lib$(BOARD).o
COBJS-$(CONFIG_IO) += io.o
COBJS-$(CONFIG_IOCON) += iocon.o
+COBJS-$(CONFIG_DLVISION_10G) += dlvision-10g.o
COBJS := $(BOARD).o $(COBJS-y)
SOBJS =
diff --git a/board/gdsys/405ep/dlvision-10g.c
b/board/gdsys/405ep/dlvision-10g.c new file mode 100644
index 000..e704f74
--- /dev/null
+++ b/board/gdsys/405ep/dlvision-10g.c
@@ -0,0 +1,126 @@
+/*
+ * (C) Copyright 2010
+ * Dirk Eibach, Guntermann Drunck GmbH, eib...@gdsys.de
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it
Re: [U-Boot] [PATCH] ppc4xx: Support multiple FPGAs
Hi Dirk,
On Monday 10 January 2011 13:33:24 Dirk Eibach wrote:
Add support for multiple FPGAs per board for gdsys
405ep architecture.
Signed-off-by: Dirk Eibach eib...@gdsys.de
---
arch/powerpc/include/asm/global_data.h |2 +-
board/gdsys/405ep/405ep.c | 62 +
board/gdsys/405ep/dlvision-10g.c | 214
--- board/gdsys/405ep/io.c |
8 +-
board/gdsys/405ep/iocon.c | 14 +-
board/gdsys/common/Makefile|1 +
board/gdsys/common/fpga.h | 12 +-
include/configs/dlvision-10g.h | 33 -
include/configs/io.h |7 +-
include/configs/iocon.h| 27 -
10 files changed, 275 insertions(+), 105 deletions(-)
diff --git a/arch/powerpc/include/asm/global_data.h
b/arch/powerpc/include/asm/global_data.h index 4068e85..fb7da21 100644
--- a/arch/powerpc/include/asm/global_data.h
+++ b/arch/powerpc/include/asm/global_data.h
@@ -173,7 +173,7 @@ typedef struct global_data {
unsigned long kbd_status;
#endif
#ifdef CONFIG_405EP
- unsigned fpga_state;
+ unsigned fpga_state[CONFIG_SYS_FPGA_COUNT];
#endif
Hmmm. Again, not 405_EP specific. And can't you squash this change with the
change from the dlvision-10g board?
#if defined(CONFIG_WD_MAX_RATE)
unsigned long long wdt_last;/* trace watch-dog triggering rate */
diff --git a/board/gdsys/405ep/405ep.c b/board/gdsys/405ep/405ep.c
index c2d9455..84ea573 100644
--- a/board/gdsys/405ep/405ep.c
+++ b/board/gdsys/405ep/405ep.c
@@ -39,24 +39,26 @@
DECLARE_GLOBAL_DATA_PTR;
-int get_fpga_state(void)
+int get_fpga_state(unsigned dev)
{
- return gd-fpga_state;
+ return gd-fpga_state[dev];
}
-void print_fpga_state(void)
+void print_fpga_state(unsigned dev)
{
- if (gd-fpga_state FPGA_STATE_DONE_FAILED)
+ if (gd-fpga_state[dev] FPGA_STATE_DONE_FAILED)
puts( Waiting for FPGA-DONE timed out.\n);
- if (gd-fpga_state FPGA_STATE_REFLECTION_FAILED)
+ if (gd-fpga_state[dev] FPGA_STATE_REFLECTION_FAILED)
puts( FPGA reflection test failed.\n);
}
int board_early_init_f(void)
{
+ unsigned k;
unsigned ctr;
- gd-fpga_state = 0;
+ for (k = 0; k CONFIG_SYS_FPGA_COUNT; ++k)
+ gd-fpga_state[k] = 0;
mtdcr(UIC0SR, 0x); /* clear all ints */
mtdcr(UIC0ER, 0x); /* disable all ints */
@@ -87,13 +89,15 @@ int board_early_init_f(void)
/*
* wait for fpga-done
*/
-#warning this will not work for dlvision-10g
- ctr = 0;
- while (!(in_le16((void *)LATCH2_BASE) 0x0010)) {
- udelay(10);
- if (ctr++ 5) {
- gd-fpga_state |= FPGA_STATE_DONE_FAILED;
- break;
+ for (k = 0; k CONFIG_SYS_FPGA_COUNT; ++k) {
+ ctr = 0;
+ while (!(in_le16((void *)LATCH2_BASE)
+ CONFIG_SYS_FPGA_DONE(k))) {
+ udelay(10);
+ if (ctr++ 5) {
+ gd-fpga_state[k] |= FPGA_STATE_DONE_FAILED;
+ break;
+ }
}
}
@@ -104,20 +108,24 @@ int board_early_init_f(void)
out_le16((void *)LATCH0_BASE, CONFIG_SYS_LATCH0_BOOT);
out_le16((void *)LATCH1_BASE, CONFIG_SYS_LATCH1_BOOT);
- /*
- * wait for fpga out of reset
- * fail ungraceful if fpga is not working properly
- */
- ctr = 0;
- while (1) {
- fpga_set_reg(CONFIG_SYS_FPGA_RFL_LOW, REFLECTION_TESTPATTERN);
- if (fpga_get_reg(CONFIG_SYS_FPGA_RFL_HIGH) ==
- REFLECTION_TESTPATTERN_INV)
- break;
- udelay(10);
- if (ctr++ 5) {
- gd-fpga_state |= FPGA_STATE_REFLECTION_FAILED;
- break;
+ for (k = 0; k CONFIG_SYS_FPGA_COUNT; ++k) {
+ /*
+ * wait for fpga out of reset
+ * fail ungraceful if fpga is not working properly
+ */
+ ctr = 0;
+ while (1) {
+ fpga_set_reg(k, CONFIG_SYS_FPGA_RFL_LOW,
+ REFLECTION_TESTPATTERN);
+ if (fpga_get_reg(k, CONFIG_SYS_FPGA_RFL_HIGH) ==
+ REFLECTION_TESTPATTERN_INV)
+ break;
+ udelay(10);
+ if (ctr++ 5) {
+ gd-fpga_state[k] |=
+ FPGA_STATE_REFLECTION_FAILED;
+ break;
+ }
}
}
diff --git a/board/gdsys/405ep/dlvision-10g.c
b/board/gdsys/405ep/dlvision-10g.c index e704f74..c217dfe 100644
---
Re: [U-Boot] [PATCH] ppc4xx: Support dual link OSD
Hi Dirk, On Monday 10 January 2011 13:33:25 Dirk Eibach wrote: Add support for dual link osd hardware for gdsys 405ep. This patch also changes many lines introduced by the 2 previous patches. Again I'm thinking if it makes more sense to squash all those 3 patches into one. Would be interesting to see the git diffstat (e.g. 8 files changed, 417 insertions(+), 3 deletions(-)) of the single squashed patch compared to the summary of the 3 single patches. What do you think? Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init
On 01/12/2011 07:08 PM, Sergei Shtylyov wrote:
Hello.
On 11-01-2011 17:52, seedshope wrote:
Since SDRAM init function have already change, So the SDRAM
initial function must be change.
Signed-off-by: seedshopebocui...@gmail.com
diff --git a/board/samsung/smdk6400/smdk6400.c
b/board/samsung/smdk6400/smdk6400.c
index 35aa40b..52b44a8 100644
--- a/board/samsung/smdk6400/smdk6400.c
+++ b/board/samsung/smdk6400/smdk6400.c
@@ -78,10 +78,18 @@ int board_init(void)
return 0;
}
-int dram_init(void)
+void dram_init_banksize(void)
{
+ DECLARE_GLOBAL_DATA_PTR;
+
gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+}
+
+int dram_init(void)
+{
+ gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+ CONFIG_MAX_RAM_BANK_SIZE);
Please indent that line more to the right, preferrebly start it under
'(volatile long *)'.
ok, But I don't know how number tab indent is appropriate. May be the
effect as following？
gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
CONFIG_MAX_RAM_BANK_SIZE);
Thanks，
seedshope
WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.
Am 09.01.2011 23:19, schrieb Wolfgang Denk:
From: Alexander Holler hol...@ahsoftware.de
gcc 4.5.1 seems to ignore (at least some) volatile definitions,
avoid that as done in the kernel.
Reading C99 6.7.3 8 and the comment 114) there, I think it is a bug of that
gcc version to ignore the volatile type qualifier used e.g. in __arch_getl().
Anyway, using a definition as in the kernel headers avoids such optimizations
when
gcc 4.5.1 is used.
Maybe the headers as used in the current linux-kernel should be used,
but to avoid large changes, I've just added a small change to the current
headers.
Signed-off-by: Alexander Holler hol...@ahsoftware.de
Signed-off-by: Dirk Behme dirk.be...@googlemail.com
Signed-off-by: Wolfgang Denk w...@denx.de
Cc: Alessandro Rubini rubini-l...@gnudd.com
---
arch/arm/include/asm/io.h | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index ff1518e..3886f15 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -117,21 +117,29 @@ extern inline void __raw_readsl(unsigned int addr, void
*data, int longlen)
*buf++ = __arch_getl(addr);
}
-#define __raw_writeb(v,a)__arch_putb(v,a)
-#define __raw_writew(v,a)__arch_putw(v,a)
-#define __raw_writel(v,a)__arch_putl(v,a)
+#define __raw_writeb(v,a)__arch_putb(v,a)
+#define __raw_writew(v,a)__arch_putw(v,a)
+#define __raw_writel(v,a)__arch_putl(v,a)
-#define __raw_readb(a) __arch_getb(a)
-#define __raw_readw(a) __arch_getw(a)
-#define __raw_readl(a) __arch_getl(a)
+#define __raw_readb(a) __arch_getb(a)
+#define __raw_readw(a) __arch_getw(a)
+#define __raw_readl(a) __arch_getl(a)
-#define writeb(v,a) __arch_putb(v,a)
-#define writew(v,a) __arch_putw(v,a)
-#define writel(v,a) __arch_putl(v,a)
+/*
+ * TODO: The kernel offers some more advanced versions of barriers, it might
+ * have some advantages to use them instead of the simple one here.
+ */
+#define dmb()__asm__ __volatile__ ( : : : memory)
+#define __iormb()dmb()
+#define __iowmb()dmb()
+
+#define writeb(v,c) ({ __iowmb(); __arch_putb(v,c); v; })
+#define writew(v,c) ({ __iowmb(); __arch_putw(v,c); v; })
+#define writel(v,c) ({ __iowmb(); __arch_putl(v,c); v; })
-#define readb(a) __arch_getb(a)
-#define readw(a) __arch_getw(a)
-#define readl(a) __arch_getl(a)
+#define readb(c) ({ u8 __v = __arch_getb(c); __iormb(); __v; })
+#define readw(c) ({ u16 __v = __arch_getw(c); __iormb(); __v; })
+#define readl(c) ({ u32 __v = __arch_getl(c); __iormb(); __v; })
/*
* The compiler seems to be incapable of optimising constants
Tested-by: Thomas Weber we...@corscience.de
on Devkit8000 with codesourcery arm2010.09 (gcc4.5.1) and arm2010q1 (gcc
4.4.1)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.
Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and the writeb in drivers/mtd/nand/omap_gpmc.c doesn't have the problem as the v1-patch. Reagards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Move RESET_VECTOR_ADDRESS into config.h
On Jan 12, 2011, at 3:27 AM, Wolfgang Denk wrote: Dear Kumar Gala, In message 1294824140-22519-1-git-send-email-ga...@kernel.crashing.org you wrote: Rather than defining it config.mk we can set it in config.h and remove config.mk from several boards that don't need it. We mimic what 4xx does and introduce CONFIG_RESET_VECTOR_ADDRESS for config.h to set. Signed-off-by: Kumar Gala ga...@kernel.crashing.org What's this? A resubmit of the previous posting? Or a new version? With any changes? Which changes? SOrry, for got the 'v2' when I posted. Its a new version that removes the extra ifdef checking around RESET_VECTOR_ADDRESS in u-boot.lds - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic
Wolfgang Denk w...@denx.de wrote on 2010/12/17 17:13:47: Dear Joakim Tjernlund, In message of3301f88e.e61f6369-onc12577fc.00573ebc-c12577fc.00576...@transmode.se you wrote: Great! then we got: [PATCH] PowerPC: Move -fPIC flag to common place [PATCH] PowerPC: Add support for -msingle-pic-base How about the above 2 patches? I think I have them on my list for next, but I got other things to do first. OK, not forgotten then. Good. This will definitely not go into v2010.12. Sure, that was not my intention either. hmm, no word on the above two patches yet. Jocke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] corenet_ds: Update to use new hwconfig APIs
Hwconfig is called before relocating. Use the new hwconfig APIs.
Signed-off-by: York Sun york...@freescale.com
---
arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c | 15 +--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
index 5bcf91a..9e00a61 100644
--- a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
+++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
@@ -33,6 +33,8 @@
static u32 serdes_prtcl_map;
+#define HWCONFIG_BUFFER_SIZE 128
+
#ifdef DEBUG
static const char *serdes_prtcl_str[] = {
[NONE] = NA,
@@ -277,6 +279,15 @@ void fsl_serdes_init(void)
const char *srds_lpd_arg;
size_t arglen;
#endif
+ char buffer[HWCONFIG_BUFFER_SIZE];
+ char *buf = NULL;
+
+ /*
+* Extract hwconfig from environment since we have not properly setup
+* the environment but need it for ddr config params
+*/
+ if (getenv_f(hwconfig, buffer, sizeof(buffer)) 0)
+ buf = buffer;
/* Is serdes enabled at all? */
if (!(in_be32(gur-rcwsr[5]) FSL_CORENET_RCWSR5_SRDS_EN))
@@ -295,8 +306,8 @@ void fsl_serdes_init(void)
if (!IS_SVR_REV(get_svr(), 1, 0))
for (bank = 1; bank ARRAY_SIZE(srds_lpd_b); bank++) {
sprintf(srds_lpd_opt, fsl_srds_lpd_b%u, bank + 1);
- srds_lpd_arg = hwconfig_subarg(serdes, srds_lpd_opt,
- arglen);
+ srds_lpd_arg = hwconfig_subarg_f(serdes, srds_lpd_opt,
+ arglen, buf);
if (srds_lpd_arg)
srds_lpd_b[bank] = simple_strtoul(srds_lpd_arg,
NULL, 0);
--
1.7.0.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init
Dear seedshope, In message 4d2dc040.7040...@gmail.com you wrote: ok, But I don't know how number tab indent is appropriate. May be the effect as following? You should start reading http://www.denx.de/wiki/U-Boot/CodingStyle (and follow the links shown there). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Oh dear, I think you'll find reality's on the blink again. - Marvin The Paranoid Android ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.
Dear Alexander Holler, In message 4d2dcb18.20...@ahsoftware.de you wrote: Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and the writeb in drivers/mtd/nand/omap_gpmc.c doesn't have the problem as the v1-patch. Thanks - but please send a formal Acked-by: and/or Tested-by: . Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe does not have laws - it has habits, and habits can be broken. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.
Am 12.01.2011 17:40, schrieb Wolfgang Denk: Dear Alexander Holler, In message4d2dcb18.20...@ahsoftware.de you wrote: Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and the writeb in drivers/mtd/nand/omap_gpmc.c doesn't have the problem as the v1-patch. Thanks - but please send a formal Acked-by: and/or Tested-by: . Oh, as I'm still listed as the author, I thought that isn't necessary. I don't know if I should paste the whole patch (this is my first ack ;) ), but here are both: Acked-by: Alexander Holler hol...@ahsoftware.de Tested-by: Alexander Holler hol...@ahsoftware.de Regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com
-Original Message- From: Paulraj, Sandeep [mailto:s-paul...@ti.com] Sent: Tuesday, January 11, 2011 7:00 PM To: Tom Warren; Tom Warren; u-boot@lists.denx.de Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Hi Tom, [Tom Warren] Hi. Sorry for top-quoting before. My comments are now in-line. Note that I've put in a request to my IT department to remove the 'confidential information' b.s. disclaimer that is appended to all my outgoing Outlook emails. If anyone knows how to get Gmail to use the standard reply-to quoting, I can start using my Gmail account instead. We keep the U-Boot in sync with what is at http://git.kernel.org/?p=linux/kernel/git/torvalds/linux- 2.6.git;a=history;f=arch/arm/tools/mach- types;h=2fea897ebeb12959415120a7c1cdcaf5d8ac8fee;hb=4162cf64973df51fc885825b c9ca4d055891c49f I can see that the kernel does not have the updated name yet. [Tom Warren] I'm surprised, since I was told the kernel's copy had been updated. I'll check with the kernel guys - perhaps it only went into Android's kernel, etc. Since it is only required while booting a kernel, i would just keep the old name for the time being. When the kernel has this update, we will update U-Boot and then you will have to send in a patch to reflect this change. In any case u mention that you have follow up patches. By the time u get all the patches accepted, the mach-types would have been updated in the kernel and in U- boot. [Tom Warren] Good idea. I'll pull out the mach-types.h change in the next (V2) patch series. Also in one of ur patches you had updates to serial driver. You will have to keep that change in a separate patch. [Tom Warren] Why separate? It's an integral part of adding Tegra2 support, which is what the 1st patch does. But if that's required, then I'll change that, too, in V2. Regards, Sandeep From: Tom Warren [twar...@nvidia.com] Sent: Tuesday, January 11, 2011 7:43 PM To: Paulraj, Sandeep; Tom Warren; u-boot@lists.denx.de Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Thanks, Sandeep. As I understand it, one of our Tegra2 kernel jockeys (Allen Martin or similar) has already had the kernel version of mach-types.h updated for Seaboard - I was just attempting to use the correct #define (MACH_TYPE_SEABOARD - we dropped all of the MACH_TYPE_TEGRA_ names AFAIK) so my patch would build/boot. Of course this define doesn't matter until the kernel is booting w/the upstreamed U-Boot, which is a ways off (it boots fine here w/our private version of U-Boot based on V2010-09). Assuming I'm correct about the Linux version of mach-types already having been updated, how do I get a sync request in? And how is that phased in to match with my patches so that it all builds/boots? Thanks, Tom -Original Message- From: Paulraj, Sandeep [mailto:s-paul...@ti.com] Sent: Tuesday, January 11, 2011 5:16 PM To: Tom Warren; u-boot@lists.denx.de Cc: Tom Warren Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Hi Tom, Nice to see support for this board #define MACH_TYPE_TI8148EVM3004 #define MACH_TYPE_TEGRA_SEABOARD 3005 +#define MACH_TYPE_SEABOARD 3005 I don't think this is the way it is supposed to be done. Patches should not contain an addition to mach-types.h. What is generally done is you ask for an ARM sync request and in the past Tom Rix and I have updated mach-types.h. I did this some weeks ago. Also i think we cannot have 2 EVMs with same MACH_TYPE_ You should probably go to ARM Linux website and register as a separate EVM. The Number you get from there should be used. I beleive you can also change the name of the board there; assu,ing you intend to use MACH_TYPE_SEABOARD instead of MACH_TYPE_TEGRA_SEABOARD. It usually takes a little bit of time for the mach-types to be updated in the linux kernel. Once that is done we sync up with the kernel. Regards, Sandeep --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] git merge summary
Hi Wolfgang, Hi all, In message m2sjxrxm38@ohwell.denx.de Detlev Zundel wrote: may I ask again for opinions about enabling that feature? I also would like to see it. Wolfgang, is there anything that you don't like about this option? Do you have any comments or pros or cons for/against this request? I'll repeat my answer given in this thread previously[1] for the benefit of the now wider audience: Personally I cannot think of negative side effects. Checking recent linux commits, it seems Linus is using this himself which would be a pro argument I guess. Also as I wrote much earlier, the new format gives me additional valuable information that is useful to me. So I'm all for it. Cheers Detlev [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/91279 -- To summarize: It is a well known and lamented fact that those people who most want to rule people are, ipso facto, those least suited to do it. To summarize the summary: anyone who is capable of getting themselves made President should on no account be allowed to do the job. -- The Hitchhikers Guide To The Galaxy -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] git merge summary
Hi Wolfgang, On Wednesday 12 January 2011 18:47:45 Detlev Zundel wrote: may I ask again for opinions about enabling that feature? I also would like to see it. Wolfgang, is there anything that you don't like about this option? Do you have any comments or pros or cons for/against this request? I'll repeat my answer given in this thread previously[1] for the benefit of the now wider audience: Personally I cannot think of negative side effects. Checking recent linux commits, it seems Linus is using this himself which would be a pro argument I guess. Also as I wrote much earlier, the new format gives me additional valuable information that is useful to me. So I'm all for it. Yes, I also think its a good idea. Lets give it a try. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-BOOT] [PATCH] arm: fix flush cache function on arm926ejs
Le 12/01/2011 05:31, Lei Wen a écrit :
On Wed, Jan 12, 2011 at 12:27 PM, Lei Wenadrian.w...@gmail.com wrote:
Hi Albert,
On Wed, Jan 12, 2011 at 3:53 AM, Albert ARIBAUDalbert.arib...@free.fr
wrote:
Hi,
Le 11/01/2011 16:40, Lei Wen a écrit :
flush_cache function should only be called when the dcache is on.
And original flush method for arm926ejs seems don't work, replace
it with new version.
Test on Marvell Pantheon pxa920 board with usb ether function.
Signed-off-by: Lei Wenlei...@marvell.com
---
arch/arm/lib/cache.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c
index 30686fe..b8d5eee 100644
--- a/arch/arm/lib/cache.c
+++ b/arch/arm/lib/cache.c
@@ -27,16 +27,16 @@
void flush_cache (unsigned long dummy1, unsigned long dummy2)
{
+ if (!dcache_status())
+ return;
#if defined(CONFIG_OMAP2420) || defined(CONFIG_ARM1136)
void arm1136_cache_flush(void);
arm1136_cache_flush();
#endif
#ifdef CONFIG_ARM926EJS
- /* test and clean, page 2-23 of arm926ejs manual */
- asm(0: mrc p15, 0, r15, c7, c10, 3\n\t bne 0b\n : : : memory);
- /* disable write buffer as well (page 2-22) */
- asm(mcr p15, 0, %0, c7, c10, 4 : : r (0));
+ /* cleaninvalidate all D cache */
+ asm(mcr p15, 0, %0, c7, c14, 0 : : r (0));
ARM's ARM926EJ-S r0p4/r0p5 TRM does not define ... c7, c14, 0. Where
did you find this exact cp15 instruction?
My mistake...
Pantheon board's sheeva core modify the standard cp15 op code a bit...
With one opcode, it could invalidate and clean the dcache all.
So could I modify the original patch like below?
asm(mcr p15, 0, %0, c7, c6, 0 : : r (0));
This would only invalidate all dcache. Since current dcache enable is
just write-through,
I think it is safe to just do the invalidate operation.
This also could works for my board.
I take my words back...
I forget to open the dcache... After dcache is on, the usb tftp still
cannot works...
Seems still do the clean cache operation...
Anyway, changes to ARM926E-JS common code must work with existing
ARM926E-JS SoCs, so this patch is NAK. Pantheon-specific cache ops
should only be executed for Pantheon-based boards.
Best regards,
Lei
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7
(I realize I did not answer the other ones)
Le 08/01/2011 11:06, Aneesh V a écrit :
Out of curiosity, can you elaborate on why the compiler would optimize
better in these cases?
While counting down the termination condition check is against 0. So
you can just decrement the loop count using a 'subs' and do a 'bne'.
When you count up you have to do a comparison with a non-zero value. So
you will need one 'cmp' instruction extra:-)
I would not try to be too smart about what instructions are generated
and how by a compiler such as gcc which has rather complex code
generation optimizations.
bigger loop inside because that reduces the frequency at which your
outer parameter changes and hence the overall number of instructions
executed. Consider this:
1. We encode both the loop counts along with other data into a register
that is finally written to CP15 register.
2. outer loop has the code for shifting and ORing the outer variable to
this register.
3. Inner loop has the code for shifting and ORing the inner variable.
Step (3) has to be executed 'way x set' number of times anyways.
But having bigger loop inside makes sure that 2 is executed fewer times!
Here too it seems like you're underestimating the compiler's optimizing
capabilities -- your explanation seems to amount to extracting a
constant calculation from a loop, something that is rather usual in code
optimizing.
With these tweaks the assembly code generated by this C code is as good
as the original hand-written assembly code with my compiler.
How about other compilers?
+ for (way = num_ways - 1; way= 0 ; way--)
+ for (set = num_sets - 1; set= 0; set--) {
Please fix whitespacing around operators. The best way to ''catch'em
all'' is to run Linux' checkpatch.pl (I do this with option --no-tree)
on all patches that you submit to u-boot and, fix all warning and errors
and if some are left that you think should not be fixed, mention them
and explain why they're wrongly emitted.
I religiously do checkpatch whenever I send out a patch. Please note
that my original mail seems to be fine. I saved it and ran checkpatch
again. No errors, no warnings! Something amiss?
Well, something like set= 0 is quite surprising as it has
inconsistent spacing around a binary operators. But you're right,
checkpatch does not detect it. Can you fix them manually?
Best regards,
Aneesh
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/8] armv7: cache maintenance operations for armv7
Le 12/01/2011 10:08, Aneesh V a écrit : On Saturday 08 January 2011 07:36 PM, Albert ARIBAUD wrote: Le 08/01/2011 14:17, Aneesh V a écrit : snip.. +/* some utility macros */ +#define mask(start, end) \ + (((1 ((end) - (start) + 1)) - 1) (start)) + +#define mask_n_get(reg, start, end) \ + (((reg) mask(start, end)) (start)) Seeing as these functions are only used in the ARMv7 cache C file, they should be moved there. I plan to use a modified version of mask_n_get() and its set couterpart mask_n_set() in my subsequent works in more files. Can I keep it here itself or should I move it to an OMAP specific header file or can I move it to a more generic header file? Please suggest. They're very generic actually. I think they should go to a gereric bit manipulation header, and be named a... bit... more explicitly. For instance, the name 'mask' does not show that the macro creates a range of 'one' bits from start to end. What I need is something like below: #define get_bit_field(nr, start, mask)\ (((nr) (mask)) (start)) #define set_bit_field(nr, start, mask, val)\ (nr) = ((nr) ~(mask)) | (((val) (start)) (mask)) Can these go in a generic header? If so, can I add them to include/linux/bitops.h After some more thought, I am wondering if a *generic* field setting and getting macro is really useful. So far everyone is fine with at most defining field-specific macros. Best regards, Aneesh Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 1294636905-30832-1-git-send-email-vap...@gentoo.org you wrote: The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: asm-offsets: generate bd_t size (2011-01-09 18:08:20 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master ... Mike Frysinger (27): MAINTAINERS: sort Blackfin entries This was already applied. Why do you include it again? Blackfin: BF50x: new processor port ... Blackfin: BF52x: unify duplicated headers Blackfin: BF537: unify duplicated headers I cannot find any trace of these commits on the mailing list nor in patchwork. Am I missing something? Blackfin: bf506f-ezkit: new board port This commit was rejected because the MAINATINERS entry is missing, yet you include it here again? Blackfin: ldrinfo: new command You posted a new version of the patch which added a README entry, yet here you include the old version Not pulled. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Pardon me for breathing, which I never do anyway so I don't know why I bother to say it, oh God, I'm so depressed. Here's another of those self-satisfied doors. Life! Don't talk to me about life. - Marvin the Paranoid Android ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] BLOCK: Add freescale IMX51 PATA driver
Signed-off-by: Marek Vasut marek.va...@gmail.com
---
drivers/block/Makefile |1 +
drivers/block/mxc_ata.c | 149 +++
2 files changed, 150 insertions(+), 0 deletions(-)
create mode 100644 drivers/block/mxc_ata.c
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index e27175b..aa7dc87 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -31,6 +31,7 @@ COBJS-$(CONFIG_FSL_SATA) += fsl_sata.o
COBJS-$(CONFIG_LIBATA) += libata.o
COBJS-$(CONFIG_CMD_MG_DISK) += mg_disk.o
COBJS-$(CONFIG_MVSATA_IDE) += mvsata_ide.o
+COBJS-$(CONFIG_MX51_PATA) += mxc_ata.o
COBJS-$(CONFIG_PATA_BFIN) += pata_bfin.o
COBJS-$(CONFIG_SATA_DWC) += sata_dwc.o
COBJS-$(CONFIG_SATA_SIL3114) += sata_sil3114.o
diff --git a/drivers/block/mxc_ata.c b/drivers/block/mxc_ata.c
new file mode 100644
index 000..62c5cf4
--- /dev/null
+++ b/drivers/block/mxc_ata.c
@@ -0,0 +1,149 @@
+/*
+ * Freescale iMX51 ATA driver
+ *
+ * Copyright (C) 2010 Marek Vasut marek.va...@gmail.com
+ *
+ * Based on code by:
+ * Mahesh Mahadevan mahesh.mahade...@freescale.com
+ *
+ * Based on code from original FSL ATA driver, which is
+ * part of eCos, the Embedded Configurable Operating System.
+ * Copyright (C) 1998, 1999, 2000, 2001, 2002 Red Hat, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include command.h
+#include config.h
+#include asm/byteorder.h
+#include asm/io.h
+#include ide.h
+
+#include asm/arch/imx-regs.h
+#include asm/arch/clock.h
+
+/* MXC ATA register offsets */
+struct mxc_ata_config_regs {
+ u8 time_off; /* 0x00 */
+ u8 time_on;
+ u8 time_1;
+ u8 time_2w;
+ u8 time_2r;
+ u8 time_ax;
+ u8 time_pio_rdx;
+ u8 time_4;
+ u8 time_9;
+ u8 time_m;
+ u8 time_jn;
+ u8 time_d;
+ u8 time_k;
+ u8 time_ack;
+ u8 time_env;
+ u8 time_udma_rdx;
+ u8 time_zah; /* 0x10 */
+ u8 time_mlix;
+ u8 time_dvh;
+ u8 time_dzfs;
+ u8 time_dvs;
+ u8 time_cvh;
+ u8 time_ss;
+ u8 time_cyc;
+ u32 fifo_data_32; /* 0x18 */
+ u32 fifo_data_16;
+ u32 fifo_fill;
+ u32 ata_control;
+ u32 interrupt_pending;
+ u32 interrupt_enable;
+ u32 interrupt_clear;
+ u32 fifo_alarm;
+};
+
+struct mxc_data_hdd_regs {
+ u32 drive_data; /* 0xa0 */
+ u32 drive_features;
+ u32 drive_sector_count;
+ u32 drive_sector_num;
+ u32 drive_cyl_low;
+ u32 drive_cyl_high;
+ u32 drive_dev_head;
+ u32 command;
+ u32 status;
+ u32 alt_status;
+};
+
+/* PIO timing table */
+#defineNR_PIO_SPECS5
+uint16_t pio_t0[NR_PIO_SPECS] = { 600, 383, 240, 180, 120 };
+uint16_t pio_t1[NR_PIO_SPECS] = { 70, 50, 30, 30, 25 };
+uint16_t pio_t2_8[NR_PIO_SPECS]= { 290, 290, 290, 80, 70 };
+uint16_t pio_t2_16[NR_PIO_SPECS] = { 165, 125, 100, 80, 70 };
+uint16_t pio_t2i[NR_PIO_SPECS] = { 40, 0, 0, 0, 0 };
+uint16_t pio_t4[NR_PIO_SPECS] = { 30, 20, 15, 10, 10 };
+uint16_t pio_t9[NR_PIO_SPECS] = { 20, 15, 10, 10, 10 };
+uint16_t pio_tA[NR_PIO_SPECS] = { 50, 50, 50, 50, 50 };
+
+#defineREG2OFF(reg)uint32_t)reg) 0x3) * 8)
+static void set_ata_bus_timing(unsigned char mode)
+{
+ uint32_t val;
+ uint32_t T = 10 / mxc_get_clock(MXC_IPG_CLK);
+
+ struct mxc_ata_config_regs *ata_cfg_regs;
+ ata_cfg_regs = (struct mxc_ata_config_regs *)CONFIG_SYS_ATA_BASE_ADDR;
+
+ if (mode = NR_PIO_SPECS)
+ return;
+
+ /* Write TIME_OFF/ON/1/2W */
+ val = (3 REG2OFF(ata_cfg_regs-time_off)) |
+ (3 REG2OFF(ata_cfg_regs-time_on)) |
+ (((pio_t1[mode] + T) / T) REG2OFF(ata_cfg_regs-time_1)) |
+ (((pio_t2_8[mode] + T) / T) REG2OFF(ata_cfg_regs-time_2w));
+ writel(val, ata_cfg_regs-time_off);
+
+ /* Write TIME_2R/AX/RDX/4 */
+ val = (((pio_t2_8[mode] + T) / T)
[U-Boot] [PATCH 2/2] iMX5: EfikaMX: Work-in-progress board support
Signed-off-by: Marek Vasut marek.va...@gmail.com --- board/efikamx/Makefile | 52 board/efikamx/config.mk| 25 ++ board/efikamx/efikamx.c| 668 board/efikamx/imximage.cfg | 124 boards.cfg |1 + include/configs/efikamx.h | 233 +++ 6 files changed, 1103 insertions(+), 0 deletions(-) create mode 100644 board/efikamx/Makefile create mode 100644 board/efikamx/config.mk create mode 100644 board/efikamx/efikamx.c create mode 100644 board/efikamx/imximage.cfg create mode 100644 include/configs/efikamx.h diff --git a/board/efikamx/Makefile b/board/efikamx/Makefile new file mode 100644 index 000..ee4a16e --- /dev/null +++ b/board/efikamx/Makefile @@ -0,0 +1,52 @@ +# +# Copyright (C) 2010, Marek Vasut marek.va...@gmail.com +# +# BASED ON: imx51evk +# +# Copyright (C) 2007, Guennadi Liakhovetski l...@denx.de +# +# (C) Copyright 2009 Freescale Semiconductor, Inc. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS := efikamx.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/efikamx/config.mk b/board/efikamx/config.mk new file mode 100644 index 000..6e90671 --- /dev/null +++ b/board/efikamx/config.mk @@ -0,0 +1,25 @@ +# +# Copyright 2009 Freescale Semiconductor, Inc. All Rights Reserved. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +CONFIG_SYS_TEXT_BASE = 0x9780 +IMX_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/imximage.cfg +ALL += $(obj)u-boot.imx diff --git a/board/efikamx/efikamx.c b/board/efikamx/efikamx.c new file mode 100644 index 000..10cf111 --- /dev/null +++ b/board/efikamx/efikamx.c @@ -0,0 +1,668 @@ +/* + * Copyright (C) 2010 Marek Vasut marek.va...@gmail.com + * + * (C) Copyright 2009 Freescale Semiconductor, Inc. + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include common.h +#include asm/io.h +#include asm/arch/imx-regs.h +#include asm/arch/mx5x_pins.h +#include asm/arch/iomux.h +#include mxc_gpio.h +#include asm/errno.h +#include asm/arch/sys_proto.h +#include asm/arch/crm_regs.h +#include i2c.h +#include mmc.h +#include fsl_esdhc.h +#include fsl_pmic.h +#include mc13892.h + +DECLARE_GLOBAL_DATA_PTR; +
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 1294636905-30832-1-git-send-email-vap...@gentoo.org you wrote: The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: asm-offsets: generate bd_t size (2011-01-09 18:08:20 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master See previous message. Not pulled either. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ... not meant for the weak-at-heart: /^(?=.*one)(?=.*two)/ If you can follow that, you can use it. - Randal L. Schwartz in ukpw67rhl3@julie.teleport.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - microblaze
Dear Michal Simek, In message 4d2d6d68.3090...@monstr.eu you wrote: Michal Simek wrote: Dear Wolfgang, please pull the following changes. Ping. pong. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You are an excellent tactician, Captain. You let your second in com- mand attack while you sit and watch for weakness. -- Khan Noonian Singh, Space Seed, stardate 3141.9 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
On Wednesday, January 12, 2011 17:43:37 Wolfgang Denk wrote: Mike Frysinger wrote: The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: asm-offsets: generate bd_t size (2011-01-09 18:08:20 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master ... Mike Frysinger (27): MAINTAINERS: sort Blackfin entries This was already applied. Why do you include it again? i posted these patches and requests before you manually merged it. i dont see how this is surprising. Blackfin: BF50x: new processor port ... Blackfin: BF52x: unify duplicated headers Blackfin: BF537: unify duplicated headers I cannot find any trace of these commits on the mailing list nor in patchwork. Am I missing something? i mentioned in the original summary that these were too large for the list because i did quite a bit of clean up on them that isnt really splittable. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
On Wednesday, January 12, 2011 17:44:18 Wolfgang Denk wrote: Mike Frysinger wrote: The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: asm-offsets: generate bd_t size (2011-01-09 18:08:20 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master See previous message. Not pulled either. you replied to the same e-mail twice -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - microblaze
Dear Michal Simek, In message 4d2abcaf.1040...@monstr.eu you wrote: Dear Wolfgang, please pull the following changes. Thanks, Michal The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: Mike Frysinger (1): asm-offsets: generate bd_t size are available in the git repository at: git://www.denx.de/git/u-boot-microblaze.git master Michal Simek (2): microblaze: Disabling interrupt should return 1 if was enabled microblaze: Fix bd_info pointer arch/microblaze/cpu/interrupts.c |5 - arch/microblaze/lib/board.c |8 +--- include/configs/microblaze-generic.h |8 3 files changed, 13 insertions(+), 8 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If a person (a) is poorly, (b) receives treatment intended to make him better, and (c) gets better, then no power of reasoning known to medical science can convince him that it may not have been the treatment that restored his health. - Sir Peter Medawar, The Art of the Soluble ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx (Update)
Dear Stefan Roese, In message 20110105.30744...@denx.de you wrote: Hi Wolfgang, The following changes since commit 89c95f0cd3f8140f3b8a82a22a6a144c148d09c6: asm-offsets: generate bd_t size (2011-01-09 18:08:20 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git master Felix Radensky (1): PPC4xx: Reduce NAND TLB window size on Canyonlands Ricardo Ribalda Delgado (1): xilinx-ppc4xx-generic: Fix Makefile to work with MAKEALL Stefan Roese (2): ppc4xx: Remove PCI support from lwmon5 ppc4xx: Fix compilation breakage in miiphy.c arch/powerpc/cpu/ppc4xx/miiphy.c |2 +- board/amcc/canyonlands/init.S|2 +- board/xilinx/ppc405-generic/Makefile | 11 +++ board/xilinx/ppc440-generic/Makefile | 14 -- include/configs/lwmon5.h | 17 - 5 files changed, 9 insertions(+), 37 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If there are self-made purgatories, then we all have to live in them. -- Spock, This Side of Paradise, stardate 3417.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-cfi-flash
Dear Stefan Roese, In message 20110045.45419...@denx.de you wrote: Hi Wolfgang, The following changes since commit 0e7790d45c1a2cda40458adb28707eaa5041: LAN91C*: Change chip names to fit the eth_device struct size (2011-01-10 22:38:36 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-cfi-flash.git master David Müller (1): add AM29F400BB to table of supported legacy flashs drivers/mtd/jedec_flash.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many QA engineers does it take to screw in a lightbulb? 3: 1 to screw it in and 2 to say I told you so when it doesn't work. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ubi/master
Dear Stefan Roese, In message 20110111.42910...@denx.de you wrote: Hi Wolfgang, The following changes since commit 0e7790d45c1a2cda40458adb28707eaa5041: LAN91C*: Change chip names to fit the eth_device struct size (2011-01-10 22:38:36 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-ubi.git master Dirk Behme (1): UBIFS: Fix dereferencing type-punned pointer compiler warning fs/ubifs/misc.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The years of peak mental activity are undoubtedly between the ages of four and eighteen. At four we know all the questions, at eighteen all the answers. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-sh
Dear Nobuhiro Iwamatsu, In message aanlktin+mbakrexd7pmuwjwa9npekm2g6f3vgjzkg...@mail.gmail.com you wrote: Dear Wolfgang Denk, The following changes since commit 0e7790d45c1a2cda40458adb28707eaa5041: LAN91C*: Change chip names to fit the eth_device struct size (2011-01-10 22:38:36 +0100) are available in the git repository at: git://git.denx.de/u-boot-sh.git master Nobuhiro Iwamatsu (14): sh: serial: Update serial driver for SH sh: Add support SH7706 sh: Add support shmin board sh: Add support showing KByte of flash memory size sh: Remove SCIF/SCI register infomation sh: sh7722: Fix multiple definition of PSDR in serial_sh sh: serial_sh: Fix build in serial_sh sh: Delete the function that was not necessary sh: Divided macro for zImage and add asm/zimage.h sh: Add support zimageboot command for Renesas SH sh: sh7785lcr: Add support zimageboot sh: r2dplus: Add support zimageboot sh: Fix build of shmin board sh: Add support T-SH7706LSR board MAINTAINERS |1 + arch/sh/include/asm/cpu_sh3.h|6 +- arch/sh/include/asm/cpu_sh7706.h | 53 +++ arch/sh/include/asm/cpu_sh7722.h | 38 -- arch/sh/include/asm/cpu_sh7750.h | 16 - arch/sh/include/asm/cpu_sh7780.h | 21 +-- arch/sh/include/asm/zimage.h | 41 +++ arch/sh/lib/Makefile |3 + arch/sh/lib/board.c |8 +- arch/sh/lib/bootm.c | 21 +- arch/sh/lib/zimageboot.c | 80 + board/shmin/Makefile | 49 +++ board/shmin/config.mk| 27 ++ board/shmin/lowlevel_init.S | 36 ++ board/shmin/shmin.c | 108 ++ boards.cfg |1 + drivers/serial/serial_sh.c | 200 --- drivers/serial/serial_sh.h | 690 ++ include/configs/r2dplus.h|1 + include/configs/sh7785lcr.h |1 + include/configs/shmin.h | 128 +++ 21 files changed, 1307 insertions(+), 222 deletions(-) create mode 100644 arch/sh/include/asm/cpu_sh7706.h create mode 100644 arch/sh/include/asm/zimage.h create mode 100644 arch/sh/lib/zimageboot.c create mode 100644 board/shmin/Makefile create mode 100644 board/shmin/config.mk create mode 100644 board/shmin/lowlevel_init.S create mode 100644 board/shmin/shmin.c create mode 100644 drivers/serial/serial_sh.h create mode 100644 include/configs/shmin.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Every time history repeats itself the price goes up. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121750.06963.vap...@gentoo.org you wrote: I cannot find any trace of these commits on the mailing list nor in patchwork. Am I missing something? i mentioned in the original summary that these were too large for the list because i did quite a bit of clean up on them that isnt really splittable. You should know the rules. Please stick to them. I will not permit you to sneak in unreviewed code like that. Don't try that again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Don't worry about people stealing your ideas. If your ideas are any good, you'll have to ram them down people's throats. - Howard Aiken ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121750.37504.vap...@gentoo.org you wrote: See previous message. Not pulled either. you replied to the same e-mail twice Sorry, I somehow had a duplicated message in my folder. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You might not be as stupid as you look. This is not hard. Let's think about this. I mean ... I'll think about this, and you can join in when you know the words. - Terry Pratchett, _Men at Arms_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 23/28 v2] Blackfin: bf506f-ezkit: new board port
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
MAINTAINERS |1 +
board/bf506f-ezkit/Makefile | 54 +++
board/bf506f-ezkit/bf506f-ezkit.c | 27 ++
boards.cfg|1 +
include/configs/bf506f-ezkit.h| 102 +
5 files changed, 185 insertions(+), 0 deletions(-)
create mode 100644 board/bf506f-ezkit/Makefile
create mode 100644 board/bf506f-ezkit/bf506f-ezkit.c
create mode 100644 include/configs/bf506f-ezkit.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 3a68bed..88431a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1031,6 +1031,7 @@ Yoshihiro Shimoda shimoda.yoshih...@renesas.com
Mike Frysinger vap...@gentoo.org
Blackfin Team u-boot-de...@blackfin.uclinux.org
+ BF506F-EZKITBF506
BF518F-EZBRDBF518
BF526-EZBRD BF526
BF527-AD7160-EVAL BF527
diff --git a/board/bf506f-ezkit/Makefile b/board/bf506f-ezkit/Makefile
new file mode 100644
index 000..cde8168
--- /dev/null
+++ b/board/bf506f-ezkit/Makefile
@@ -0,0 +1,54 @@
+#
+# U-boot - Makefile
+#
+# Copyright (c) 2005-2008 Analog Device Inc.
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS-y:= $(BOARD).o
+
+SRCS := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
+OBJS := $(addprefix $(obj),$(COBJS-y))
+SOBJS := $(addprefix $(obj),$(SOBJS-y))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+ $(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+clean:
+ rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+ rm -f $(LIB) core *.bak $(obj).depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/bf506f-ezkit/bf506f-ezkit.c
b/board/bf506f-ezkit/bf506f-ezkit.c
new file mode 100644
index 000..638500d
--- /dev/null
+++ b/board/bf506f-ezkit/bf506f-ezkit.c
@@ -0,0 +1,27 @@
+/*
+ * U-boot - main board file
+ *
+ * Copyright (c) 2008-2010 Analog Devices Inc.
+ *
+ * Licensed under the GPL-2 or later.
+ */
+
+#include common.h
+#include asm/blackfin.h
+
+int checkboard(void)
+{
+ printf(Board: ADI BF506F EZ-Kit board\n);
+ printf( Support: http://blackfin.uclinux.org/\n;);
+ return 0;
+}
+
+int board_early_init_f(void)
+{
+ bfin_write_EBIU_MODE(1);
+ SSYNC();
+ bfin_write_FLASH_CONTROL_CLEAR(1);
+ udelay(1);
+ bfin_write_FLASH_CONTROL_SET(1);
+ return 0;
+}
diff --git a/boards.cfg b/boards.cfg
index b8d077f..ded9880 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -166,6 +166,7 @@ favr-32-ezkitavr32 at32ap -
earthlc
mimc200 avr32 at32ap - mimc
at32ap700x
hammerhead avr32 at32ap -
miromico at32ap700x
bct-brettl2 blackfinblackfin
+bf506f-ezkit blackfinblackfin
bf518f-ezbrd blackfinblackfin
bf525-ucr2 blackfinblackfin
bf526-ezbrd blackfinblackfin
diff --git a/include/configs/bf506f-ezkit.h b/include/configs/bf506f-ezkit.h
new file mode 100644
index 000..c7f4af7
--- /dev/null
+++ b/include/configs/bf506f-ezkit.h
@@ -0,0 +1,102 @@
+/*
+ * U-boot - Configuration file for BF506F EZ-Kit board
+ */
+
+#ifndef __CONFIG_BF506F_EZKIT_H__
+#define __CONFIG_BF506F_EZKIT_H__
+
+#include asm/config-pre.h
+
+
+/*
+ * Processor Settings
+ */
+#define CONFIG_BFIN_CPU bf506-0.0
+#define CONFIG_BFIN_BOOT_MODE BFIN_BOOT_PARA
+
+
+/*
+ * Clock Settings
+ * CCLK = (CLKIN * VCO_MULT) / CCLK_DIV
+ * SCLK = (CLKIN * VCO_MULT) / SCLK_DIV
+ */
+/* CONFIG_CLKIN_HZ is any value in Hz */
+#define CONFIG_CLKIN_HZ2500
+/* CLKIN_HALF controls the DF bit in PLL_CTL 0 = CLKIN*/
+/*
Re: [U-Boot] Pull request u-boot-blackfin.git
On Wednesday, January 12, 2011 18:03:35 Wolfgang Denk wrote: Mike Frysinger wrote: I cannot find any trace of these commits on the mailing list nor in patchwork. Am I missing something? i mentioned in the original summary that these were too large for the list because i did quite a bit of clean up on them that isnt really splittable. You should know the rules. Please stick to them. I will not permit you to sneak in unreviewed code like that. Don't try that again. stop making crap up. i'm not sneaking anything thing in. i explicitly called out these patches on the list and mentioned exactly where to find them. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 23/28 v2] Blackfin: bf506f-ezkit: new board port
Dear Mike Frysinger, In message 1294874051-19958-1-git-send-email-vap...@gentoo.org you wrote: Signed-off-by: Mike Frysinger vap...@gentoo.org --- MAINTAINERS |1 + board/bf506f-ezkit/Makefile | 54 +++ board/bf506f-ezkit/bf506f-ezkit.c | 27 ++ boards.cfg|1 + include/configs/bf506f-ezkit.h| 102 + 5 files changed, 185 insertions(+), 0 deletions(-) create mode 100644 board/bf506f-ezkit/Makefile create mode 100644 board/bf506f-ezkit/bf506f-ezkit.c create mode 100644 include/configs/bf506f-ezkit.h NAK. Please stick to the rulse and describe what you changed in this v2 patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I've finally learned what `upward compatible' means. It means we get to keep all our old mistakes. - Dennie van Tassel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com
Replying from my Gmail account until NVIDIA IT can remove the canned disclaimer. Sorry for the top-quote - just wanted to see if Gmail would correctly quote previous text. If there are no other critiques or NAKs, etc., then I'll start working on a V2 patch with Sandeep's changes. Thanks, Tom On Wed, Jan 12, 2011 at 10:05 AM, Tom Warren twar...@nvidia.com wrote: -Original Message- From: Paulraj, Sandeep [mailto:s-paul...@ti.com] Sent: Tuesday, January 11, 2011 7:00 PM To: Tom Warren; Tom Warren; u-boot@lists.denx.de Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Hi Tom, [Tom Warren] Hi. Sorry for top-quoting before. My comments are now in-line. Note that I've put in a request to my IT department to remove the 'confidential information' b.s. disclaimer that is appended to all my outgoing Outlook emails. If anyone knows how to get Gmail to use the standard reply-to quoting, I can start using my Gmail account instead. We keep the U-Boot in sync with what is at http://git.kernel.org/?p=linux/kernel/git/torvalds/linux- 2.6.git;a=history;f=arch/arm/tools/mach- types;h=2fea897ebeb12959415120a7c1cdcaf5d8ac8fee;hb=4162cf64973df51fc885825b c9ca4d055891c49f I can see that the kernel does not have the updated name yet. [Tom Warren] I'm surprised, since I was told the kernel's copy had been updated. I'll check with the kernel guys - perhaps it only went into Android's kernel, etc. Since it is only required while booting a kernel, i would just keep the old name for the time being. When the kernel has this update, we will update U-Boot and then you will have to send in a patch to reflect this change. In any case u mention that you have follow up patches. By the time u get all the patches accepted, the mach-types would have been updated in the kernel and in U- boot. [Tom Warren] Good idea. I'll pull out the mach-types.h change in the next (V2) patch series. Also in one of ur patches you had updates to serial driver. You will have to keep that change in a separate patch. [Tom Warren] Why separate? It's an integral part of adding Tegra2 support, which is what the 1st patch does. But if that's required, then I'll change that, too, in V2. Regards, Sandeep From: Tom Warren [twar...@nvidia.com] Sent: Tuesday, January 11, 2011 7:43 PM To: Paulraj, Sandeep; Tom Warren; u-boot@lists.denx.de Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Thanks, Sandeep. As I understand it, one of our Tegra2 kernel jockeys (Allen Martin or similar) has already had the kernel version of mach-types.h updated for Seaboard - I was just attempting to use the correct #define (MACH_TYPE_SEABOARD - we dropped all of the MACH_TYPE_TEGRA_ names AFAIK) so my patch would build/boot. Of course this define doesn't matter until the kernel is booting w/the upstreamed U-Boot, which is a ways off (it boots fine here w/our private version of U-Boot based on V2010-09). Assuming I'm correct about the Linux version of mach-types already having been updated, how do I get a sync request in? And how is that phased in to match with my patches so that it all builds/boots? Thanks, Tom -Original Message- From: Paulraj, Sandeep [mailto:s-paul...@ti.com] Sent: Tuesday, January 11, 2011 5:16 PM To: Tom Warren; u-boot@lists.denx.de Cc: Tom Warren Subject: RE: [U-Boot] [PATCH 3/3] arm: Tegra2: Add support for NVIDIA Seaboard board Signed-off-by: Tom Warren twar...@nvidia.com Hi Tom, Nice to see support for this board #define MACH_TYPE_TI8148EVM 3004 #define MACH_TYPE_TEGRA_SEABOARD 3005 +#define MACH_TYPE_SEABOARD 3005 I don't think this is the way it is supposed to be done. Patches should not contain an addition to mach-types.h. What is generally done is you ask for an ARM sync request and in the past Tom Rix and I have updated mach-types.h. I did this some weeks ago. Also i think we cannot have 2 EVMs with same MACH_TYPE_ You should probably go to ARM Linux website and register as a separate EVM. The Number you get from there should be used. I beleive you can also change the name of the board there; assu,ing you intend to use MACH_TYPE_SEABOARD instead of MACH_TYPE_TEGRA_SEABOARD. It usually takes a little bit of time for the mach-types to be updated in the linux kernel. Once that is done we sync up with the kernel. Regards, Sandeep --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the
[U-Boot] Pull request: nand flash
The following changes since commit c6b734f5aea2ba75caaa1929f7e649ecda8d2f31: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-sh are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Alexander Holler (1): nand: fix bug with multiple NAND devices if CONFIG_MTD_DEVICE is defined. Lei Wen (2): NAND: add the ability to directly write yaffs image mtd: nand: Allow caller to pass alternative ID table to nand_scan_ident() common/cmd_nand.c | 15 +- drivers/mtd/nand/atmel_nand.c |2 +- drivers/mtd/nand/nand.c |2 +- drivers/mtd/nand/nand_base.c | 29 ++- drivers/mtd/nand/nand_util.c | 63 +++- include/linux/mtd/nand.h |4 ++- include/nand.h|2 +- 7 files changed, 90 insertions(+), 27 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 23/28 v2] Blackfin: bf506f-ezkit: new board port
On Wednesday, January 12, 2011 18:10:24 Wolfgang Denk wrote: Mike Frysinger wrote: Signed-off-by: Mike Frysinger vap...@gentoo.org --- MAINTAINERS |1 + board/bf506f-ezkit/Makefile | 54 +++ board/bf506f-ezkit/bf506f-ezkit.c | 27 ++ boards.cfg|1 + include/configs/bf506f-ezkit.h| 102 + 5 files changed, 185 insertions(+), 0 deletions(-) create mode 100644 board/bf506f-ezkit/Makefile create mode 100644 board/bf506f-ezkit/bf506f-ezkit.c create mode 100644 include/configs/bf506f-ezkit.h NAK. Please stick to the rulse and describe what you changed in this v2 patch. you already wrote the changelog: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/91455/focus=92190 -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121808.17659.vap...@gentoo.org you wrote: stop making crap up. i'm not sneaking anything thing in. i explicitly called out these patches on the list and mentioned exactly where to find them. Did you? In some summary message nobody is going to read? You are supposed to submit patches. Please (re-) read http://www.denx.de/wiki/U-Boot/Patches ; some link to some git repository is NOT sufficient (especially when it comes whithout any spoecific information like commit ID or at least branch name and Subject. As a custodian you are supposed to be especially careful and to set an example for others, less experienced developers. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de This is a test of the Emergency Broadcast System. If this had been an actual emergency, do you really think we'd stick around to tell you? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ea20: fix undefined PHY_* errors
On Tuesday, January 11, 2011 14:48:17 Ben Gardiner wrote: This patch fixes ea20 after 8ef583a0351590a91394499eb5ca2ab8a703d959 where the u-boot custom PHY_ macros were replaced with those of linux/mii.h MII_ definitions except in the RMII support for davinci_emac. Probably also due to the merge path of changes in 2010.12. yeah, i didnt have this driver when i wrote the patch Acked-by: Mike Frysinger vap...@gentoo.org -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Divides variable of linker flags to LDFLAGS-u-boot and LDFLAGS
On Tuesday, January 11, 2011 07:07:32 Nobuhiro Iwamatsu wrote: Linker needs to use the proper endian/bfd flags even when doing partial linking. LDFLAGS_u-boot sets linker option which is called it when U-boot is built (u-boot final). LDFLAGS sets necessary option by partial linking (use in cmd_link_o_target). Acked-by: Mike Frysinger vap...@gentoo.org -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] uboot load ftb
On Wed, 12 Jan 2011 09:00:52 +0100 Wolfgang Denk w...@denx.de wrote: Dear =?UTF-8?B?5byg5oms?=, In message aanlktinux-nmpundbm=scyeahckbad9=dx8b3ro7g...@mail.gmail.com you wrote: i trying to sue the kernel's Makefile rule, but the issue is not solved. WARNING: could not set linux,stdout-path FDT_ERR_NOTFOUND. ERROR: /chosen node create failed - must RESET the board to recover. Well, seems your device tree has some problem. My guess is it's an old U-Boot that can't create properties in /chosen if /chosen doesn't already exist. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121808.17659.vap...@gentoo.org you wrote: stop making crap up. i'm not sneaking anything thing in. i explicitly called out these patches on the list and mentioned exactly where to find them. Actually I can see absolutely no good reason for not posting these patches. As far as I can tell, none of them exceeds the ML's hard size limit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The main thing is the play itself. I swear that greed for money has nothing to do with it, although heaven knows I am sorely in need of money. - Feodor Dostoyevsky ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
On Wednesday, January 12, 2011 18:18:25 Wolfgang Denk wrote: Mike Frysinger wrote: stop making crap up. i'm not sneaking anything thing in. i explicitly called out these patches on the list and mentioned exactly where to find them. Did you? In some summary message nobody is going to read? that's crap. the whole point of the summary message is to *summarize* the patchset and give an overview of what's going on. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
On Wednesday, January 12, 2011 18:32:36 Wolfgang Denk wrote: Mike Frysinger wrote: stop making crap up. i'm not sneaking anything thing in. i explicitly called out these patches on the list and mentioned exactly where to find them. Actually I can see absolutely no good reason for not posting these patches. As far as I can tell, none of them exceeds the ML's hard size limit. i dont know what you're looking at, but you're mistaken. i explicitly got rejection notices about being too big. they're each 250+ KiB. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121837.43007.vap...@gentoo.org you wrote: Actually I can see absolutely no good reason for not posting these patches. As far as I can tell, none of them exceeds the ML's hard size limit. i dont know what you're looking at, but you're mistaken. i explicitly got rejection notices about being too big. they're each 250+ KiB. I was looking at your repo. The ML soft limit is 100 KiB, the hard limit is 400 KiB. As I wrote: no reason at all not to post them (except that they need cleanup, for example because of exceeding max line length, or using incorrect multiline comments etc.). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Oh, that sound of male ego. You travel halfway across the galaxy and it's still the same song. -- Eve McHuron, Mudd's Women, stardate 1330.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 201101121836.14803.vap...@gentoo.org you wrote: that's crap. the whole point of the summary message is to *summarize* the patchset and give an overview of what's going on. Right. But (links to) patches are NOT posted in a summary message but sperately, with appropriate subject and full commit message. And a link to some git repo is NOT accepted. Please (re-) read http://www.denx.de/wiki/U-Boot/Patches Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Reader, suppose you were an idiot. And suppose you were a member of Congress. But I repeat myself. - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] arm: Tegra2: Add generic Tegra2 SoC support Signed-off-by: Tom Warren twar...@nvidia.com
Hi,
Your Signed-off-by seems to have made its way into the subject line. It
should be moved into the email contents. A brief description of what
this patch does, what peripherals are supported, etc would be nice too.
snip
create mode 100644 board/tegra2/common/board.c
create mode 100644 board/tegra2/common/board.h
The format of the board directory is generally board/vendor/board or
board/board if the vendor only plans on maintaining 1 board. If these
are nvidia-supported boards I'd think board/nvidia is the proper place
to add files board-specific files.
snip
+/*
+ * Boot ROM initializes the odmdata in APBDEV_PMC_SCRATCH20_0,
+ * so we are using this value to identify memory size.
+ */
+
+static unsigned int query_sdram_size(void)
+{
+ pmc_ctlr *const pmc = (pmc_ctlr *)NV_PA_PMC_BASE;
+ u32 reg;
+
+ reg = pmc-pmc_scratch20;
In powerpc-land we use io access functions to access registers, eg
in_be32(). I'm not familiar with ARM, but I'd guess they should be used
in general. Someone with ARM experience feel free to chime in here.
+ debug(pmc-pmc_scratch20 (ODMData) = 0x%08lX\n, reg);
+
+ /* bits 31:28 in OdmData are used for RAM size */
+ switch ((reg) 28) {
+ case 1:
+ return 0x1000; /* 256 MB */
+ case 2:
+ return 0x2000; /* 512 MB */
+ case 3:
+ default:
+ return 0x4000; /* 1GB */
+ }
+}
snip
+#ifndef _CLK_RST_H_
+#define _CLK_RST_H_
+
+/* Clock/Reset Controller (CLK_RST_CONTROLLER_) regs */
+
Instead of adding a new vol_uint typedef and making each field of this
struct vol_uint, you can make each one uint, then instantiate the
structure as volatile.
There are a mixture of lower and upper case hex digits in the comments
below too - it'd be good to be consistent.
+typedef struct clk_rst_ctlr {
+ vol_uint crc_rst_src; /* _RST_SOURCE_0, 0x00*/
+ vol_uint crc_rst_dev_l; /* _RST_DEVICES_L_0,0x04*/
+ vol_uint crc_rst_dev_h; /* _RST_DEVICES_H_0,0x08*/
+ vol_uint crc_rst_dev_u; /* _RST_DEVICES_U_0,0x0C*/
+ vol_uint crc_clk_out_enb_l; /* _CLK_OUT_ENB_L_0,0x10*/
+ vol_uint crc_clk_out_enb_h; /* _CLK_OUT_ENB_H_0,0x14*/
+ vol_uint crc_clk_out_enb_u; /* _CLK_OUT_ENB_U_0,0x18*/
+ vol_uint crc_reserved0; /* reserved_0, 0x1c*/
+ vol_uint crc_cclk_brst_pol; /* _CCLK_BURST_POLICY_0,0x20*/
+ vol_uint crc_super_cclk_div;/* _SUPER_CCLK_DIVIDER_0,0x24*/
+ vol_uint crc_sclk_brst_pol; /* _SCLK_BURST_POLICY_0, 0x28*/
+ vol_uint crc_super_sclk_div;/* _SUPER_SCLK_DIVIDER_0,0x2C*/
+ vol_uint crc_clk_sys_rate; /* _CLK_SYSTEM_RATE_0, 0x30*/
+ vol_uint crc_prog_dly_clk; /* _PROG_DLY_CLK_0, 0x34*/
+ vol_uint crc_aud_sync_clk_rate; /* _AUDIO_SYNC_CLK_RATE_0,0x38*/
+ vol_uint crc_reserved1; /* reserved_1, 0x3c*/
+ vol_uint crc_cop_clk_skip_plcy; /* _COP_CLK_SKIP_POLICY_0,0x40*/
+ vol_uint crc_clk_mask_arm; /* _CLK_MASK_ARM_0, 0x44*/
+ vol_uint crc_misc_clk_enb; /* _MISC_CLK_ENB_0, 0x48*/
+ vol_uint crc_clk_cpu_cmplx; /* _CLK_CPU_CMPLX_0,0x4C*/
+ vol_uint crc_osc_ctrl; /* _OSC_CTRL_0, 0x50*/
+ vol_uint crc_pll_lfsr; /* _PLL_LFSR_0, 0x54*/
+ vol_uint crc_osc_freq_det; /* _OSC_FREQ_DET_0, 0x58*/
+ vol_uint crc_osc_freq_det_stat; /* _OSC_FREQ_DET_STATUS_0,0x5C*/
+ vol_uint crc_reserved2[8]; /* reserved_2[8], 0x60-7C*/
+
+ vol_uint crc_pllc_base; /* _PLLC_BASE_0,0x80*/
+ vol_uint crc_pllc_out; /* _PLLC_OUT_0, 0x84*/
+ vol_uint crc_reserved3; /* reserved_3, 0x88*/
+ vol_uint crc_pllc_misc; /* _PLLC_MISC_0,0x8C*/
+
+ vol_uint crc_pllm_base; /* _PLLM_BASE_0,0x90*/
+ vol_uint crc_pllm_out; /* _PLLM_OUT_0, 0x94*/
+ vol_uint crc_reserved4; /* reserved_4, 0x98*/
+ vol_uint crc_pllm_misc; /* _PLLM_MISC_0,0x9C*/
+
+ vol_uint crc_pllp_base; /* _PLLP_BASE_0,0xA0*/
+ vol_uint crc_pllp_outa; /* _PLLP_OUTA_0,0xA4*/
+ vol_uint crc_pllp_outb; /* _PLLP_OUTB_0,0xA8*/
+ vol_uint crc_pllp_misc; /* _PLLP_MISC_0,0xAC*/
+
+ vol_uint crc_plla_base; /* _PLLA_BASE_0,0xB0*/
+ vol_uint crc_plla_out; /* _PLLA_OUT_0, 0xB4*/
+ vol_uint crc_reserved5; /* reserved_5, 0xB8*/
+ vol_uint crc_plla_misc; /* _PLLA_MISC_0,0xBC*/
+
+ vol_uint crc_pllu_base; /* _PLLU_BASE_0,0xC0*/
+ vol_uint crc_reserved6; /* _reserved_6, 0xC4*/
+ vol_uint crc_reserved7; /* _reserved_7, 0xC8*/
+
Re: [U-Boot] [PATCH 2/3] arm: Tegra2: Add support for NVIDIA Harmony board Signed-off-by: Tom Warren twar...@nvidia.com
snip
--- a/boards.cfg
+++ b/boards.cfg
@@ -122,6 +122,7 @@ omap4_panda arm armv7
panda ti
omap4_sdp4430arm armv7 sdp4430 ti
omap4
s5p_goni arm armv7 goni
samsungs5pc1xx
smdkc100 arm armv7 smdkc100
samsungs5pc1xx
+harmony arm armv7 harmony
tegra2 tegra2
I think 1st tegra2 above should be changed to nvidia.
actux1 arm ixp
actux2 arm ixp
actux3 arm ixp
snip
diff --git a/include/configs/nv-common.h b/include/configs/nv-common.h
Perhaps a more descriptive name could be used? NV == non-volatile to me
at first glance, and if this is tegra2-specific maybe tegra2-common.h
would be more appropriate?
new file mode 100644
index 000..46872d3
--- /dev/null
+++ b/include/configs/nv-common.h
@@ -0,0 +1,166 @@
+/*
+ * (C) Copyright 2010,2011
+ * NVIDIA Corporation www.nvidia.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __TEGRA2_COMMON_H
+#define __TEGRA2_COMMON_H
This define should match the name of the file.
+#include asm/sizes.h
+
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARMCORTEXA9 /* This is an ARM V7 CPU core */
+#define CONFIG_TEGRA2/* in a NVidia Tegra2 core */
+#define CONFIG_MACH_TEGRA_GENERIC/* which is a Tegra generic machine */
+#define CONFIG_L2_OFF/* No L2 cache */
+
+#include asm/arch/tegra2.h /* get chip and board defs */
+
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+
+#undef CONFIG_USE_IRQ
The general policy is not to undef things unless its necessary.
Assuming CONFIG_USE_IRQ isn't defined elsewhere I'd remove the above
line.
+
+#define CONFIG_SKIP_RELOCATE_UBOOT
+#define CONFIG_SKIP_LOWLEVEL_INIT
+
+#define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
+
+/* Environment */
+#define CONFIG_ENV_IS_NOWHERE
+#define CONFIG_ENV_SIZE 0x2 /* Total Size
Environment */
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN(4 20) /* 4MB */
+
+/*
+ * PllX Configuration
+ */
+#define CONFIG_SYS_CPU_OSC_FREQUENCY 100 /* Set CPU clock to 1GHz */
+
+/*
+ * NS16550 Configuration
+ */
+#define V_NS16550_CLK21600 /* 216MHz
(pllp_out0) */
+
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE (-4)
+#define CONFIG_SYS_NS16550_CLK V_NS16550_CLK
+
+/*
+ * select serial console configuration
+ */
+#define CONFIG_CONS_INDEX1
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+#define CONFIG_BAUDRATE 115200
+#define CONFIG_SYS_BAUDRATE_TABLE{4800, 9600, 19200, 38400, 57600,\
+ 115200}
+
+/* include default commands */
+#include config_cmd_default.h
+
+/* remove unused commands */
+#undef CONFIG_CMD_FLASH /* flinfo, erase, protect */
+#undef CONFIG_CMD_FPGA /* FPGA configuration support */
+#undef CONFIG_CMD_IMI
+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_NFS/* NFS support */
+#undef CONFIG_CMD_NET/* network support */
+
+/* turn on command-line edit/hist/auto */
+#define CONFIG_CMDLINE_EDITING
+#define CONFIG_COMMAND_HISTORY
+#define CONFIG_AUTOCOMPLETE
+
+#define CONFIG_SYS_NO_FLASH
+
+/* Environment information */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ console=ttyS0,115200n8\0 \
+ mem= TEGRA2_SYSMEM \0 \
+ smpflag=smp\0 \
+
+#define CONFIG_LOADADDR 0x408000/* def. location for
kernel */
+#define CONFIG_BOOTDELAY 2 /* -1 to disable auto boot */
+
+/*
+ * Miscellaneous configurable options
+ */
+#define
Re: [U-Boot] [patch] u-boot powerpc build error
Wolfgang Denk wrote: In message4d2d324c.3010...@gmail.com you wrote: Hello, I met this error (use GNU make 3.80). $ make MPC885ADS_config $ make /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after `else' directive /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else' per conditional. Stop. Can you please submit this as a proper patch, i. e. with a proper commit message and your Signed-off-by: line? Please see http://www.denx.de/wiki/U-Boot/Patches for details. After sending a patch, I noticed I need GNU make 3.81 and now I use it to build U-Boot. 3.81 was released at 2006. So that, I think modifying all the makefiles to support 3.80 or older is not good. Hmm, you may want to add a section like 'SOFTWARE REQUIREMENTS'. regards, namsh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [patch] u-boot powerpc build error
On Wed, 12 Jan 2011 13:47:08 +0900 gmane gow...@gmail.com wrote: Hello, I met this error (use GNU make 3.80). else ifdef appears to be new in make 3.81. $ make MPC885ADS_config $ make /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after `else' directive /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else' per conditional. Stop. Regards, namsh diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk index 2912604..5eeba9a 100644 --- a/arch/powerpc/config.mk +++ b/arch/powerpc/config.mk @@ -32,13 +32,15 @@ PLATFORM_LDFLAGS += -n --gc-sections ifdef CONFIG_SYS_LDSCRIPT # need to strip off double quotes LDSCRIPT := $(subst ,,$(CONFIG_SYS_LDSCRIPT)) -else ifdef CONFIG_NAND_SPL +else +ifdef CONFIG_NAND_SPL LDSCRIPT := $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds else ifneq ($(wildcard $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds),) LDSCRIPT := $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds endif endif +endif Shouldn't CONFIG_SYS_LDSCRIPT override only the main U-boot's linker script, not the NAND SPL? It's unlikely that the same linker script would be used for both. If the NAND SPL linker script needs to be overridden (probably unlikely), it would need CONFIG_SYS_LDSCRIPT_SPL, similar to CONFIG_SYS_TEXT_BASE_SPL. I know this isn't your change, but this is where I noticed it. :-) -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] mpq101: initial support for Mercury Computer Systems MPQ101 board
1. I want to fit an environment and the bootloader into a single flash sector. This is a very bad idea as it will open a window brick your system at each and every saveenv command. I strongly recommend not to do that. This issue is well understood. Yet, we are talking an industrial mezzanine card here, of variety which is put into the (ups-backed in most cases) rack once and forgotten. If it was a consumer or developer oriented device, I, of course, would use a safer approach. From what I've seen, this is more or less in line with many other boards already supported by u-boot. If you stop doing 1., all other problems will just disappear. Unfortunately, these boards have flash chips without small boot blocks, and considering the nature of typical board usage (as described) vs value of some additional flash space, I see it as a reasonable trade-off. If you really insist in such an unreliablke configuration, a custom linker script would IMO be better, as it would make the image layout more visible. Typical ld script is rather largish with many details of no direct relevance to any specific board. Single flag modifying the section offset has the advantage of being concise and immediately visible. I will, of course, look at it again. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] USB storage performance EHCI question
I just got EHCI support working with our chip and I was wondering what sort of performance I could expect using ext2? Right now it seems extremely slow coming off of a fast solid-state drive. I'm getting around 100KB/second. It's running at full-speed (480Mbps). Is this normal? We are basically using the standard EHCI driver with only a few minor modifications. -Aaron ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot,PATCHv4] pca953x: support 16-pin devices
On Mon, Jan 10, 2011 at 8:02 PM, Heiko Schocher h...@denx.de wrote:
Hello Chris,
Sorry for the late reply, but just looked in patchwork and found that
I am responsible for your patch, so ...
Chris Packham wrote:
This adds support for for the PCA9535/PCA9539 family of gpio devices which
have 16 output pins.
To let the driver know which devices are 16-pin it is necessary to define
CONFIG_SYS_I2C_PCA953X_WIDTH in your board config file. This is used to
create an array of {chip, ngpio} tuples that are used to determine the
width of a particular chip. For backwards compatibility it is assumed that
any chip not defined in CONFIG_SYS_I2C_PCA953X_WIDTH has 8 pins.
Acked-by: Peter Tyser pty...@xes-inc.com
Tested-by: Peter Tyser pty...@xes-inc.com
Signed-off-by: Chris Packham chris.pack...@alliedtelesis.co.nz
---
Changes since v3:
- pca953x_ngpio is now a function in all cases.
- Added Peter's ACK to the commit message.
README | 4 ++
drivers/gpio/pca953x.c | 114
++--
2 files changed, 95 insertions(+), 23 deletions(-)
Compiles with actual u-boot the xpedite* boards, so added to
u-boot-i2c.git
Thanks!
bye,
Heiko
Thanks I was about to poke the mailing list to find out where things
had got to. Did I miss something on
http://www.denx.de/wiki/U-Boot/Patches that says look here list for
a custodian and CC them?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Die Zusammenarbeit
Hallo, Das Managementteam unserer Organisation mochte sich hiermit bei Ihnen fur Ihr Interesse an unseren Job Angeboten bedanken. Die Firma AVEKO ist ein Handler der fuhrenden Klimaanlagehersteller, wie z.B. SAMSUNG, YORK, LG. Au?erdem ist unsere Firma ein Handler von AIRELEC Gesellschaften, die im Bereich der Heizapparatherstellung tatig sind, von VIESSMANN, einem deutschen Unternehmen, das Dampfkessel herstellt, von Systemair, einem schwedischen Unternehmen, das die Beluftungs- und Heizungsanlagen produziert, von italienischen Gesellschaften LIEBERT-HIROSS und UNIFLAIR, die feine Klimaanlagen fur Telekommunikationen, Kommunikationen und Computerzentren herstellen und von SolerPalau, einem spanischen Unternehmen, das mit den Beluftungsanlagen sich beschaftigt. Ein moglichst umfassendes Leistungsangebot unseren Kunden in der Ukraine und anderen Landern zur Verfugung zu stellen ist das Hauptziel von AVEKO. Dieses Ziel versuchen wir mithilfe eines Handlernetzes, das alle Regionen in der Ukraine deckt, zu erreichen. Unseren Handlern und korporativen Kunden bieten wir spezielle Bedingungen an, die folgend e Vorteile einschlie?en: spezielle gunstige Preise, breite Auswahl an Anlagen, gunstigere Zahlungstermine, Moglichkeit unter Auftrag die Anlagen und Ersatzteile zu liefern, Installation durchzufuhren und Serviceleistungen zu erbringen, Personalschulungen durchzufuhren und Unterstutzung bei Werbeaktivitaten zu leisten. Infolge der Erweiterung ist unser Unternehmen auf der Suche nach tatkraftigen und verantwortlichen Personen, die fur eine verantwortliche Arbeit bereit sind und die sich mit einigen Steuerproblemen in unserem Land verstandnisvoll vertragen werden. Wir wurden Ihnen kurz die heutige wirtschaftliche Situation in der Ukraine beschreiben. Zunachst mochten wir Ihre Aufmerksamkeit auf die Angaben, die die untenstehende interessante Analyse beinhaltet, lenken. Gema? der PayingTaxes Bewertung, die durch die Weltbank in Zusammenarbeit mit der Audit Gesellschaft PriceWaterhouseCoopers durchgefuhrt wurde, ist das ukrainische Steuersystem eins der lastigsten in der Welt. Ukrainische Unternehmer sollen 99 Steuer zahlen und 2 Tausend Stunden aufwenden, d.h. die Staatskasse bekommt 72% des Einkommens der legalen Unternehmen. Das ukrainische Steuersystem ist sehr kompliziert, die Gesetze werden standig geandert (z.B. laut der Presse gab es mehr als 500 Anderungen in Mehrwertsteuergesetz durc h Erstellung von 110 Gesetzen). Das ist kein Geheimnis, dass das Steuersystem reformiert und optimiert werden soll. Gema? der Stellungnahme von Auditoren aus PriceWaterhouseCoopers, ein ehrliches Geschaft in der Ukraine zu fuhren ware extrem lastig. Infolgedessen ist die Frage der Auswahl eines optimalen Steuersystems fur ein Unternehmen immer wichtig, besonders bei der Eroffnung, Reorganisation, Aktivitatsanderung, Personalwandel usw. Ein Manager-Kassierer, der mit korporativen regionalen Kunden arbeitet, ist eine besonders verantwortliche Position, jedoch ist der Aufwand dabei nicht so hoch. Gute Kommunikations- und Prasentationsfahigkeiten, Kontrolle uber die Zahlungen fur die gelieferten Waren und erbrachten Dienstleistungen, sowie Kontrolle uber Zahlungsverkehr bei der Buchhaltungsabteilung im Stammhaus via marktgangige Zahlungssysteme, Fahigkeit mit anderen Leuten gute Verhaltnisse zu bilden, ihre Loyalitat zu verdienen und aufrechtzuerhalten, sowie die Fahigkeit erfolgreich Verhandlungen zu fuhren und Ehrlichkeit sind unsere Basisanforderungen. Wenn Sie bereit sind anzufangen und fur Sie dabei alles klar ist, dann bitte kontaktieren j...@avekoconditioners.org Sie uns noch mal fur weitere Anweisungen. Wir konnen unsere Verhaltnisse dann vertraglich gestalten indem wir eine Vereinbarung uber die Agentendienstleistungen unterschreiben. Mit freundlichen Gruben, Viktor Babkin d...@avekoconditioners.org ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong CONFIG_SYS_MPC85xx_SERDES1_ADDR #define
CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES1_OFFSET.
Signed-off-by: Prabhakar prabha...@freescale.com
---
arch/powerpc/include/asm/immap_85xx.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/include/asm/immap_85xx.h
b/arch/powerpc/include/asm/immap_85xx.h
index 81f215b..7b371e3 100644
--- a/arch/powerpc/include/asm/immap_85xx.h
+++ b/arch/powerpc/include/asm/immap_85xx.h
@@ -2308,7 +2308,7 @@ typedef struct ccsr_pme { #define
CONFIG_SYS_MPC85xx_CPM_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET) #define
CONFIG_SYS_MPC85xx_SERDES1_ADDR \
- (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
+ (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
#define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
#define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \
--
1.6.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot,PATCHv4] pca953x: support 16-pin devices
On Thu, 2011-01-13 at 17:02 +1300, Chris Packham wrote:
On Mon, Jan 10, 2011 at 8:02 PM, Heiko Schocher h...@denx.de wrote:
Hello Chris,
Sorry for the late reply, but just looked in patchwork and found that
I am responsible for your patch, so ...
Chris Packham wrote:
This adds support for for the PCA9535/PCA9539 family of gpio devices which
have 16 output pins.
To let the driver know which devices are 16-pin it is necessary to define
CONFIG_SYS_I2C_PCA953X_WIDTH in your board config file. This is used to
create an array of {chip, ngpio} tuples that are used to determine the
width of a particular chip. For backwards compatibility it is assumed that
any chip not defined in CONFIG_SYS_I2C_PCA953X_WIDTH has 8 pins.
Acked-by: Peter Tyser pty...@xes-inc.com
Tested-by: Peter Tyser pty...@xes-inc.com
Signed-off-by: Chris Packham chris.pack...@alliedtelesis.co.nz
---
Changes since v3:
- pca953x_ngpio is now a function in all cases.
- Added Peter's ACK to the commit message.
README |4 ++
drivers/gpio/pca953x.c | 114
++--
2 files changed, 95 insertions(+), 23 deletions(-)
Compiles with actual u-boot the xpedite* boards, so added to
u-boot-i2c.git
Thanks!
bye,
Heiko
Thanks I was about to poke the mailing list to find out where things
had got to. Did I miss something on
http://www.denx.de/wiki/U-Boot/Patches that says look here list for
a custodian and CC them?
There's a list of custodians at
http://www.denx.de/wiki/U-Boot/Custodians , but your GPIO driver doesn't
really fall neatly into any one of their areas of responsibility, so
it'd be tough to know who to CC. I added a comment to
http://www.denx.de/wiki/U-Boot/Patches to mention that appropriate
maintainers should be CC-ed, as well as people who might be familiar
with the change based on past commits for what its worth.
Best,
Peter
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB storage performance EHCI question
Dear Aaron Williams, In message 201101121955.04367.aaron.willi...@caviumnetworks.com you wrote: I just got EHCI support working with our chip and I was wondering what sort of performance I could expect using ext2? Right now it seems extremely slow coming off of a fast solid-state drive. I'm getting around 100KB/second. It's running at full-speed (480Mbps). Is this normal? As you don't provide any of the important information let me guess: this is on an ARM board, and you are using U-Boot version v2010.09 or older? If this is true then yes, this is to be expected. Hm... I just notice the caviumnetworks in your address, so this is probably MIPS? Check if your caches are turned on... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe, they said, depended for its operation on the balance of four forces which they identified as charm, persuasion, uncertainty and bloody-mindedness. -- Terry Pratchett, The Light Fantastic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong CONFIG_SYS_MPC85xx_SERDES1_ADDR #define
Dear Kushwaha Prabhakar-B32579,
In message
071a08f2c6a57e4e94d980eca553f874070...@039-sn1mpn1-004.039d.mgd.msft.net you
wrote:
CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES1_OFFSET.
Please restrict the line length of the commit message to 70
characters.
diff --git a/arch/powerpc/include/asm/immap_85xx.h
b/arch/powerpc/include/asm/immap_85xx.h
index 81f215b..7b371e3 100644
--- a/arch/powerpc/include/asm/immap_85xx.h
+++ b/arch/powerpc/include/asm/immap_85xx.h
@@ -2308,7 +2308,7 @@ typedef struct ccsr_pme { #define
CONFIG_SYS_MPC85xx_CPM_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET) #define
CONFIG_SYS_MPC85xx_SERDES1_ADDR \
- (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
+ (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
#define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
#define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \
This patch looks corrupted and does not apply.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Microsoft Multitasking:
several applications can crash at the same time.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong CONFIG_SYS_MPC85xx_SERDES1_ADDR #define
Thanks for your comments. Please see my response inline.
Regards,
Prabhakar
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Thursday, January 13, 2011 11:42 AM
To: Kushwaha Prabhakar-B32579
Cc: u-boot@lists.denx.de
Subject: Re: [U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong
CONFIG_SYS_MPC85xx_SERDES1_ADDR #define
Dear Kushwaha Prabhakar-B32579,
In message 071A08F2C6A57E4E94D980ECA553F874070BF5@039-SN1MPN1-
004.039d.mgd.msft.net you wrote:
CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR +
CONFIG_SYS_MPC85xx_SERDES1_OFFSET.
Please restrict the line length of the commit message to 70 characters.
I will correct it
diff --git a/arch/powerpc/include/asm/immap_85xx.h
b/arch/powerpc/include/asm/immap_85xx.h
index 81f215b..7b371e3 100644
--- a/arch/powerpc/include/asm/immap_85xx.h
+++ b/arch/powerpc/include/asm/immap_85xx.h
@@ -2308,7 +2308,7 @@ typedef struct ccsr_pme { #define
CONFIG_SYS_MPC85xx_CPM_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET) #define
CONFIG_SYS_MPC85xx_SERDES1_ADDR \
- (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
+ (CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
#define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
#define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \
This patch looks corrupted and does not apply.
I will rebase it and send it soon.
Kind Regards,
Prabhakar
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [GIT PULL] Pull request: u-boot-imx
Hi Wolfgang, The following changes since commit cdc51c294ad33879c4e57edf4c9d2155381b1d59: Merge branch 'next' of ../next (2010-12-22 21:16:17 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master Liu Hui-R64343 (9): MX51EVK: UART does not print out the early information MX5: Add initial support for MX53 processor fec_mxc: add support for MX53 processor serial_mxc: add support for MX53 processor mxc_gpio: add support for MX53 processor mxc_i2c: add support for MX53 processor fsl_pmic: add I2C interface support imximage: Add MX53 boot image support MX5:MX53: add initial support for MX53EVK board MAINTAINERS |4 + arch/arm/cpu/armv7/mx5/iomux.c | 30 ++- arch/arm/cpu/armv7/mx5/lowlevel_init.S | 91 +++--- arch/arm/cpu/armv7/mx5/soc.c| 22 +- arch/arm/include/asm/arch-mx5/asm-offsets.h |5 + arch/arm/include/asm/arch-mx5/imx-regs.h| 82 ++--- arch/arm/include/asm/arch-mx5/iomux.h | 102 -- arch/arm/include/asm/arch-mx5/mx5x_pins.h | 469 ++- board/freescale/mx51evk/mx51evk.c | 11 +- board/freescale/mx53evk/Makefile| 48 +++ board/freescale/mx53evk/config.mk | 24 ++ board/freescale/mx53evk/imximage.cfg| 112 +++ board/freescale/mx53evk/mx53evk.c | 397 +++ boards.cfg |1 + doc/README.imximage | 12 +- drivers/gpio/mxc_gpio.c |9 +- drivers/i2c/mxc_i2c.c | 21 +- drivers/misc/fsl_pmic.c | 45 +++- drivers/net/fec_mxc.c |2 +- drivers/net/fec_mxc.h |4 +- drivers/serial/serial_mxc.c |6 + include/configs/mx51evk.h |5 +- include/configs/mx53evk.h | 193 +++ include/configs/vision2.h |3 +- include/mc13892.h |5 + tools/imximage.c| 421 +++- tools/imximage.h| 110 +-- 27 files changed, 1900 insertions(+), 334 deletions(-) mode change 100644 = 100755 arch/arm/cpu/armv7/mx5/iomux.c mode change 100644 = 100755 arch/arm/cpu/armv7/mx5/lowlevel_init.S mode change 100644 = 100755 arch/arm/include/asm/arch-mx5/imx-regs.h mode change 100644 = 100755 arch/arm/include/asm/arch-mx5/mx5x_pins.h create mode 100755 board/freescale/mx53evk/Makefile create mode 100755 board/freescale/mx53evk/config.mk create mode 100644 board/freescale/mx53evk/imximage.cfg create mode 100755 board/freescale/mx53evk/mx53evk.c mode change 100644 = 100755 drivers/i2c/mxc_i2c.c mode change 100644 = 100755 include/configs/mx51evk.h create mode 100755 include/configs/mx53evk.h -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - microblaze
Wolfgang Denk wrote: Dear Michal Simek, In message 4d2d6d68.3090...@monstr.eu you wrote: Michal Simek wrote: Dear Wolfgang, please pull the following changes. Ping. pong. :-) Best regards, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-imx
Le 13/01/2011 07:40, Stefano Babic a écrit : Hi Wolfgang, The following changes since commit cdc51c294ad33879c4e57edf4c9d2155381b1d59: Merge branch 'next' of ../next (2010-12-22 21:16:17 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master Liu Hui-R64343 (9): MX51EVK: UART does not print out the early information MX5: Add initial support for MX53 processor fec_mxc: add support for MX53 processor serial_mxc: add support for MX53 processor mxc_gpio: add support for MX53 processor mxc_i2c: add support for MX53 processor fsl_pmic: add I2C interface support imximage: Add MX53 boot image support MX5:MX53: add initial support for MX53EVK board MAINTAINERS |4 + arch/arm/cpu/armv7/mx5/iomux.c | 30 ++- arch/arm/cpu/armv7/mx5/lowlevel_init.S | 91 +++--- arch/arm/cpu/armv7/mx5/soc.c| 22 +- arch/arm/include/asm/arch-mx5/asm-offsets.h |5 + arch/arm/include/asm/arch-mx5/imx-regs.h| 82 ++--- arch/arm/include/asm/arch-mx5/iomux.h | 102 -- arch/arm/include/asm/arch-mx5/mx5x_pins.h | 469 ++- board/freescale/mx51evk/mx51evk.c | 11 +- board/freescale/mx53evk/Makefile| 48 +++ board/freescale/mx53evk/config.mk | 24 ++ board/freescale/mx53evk/imximage.cfg| 112 +++ board/freescale/mx53evk/mx53evk.c | 397 +++ boards.cfg |1 + doc/README.imximage | 12 +- drivers/gpio/mxc_gpio.c |9 +- drivers/i2c/mxc_i2c.c | 21 +- drivers/misc/fsl_pmic.c | 45 +++- drivers/net/fec_mxc.c |2 +- drivers/net/fec_mxc.h |4 +- drivers/serial/serial_mxc.c |6 + include/configs/mx51evk.h |5 +- include/configs/mx53evk.h | 193 +++ include/configs/vision2.h |3 +- include/mc13892.h |5 + tools/imximage.c| 421 +++- tools/imximage.h| 110 +-- 27 files changed, 1900 insertions(+), 334 deletions(-) mode change 100644 = 100755 arch/arm/cpu/armv7/mx5/iomux.c mode change 100644 = 100755 arch/arm/cpu/armv7/mx5/lowlevel_init.S mode change 100644 = 100755 arch/arm/include/asm/arch-mx5/imx-regs.h mode change 100644 = 100755 arch/arm/include/asm/arch-mx5/mx5x_pins.h create mode 100755 board/freescale/mx53evk/Makefile create mode 100755 board/freescale/mx53evk/config.mk create mode 100644 board/freescale/mx53evk/imximage.cfg create mode 100755 board/freescale/mx53evk/mx53evk.c mode change 100644 = 100755 drivers/i2c/mxc_i2c.c mode change 100644 = 100755 include/configs/mx51evk.h create mode 100755 include/configs/mx53evk.h I think I should be the one doing the pull as the ARM custodian. I'll be doing it this evening. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
