Re: [U-Boot] [PATCH] add missing space

[Luka Perkov]

On Fri, Dec 16, 2011 at 10:59:03AM -0500, Mike Frysinger wrote:
 On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote:
  On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote:
   Cosmetic patch for first U-Boot line that gets printed.
   
   --- a/include/version.h
   +++ b/include/version.h
   
#define U_BOOT_VERSION_STRING U_BOOT_VERSION  ( U_BOOT_DATE  -  \
   - U_BOOT_TIME ) CONFIG_IDENT_STRING
   + U_BOOT_TIME )  CONFIG_IDENT_STRING
  
  This change is not needed I think. Most boards defining
  CONFIG_IDENT_STRING use either a string starting with new line or
  strings like  something. So this patch will deface version string.
  Your CONFIG_IDENT_STRING should be fixed instead.
 
 +1
 -mike

Ok, thanks for pointing this out. I guess that something like patch
bellow is not acceptable?

# grep CONFIG_IDENT_STRING * -r | grep ' ' | wc -l
41

Bye,
Luka

diff --git a/include/configs/GEN860T.h b/include/configs/GEN860T.h
index 68a0cfd..01e5b93 100644
--- a/include/configs/GEN860T.h
+++ b/include/configs/GEN860T.h
@@ -41,9 +41,9 @@
  * Identify the board
  */
 #if !defined(CONFIG_SC)
-#define CONFIG_IDENT_STRING B2
+#define CONFIG_IDENT_STRINGB2
 #else
-#define CONFIG_IDENT_STRING SC
+#define CONFIG_IDENT_STRINGSC
 #endif
 
 /*
diff --git a/include/configs/IVML24.h b/include/configs/IVML24.h
index b827954..7d8d2e0 100644
--- a/include/configs/IVML24.h
+++ b/include/configs/IVML24.h
@@ -39,11 +39,11 @@
 #defineCONFIG_SYS_TEXT_BASE0xFF00
 
 #if defined (CONFIG_IVML24_16M)
-# define CONFIG_IDENT_STRING  IVML24
+# define CONFIG_IDENT_STRING IVML24
 #elif defined (CONFIG_IVML24_32M)
-# define CONFIG_IDENT_STRING  IVML24_128
+# define CONFIG_IDENT_STRING IVML24_128
 #elif defined (CONFIG_IVML24_64M)
-# define CONFIG_IDENT_STRING  IVML24_256
+# define CONFIG_IDENT_STRING IVML24_256
 #endif
 
 #defineCONFIG_8xx_CONS_SMC11   /* Console is on SMC1   
*/
diff --git a/include/configs/IVMS8.h b/include/configs/IVMS8.h
index 9b0c32a..9a3b258 100644
--- a/include/configs/IVMS8.h
+++ b/include/configs/IVMS8.h
@@ -39,11 +39,11 @@
 #defineCONFIG_SYS_TEXT_BASE0xFF00
 
 #if defined (CONFIG_IVMS8_16M)
-# define CONFIG_IDENT_STRING  IVMS8
+# define CONFIG_IDENT_STRING IVMS8
 #elif defined (CONFIG_IVMS8_32M)
-# define CONFIG_IDENT_STRING  IVMS8_128
+# define CONFIG_IDENT_STRING IVMS8_128
 #elif defined (CONFIG_IVMS8_64M)
-# define CONFIG_IDENT_STRING  IVMS8_256
+# define CONFIG_IDENT_STRING IVMS8_256
 #endif
 
 #defineCONFIG_8xx_CONS_SMC11   /* Console is on SMC1   
*/
diff --git a/include/configs/KAREF.h b/include/configs/KAREF.h
index 06fa676..d46c2ad 100644
--- a/include/configs/KAREF.h
+++ b/include/configs/KAREF.h
@@ -52,7 +52,7 @@
 #define CONFIG_VERY_BIG_RAM 1
 #define CONFIG_VERSION_VARIABLE
 
-#define CONFIG_IDENT_STRING  Sandburst Kamino Reference Design
+#define CONFIG_IDENT_STRING Sandburst Kamino Reference Design
 
 /*---
  * Base addresses -- Note these are effective addresses where the
diff --git a/include/configs/METROBOX.h b/include/configs/METROBOX.h
index c75a256..9e9eb31 100644
--- a/include/configs/METROBOX.h
+++ b/include/configs/METROBOX.h
@@ -118,7 +118,7 @@
 #define CONFIG_VERY_BIG_RAM 1
 #define CONFIG_VERSION_VARIABLE
 
-#define CONFIG_IDENT_STRING  Sandburst Metrobox
+#define CONFIG_IDENT_STRING Sandburst Metrobox
 
 /*---
  * Base addresses -- Note these are effective addresses where the
diff --git a/include/configs/TOP860.h b/include/configs/TOP860.h
index 3a01292..15a726e 100644
--- a/include/configs/TOP860.h
+++ b/include/configs/TOP860.h
@@ -57,7 +57,7 @@
 #defineCONFIG_SYS_TEXT_BASE0x8000
 
 #undef CONFIG_WATCHDOG /* watchdog disabled*/
-#defineCONFIG_IDENT_STRING  EMK TOP860
+#defineCONFIG_IDENT_STRING EMK TOP860
 
 /*---
  * CLOCK settings
diff --git a/include/configs/WUH405.h b/include/configs/WUH405.h
index 504ad96..21cae7c 100644
--- a/include/configs/WUH405.h
+++ b/include/configs/WUH405.h
@@ -32,7 +32,7 @@
  * High Level Configuration Options
  * (easy to change)
  */
-#define CONFIG_IDENT_STRING  $Name:  $
+#define CONFIG_IDENT_STRING $Name:  $
 
 #define CONFIG_405EP   1   /* This is a PPC405 CPU */
 #define CONFIG_4xx 1   /* ...member of PPC4xx family   */
diff --git a/include/configs/dlvision-10g.h b/include/configs/dlvision-10g.h
index 1468197..e069b60 100644
--- a/include/configs/dlvision-10g.h
+++ b/include/configs/dlvision-10g.h
@@ -34,7 +34,7 @@
  * Include common defines/options for all AMCC eval boards
  */
 #define CONFIG_HOSTNAMEdlvsion-10g
-#define CONFIG_IDENT_STRING 

[U-Boot] [PATCH] common/cmd_nvedit.c: Fix size calculation in do_env_import()

[Horst Kronstorfer]

do_env_import() missed the final '\0' terminator when calculating the
size of an environment data block.  This led to an erroneous 'bad CRC,
import failed' message for a checksum protected environment (-c.)

Signed-off-by: Horst Kronstorfer hkron...@frequentis.com
---
 common/cmd_nvedit.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index baaa513..63afc82 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -868,7 +868,7 @@ static int do_env_import(cmd_tbl_t *cmdtp, int flag,
printf(## Warning: Input data exceeds %d bytes
 - truncated\n, MAX_ENV_SIZE);
}
-   ++size;
+   size += 2;
printf(## Info: input data size = %zu = 0x%zX\n, size, size);
}
 
-- 
1.7.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] arm, da850: Question about start point

[Christian Riesch]

Hi Gabriele,

On Friday, December 16, 2011, Gabriele Filosofi gabrie...@cosmed.it wrote:
 Hi all,

 I'm new to this mailing-list and to u-boot.
 I've to port the TI SDK_5.02 to a LogicPD_SOM_AM1808 -based application
board.
 The SDK_5.02 is based on PSP_03.21.00.04, whose u-boot was developed on
git u-boot 2010.12

 The question is

 What's the better, to start from SDK's u-boot or from git u-boot 2010.12
 ?


I recommend to use the most recent u-boot from git, it works fine on the
am1808 som (as long as you use the da850evm_config and not
da850_am18xx_config, the latter is broken). I started with u-boot from the
SDK but switched later to git because I needed features that are only in
newer u-boots.
Christian

 Thanks a lot,
 Gabriele

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] USB: move keyboard polling from EHCI driver into kbd driver

[Remy Bohmer]

Hi,

2011/12/16 Allen Martin amar...@nvidia.com:
 This removes dependency on global variable new from EHCI driver with
 CONFIG_SYS_USB_EVENT_POLL turned on and gets USB keyboard working with
 EHCI driver again.

 Signed-off-by: Allen Martin amar...@nvidia.com
 ---
  common/usb_kbd.c            |   18 +-
  drivers/usb/host/ehci-hcd.c |   30 --
  2 files changed, 17 insertions(+), 31 deletions(-)

 diff --git a/common/usb_kbd.c b/common/usb_kbd.c
 index 75107c9..e94bb7e 100644
 --- a/common/usb_kbd.c
 +++ b/common/usb_kbd.c
 @@ -313,7 +313,23 @@ static int usb_kbd_irq(struct usb_device *dev)
  static inline void usb_kbd_poll_for_event(struct usb_device *dev)
  {
  #if    defined(CONFIG_SYS_USB_EVENT_POLL)
 -       usb_event_poll();
 +       struct usb_interface *iface;
 +       struct usb_endpoint_descriptor *ep;
 +       struct usb_kbd_pdata *data;
 +       int pipe;
 +       int maxp;
 +
 +       /* Get the pointer to USB Keyboard device pointer */
 +       data = dev-privptr;
 +       iface = dev-config.if_desc[0];
 +       ep = iface-ep_desc[0];
 +       pipe = usb_rcvintpipe(dev, ep-bEndpointAddress);
 +
 +       /* Submit a interrupt transfer request */
 +       maxp = usb_maxpacket(dev, pipe);
 +       usb_submit_int_msg(dev, pipe, data-new[0],
 +                       maxp  8 ? 8 : maxp, ep-bInterval);
 +
        usb_kbd_irq_worker(dev);
  #elif  defined(CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP)
        struct usb_interface *iface;
 diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
 index db10316..94a5eed 100644
 --- a/drivers/usb/host/ehci-hcd.c
 +++ b/drivers/usb/host/ehci-hcd.c
 @@ -26,10 +26,6 @@
  #include asm/io.h
  #include malloc.h
  #include watchdog.h
 -#ifdef CONFIG_USB_KEYBOARD
 -#include stdio_dev.h
 -extern unsigned char new[];
 -#endif

  #include ehci.h

 @@ -946,29 +942,3 @@ submit_int_msg(struct usb_device *dev, unsigned long 
 pipe, void *buffer,
        return ehci_submit_async(dev, pipe, buffer, length, NULL);
  }

 -#ifdef CONFIG_SYS_USB_EVENT_POLL
 -/*
 - * This function polls for USB keyboard data.
 - */
 -void usb_event_poll()
 -{
 -       struct stdio_dev *dev;
 -       struct usb_device *usb_kbd_dev;
 -       struct usb_interface *iface;
 -       struct usb_endpoint_descriptor *ep;
 -       int pipe;
 -       int maxp;
 -
 -       /* Get the pointer to USB Keyboard device pointer */
 -       dev = stdio_get_by_name(usbkbd);
 -       usb_kbd_dev = (struct usb_device *)dev-priv;
 -       iface = usb_kbd_dev-config.if_desc[0];
 -       ep = iface-ep_desc[0];
 -       pipe = usb_rcvintpipe(usb_kbd_dev, ep-bEndpointAddress);
 -
 -       /* Submit a interrupt transfer request */
 -       maxp = usb_maxpacket(usb_kbd_dev, pipe);
 -       usb_submit_int_msg(usb_kbd_dev, pipe, new[0],
 -                       maxp  8 ? 8 : maxp, ep-bInterval);
 -}
 -#endif /* CONFIG_SYS_USB_EVENT_POLL */

The usb_event_poll() is implemented in more drivers. This is not only
limited to the EHCI driver.
Please update the other drivers as well.

drivers/usb/musb/musb_hcd.c:1274:void usb_event_poll()
drivers/usb/host/r8a66597-hcd.c:911:void usb_event_poll(void)
drivers/usb/host/ohci-hcd.c:1775:void usb_event_poll(void)
include/usb.h:152:void usb_event_poll(void);

Kind regards,

Remy
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] add missing space

[Wolfgang Denk]

Dear Luka Perkov,

In message 20111216234317.GB1393@w500.iskon.local you wrote:

 Ok, thanks for pointing this out. I guess that something like patch
 bellow is not acceptable?

acceptable is somethign that is a bit hard to define.

Let's say, there is no real incentive to apply this patch.  Instead of
leaving all formatting options open to the end user (including the
option to directoy attach his custom string to the standard output)
this would dictate that there always has to be a space, and even
boards which do not want to use a custom sting would output the space.

Sorry, this makes no sense to me.

I'm not going to accept this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The price of curiosity is a terminal experience.
 - Terry Pratchett, _The Dark Side of the Sun_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] U-Boot on Nokia RX-51 (aka N900)

[Pali Rohár]

Hello,

I'm sending new patch series, which add Nokia RX-51 support to U-Boot. This
patches are based on master commit 06e42c6e2ce269667daecd6229d0b7c813838203
and now U-Boot working on Nokia RX-51.

--
Pali Rohár
pali.ro...@gmail.com

signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 01/16] arch/arm/cpu/armv7/omap3/lowlevel_init.S: save_boot_params

[Pali Rohár]

* Hide function save_boot_params if CONFIG_SPL_BUILD is not defined (function 
do nothing)

* Same behaviour as in file arch/arm/cpu/armv7/omap4/lowlevel_init.S
* This allow to implement board specified function save_boot_params in board 
code

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 arch/arm/cpu/armv7/omap3/lowlevel_init.S |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap3/lowlevel_init.S 
b/arch/arm/cpu/armv7/omap3/lowlevel_init.S
index 2f6930b..c42c5dd 100644
--- a/arch/arm/cpu/armv7/omap3/lowlevel_init.S
+++ b/arch/arm/cpu/armv7/omap3/lowlevel_init.S
@@ -35,15 +35,15 @@
 _TEXT_BASE:
.word   CONFIG_SYS_TEXT_BASE/* sdram load addr from config.mk */
 
+#ifdef CONFIG_SPL_BUILD
 .global save_boot_params
 save_boot_params:
-#ifdef CONFIG_SPL_BUILD
ldr r4, =omap3_boot_device
ldr r5, [r0, #0x4]
and r5, r5, #0xff
str r5, [r4]
-#endif
bx  lr
+#endif
 
 .global omap3_gp_romcode_call
 omap3_gp_romcode_call:
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 02/16] arch/arm/lib/bootm.c: Optionally use existing atags

[Pali Rohár]

This patch adapts the bootm command so that it can use an existing atags command
set up by a previous bootloader. If the environment variable atagaddr is 
unset,
bootm behaves as normal. If atagaddr is set, bootm will use atags address from
environment variable and also append new boot args (if specified in u-boot). For
example, if a previous boot loader already set up the atags struct at 
0x8100:

setenv atagaddr 0x8100; bootm 0x80008000

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 README   |2 ++
 arch/arm/lib/bootm.c |   27 +--
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/README b/README
index ff72e47..3dd5a97 100644
--- a/README
+++ b/README
@@ -3564,6 +3564,8 @@ Some configuration options can be set using Environment 
Variables.
 
 List of environment variables (most likely not complete):
 
+  atagaddr - bootm will use ATAGs struct from specified address (arm only)
+
   baudrate - see CONFIG_BAUDRATE
 
   bootdelay- see CONFIG_BOOTDELAY
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
index 802e833..4a3c423 100644
--- a/arch/arm/lib/bootm.c
+++ b/arch/arm/lib/bootm.c
@@ -125,12 +125,24 @@ int do_bootm_linux(int flag, int argc, char *argv[], 
bootm_headers_t *images)
debug (## Transferring control to Linux (at address %08lx) ...\n,
   (ulong) kernel_entry);
 
+   s = getenv (atagaddr);
+   if (s) {
+   bd-bi_boot_params = simple_strtoul(s, NULL, 16);
+   printf(Using existing atags at %#x\n, bd-bi_boot_params);
+
+   params = (struct tag *) bd-bi_boot_params;
+   while (params-hdr.size  0)
+   params = tag_next (params);
+   } else {
 #if defined (CONFIG_SETUP_MEMORY_TAGS) || \
 defined (CONFIG_CMDLINE_TAG) || \
 defined (CONFIG_INITRD_TAG) || \
 defined (CONFIG_SERIAL_TAG) || \
 defined (CONFIG_REVISION_TAG)
-   setup_start_tag (bd);
+   setup_start_tag (bd);
+   }
+#endif
+
 #ifdef CONFIG_SERIAL_TAG
setup_serial_tag (params);
 #endif
@@ -147,8 +159,19 @@ int do_bootm_linux(int flag, int argc, char *argv[], 
bootm_headers_t *images)
if (images-rd_start  images-rd_end)
setup_initrd_tag (bd, images-rd_start, images-rd_end);
 #endif
-   setup_end_tag(bd);
+
+   if (s) {
+   if (params-hdr.size  0)
+   setup_end_tag(bd);
+   } else {
+#if defined (CONFIG_SETUP_MEMORY_TAGS) || \
+defined (CONFIG_CMDLINE_TAG) || \
+defined (CONFIG_INITRD_TAG) || \
+defined (CONFIG_SERIAL_TAG) || \
+defined (CONFIG_REVISION_TAG)
+   setup_end_tag(bd);
 #endif
+   }
 
announce_and_cleanup();
 
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 03/16] include/twl4030.h: Add power bus message definitions

[Pali Rohár]

* Code from linux kernel: include/linux/i2c/twl.h

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 include/twl4030.h |   98 +
 1 files changed, 98 insertions(+), 0 deletions(-)

diff --git a/include/twl4030.h b/include/twl4030.h
index 9cd32ab..f040594 100644
--- a/include/twl4030.h
+++ b/include/twl4030.h
@@ -151,6 +151,103 @@
 #define TWL4030_PM_MASTER_SW_EVENTS_DEVSLP (1  1)
 #define TWL4030_PM_MASTER_SW_EVENTS_DEVOFF (1  0)
 
+/* Power bus message definitions */
+
+/* The TWL4030/5030 splits its power-management resources (the various
+ * regulators, clock and reset lines) into 3 processor groups - P1, P2 and
+ * P3. These groups can then be configured to transition between sleep, wait-on
+ * and active states by sending messages to the power bus.  See Section 5.4.2
+ * Power Resources of TWL4030 TRM
+ */
+
+/* Processor groups */
+#define DEV_GRP_NULL   0x0
+#define DEV_GRP_P1 0x1 /* P1: all OMAP devices */
+#define DEV_GRP_P2 0x2 /* P2: all Modem devices */
+#define DEV_GRP_P3 0x4 /* P3: all peripheral devices */
+
+/* Resource groups */
+#define RES_GRP_RES0x0 /* Reserved */
+#define RES_GRP_PP 0x1 /* Power providers */
+#define RES_GRP_RC 0x2 /* Reset and control */
+#define RES_GRP_PP_RC  0x3
+#define RES_GRP_PR 0x4 /* Power references */
+#define RES_GRP_PP_PR  0x5
+#define RES_GRP_RC_PR  0x6
+#define RES_GRP_ALL0x7 /* All resource groups */
+
+#define RES_TYPE2_R0   0x0
+
+#define RES_TYPE_ALL   0x7
+
+/* Resource states */
+#define RES_STATE_WRST 0xF
+#define RES_STATE_ACTIVE   0xE
+#define RES_STATE_SLEEP0x8
+#define RES_STATE_OFF  0x0
+
+/* Power resources */
+
+/* Power providers */
+#define RES_VAUX1   1
+#define RES_VAUX2   2
+#define RES_VAUX3   3
+#define RES_VAUX4   4
+#define RES_VMMC1   5
+#define RES_VMMC2   6
+#define RES_VPLL1   7
+#define RES_VPLL2   8
+#define RES_VSIM9
+#define RES_VDAC10
+#define RES_VINTANA111
+#define RES_VINTANA212
+#define RES_VINTDIG 13
+#define RES_VIO 14
+#define RES_VDD115
+#define RES_VDD216
+#define RES_VUSB_1V517
+#define RES_VUSB_1V818
+#define RES_VUSB_3V119
+#define RES_VUSBCP  20
+#define RES_REGEN   21
+/* Reset and control */
+#define RES_NRES_PWRON  22
+#define RES_CLKEN   23
+#define RES_SYSEN   24
+#define RES_HFCLKOUT25
+#define RES_32KCLKOUT   26
+#define RES_RESET   27
+/* Power Reference */
+#define RES_Main_Ref28
+
+#define TOTAL_RESOURCES28
+/*
+ * Power Bus Message Format ... these can be sent individually by Linux,
+ * but are usually part of downloaded scripts that are run when various
+ * power events are triggered.
+ *
+ *  Broadcast Message (16 Bits):
+ *DEV_GRP[15:13] MT[12]  RES_GRP[11:9]  RES_TYPE2[8:7] RES_TYPE[6:4]
+ *RES_STATE[3:0]
+ *
+ *  Singular Message (16 Bits):
+ *DEV_GRP[15:13] MT[12]  RES_ID[11:4]  RES_STATE[3:0]
+ */
+
+#define MSG_BROADCAST(devgrp, grp, type, type2, state) \
+   ( (devgrp)  13 | 1  12 | (grp)  9 | (type2)  7 \
+   | (type)  4 | (state))
+
+#define MSG_SINGULAR(devgrp, id, state) \
+   ((devgrp)  13 | 0  12 | (id)  4 | (state))
+
+#define MSG_BROADCAST_ALL(devgrp, state) \
+   ((devgrp)  5 | (state))
+
+#define MSG_BROADCAST_REF MSG_BROADCAST_ALL
+#define MSG_BROADCAST_PROV MSG_BROADCAST_ALL
+#define MSG_BROADCAST__CLK_RST MSG_BROADCAST_ALL
+
 /* Power Managment Receiver */
 #define TWL4030_PM_RECEIVER_SC_CONFIG  0x5B
 #define TWL4030_PM_RECEIVER_SC_DETECT1 0x5C
@@ -311,6 +408,7 @@
 #define TWL4030_PM_RECEIVER_VDAC_VSEL_18   0x03
 #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30  0x02
 #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32  0x03
+#define TWL4030_PM_RECEIVER_VSIM_VSEL_18   0x03
 
 /* Device Selection in PM Receiver Module */
 #define TWL4030_PM_RECEIVER_DEV_GRP_P1 0x20
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 04/16] include/common.h: Add some ANSI escape codes definitions

[Pali Rohár]

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 include/common.h |   18 ++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/include/common.h b/include/common.h
index 5cfdd76..0a5e84e 100644
--- a/include/common.h
+++ b/include/common.h
@@ -760,6 +760,24 @@ void   clear_ctrlc (void); /* clear the Control-C 
condition */
 intdisable_ctrlc (int);/* 1 to disable, 0 to enable Control-C detect */
 
 /*
+ * ANSI terminal
+ */
+
+#define ANSI_CURSOR_UP \e[%dA
+#define ANSI_CURSOR_DOWN   \e[%dB
+#define ANSI_CURSOR_FORWARD\e[%dC
+#define ANSI_CURSOR_BACK   \e[%dD
+#define ANSI_CURSOR_NEXTLINE   \e[%dE
+#define ANSI_CURSOR_PREVIOUSLINE   \e[%dF
+#define ANSI_CURSOR_COLUMN \e[%dG
+#define ANSI_CURSOR_POSITION   \e[%d;%dH
+#define ANSI_CLEAR_CONSOLE \e[2J
+#define ANSI_CLEAR_LINE_TO_END \e[0K
+#define ANSI_CLEAR_LINE\e[2K
+#define ANSI_COLOR_RESET   \e[0m
+#define ANSI_COLOR_REVERSE \e[7m
+
+/*
  * STDIO based functions (can always be used)
  */
 /* serial stuff */
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 05/16] common/main.c: Fix function readline

[Pali Rohár]

 * Ignore ANSI escape sequences for moving cursor, which are generated by 
keyboard

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 common/main.c |   49 +
 1 files changed, 49 insertions(+), 0 deletions(-)

diff --git a/common/main.c b/common/main.c
index e96c95a..5531130 100644
--- a/common/main.c
+++ b/common/main.c
@@ -958,6 +958,7 @@ int readline_into_buffer (const char *const prompt, char * 
buffer)
int n = 0;  /* buffer index */
int plen = 0;   /* prompt length*/
int col;/* output column cnt*/
+   int esc = 0;/* ansi escape char */
charc;
 
/* print prompt */
@@ -1024,7 +1025,55 @@ int readline_into_buffer (const char *const prompt, char 
* buffer)
p=delete_char(p_buf, p, col, n, plen);
continue;
 
+   case '\e':  /* ANSI escape char 
*/
+   esc = 1;
+   continue;
+
default:
+
+   /*
+* Check for ANSI escape chars
+*/
+   if (esc == 0  c == '\e') {
+   esc = 1;
+   continue;
+   } else if (esc == 1) {
+   if (c == '[') {
+   esc = 2;
+   continue;
+   }
+   if (n  CONFIG_SYS_CBSIZE-2) {
+   ++n;
+   *p++ = '\e';
+   putc('\e');
+   }
+   esc = 0;
+   } else if (esc == 2 || esc == 3) {
+   if (esc == 2  c == '1') {
+   esc = 3;
+   continue;
+   }
+   /* Ignore ANSI escape sequences generated by 
keyboard */
+   /* \e [ 1 A-D and \e [ A-D */
+   if ( c = 'A'  c = 'D' ) {
+   esc = 0;
+   continue;
+   }
+   if (esc == 2  n  CONFIG_SYS_CBSIZE-3) {
+   n += 2;
+   *p++ = '\e';
+   *p++ = '[';
+   puts(\e[);
+   } else if (esc == 3  n  CONFIG_SYS_CBSIZE-4) 
{
+   n += 3;
+   *p++ = '\e';
+   *p++ = '[';
+   *p++ = '1';
+   puts(\e[1);
+   }
+   esc = 0;
+   }
+
/*
 * Must be a normal character then
 */
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 06/16] drivers/video/cfb_console.c: Fix function console_scrollup

[Pali Rohár]

 * Use correct buffer size, do not damage screen output

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 drivers/video/cfb_console.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 904caf7..9092399 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -701,7 +701,7 @@ static void console_scrollup(void)
);
 #else
memcpyl(CONSOLE_ROW_FIRST, CONSOLE_ROW_SECOND,
-   CONSOLE_SCROLL_SIZE  2);
+   CONSOLE_SCROLL_SIZE);
 #endif
 
/* clear the last one */
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 07/16] drivers/video/cfb_console.c: Add function console_swap_colors

[Pali Rohár]

 * swap background and text color

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 drivers/video/cfb_console.c |8 
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 9092399..867c789 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -602,6 +602,14 @@ static void video_putchar(int xx, int yy, unsigned char c)
video_drawchars(xx, yy + video_logo_height, c, 1);
 }
 
+static void console_swap_colors(void)
+{
+   eorx = fgx;
+   fgx = bgx;
+   bgx = eorx;
+   eorx = fgx ^ bgx;
+}
+
 #if defined(CONFIG_CONSOLE_CURSOR) || defined(CONFIG_VIDEO_SW_CURSOR)
 static void video_set_cursor(void)
 {
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 08/16] drivers/video/cfb_console.c: Add function console_clear and console_clear_line

[Pali Rohár]

 * console_clear - clear full console framebuffer output
 * console_clear_line - clear part of specified line (or full)

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 drivers/video/cfb_console.c |   56 +-
 1 files changed, 44 insertions(+), 12 deletions(-)

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 867c789..7a4f0f3 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -691,6 +691,49 @@ static void memcpyl(int *d, int *s, int c)
 }
 #endif
 
+static void console_clear(void)
+{
+#ifdef VIDEO_HW_RECTFILL
+   video_hw_rectfill(VIDEO_PIXEL_SIZE, /* bytes per pixel */
+ 0,/* dest pos x */
+ video_logo_height,/* dest pos y */
+ VIDEO_VISIBLE_COLS,   /* frame width */
+ VIDEO_VISIBLE_ROWS,   /* frame height */
+ bgx   /* fill color */
+   );
+#else
+   memsetl(CONSOLE_ROW_FIRST, CONSOLE_SIZE, bgx);
+#endif
+}
+
+static void console_clear_line(int line, int begin, int end)
+{
+#ifdef VIDEO_HW_RECTFILL
+   video_hw_rectfill(VIDEO_PIXEL_SIZE, /* 
bytes per pixel */
+ VIDEO_FONT_WIDTH * begin, /* dest 
pos x */  /* FIXME: correct? */
+ video_logo_height + CONSOLE_ROW_SIZE * line,  /* dest 
pos y */  /* FIXME: correct? */
+ VIDEO_FONT_WIDTH * ( end - begin ),   /* 
frame width */ /* FIXME: correct? */
+ VIDEO_FONT_HEIGHT,/* 
frame height */
+ bgx   /* fill 
color */
+   );
+#else
+   int i;
+   if ( begin == 0  end == CONSOLE_COLS )
+   memsetl(CONSOLE_ROW_FIRST + CONSOLE_ROW_SIZE * line,/* 
offset of row */
+   CONSOLE_ROW_SIZE  2,  /* 
length of row */
+   bgx /* fill 
color */
+   );
+   else
+   for ( i = 0; i  VIDEO_FONT_HEIGHT; ++i )
+   memsetl(CONSOLE_ROW_FIRST + CONSOLE_ROW_SIZE * line +   
/* offset of row */
+   VIDEO_FONT_WIDTH * VIDEO_PIXEL_SIZE * begin +   
/* offset of col */
+   i * VIDEO_LINE_LEN, 
/* col offset of i-th line */
+   (VIDEO_FONT_WIDTH * VIDEO_PIXEL_SIZE * ( end - 
begin + 1))  2, /* length to end of line */
+   bgx 
/* fill color */
+   );
+#endif
+}
+
 static void console_scrollup(void)
 {
/* copy up rows ignoring the first one */
@@ -713,18 +756,7 @@ static void console_scrollup(void)
 #endif
 
/* clear the last one */
-#ifdef VIDEO_HW_RECTFILL
-   video_hw_rectfill(VIDEO_PIXEL_SIZE, /* bytes per pixel */
- 0,/* dest pos x */
- VIDEO_VISIBLE_ROWS
- - VIDEO_FONT_HEIGHT,  /* dest pos y */
- VIDEO_VISIBLE_COLS,   /* frame width */
- VIDEO_FONT_HEIGHT,/* frame height */
- CONSOLE_BG_COL/* fill color */
-   );
-#else
-   memsetl(CONSOLE_ROW_LAST, CONSOLE_ROW_SIZE  2, CONSOLE_BG_COL);
-#endif
+   console_clear_line(CONSOLE_ROWS-1, 0, CONSOLE_COLS);
 }
 
 static void console_back(void)
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 09/16] drivers/video/cfb_console.c: Add functions for moving with cursor

[Pali Rohár]

 * console_cursor_fix - check and fix cursor position (if it is not out of 
screen)
 * console_cursor_up, console_cursor_down, console_cursor_left, 
console_cursor_right and console_cursor_set_position for changing cursor 
position
 * console_newline - added param to specify count of creating new lines
 * console_previewsline - opposite of console_newline

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 drivers/video/cfb_console.c |   64 +++
 1 files changed, 58 insertions(+), 6 deletions(-)

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 7a4f0f3..9e0f665 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -773,9 +773,54 @@ static void console_back(void)
CURSOR_SET;
 }
 
-static void console_newline(void)
+static void console_cursor_fix(void)
 {
-   console_row++;
+   if (console_row  0)
+   console_row = 0;
+   if (console_row = CONSOLE_ROWS)
+   console_row = CONSOLE_ROWS-1;
+   if (console_col  0)
+   console_col = 0;
+   if (console_col = CONSOLE_COLS)
+   console_col = CONSOLE_COLS-1;
+}
+
+static void console_cursor_up(int n)
+{
+   console_row -= n;
+   console_cursor_fix();
+}
+
+static void console_cursor_down(int n)
+{
+   console_row += n;
+   console_cursor_fix();
+}
+
+static void console_cursor_left(int n)
+{
+   console_col -= n;
+   console_cursor_fix();
+}
+
+static void console_cursor_right(int n)
+{
+   console_col += n;
+   console_cursor_fix();
+}
+
+static void console_cursor_set_position(int row, int col)
+{
+   if (console_row != -1)
+   console_row = row;
+   if (console_col != -1)
+   console_col = col;
+   console_cursor_fix();
+}
+
+static void console_newline(int n)
+{
+   console_row += n;
console_col = 0;
 
/* Check if we need to scroll the terminal */
@@ -784,10 +829,17 @@ static void console_newline(void)
console_scrollup();
 
/* Decrement row number */
-   console_row--;
+   console_row = CONSOLE_ROWS-1;
}
 }
 
+static void console_previewsline(int n)
+{
+   /* FIXME: also scroll terminal ? */
+   console_row -= n;
+   console_cursor_fix();
+}
+
 static void console_cr(void)
 {
console_col = 0;
@@ -806,7 +858,7 @@ void video_putc(const char c)
 
case '\n':  /* next line */
if (console_col || (!console_col  nl))
-   console_newline();
+   console_newline(1);
nl = 1;
break;
 
@@ -815,7 +867,7 @@ void video_putc(const char c)
console_col = ~0x0007;
 
if (console_col = CONSOLE_COLS)
-   console_newline();
+   console_newline(1);
break;
 
case 8: /* backspace */
@@ -829,7 +881,7 @@ void video_putc(const char c)
 
/* check for newline */
if (console_col = CONSOLE_COLS) {
-   console_newline();
+   console_newline(1);
nl = 0;
}
}
-- 
1.7.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 10/16] drivers/video/cfb_console.c: Add support for some ANSI terminal escape codes

[Pali Rohár]

 * This patch add support for cursor move and reverse colors via ANSI espace 
codes in cfb_console driver
 * ANSI escape codes can be enabled/disabled via CONFIG_CFB_CONSOLE_ANSI

Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
 drivers/video/cfb_console.c |  205 ++-
 1 files changed, 204 insertions(+), 1 deletions(-)

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 9e0f665..845efde 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -377,6 +377,10 @@ static int console_row;/* cursor row */
 
 static u32 eorx, fgx, bgx; /* color pats */
 
+static char ansi_buf[10] = { 0, };
+static int ansi_buf_size = 0;
+static int ansi_colors_need_revert = 0;
+
 static const int video_font_draw_table8[] = {
0x, 0x00ff, 0xff00, 0x,
0x00ff, 0x00ff00ff, 0x0000, 0x00ff,
@@ -845,7 +849,7 @@ static void console_cr(void)
console_col = 0;
 }
 
-void video_putc(const char c)
+static void parse_putc(const char c)
 {
static int nl = 1;
 
@@ -888,6 +892,205 @@ void video_putc(const char c)
CURSOR_SET;
 }
 
+void video_putc(const char c)
+{
+#ifdef CONFIG_CFB_CONSOLE_ANSI
+   int i;
+
+   if (c == 27) {
+   for (i = 0; i  ansi_buf_size; ++i)
+   parse_putc(ansi_buf[i]);
+   ansi_buf[0] = 27;
+   ansi_buf_size = 1;
+   return;
+   }
+
+   if (ansi_buf_size  0) {
+   /*
+   0 - ESC
+   1 - [
+   2 - num1
+   3 - ..
+   4 - ;
+   5 - num2
+   6 - ..
+   7 - cchar
+   */
+   int next = 0;
+
+   int flush = 0;
+   int fail = 0;
+
+   int num1 = 0;
+   int num2 = 0;
+   int cchar = 0;
+
+   ansi_buf[ansi_buf_size++] = c;
+
+   if (ansi_buf_size = sizeof (ansi_buf))
+   fail = 1;
+
+   for (i = 0; i  ansi_buf_size; ++i) {
+   if (fail)
+   break;
+
+   switch (next) {
+   case 0:
+   if (ansi_buf[i] == 27)
+   next = 1;
+   else
+   fail = 1;
+   break;
+
+   case 1:
+   if (ansi_buf[i] == '[')
+   next = 2;
+   else
+   fail = 1;
+   break;
+
+   case 2:
+   if (ansi_buf[i] = '0'  ansi_buf[i] = '9') {
+   num1 = ansi_buf[i]-'0';
+   next = 3;
+   } else {
+   --i;
+   num1 = 1;
+   next = 4;
+   }
+   break;
+
+   case 3:
+   if (ansi_buf[i] = '0'  ansi_buf[i] = '9') {
+   num1 *= 10;
+   num1 += ansi_buf[i]-'0';
+   } else {
+   --i;
+   next = 4;
+   }
+   break;
+
+   case 4:
+   if (ansi_buf[i] != ';') {
+   --i;
+   next = 7;
+   } else
+   next = 5;
+   break;
+
+   case 5:
+   if (ansi_buf[i] = '0'  ansi_buf[i] = '9') {
+   num2 = ansi_buf[i]-'0';
+   next = 6;
+   } else
+   fail = 1;
+   break;
+
+   case 6:
+   if (ansi_buf[i] = '0'  ansi_buf[i] = '9') {
+   num2 *= 10;
+   num2 += ansi_buf[i]-'0';
+   } else {
+   --i;
+   next = 7;
+   }
+   break;
+
+   case 7:
+   if ((ansi_buf[i] = 'A'  ansi_buf[i] = 'H') 
|| ansi_buf[i] == 'J' || ansi_buf[i] == 'K' || ansi_buf[i] == 'm') {
+

[U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask

[Michael Walle]

Since the data alignment fault was enabled recently in commit
  arm, arm926ejs: always do cpu critical inits
the driver won't work anymore and all boards which use an environment in an
SPI flash will fail booting.

Signed-off-by: Michael Walle mich...@walle.cc
Cc: Albert ARIBAUD albert.u.b...@aribaud.net
Cc: Prafulla Wadaskar prafu...@marvell.com
---
 drivers/spi/kirkwood_spi.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a50e498..9aaecfe 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -67,7 +67,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned 
int cs,
debug(data = 0x%08x \n, data);
 
writel(KWSPI_SMEMRDIRQ, spireg-irq_cause);
-   writel(KWSPI_IRQMASK, spireg-irq_mask);
+   writel(KWSPI_IRQMASK, spireg-irq_mask);
 
/* program mpp registers to select  SPI_CSn */
if (cs) {
-- 
1.7.2.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask

[Michael Walle]

Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
 Since the data alignment fault was enabled recently in commit
   arm, arm926ejs: always do cpu critical inits
 the driver won't work anymore and all boards which use an environment in an
 SPI flash will fail booting.

Sorry i don't know how you track patches that should be applied for the RC. 
But IMHO this is one :)

-- 
Michael
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: Fix arguments in tftpput command

[Mike Frysinger]

Acked-by: Mike Frysinger vap...@gentoo.org
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] U-Boot on Nokia RX-51 (aka N900)

[Wolfgang Denk]

Dear Pali =?ISO-8859-1?Q?Roh=E1r?=,

In message 2772527.Czs1Sl5aoH@pali-elitebook you wrote:
 
 I'm sending new patch series, which add Nokia RX-51 support to U-Boot.
 This 
 patches are based on master commit 06e42c6e2ce269667daecd6229d0b7c81383
 8203 
 and now U-Boot working on Nokia RX-51.

This patch series generates a ton of checkpatch warnings.  Please run
your code through checkpatch, and make sure to read the respective
hits at http://www.denx.de/wiki/U-Boot/Patches ; then clean up the
code and resubmit. 

Um, and while doing so, please make sure NOT to send all this stuff
base64 encoded.  Thanks.

WARNING: space prohibited between function name and open parenthesis '('
#130: FILE: arch/arm/lib/bootm.c:128:
+   s = getenv (atagaddr);

WARNING: consider using kstrto* in preference to simple_strtoul
#132: FILE: arch/arm/lib/bootm.c:130:
+   bd-bi_boot_params = simple_strtoul(s, NULL, 16);

WARNING: space prohibited between function name and open parenthesis '('
#137: FILE: arch/arm/lib/bootm.c:135:
+   params = tag_next (params);

WARNING: space prohibited between function name and open parenthesis '('
#145: FILE: arch/arm/lib/bootm.c:142:
+   setup_start_tag (bd);

WARNING: space prohibited between function name and open parenthesis '('
#162: FILE: arch/arm/lib/bootm.c:167:
+#if defined (CONFIG_SETUP_MEMORY_TAGS) || \

WARNING: please, no spaces at the start of a line
#163: FILE: arch/arm/lib/bootm.c:168:
+defined (CONFIG_CMDLINE_TAG) || \$

WARNING: space prohibited between function name and open parenthesis '('
#163: FILE: arch/arm/lib/bootm.c:168:
+defined (CONFIG_CMDLINE_TAG) || \

WARNING: please, no spaces at the start of a line
#164: FILE: arch/arm/lib/bootm.c:169:
+defined (CONFIG_INITRD_TAG) || \$

WARNING: space prohibited between function name and open parenthesis '('
#164: FILE: arch/arm/lib/bootm.c:169:
+defined (CONFIG_INITRD_TAG) || \

WARNING: please, no spaces at the start of a line
#165: FILE: arch/arm/lib/bootm.c:170:
+defined (CONFIG_SERIAL_TAG) || \$

WARNING: space prohibited between function name and open parenthesis '('
#165: FILE: arch/arm/lib/bootm.c:170:
+defined (CONFIG_SERIAL_TAG) || \

WARNING: please, no spaces at the start of a line
#166: FILE: arch/arm/lib/bootm.c:171:
+defined (CONFIG_REVISION_TAG)$

WARNING: space prohibited between function name and open parenthesis '('
#166: FILE: arch/arm/lib/bootm.c:171:
+defined (CONFIG_REVISION_TAG)

total: 0 errors, 13 warnings, 53 lines checked

/home/wd/Mail/U-Boot/12777 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: space prohibited after that open parenthesis '('
#194: FILE: include/twl4030.h:238:
+   ( (devgrp)  13 | 1  12 | (grp)  9 | (type2)  7 \

total: 1 errors, 0 warnings, 110 lines checked

/home/wd/Mail/U-Boot/12778 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 24 lines checked

/home/wd/Mail/U-Boot/12779 has no obvious style problems and is ready for 
submission.
WARNING: line over 80 characters
#117: FILE: common/main.c:1028:
+   case '\e':  /* ANSI escape char 
*/

WARNING: line over 80 characters
#145: FILE: common/main.c:1056:
+   /* Ignore ANSI escape sequences generated by 
keyboard */

ERROR: space prohibited after that open parenthesis '('
#147: FILE: common/main.c:1058:
+   if ( c = 'A'  c = 'D' ) {

ERROR: space prohibited before that close parenthesis ')'
#147: FILE: common/main.c:1058:
+   if ( c = 'A'  c = 'D' ) {

WARNING: line over 80 characters
#156: FILE: common/main.c:1067:
+   } else if (esc == 3  n  CONFIG_SYS_CBSIZE-4) 
{

total: 2 errors, 3 warnings, 62 lines checked

/home/wd/Mail/U-Boot/12780 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 8 lines checked

/home/wd/Mail/U-Boot/12781 has no obvious style problems and is ready for 
submission.
WARNING: line over 80 characters
#129: FILE: drivers/video/cfb_console.c:712:
+   video_hw_rectfill(VIDEO_PIXEL_SIZE, /* 
bytes per pixel */

WARNING: line over 80 characters
#130: FILE: drivers/video/cfb_console.c:713:
+ VIDEO_FONT_WIDTH * begin, /* dest 
pos x */  /* FIXME: correct? */

WARNING: line over 80 characters
#131: FILE: drivers/video/cfb_console.c:714:
+ video_logo_height + CONSOLE_ROW_SIZE * line,  /* dest 
pos y */  /* FIXME: correct? */

WARNING: line over 80 characters
#132: FILE: drivers/video/cfb_console.c:715:
+   

Re: [U-Boot] [GIT PULL] Please pull powerpc/mpc83xx: set TXEQA/TXEQE value for mpc837XE sata

[Wolfgang Denk]

Dear Kim Phillips,

In message 20111212185411.efd76b8871ab4b5b3a0bb...@freescale.com you wrote:
 Wolfgang Denk,
 
 Please pull, for u-boot v2011.12:
 
 The following changes since commit 06e42c6e2ce269667daecd6229d0b7c813838203:
 
   Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging 
 (2011-12-12 14:51:16 +0100)
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-mpc83xx.git master
 
 Jerry Huang (1):
   powerpc/mpc83xx: set TXEQA/TXEQE value for mpc837XE sata
 
  arch/powerpc/cpu/mpc83xx/serdes.c |   11 ++-
  1 files changed, 10 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If only God would give me some clear sign! Like making a large  depo-
sit in my name at a Swiss Bank. - Woody Allen
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-usb

[Wolfgang Denk]

Dear Remy Bohmer,

In message canqctqlxbgjg07a39j3gx-x4ankzshx8snx+d7kxhfvire2...@mail.gmail.com 
you wrote:
 The following changes since commit 06e42c6e2ce269667daecd6229d0b7c813838203:
 
   Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging
 (2011-12-12 14:51:16 +0100)
 
 are available in the git repository at:
 
   git://git.denx.de/u-boot-usb.git master
 
 Igor Grinberg (4):
   USB: ULPI: switch argument type from u8 to unsigned
   USB: ULPI: clean a mixup of return types
   USB: ULPI: increase error case verbosity
   README: add documentation for CONFIG_USB_ULPI*
 
 Lukasz Majewski (1):
   usb:gadget:s5p Enable the USB Gadget framework at Exynos4210
 (C210 Universal)
 
 Tom Rini (1):
   USB: Use (get|put)_unaligned for accessing wMaxPacketSize
 
  README   |8 +
  arch/arm/include/asm/arch-exynos/cpu.h   |1 +
  board/samsung/universal_c210/universal.c |   48 
 ++
  common/cmd_usb.c |3 +-
  common/usb.c |   27 -
  drivers/serial/usbtty.c  |   10 --
  drivers/usb/gadget/epautoconf.c  |8 +++--
  drivers/usb/gadget/s3c_udc_otg.c |   10 --
  drivers/usb/ulpi/ulpi-viewport.c |4 +-
  drivers/usb/ulpi/ulpi.c  |   30 +-
  include/configs/s5pc210_universal.h  |4 ++
  include/max8998_pmic.h   |1 +
  include/usb/ulpi.h   |8 ++--
  include/usbdescriptors.h |2 +-
  14 files changed, 122 insertions(+), 42 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I have a theory that it's impossible to prove anything, but  I  can't
prove it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 1/3] mx28: Let imx_get_mac_from_fuse be common for mx28

[Wolfgang Denk]

Dear Fabio,

In message 4eea340a.3080...@denx.de Stefano Babic wrote:
 On 15/12/2011 17:34, Fabio Estevam wrote:
  Let imx_get_mac_from_fuse function be a common function, so that other
  mx28 boards can reuse it.
  
  Signed-off-by: Fabio Estevam fabio.este...@freescale.com
  ---
 
 Hi Fabio,
 
  +   if (mx28_wait_mask_clr(ocotp_regs-hw_ocotp_ctrl_reg, OCOTP_CTRL_BUSY,
  +   MXS_OCOTP_MAX_TIMEOUT)) {
  +   puts(MXS FEC: Can't get MAC from OCOTP\n);
  +   return;
  +   }
  +
  +   data = readl(ocotp_regs-hw_ocotp_cust0);
  +
  +   mac[0] = 0x00;
  +   mac[1] = 0x04;
 
 Maybe it is worth to add a comment to explain that the magic numbers
 0x00 - 0x04 are the Freescale's vendor prefix.

This is a common file, right?  Then what about boards from other
vendors?

I think this is not OK as is.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Dealing with failure is easy: work hard to improve. Success  is  also
easy  to  handle:  you've  solved  the  wrong  problem.  Work hard to
improve.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] tools/setlocalversion: Update from the Linux Kernel

[Wolfgang Denk]

Dear Kyle Moffett,

In message 1324070080-16827-1-git-send-email-kyle.d.moff...@boeing.com you 
wrote:
 Several bugfixes have occurred upstream since this script was imported
 into U-Boot.  In particular, the script currently in U-Boot does not
 describe commit f8bbb4dad0e9d91b7a51d6cc54dcf66d142f50fe correctly,
 resulting in a version of 2011.09 instead of 2011.09-01460-gf8bbb4d.
 
 With that commit checked out, the command git name-rev --tags HEAD
 gives this result:
   HEAD tags/v2011.12-rc1~30^2
 
 Then the changes regex does not match because of the trailing '^2':
   grep -E '^HEAD[[:space:]]+(.*~[0-9]*|undefined)$'
 
 The new version of tools/setlocalversion in the kernel correctly handles
 those situations by using different plumbing commands.
 
 The version from the kernel is not directly usable as it does not append
 the full GIT version that U-Boot expects unless the right config options
 are set (CONFIG_LOCALVERSION_AUTO=y).  Other than a few minor changes
 for Kconfig, the imported version is very similar to Linux v3.2-rc4.
 
 Signed-off-by: Kyle Moffett kyle.d.moff...@boeing.com
 Cc: Wolfgang Denk w...@denx.de
 Cc: Mike Frysinger vap...@gentoo.org
 
 --
 Changelog:
   v3:  Fix localversion-* file support and minimize kernel delta.
 ---
  tools/setlocalversion |  185 
 ++---
  1 files changed, 161 insertions(+), 24 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The C-shell doesn't parse. It adhoculates.
- casper@holland.sun.com in 3ol96k$b...@engnews2.eng.sun.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: Fix arguments in tftpput command

[Wolfgang Denk]

Dear Simon Glass,

In message 1324095888-22757-1-git-send-email-...@chromium.org you wrote:
 The switch to strict_strtoul() was not done correctly - this fixes
 the compile error when CONFIG_CMD_TFTPPUT is active.
 
 Signed-off-by: Simon Glass s...@chromium.org
 ---
  common/cmd_net.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/common/cmd_net.c b/common/cmd_net.c
 index f89a24b..be7cc01 100644
 --- a/common/cmd_net.c
 +++ b/common/cmd_net.c
 @@ -221,8 +221,8 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t 
 *cmdtp, int argc,
  
  #ifdef CONFIG_CMD_TFTPPUT
   case 4:
 - save_addr = strict_strtoul(argv[1], NULL, 16);
 - save_size = strict_strtoul(argv[2], NULL, 16);
 + strict_strtoul(argv[1], 16, save_addr);
 + strict_strtoul(argv[2], 16, save_size);

strict_strtoul() returns error codes.  We should not ignore these.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Vulcans believe peace should not depend on force.
-- Amanda, Journey to Babel, stardate 3842.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] common/cmd_nvedit.c: Fix size calculation in do_env_import()

[Wolfgang Denk]

Dear Horst Kronstorfer,

In message 1324114390-27290-1-git-send-email-hkron...@frequentis.com you 
wrote:
 do_env_import() missed the final '\0' terminator when calculating the
 size of an environment data block.  This led to an erroneous 'bad CRC,
 import failed' message for a checksum protected environment (-c.)

Can you please describe a test case that shows this bug?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
God made the integers; all else is the work of Man.   - Kronecker
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Some thoughts on SPL

[Wolfgang Denk]

Dear Simon Glass,

In message CAPnjgZ0E4RfzzL2tfff=cn0xq5ov+v-qtqny3s3zb6hn7sv...@mail.gmail.com 
you wrote:
 
 On Fri, Dec 16, 2011 at 9:20 AM, jonsm...@gmail.com jonsm...@gmail.com wr=
 ote:
...
  The concept is to remove SPL as a special class and turn it into the
  base layer that everything builds on. Changing the model in this was
  should make the config files easier to understand. Instead of having a
  single file combining SPL and full u-boot you'd have two independent
  ones. In my case I'd build one u-boot config that fits into 96K and
  another full 250K one. Of course the two config files could each
  include a common base config.
...
 That's one way to do it, and makes more and more sense as the amount
 of available SRAM increases. Of course some SOCs can even set up their
 SDRAM and read entire programs in, so there are no restrictions. But
 for those with limitations, it makes sense to me to make SPL more a
 cut down build of U-Boot than a special program that pulls in #ifdefed
 code from various places.
 
 Another approach is to just have one U-Boot, but keep everything you
 need to get started in the first 96KB.

Please keep in mind that there is also a large number of boards that
boot form some boot ROM (like NOR flash), i. e. that can directly
execute _all_ U-Boot code, without need of any SPL at all.

Any changes to the design of the SPL must not have any adverse
effects on such XIP booting systems.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
More software projects have gone awry for lack of calendar time than
for all other causes combined.
 - Fred Brooks, Jr., _The Mythical Man Month_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ftintc010.h: add header of ftintc010 interrupt controller

[Wolfgang Denk]

Dear Macpaul Lin,

In message 1324024304-32444-1-git-send-email-macp...@andestech.com you wrote:
 add header definition of faraday interrupt controller
 
 Signed-off-by: Macpaul Lin macp...@andestech.com
 ---
  include/faraday/ftintc010.h |  101 
 +++
  1 files changed, 101 insertions(+), 0 deletions(-)
  create mode 100644 include/faraday/ftintc010.h

Who needs that?

Please submit together with any code thjat actually uses this.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Do you know about being with somebody? Wanting to be? If  I  had  the
whole  universe,  I'd  give it to you, Janice. When I see you, I feel
like I'm hungry all over. Do you know how that feels?
-- Charlie Evans, Charlie X, stardate 1535.8
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mpc8xxx: Fix DRAM message formatting

[Wolfgang Denk]

Dear Kyle Moffett,

In message 1324001689-15226-1-git-send-email-kyle.d.moff...@boeing.com you 
wrote:
 When the Detected RDIMM [...] message was added, it broke the
 pretty-printing of the DRAM information during boot.
 
 It used to look like this:
   DRAM:  2 GiB (DDR2, 64-bit, CL=4, ECC on)
  DDR Chip-Select Interleaving Mode: CS0+CS1
 
 Right now, it looks like this:
   DRAM:  Detected RDIMM VL493T5663D-E6M
   2 GiB (DDR2, 64-bit, CL=4, ECC on)
  DDR Chip-Select Interleaving Mode: CS0+CS1
 
 After this patch, it is:
   DRAM:  Detected RDIMM VL493T5663D-E6M
  2 GiB (DDR2, 64-bit, CL=4, ECC on)
  DDR Chip-Select Interleaving Mode: CS0+CS1

We discussed this before.

This outpout is too verbose.  It should read:

DRAM:  2 GiB

And not more.  Any additional information should only be printed upon
explicit request from the user.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A verbal contract isn't worth the paper it's written on.
-- Samuel Goldwyn
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net/eth: Don't issue warnings for offboard ethernet chips

[Wolfgang Denk]

Dear Kyle Moffett,

In message 1324001821-15337-1-git-send-email-kyle.d.moff...@boeing.com you 
wrote:
 When using an offboard ethernet chip such as e1000, it is highly likely
 that the driver has already read a valid MAC address from the onboard
 EEPROM.  In that case, U-Boot should not issue a warning about the
 absence of an eth*addr value in the environment.

Yes, it should.  The rule is that then environment settings always
have precedence, and if they are missing or contain different data
than other sources for this inofmration, a waning shall be printed.


 A properly configured HWW-1U-1A board is fixed from this output:
 
   Net:   e1000: 00:50:93:81:ff:8a
  e1000: 00:50:93:81:ff:8b
  owt0, owt1, peer, e1000#0
   Warning: failed to set MAC address
   , e1000#1
   Warning: failed to set MAC address
 
 To this:
 
   Net:   e1000: 00:50:93:81:ff:8a
  e1000: 00:50:93:81:ff:8b
  owt0, owt1, peer, e1000#0, e1000#1

This is also not correct.  There should never be any printing of the
MAC addresses here.

The messages should be:

Net:   owt0, owt1, peer, e1000#0, e1000#1

 Furthermore, the log messages should avoid screwing up the Net: output
 formatting provided by the calling code, EG:
 
   Net:   eth0, eth1 [could not set MAC: 00:50:93:81:ff:8a], eth2

No.  could not set is an error message, and deserves a separate
line.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
What terrible way to die.
There are no good ways.
-- Sulu and Kirk, That Which Survives, stardate unknown
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup

[Wolfgang Denk]

Dear Stefan Roese,

In message 201112151715.35434...@denx.de you wrote:

 Okay. If nobody objects I'll queue these patches up in u-boot-ppc4xx/next in 
 the next few days.

Hm... I think I will just pull this whole list of checkpatch patches
directly into next.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Men of peace usually are [brave].
-- Spock, The Savage Curtain, stardate 5906.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup

[Wolfgang Denk]

Dear Matthias Fuchs,

In message 4eea14e6.2020...@esd.eu you wrote:
 Hi Marek,
 
 thanks for that work.
 The patches against the esd files are
 
 Acked-by: Matthias Fuchs matthias.fu...@esd.eu

Sorry, but doing it this way is a pretty reliable way that your
Acked-by: gets _lost_.

We don't add these manually, instead we trust that PatchWork will
collect this information for us, so it is essential that you sned
proper replies to the patches you are actually ACKing.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Conceptual integrity in turn dictates that the  design  must  proceed
from  one  mind,  or  from  a  very small number of agreeing resonant
minds.   - Frederick Brooks Jr., The Mythical Man Month
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup

[Wolfgang Denk]

Dear Anatolij Gustschin,

In message 20111215181509.57c6535d@wker you wrote:
 On Thu, 15 Dec 2011 14:26:41 +0100
 Marek Vasut marek.va...@gmail.com wrote:
 
  First of the CHECKPATCH series of patches with per-file checkpatch fixes.
  
  This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. 
  There
  are no functional changes, only CHECKPATCH fixes.
...
 For all 18 patches:
 
 Acked-by: Anatolij Gustschin ag...@denx.de

Sorry, this information gets lost, too.

See http://article.gmane.org/gmane.comp.boot-loaders.u-boot/120706


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Keep your head and your heart going in the right  direction  and  you
will not have to worry about your feet.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver

[Wolfgang Denk]

Dear Che-Liang Chiou,

In message 1323852504-19954-3-git-send-email-clch...@chromium.org you wrote:
 Peter Huewe implemented the original driver; this patch only reorganizes
 the code structure of the driver, and does not make logical changes.
 
 tpm.c implements the interface defined in tpm.h based on underlying
 LPC or i2C TPM driver.  tpm.c and the underlying driver communicate
 throught tpm_private.h.
 
 This patch is tested on a tegra2-based machine, where the i2c driver is
 not upstreamed yet.
 
 Note: Merging the LPC driver with tpm.c is left to future patches.
 
 Signed-off-by: Peter Huewe peter.hu...@infineon.com
 Signed-off-by: Che-Liang Chiou clch...@chromium.org

...
 + if (ordinal  TPM_MAX_ORDINAL)
 + duration_idx = tpm_ordinal_duration[ordinal];
 + else if ((ordinal  TPM_PROTECTED_ORDINAL_MASK) 
 + TPM_MAX_PROTECTED_ORDINAL)
 + duration_idx = tpm_protected_ordinal_duration[ordinal 
 + TPM_PROTECTED_ORDINAL_MASK];

Braces needed around multiline statement.

 + if (duration_idx != TPM_UNDEFINED)
 + duration = chip-vendor.duration[duration_idx];
 + if (duration = 0)

Readability could be improved by inserting a blank line before this
one.

...
 + debug(%s: waiting for status...\n, __func__);
 + u8 status = tpm_chip.vendor.status(tpm_chip);
 + if ((status  tpm_chip.vendor.req_complete_mask) ==

Please always seaprate declarations and code by one blank line.
Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Yes, it's a technical challenge, and  you  have  to  kind  of  admire
people  who go to the lengths of actually implementing it, but at the
same time you wonder about their IQ...
 --  Linus Torvalds in 5phda5$ml6$1...@palladium.transmeta.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1 1/2] tpm: Rename generic_lpc_tpm to tpm_tis_lpc

[Wolfgang Denk]

Dear Che-Liang Chiou,

In message 1323852504-19954-2-git-send-email-clch...@chromium.org you wrote:
 The new name is more aligned with Linux kernel's naming of TPM driver.
 
 Signed-off-by: Peter Huewe peter.hu...@infineon.com
 Signed-off-by: Che-Liang Chiou clch...@chromium.org
 Acked-by: Mike Frysinger vap...@gentoo.org
 ---
 Changes in v1:
 - Update s-o-b Peter Huewe's email address
 
  Makefile |2 +-
  README   |5 -
  drivers/tpm/Makefile |2 +-
  drivers/tpm/{generic_lpc_tpm.c = tpm_tis_lpc.c} |0
  4 files changed, 6 insertions(+), 3 deletions(-)
  rename drivers/tpm/{generic_lpc_tpm.c = tpm_tis_lpc.c} (100%)

Does such a change actually make sense?

Should we not rather remove all this dead code again?

Until today there are no users for this code in mainline, and no
patches have been submitted that intend to use it.

I think we should scrap this in the next release.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Drawing on my fine command of language, I said nothing.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 01/18 V2] CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ARMV7: Add support For Logic OMAP35x/DM37x modules

[Wolfgang Denk]

Dear Peter Barada,

In message 1324067511-14142-1-git-send-email-peter.bar...@logicpd.com you 
wrote:
 This patch adds basic support for OMAP35x/DM37x SOM LV/Torpedo
 reference boards. It assumes U-boot is loaded to SDRAM with the
 help of another small bootloader (x-load) running from SRAM.
 
 Signed-off-by: Peter Barada peter.bar...@logicpd.com
 Cc: Tom Rini tom.r...@gmail.com
 Cc: Igor Grinberg grinb...@compulab.co.il
...
  board/logicpd/omap3som/Makefile |   42 +++
  board/logicpd/omap3som/omap3logic.c |  523 
 +++
  board/logicpd/omap3som/omap3logic.h |   35 +++
  boards.cfg  |1 +
  include/configs/omap3_logic.h   |  351 +++
  5 files changed, 952 insertions(+), 0 deletions(-)
  create mode 100644 board/logicpd/omap3som/Makefile
  create mode 100644 board/logicpd/omap3som/omap3logic.c
  create mode 100644 board/logicpd/omap3som/omap3logic.h
  create mode 100644 include/configs/omap3_logic.h

Entry to MAINTAINERS missing.

 +/* two dimensional array of strucures containining board name and Linux
 + * machine IDs; row it selected based on CPU column is slected based
 + * on hsusb0_data5 pin having a pulldown resistor */

Incorrect multiline comment style.  Please fix globally.


 +#ifdef CONFIG_SMC911X
 +/* GPMC CS1 settings for Logic SOM LV/Torpedo LAN92xx Ethernet chip */
 +static const u32 gpmc_lan92xx_config[] = {
 + 0x1000,
 + 0x00080801,
 + 0x,
 + 0x08010801,
 + 0x00080a0a,
 + 0x03000280,
 +};

And what exactly is the meaning of these magic numbers?


 +#define CONFIG_HARD_I2C  1
 +#define CONFIG_SYS_I2C_SPEED 10
 +#define CONFIG_SYS_I2C_SLAVE 1
 +#define CONFIG_SYS_I2C_BUS   0
 +#define CONFIG_SYS_I2C_BUS_SELECT1
 +#define CONFIG_I2C_MULTI_BUS 1
 +#define CONFIG_DRIVER_OMAP34XX_I2C   1

Please do not define values for macros that only switch on a feature.

...
 +#define CONFIG_PREBOOT \
 + echo ==NOTICE;\
 + echo The u-boot environment is not set. - You are;\
 + echo required to set a valid display for your LCD panel.; \
 + echo Valid display options are:;  \
 + echo \  2 == LQ121S1DG31 TFT SVGA(12.1)  Sharp\;\
 + echo \  3 == LQ036Q1DA01 TFT QVGA(3.6)   Sharp w/ASIC\; \
 + echo \  5 == LQ064D343   TFT VGA (6.4)   Sharp\;\
 + echo \  7 == LQ10D368TFT VGA (10.4)  Sharp\;\
 + echo \ 15 == LQ043T1DG01 TFT WQVGA   (4.3)   Sharp (DEFAULT)\; \
 + echo \ vga[-16 OR -24]   LCD VGA 640x480\;  \
 + echo \ svga[-16 OR -24]  LCD SVGA800x600\;  \
 + echo \ xga[-16 OR -24]   LCD XGA 1024x768\; \
 + echo \ 720p[-16 OR -24]  LCD 720P1280x720\; \
 + echo \ sxga[-16 OR -24]  LCD SXGA1280x1024\;\
 + echo \ uxga[-16 OR -24]  LCD UXGA1600x1200\;\
 + echo MAKE SURE YOUR DISPLAY VARIABLE IS CORRECTLY ENTERED!;   \
 + setenv display 15;\

Strange.  First you ask the user to set a valid display type, and then
you hard-set it to some predefined value.  What's the reationale
behind that?

 + setenv preboot;   \
 + saveenv;

Would it not be better to erase the preboot setting only after some
display type definition was entered and saved _by_the_user_ ?

 +/*---
 + * Physical Memory Map
 + */

Incorrect multiline comment style. Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If all the Chinese simultaneously jumped into the Pacific  off  a  10
foot platform erected 10 feet off their coast, it would cause a tidal
wave that would destroy everything in this country west of Nebraska.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/18 V2] CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 03/18 V2] CHECKPATCH: ./board/esd/du405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] git-mailrc: Add self to davinci/omap, add ti

[Wolfgang Denk]

Dear Tom Rini,

In message 1323879316-21776-1-git-send-email-tr...@ti.com you wrote:
 Adding a 'ti' alias since not all parts are omap or davinci and
 adding myself to that alias as co-custodian of u-boot-ti
 
 Signed-off-by: Tom Rini tr...@ti.com
 ---
  doc/git-mailrc |5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
No man knows what true happiness is until he gets married.  By  then,
of course, its too late.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 04/18 V2] CHECKPATCH: ./board/esd/canbt/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 05/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 06/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 07/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 08/18 V2] CHECKPATCH: ./board/esd/wuh405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] km/common: add toolchain variable

[Wolfgang Denk]

Dear Holger Brunck,

In message 1323879110-8404-1-git-send-email-holger.bru...@keymile.com you 
wrote:
 Add a variable toolchain and configure the rootpath
 for the nfsargs with this variable.
 
 Signed-off-by: Holger Brunck holger.bru...@keymile.com
 cc: Wolfgang Denk w...@denx.de
 ---
  board/keymile/scripts/README |2 +-
  board/keymile/scripts/develop-common.txt |3 ++-
  2 files changed, 3 insertions(+), 2 deletions(-)
 
 diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README
 index 7fbcf74..dd935b2 100644
 --- a/board/keymile/scripts/README
 +++ b/board/keymile/scripts/README
 @@ -7,7 +7,7 @@ default environment must be parsed:
  run develop : setup environment to configure for rootfs via nfs
  run ramfs   : setup environment to configure for rootfs in ram
  
 -Last change: 20.05.2011
 +Last change: 24.11.2011

Does this really make any sense?  Which date are you recording here/
When you (think) you last edited the file? When you applied the patch
to your local tree? When you submitted it for mainline? When it
actually got applied?

I recommend to get rid of this, and rather use git revision
information instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The human mind  ordinarily  operates  at  only  ten  percent  of  its
capacity. The rest is overhead for the operating system.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 09/18 V2] CHECKPATCH: ./board/esd/plu405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/18 V2] CHECKPATCH: ./board/esd/ar405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 11/18 V2] CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/18 V2] CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/18 V2] CHECKPATCH: ./board/esd/ash405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 14/18 V2] CHECKPATCH: ./board/esd/voh405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 15/18 V2] CHECKPATCH: ./board/esd/apc405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 16/18 V2] CHECKPATCH: ./board/esd/tasreg/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 17/18 V2] CHECKPATCH: ./board/esd/pci405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 18/18 V2] CHECKPATCH: ./board/esd/hh405/fpgadata.c

[Anatolij Gustschin]

Acked-by: Anatolij Gustschin ag...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 0/4] Buffer overruns in printf

[Wolfgang Denk]

Dear Simon Glass,

In message CAPnjgZ0MFpTsLghMxEOP-nvpe=h-v2p4r3eptdpv7rv8xsr...@mail.gmail.com 
you wrote:
 
 Is this series going into this month's release?

No.  This goes into next.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Do not follow where the path may leadgo instead where there is no
path and leave a trail.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 1/4] Move vsprintf functions into their own header

[Wolfgang Denk]

Dear Simon Glass,

In message 1320263530-22843-2-git-send-email-...@chromium.org you wrote:
 common.h is very large, so before changing the vsprintf functions, move the
 prototypes into their own header file.
 
 Signed-off-by: Simon Glass s...@chromium.org
 ---
 Changes in v3:
 - Move prototypes from common.h to vsprintf.h
 
  include/common.h   |   11 +--
  include/vsprintf.h |   39 +++
  2 files changed, 40 insertions(+), 10 deletions(-)
  create mode 100644 include/vsprintf.h

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Man is the best computer we can put aboard a spacecraft ...  and  the
only one that can be mass produced with unskilled labor.
 -- Wernher von Braun
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 2/4] Add safe vsnprintf and snprintf library functions

[Wolfgang Denk]

Dear Simon Glass,

In message 1320263530-22843-3-git-send-email-...@chromium.org you wrote:
 From: Sonny Rao sonny...@chromium.org
 
 From: Sonny Rao sonny...@chromium.org
 
 These functions are useful in U-Boot because they allow a graceful failure
 rather than an unpredictable stack overflow when printf() buffers are
 exceeded.
 
 Mostly copied from the Linux kernel. I copied vscnprintf and
 scnprintf so we can change printf and vprintf to use the safe
 implementation but still return the correct values.
 
 (Simon Glass s...@chromium.org modified this commit a little)
 
 Signed-off-by: Sonny Rao sonny...@chromium.org
 ---
 Changes in v3:
 - Add CONFIG_SYS_VSNPRINT option to enable vsnprintf() functions
 - Update README with CONFIG_SYS_VSNPRINT docs
 - Use ADDCH macro to support checking/not checking end pointer
 
 Changes in v4:
 - Add these changes in unless CONFIG_NO_SYS_VSNPRINT is defined
 - Reduce code size overhead if disabled to only 4 bytes on ARM
 - Remove the ugly #ifdef patch from series since it only saves 4 bytes
 
 Changes in v5:
 - Define INT_MAX locally within vsprintf.c
 
 Changes in v6:
 - Change the config option to CONFIG_SYS_VSNPRINTF
 - Make the default be to NOT include safe printf functions
 
  README |9 ++
  include/vsprintf.h |   19 
  lib/vsprintf.c |  265 +--
  3 files changed, 241 insertions(+), 52 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
IBM uses what I like to call the 'hole-in-the-ground  technique'  to
destroy  the  competition.  IBM digs a big HOLE in the ground and
covers it with leaves. It then puts a big POT OF GOLD nearby. Then it
gives the call, 'Hey, look at all this gold, get over here fast.'  As
soon  as  the competitor approaches the pot, he falls into the pit
 - John C. Dvorak
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 3/4] vsprintf: Move function documentation into header file

[Wolfgang Denk]

Dear Simon Glass,

In message 1320263530-22843-4-git-send-email-...@chromium.org you wrote:
 Now that this is not in common.h, perhaps it is acceptable to move this
 documentation into the header file.
 
 Signed-off-by: Simon Glass s...@chromium.org
 ---
 Changes in v3:
 - Move function documentation into header file
 
  include/vsprintf.h |  123 
 
  lib/vsprintf.c |  100 --
  2 files changed, 123 insertions(+), 100 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Overdrawn?  But I still have checks left!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/4] Make printf and vprintf safe from buffer overruns

[Wolfgang Denk]

Dear Simon Glass,

In message 1320263530-22843-5-git-send-email-...@chromium.org you wrote:
 From: Sonny Rao sonny...@chromium.org
 
 From: Sonny Rao sonny...@chromium.org
 
 utilize the added vscnprintf functions to avoid buffer overruns
 The implementation is fairly dumb in that it doesn't detect
 that the buffer is too small, but at least will not cause crashes.
 
 Signed-off-by: Sonny Rao sonny...@chromium.org
 ---
 Changes in v2:
 - Use sizeof(printbuffer) instead of CONFIG_SYS_PBSIZE
 - Drop patch which changes network code to use snprintf()
 
 Changes in v5:
 - Drop limits.h as it is used in only two places in U-Boot
 
  common/console.c |   10 +-
  1 files changed, 5 insertions(+), 5 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There is, however, a strange, musty smell in the air that reminds  me
of something...hmm...yes...I've got it...there's a VMS nearby, or I'm
a Blit.  - Larry Wall in Configure from the perl distribution
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] sandbox: Add tap based networking

[Wolfgang Denk]

Dear Matthias Weisser,

In message 1323021425-7854-1-git-send-email-weiss...@arcor.de you wrote:
 This patch adds support for networking to sandbox architecture using
 tap. A tap device tap0 has to be created e.g. using openvpn
 
 $ openvpn --mktun --dev tap0
 
 u-boot should then be able to detect the network device on startup.
 To test the network related commands the following commands can be used
 to create an ethernet bridge to local network connection.
 
 $ brctl addbr br0
 $ ifconfig eth0 0.0.0.0 promisc
 $ ifconfig tap0 0.0.0.0
 $ brctl addif br0 eth0
 $ brctl addif br0 tap0
 $ ifconfig br0 up
 $ pump -i br0
 
 Signed-off-by: Matthias Weisser weiss...@arcor.de
...
 +int os_tap_set_hw_addr(int fd, unsigned char *hwaddr)
 +{
 + /*
 +  * The following code should be able to change the MAC of a TAP
 +  * interface but doesn't work on my box. So leave it disabled
 +  * here as a reference if someone is going to pick that up in
 +  * the future.
 +  */
 +#if 0
 + struct ifreq ifr;
 +
 + memset(ifr, 0, sizeof(ifr));
 + strncpy(ifr.ifr_name, tap0, IFNAMSIZ);
 +
 + /* Get the interface flags */
 + if (ioctl(fd, SIOCGIFFLAGS, ifr)  0) {
 + perror(Could not get interface flags);
 + return -1;
 + }
 + /* Shut down the interface */
 + ifr.ifr_flags = ~(IFF_UP);
 + if (ioctl(fd, SIOCSIFFLAGS, ifr)  0) {
 + perror(Could not down the interface);
 + return -1;
 + }
 +
 + /* Set the new hw address */
 + ifr.ifr_hwaddr.sa_family = ARPHRD_ETHER;
 + memcpy(ifr.ifr_hwaddr.sa_data, hwaddr, ETH_ALEN);
 +
 + if (ioctl(fd, SIOCSIFHWADDR, ifr)  0) {
 + perror(ioctl(SIOCSIFHWADDR));
 + return -1;
 + }
 +
 + /* Get the interface flags */
 + if (ioctl(fd, SIOCGIFFLAGS, ifr)  0) {
 + perror(Could not get interface flags);
 + return -1;
 + }
 + /* Shut down the interface */
 + ifr.ifr_flags |= IFF_UP;
 + if (ioctl(fd, SIOCSIFFLAGS, ifr)  0) {
 + perror(Could not up the interface);
 + return -1;
 + }
 + return 0;
 +#endif

Please do not add dead code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Even historians fail to learn from history -- they repeat the same
mistakes.
-- John Gill, Patterns of Force, stardate 2534.7
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm, fdt: update ethernet mac address before booting Linux

[Wolfgang Denk]

Dear Heiko Schocher,

In message 1316063790-4583-1-git-send-email...@denx.de you wrote:
 Signed-off-by: Heiko Schocher h...@denx.de
 Cc: Albert ARIBAUD albert.u.b...@aribaud.net
 Cc: Gerald van Baren gvb.ub...@gmail.com
 ---
  arch/arm/lib/bootm.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

Acked-by: Wolfgang Denk w...@denx.de


Albert, can you please take this through your tree for -rc2 ?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If you can't beat it or corrupt it, you pretend it was your  idea  in
the first place. - Terry Pratchett, _Guards! Guards!_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier

[Wolfgang Denk]

Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1323939415-21743-2-git-send-email-andreas.de...@googlemail.com you 
wrote:
 From: Andreas Bießmann biessm...@corscience.de
 
 size_t is not always 'unsigned int', use corret length modifer.
 
 This patch fixes following warning:
 
 ---8---
 cmd_sf.c: In function 'spi_flash_update_block':
 cmd_sf.c:130: warning: format '%#x' expects type 'unsigend int', but argument 
 4 has type 'size_t'
 cmd_sf.c:135: warning: format '%x' expects type 'unsigned int', but argument 
 3 has type 'size_t'
 ---8---
 
 Signed-off-by: Andreas Bießmann biessm...@corscience.de
 cc: Mike Frysinger vap...@gentoo.org
 cc: Thomas Chou tho...@wytron.com.tw
 ---
 changes since v1: split off into single patches
 
 total: 0 errors, 0 warnings, 14 lines checked
 
 NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
 MULTISTATEMENT_MACRO_USE_DO_WHILE
 
 0001-cmd_sf.c-fix-printf-length-modifier.patch has no obvious style problems 
 and is ready for submission.
 
  common/cmd_sf.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Anything that is worth doing at all is worth doing well.
   -- Philip Earl of Chesterfield
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/3] fat.c: fix printf() length modifier

[Wolfgang Denk]

Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1323939415-21743-3-git-send-email-andreas.de...@googlemail.com you 
wrote:
 From: Andreas Bießmann biessm...@corscience.de
 
 The DIRENTSPERBLOCK utilizes sizeof() which will return a size_t which has no
 fixed size. Therefor use correct length modifer for printf() statement to
 prevent compiler warnings.
 
 This patch fixes following warning:
 
 ---8---
 fat.c: In function 'do_fat_read':
 fat.c:879: warning: format '%d' expects type 'int', but argument 4 has type 
 'long unsigned int'
 ---8---
 
 Signed-off-by: Andreas Bießmann biessm...@corscience.de
 cc: Mike Frysinger vap...@gentoo.org
 cc: Thomas Chou tho...@wytron.com.tw
 cc: rjo...@nexus-tech.net
 cc: khar...@nexus-tech.net
 ---
 changes since v1: split off into single patches
 
 total: 0 errors, 0 warnings, 8 lines checked
 
 NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
 MULTISTATEMENT_MACRO_USE_DO_WHILE
 
 0002-fat.c-fix-printf-length-modifier.patch has no obvious style problems and 
 is ready for submission.
 
  fs/fat/fat.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Send lawyers, guns and money...  - Lyrics from a Warren Zevon song
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 3/3] avr32:mmu.c: fix printf() length modifier

[Wolfgang Denk]

Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1323939415-21743-4-git-send-email-andreas.de...@googlemail.com you 
wrote:
 From: Andreas Bießmann biessm...@corscience.de
 
 avr32 uses unsigned long addresses, fix the printf() length modifier for that
 fact.
 
 Before this patch following warning occours:
 
 ---8---
 mmu.c: In function 'mmu_init_r':
 mmu.c:25: warning: format '%08x' expects type 'unsigned int', but argument 2 
 has type 'uintptr_t'
 ---8---
 
 Signed-off-by: Andreas Bießmann biessm...@corscience.de
 cc: Mike Frysinger vap...@gentoo.org
 cc: Thomas Chou tho...@wytron.com.tw
 cc: Reinhard Meyer u-b...@emk-elektronik.de
 ---
 changes since v1: split off into single patches
 
 total: 0 errors, 0 warnings, 8 lines checked
 
 NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
 MULTISTATEMENT_MACRO_USE_DO_WHILE
 
 0003-avr32-mmu.c-fix-printf-length-modifier.patch has no obvious style 
 problems and is ready for submission.
 
  arch/avr32/cpu/at32ap700x/mmu.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Spock, did you see the looks on their faces?
Yes, Captain, a sort of vacant contentment.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 01/18 V2] CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-2-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/dave/PPChameleonEVB/fpgadata.c | 3416 ++---
  1 files changed, 2277 insertions(+), 1139 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
365 Days of drinking Lo-Cal beer.   = 1 Lite-year
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/18 V2] CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-3-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/cpciiser4/fpgadata.c | 6204 ++-
  1 files changed, 4136 insertions(+), 2068 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Our OS who art in CPU, UNIX be thy name.
Thy programs run, thy syscalls done,
In kernel as it is in user!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 03/18 V2] CHECKPATCH: ./board/esd/du405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-4-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/du405/fpgadata.c | 2108 
 +---
  1 files changed, 1405 insertions(+), 703 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
KLB is an acronym for `Known Lazy Bastard', aka non-FAQ  reader,  aka
person  who  would  rather  make  someone  take their time to explain
something basic than look it up in a  FAQ.
 -- Tom Christiansen in 6aq547$mnr$2...@csnews.cs.colorado.edu
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 04/18 V2] CHECKPATCH: ./board/esd/canbt/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-5-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/canbt/fpgadata.c | 1211 
 +---
  1 files changed, 807 insertions(+), 404 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You are only young once, but you can stay immature indefinitely.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 05/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-6-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/cpci405/fpgadata_cpci4052.c | 2294 
 ++---
  1 files changed, 1529 insertions(+), 765 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Steal five dollars and you were a petty  thief.  Steal  thousands  of
dollars and you are either a government or a hero.
   - Terry Pratchett, _Going_Postal_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 07/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-8-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/cpci405/fpgadata_cpci405.c | 1025 ++---
  1 files changed, 683 insertions(+), 342 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
And they told us, what they wanted... Was a sound  that  could  kill
some-one, from a distance.   - Kate Bush
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 06/18 V2] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-7-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/cpci405/fpgadata_cpci405ab.c | 3854 
 +---
  1 files changed, 2569 insertions(+), 1285 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A committee is a life form with six or more legs and no brain.
  -- Lazarus Long, Time Enough For Love
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 08/18 V2] CHECKPATCH: ./board/esd/wuh405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-9-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/wuh405/fpgadata.c | 5454 --
  1 files changed, 3636 insertions(+), 1818 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Of course there's no reason for it, it's just our policy.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 09/18 V2] CHECKPATCH: ./board/esd/plu405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-10-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/plu405/fpgadata.c | 3537 --
  1 files changed, 2358 insertions(+), 1179 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The man on tops walks a lonely street;  the  chain  of  command  is
often a noose.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/18 V2] CHECKPATCH: ./board/esd/ar405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-11-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/ar405/fpgadata.c | 8250 
 +---
  1 files changed, 5500 insertions(+), 2750 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Why don't you have a Linux partition installed so you can be  working
in  a  programmer-friendly environment instead of a keep-gates'-bank-
account-happy one? :-)-- Tom Christiansen
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/18 V2] CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-13-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/dasa_sim/fpgadata.c | 5855 
 +++--
  1 files changed, 3903 insertions(+), 1952 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I program, therefore I am.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 11/18 V2] CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-12-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/ar405/fpgadata_xl30.c | 7308 
 ++-
  1 files changed, 4872 insertions(+), 2436 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Neckties strangle clear thinking.   -- Lin Yutang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/18 V2] CHECKPATCH: ./board/esd/ash405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-14-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/ash405/fpgadata.c | 7475 --
  1 files changed, 4983 insertions(+), 2492 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Microsoft Compatibility:
 your old Windows 3.11 application crash exactly as the new ones.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 15/18 V2] CHECKPATCH: ./board/esd/apc405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-16-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/apc405/fpgadata.c | 6012 --
  1 files changed, 4008 insertions(+), 2004 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Without facts, the decision cannot be made logically. You  must  rely
on your human intuition.
-- Spock, Assignment: Earth, stardate unknown
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 14/18 V2] CHECKPATCH: ./board/esd/voh405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-15-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/voh405/fpgadata.c | 6032 --
  1 files changed, 4021 insertions(+), 2011 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Ordnung ist die Lust der Vernunft,
aber Unordnung die Wonne der Phantasie - Paul Claudel
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 17/18 V2] CHECKPATCH: ./board/esd/pci405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-18-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/pci405/fpgadata.c | 2238 --
  1 files changed, 1492 insertions(+), 746 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Bureaucracy is the enemy of innovation.
   - Mark Shepherd, former President and CEO of Texas Instruments
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 16/18 V2] CHECKPATCH: ./board/esd/tasreg/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-17-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/tasreg/fpgadata.c |15992 --
  1 files changed, 10661 insertions(+), 5331 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Microsoft Multimedia:
You have nice graphics, sound and animations when the system crashes.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 18/18 V2] CHECKPATCH: ./board/esd/hh405/fpgadata.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323955619-8691-19-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Anatolij Gustschin ag...@denx.de
 Cc: Stefano Babic sba...@denx.de
 ---
  board/esd/hh405/fpgadata.c | 7551 
 +---
  1 files changed, 5034 insertions(+), 2517 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Quote from the Boss after overriding the decision of a task force  he
created  to  find  a  solution:  I'm  sorry  if  I ever gave you the
impression your input would have any effect on my  decision  for  the
outcome of this project!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/7] CHECKPATCH: ./board/esd/voh405/logo_320_240_4bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-3-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/voh405/logo_320_240_4bpp.c |  230 ++---
  1 files changed, 153 insertions(+), 77 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I believe the use of noise to make  music  will  increase  until  we
reach  a  music  produced  through  the aid of electrical instruments
which will make available for musical purposes  any  and  all  sounds
that can be heard.- composer John Cage, 1937
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7] CHECKPATCH: ./board/esd/voh405/logo_640_480_24bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-2-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/voh405/logo_640_480_24bpp.c | 5165 
 ++---
  1 files changed, 3443 insertions(+), 1722 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It is more rational to sacrifice one life than six.
-- Spock, The Galileo Seven, stardate 2822.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/7] CHECKPATCH: ./board/esd/apc405/logo_640_480_24bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-4-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/apc405/logo_640_480_24bpp.c | 1694 
 ++---
  1 files changed, 1129 insertions(+), 565 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It would be illogical to kill without reason
-- Spock, Journey to Babel, stardate 3842.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/7] CHECKPATCH: ./board/esd/hh405/logo_640_480_24bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-5-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/hh405/logo_640_480_24bpp.c |12626 ++---
  1 files changed, 8417 insertions(+), 4209 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
... The prejudices people feel about each other disappear  when  then
get to know each other.
-- Kirk, Elaan of Troyius, stardate 4372.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/7] CHECKPATCH: ./board/esd/hh405/logo_320_240_4bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-6-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/hh405/logo_320_240_4bpp.c |  681 
 +++
  1 files changed, 454 insertions(+), 227 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The sooner our happiness together begins, the longer it will last.
-- Miramanee, The Paradise Syndrome, stardate 4842.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 7/7] CHECKPATCH: ./board/esd/hh405/logo_320_240_8bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-8-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/hh405/logo_320_240_8bpp.c | 1563 
 +++
  1 files changed, 1042 insertions(+), 521 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Es sind überhaupt nur die Dummköpfe, die sich den Befehlen der  Mäch-
tigen  widersetzen.  Um  sie  zu ruinieren ist es genug, ihre Befehle
treu zu erfüllen.  - Peter Hacks: Die schöne Helena
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 6/7] CHECKPATCH: ./board/esd/hh405/logo_1024_768_8bpp.c

[Wolfgang Denk]

Dear Marek Vasut,

In message 1323956755-9826-7-git-send-email-marek.va...@gmail.com you wrote:
 Signed-off-by: Marek Vasut marek.va...@gmail.com
 Cc: Stefan Roese s...@denx.de
 ---
  board/esd/hh405/logo_1024_768_8bpp.c | 7631 ++---
  1 files changed, 5087 insertions(+), 2544 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You'll learn something  about  men  and  women  --  the  way  they're
supposed  to  be. Caring for each other, being happy with each other,
being good to each other. That's what we call love. You'll like  that
a lot.
-- Kirk, The Apple, stardate 3715.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [STATUS] next branch started

[Wolfgang Denk]

Hi,

as you may have seen from some of my confirmation messages, I have
started a next branch.

Please feel free to send pull-requests for next, or to point me to
patches that should go into next (or even into the upcoming release).

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It took him several minutes to understand any new idea  put  to  him,
and  this is a very valuable trait in a leader, because anything any-
one is still trying to explain to you after two minutes  is  probably
important  and anything they give up after a mere minute or so is al-
most certainly something they shouldn't have been bothering you  with
in the first place.   - Terry Pratchett, _Reaper Man_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask

[Prafulla Wadaskar]

 -Original Message-
 From: Michael Walle [mailto:mich...@walle.cc]
 Sent: 17 December 2011 09:31
 To: u-boot@lists.denx.de
 Cc: Albert ARIBAUD; Prafulla Wadaskar; Wolfgang Denk
 Subject: Re: [PATCH] kirkwood_spi: fix setting of irq mask
 
 Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
  Since the data alignment fault was enabled recently in commit
arm, arm926ejs: always do cpu critical inits
  the driver won't work anymore and all boards which use an
 environment in an
  SPI flash will fail booting.
 
 Sorry i don't know how you track patches that should be applied for
 the RC.
 But IMHO this is one :)

Thanks Michael
I will take care of that.

Regards..
Prafulla . . .

 
 --
 Michael
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: Fix arguments in tftpput command

[Simon Glass]

Hi Wolfgang,

On Sat, Dec 17, 2011 at 12:00 PM, Wolfgang Denk w...@denx.de wrote:
 Dear Simon Glass,

 In message 1324095888-22757-1-git-send-email-...@chromium.org you wrote:
 The switch to strict_strtoul() was not done correctly - this fixes
 the compile error when CONFIG_CMD_TFTPPUT is active.

 Signed-off-by: Simon Glass s...@chromium.org
 ---
  common/cmd_net.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/common/cmd_net.c b/common/cmd_net.c
 index f89a24b..be7cc01 100644
 --- a/common/cmd_net.c
 +++ b/common/cmd_net.c
 @@ -221,8 +221,8 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t 
 *cmdtp, int argc,

  #ifdef CONFIG_CMD_TFTPPUT
       case 4:
 -             save_addr = strict_strtoul(argv[1], NULL, 16);
 -             save_size = strict_strtoul(argv[2], NULL, 16);
 +             strict_strtoul(argv[1], 16, save_addr);
 +             strict_strtoul(argv[2], 16, save_size);

 strict_strtoul() returns error codes.  We should not ignore these.

Er yes, I wondered about that. I will resubmit with a cmd_usage() in that case.

Regards,
Simon


 Best regards,

 Wolfgang Denk

 --
 DENX Software Engineering GmbH,     MD: Wolfgang Denk  Detlev Zundel
 HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
 Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
 Vulcans believe peace should not depend on force.
        -- Amanda, Journey to Babel, stardate 3842.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Some thoughts on SPL

[Simon Glass]

Hi Wolfgang,

On Sat, Dec 17, 2011 at 12:08 PM, Wolfgang Denk w...@denx.de wrote:
 Dear Simon Glass,

 In message 
 CAPnjgZ0E4RfzzL2tfff=cn0xq5ov+v-qtqny3s3zb6hn7sv...@mail.gmail.com you 
 wrote:

 On Fri, Dec 16, 2011 at 9:20 AM, jonsm...@gmail.com jonsm...@gmail.com wr=
 ote:
 ...
  The concept is to remove SPL as a special class and turn it into the
  base layer that everything builds on. Changing the model in this was
  should make the config files easier to understand. Instead of having a
  single file combining SPL and full u-boot you'd have two independent
  ones. In my case I'd build one u-boot config that fits into 96K and
  another full 250K one. Of course the two config files could each
  include a common base config.
 ...
 That's one way to do it, and makes more and more sense as the amount
 of available SRAM increases. Of course some SOCs can even set up their
 SDRAM and read entire programs in, so there are no restrictions. But
 for those with limitations, it makes sense to me to make SPL more a
 cut down build of U-Boot than a special program that pulls in #ifdefed
 code from various places.

 Another approach is to just have one U-Boot, but keep everything you
 need to get started in the first 96KB.

 Please keep in mind that there is also a large number of boards that
 boot form some boot ROM (like NOR flash), i. e. that can directly
 execute _all_ U-Boot code, without need of any SPL at all.

 Any changes to the design of the SPL must not have any adverse
 effects on such XIP booting systems.

This is a degenerate case for the system I describe - where all the
code is in the first part and the second part is empty. It adds
nothing but for the extra build complexity already mentioned. I'm not
involved enough in SPL yet to be able to say how useful all this is,
perhaps later.

Regards,
Simon


 Best regards,

 Wolfgang Denk

 --
 DENX Software Engineering GmbH,     MD: Wolfgang Denk  Detlev Zundel
 HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
 Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
 More software projects have gone awry for lack of calendar time than
 for all other causes combined.
                         - Fred Brooks, Jr., _The Mythical Man Month_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot